)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"edd69fb555181490cd0c0572e6035bd03f280e8e","unresolved":true,"context_lines":[{"line_number":7,"context_line":"snapshot: allow revert to any point for rbd driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"RBD can rollback to any snapshot and checking if the snapshot is the latest can be skip for RBD driver"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"Signed-off-by: Seena Fallah \u003cseenafallah@gmail.com\u003e"},{"line_number":12,"context_line":"Change-Id: Iffe3295f74fcb5d04fcd6002346c21d123dbb1e0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"61ff5a7e_cc89d53c","line":10,"updated":"2021-09-03 07:21:03.000000000","message":"It would be helpful if link to blueprint; or link mentioned by Xuan is specified in commit message.","commit_id":"fd09ebb195e7ccca17977ce6c5564a25559ceb77"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0ad00238e2b85e7af4118e4a8c64395f9a1fb580","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0efc63dd_b213c287","updated":"2021-11-11 16:24:27.000000000","message":"In addition to the spec issue Sean noted, there\u0027s another patch up addressing this issue:\nhttps://review.opendev.org/c/openstack/cinder/+/745436\n\nYou may want to coordinate with the owner of that patch once the spec is approved to collaborate on the implementation.","commit_id":"c65598e94b2b972ad97f71717f245ff1127e791a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"152f4c7b52169281352c4d3bd48c8a52d0829f3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"1f0823c1_d880e69e","updated":"2021-10-19 16:03:13.000000000","message":"Spec has not merged and this does not appear to follow the design.","commit_id":"c65598e94b2b972ad97f71717f245ff1127e791a"},{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"24008798744dd9b32dfede117e552e408393e26f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"cc11b028_b3b0b9d2","updated":"2021-10-19 16:03:19.000000000","message":"https://review.opendev.org/c/openstack/cinder-specs/+/736111","commit_id":"c65598e94b2b972ad97f71717f245ff1127e791a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e33d5d8cdada7e456008fb6431bcdfec3c53c119","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3405dc32_c5664200","in_reply_to":"035ce308_0965c6ee","updated":"2021-11-11 15:43:52.000000000","message":"Seena, the spec freeze for Yoga is Friday 17 December.\nhttps://releases.openstack.org/yoga/schedule.html#y-cinder-spec-freeze","commit_id":"c65598e94b2b972ad97f71717f245ff1127e791a"},{"author":{"_account_id":33826,"name":"Seena Fallah","email":"seenafallah@gmail.com","username":"clwluvw"},"change_message_id":"e951b1628944860c4668752a1524082b8366d4e7","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":10,"id":"035ce308_0965c6ee","in_reply_to":"1f0823c1_d880e69e","updated":"2021-10-21 21:49:45.000000000","message":"Is there any due date for the spec so I can change my code with that?\nAlso can you please check this PR? I want to make sure my change works probably!\nhttps://review.opendev.org/c/openstack/cinder-tempest-plugin/+/812032","commit_id":"c65598e94b2b972ad97f71717f245ff1127e791a"}],"cinder/api/v3/volumes.py":[{"author":{"_account_id":30092,"name":"Xuan Yandong","email":"xuanyd@outlook.com","username":"xuanyandong"},"change_message_id":"229306f153728208f19b9534e2549afd8170374c","unresolved":true,"context_lines":[{"line_number":226,"context_line":"        context \u003d req.environ[\u0027cinder.context\u0027]"},{"line_number":227,"context_line":"        self.assert_valid_body(body, \u0027revert\u0027)"},{"line_number":228,"context_line":"        snapshot_id \u003d body[\u0027revert\u0027].get(\u0027snapshot_id\u0027)"},{"line_number":229,"context_line":""},{"line_number":230,"context_line":"        if snapshot_id is None:"},{"line_number":231,"context_line":"            msg \u003d _(\"Specified snapshot %(s_id)s is None\")"},{"line_number":232,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg % {\u0027s_id\u0027: snapshot_id})"},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"        volume \u003d self.volume_api.get_volume(context, id)"},{"line_number":235,"context_line":"        try:"},{"line_number":236,"context_line":"            snap \u003d volume.get_snapshot(snapshot_id)"},{"line_number":237,"context_line":"        except exception.VolumeSnapshotNotFound:"},{"line_number":238,"context_line":"            msg \u003d _(\"Volume %s doesn\u0027t have snapshot %s.\")"},{"line_number":239,"context_line":"            raise exc.HTTPBadRequest(explanation\u003dmsg"},{"line_number":240,"context_line":"                                     % (volume.id, snapshot_id))"},{"line_number":241,"context_line":"        # Ensure volume and snapshot match."},{"line_number":242,"context_line":"        if volume.size !\u003d snap.volume_size:"}],"source_content_type":"text/x-python","patch_set":6,"id":"5c9bc0fa_bc0b711d","line":239,"range":{"start_line":229,"start_character":0,"end_line":239,"end_character":52},"updated":"2021-09-03 07:41:26.000000000","message":"hello, thanks for this code.\n\nthis was the part of bp \u0027revert_to_any_snapshot\u0027. \nAs we dissuss,if we do this, all storage backends can revert to any snapshot, this is not suitable.\n\nThe bp spec is not merged, we will do it in next version. Thanks very much.","commit_id":"fd09ebb195e7ccca17977ce6c5564a25559ceb77"}],"cinder/volume/manager.py":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"edd69fb555181490cd0c0572e6035bd03f280e8e","unresolved":true,"context_lines":[{"line_number":1126,"context_line":""},{"line_number":1127,"context_line":"        # Check wheter snapshot should be latest or not"},{"line_number":1128,"context_line":"        if self.driver.snapshot_revert_should_be_latest():"},{"line_number":1129,"context_line":"            l_snap \u003d volume.get_latest_snapshot()"},{"line_number":1130,"context_line":"            if l_snap.id !\u003d snapshot.id:"},{"line_number":1131,"context_line":"                msg \u003d (_(\"Specified snapshot %(s_id)s is not \""},{"line_number":1132,"context_line":"                         \"the latest one of volume %(v_id)s.\")"}],"source_content_type":"text/x-python","patch_set":6,"id":"9b8e4b8d_b27f75f8","line":1129,"range":{"start_line":1129,"start_character":12,"end_line":1129,"end_character":18},"updated":"2021-09-03 07:21:03.000000000","message":"a better name can be: latest_snap","commit_id":"fd09ebb195e7ccca17977ce6c5564a25559ceb77"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"edd69fb555181490cd0c0572e6035bd03f280e8e","unresolved":true,"context_lines":[{"line_number":1128,"context_line":"        if self.driver.snapshot_revert_should_be_latest():"},{"line_number":1129,"context_line":"            l_snap \u003d volume.get_latest_snapshot()"},{"line_number":1130,"context_line":"            if l_snap.id !\u003d snapshot.id:"},{"line_number":1131,"context_line":"                msg \u003d (_(\"Specified snapshot %(s_id)s is not \""},{"line_number":1132,"context_line":"                         \"the latest one of volume %(v_id)s.\")"},{"line_number":1133,"context_line":"                       % {\"vol_id\": volume.id,"},{"line_number":1134,"context_line":"                          \"snap_id\": snapshot.id})"}],"source_content_type":"text/x-python","patch_set":6,"id":"be9c5171_c13c8759","line":1131,"range":{"start_line":1131,"start_character":47,"end_line":1131,"end_character":51},"updated":"2021-09-03 07:21:03.000000000","message":"snap_id","commit_id":"fd09ebb195e7ccca17977ce6c5564a25559ceb77"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"edd69fb555181490cd0c0572e6035bd03f280e8e","unresolved":true,"context_lines":[{"line_number":1129,"context_line":"            l_snap \u003d volume.get_latest_snapshot()"},{"line_number":1130,"context_line":"            if l_snap.id !\u003d snapshot.id:"},{"line_number":1131,"context_line":"                msg \u003d (_(\"Specified snapshot %(s_id)s is not \""},{"line_number":1132,"context_line":"                         \"the latest one of volume %(v_id)s.\")"},{"line_number":1133,"context_line":"                       % {\"vol_id\": volume.id,"},{"line_number":1134,"context_line":"                          \"snap_id\": snapshot.id})"},{"line_number":1135,"context_line":"                raise exception.InvalidSnapshot(reason\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":6,"id":"01457030_12d92206","line":1132,"range":{"start_line":1132,"start_character":53,"end_line":1132,"end_character":57},"updated":"2021-09-03 07:21:03.000000000","message":"vol_id","commit_id":"fd09ebb195e7ccca17977ce6c5564a25559ceb77"}]}
