)]}'
{"cinder/tests/unit/policies/test_volume_actions.py":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"a2e3fa391fc7f6a2d014904f0521b85b868f3554","unresolved":true,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        # DB validations will throw VolumeNotFound for some contexts"},{"line_number":125,"context_line":"        unauthorized_exceptions \u003d ["},{"line_number":126,"context_line":"            exception.VolumeNotFound,"},{"line_number":127,"context_line":"        ]"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        self.common_policy_check(user_id, self.authorized_users,"}],"source_content_type":"text/x-python","patch_set":2,"id":"827880ab_e3bef9af","line":126,"updated":"2021-09-08 20:30:26.000000000","message":"This is common for all the volume action policies, and could be deduped by making this a class attribute. I\u0027ll live it here for now, and consider it again when doing a more global cleanup of all the new policy tests.","commit_id":"ded50d0219809aaf39df568f1eb36c43f84f97e0"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"911b17e303717bf14022ed8ad90e323fde8d6be7","unresolved":true,"context_lines":[{"line_number":123,"context_line":""},{"line_number":124,"context_line":"        # DB validations will throw VolumeNotFound for some contexts"},{"line_number":125,"context_line":"        unauthorized_exceptions \u003d ["},{"line_number":126,"context_line":"            exception.VolumeNotFound,"},{"line_number":127,"context_line":"        ]"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        self.common_policy_check(user_id, self.authorized_users,"}],"source_content_type":"text/x-python","patch_set":2,"id":"e6618a57_c2b38ea9","line":126,"in_reply_to":"827880ab_e3bef9af","updated":"2021-09-13 15:14:02.000000000","message":"Agree, we need to revisit all these in Yoga anyway, so no point doing premature optimizations.","commit_id":"ded50d0219809aaf39df568f1eb36c43f84f97e0"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"11360f1217496c8063e6654ac5c1add4573344a5","unresolved":true,"context_lines":[{"line_number":291,"context_line":"    def test_force_detach_policy(self, user_id,"},{"line_number":292,"context_line":"                                 mock_terminate_connection,"},{"line_number":293,"context_line":"                                 mock_detach_volume):"},{"line_number":294,"context_line":"        # Redirect the RPC calls directly to the volume manager."},{"line_number":295,"context_line":"        # The volume manager needs the volume.id, not the volume."},{"line_number":296,"context_line":"        def detach_volume(ctxt, volume, connector, force\u003dFalse):"},{"line_number":297,"context_line":"            return self.manager.detach_volume(ctxt, volume.id,"},{"line_number":298,"context_line":"                                              attachment_id\u003dNone,"}],"source_content_type":"text/x-python","patch_set":6,"id":"2286deff_47bafae8","line":295,"range":{"start_line":294,"start_character":0,"end_line":295,"end_character":65},"updated":"2021-09-15 11:20:59.000000000","message":"We could also mention that the reason for this is, since we check the policy initially, no need to go to volume/api code and manager driver calls are already mocked","commit_id":"639224f90397e470bf2552fb054ae4e9f6166197"}]}