)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"6abbb51b015c0efec3e9558254059b9107c359f5","unresolved":true,"context_lines":[{"line_number":14,"context_line":"Fixed the above issue by adding a check for multi-attach"},{"line_number":15,"context_line":"volumes and get the host mapping info of a volume."},{"line_number":16,"context_line":"if the volume is attached to single host skip the"},{"line_number":17,"context_line":"terminate connection function and return."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"closes bug: #1941694"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"8d487765_12d477cb","line":17,"updated":"2021-10-12 15:11:30.000000000","message":"nit:\nIf the volume is attached to single host, skip the\nterminate connection function and return.","commit_id":"1154a8e9214d6bd9bd75f320e8fb8bf8381230cd"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"76b9edb60c3a1bc84eb8cb19c95c13aa3f71609f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e87428d7_92e25cfe","updated":"2021-10-11 15:19:47.000000000","message":"See comment inline.","commit_id":"416fb3589b37126187eb435b625585bfd072fc3f"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"6294c5c46c0ecf4e8f9146bbd520926ca77cc5b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"2ab3c6e6_08831607","updated":"2021-10-11 04:43:58.000000000","message":"recheck","commit_id":"416fb3589b37126187eb435b625585bfd072fc3f"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"4c29341ed7439f9c4f78c8ad631a5f247c3d0b96","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"008b457a_fa418f51","updated":"2021-10-26 05:01:15.000000000","message":"run-IBM Storage CI","commit_id":"1154a8e9214d6bd9bd75f320e8fb8bf8381230cd"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"d5a2e9588ecaa349f4f3c90c0c765f376da179bf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"02ccc2fd_fda8d9a0","updated":"2021-10-25 15:04:20.000000000","message":"run-IBM Storage CI","commit_id":"1154a8e9214d6bd9bd75f320e8fb8bf8381230cd"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"eac1f1f39fe289064f9c8349b6f6ee584d6f2d46","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"a060c078_765ab35d","updated":"2021-10-26 07:00:21.000000000","message":"run-IBM Storage CI","commit_id":"1154a8e9214d6bd9bd75f320e8fb8bf8381230cd"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"c70707d6244e10a85f9136202e375b0899da939a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"bcfb3325_0ef3cd7c","updated":"2021-10-11 17:56:43.000000000","message":"run-IBM Storage CI","commit_id":"1154a8e9214d6bd9bd75f320e8fb8bf8381230cd"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"88fbcc8e6a4e3f857bc9fceb3bf668c78f176c35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c4fd249f_90bcc314","updated":"2021-10-27 05:48:40.000000000","message":"run-IBM Storage CI","commit_id":"1154a8e9214d6bd9bd75f320e8fb8bf8381230cd"},{"author":{"_account_id":32266,"name":"Venkata krishna Thumu","display_name":"VenkataKrishna","email":"venkata.krishna.reddy@ibm.com","username":"venkatakrishnathumu","status":"Active"},"change_message_id":"3358c97dc29e59fb14be63823e4c71becd0b9ce2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"fc5ee787_3fac3be2","updated":"2021-10-25 05:43:16.000000000","message":"run-IBM Storage CI","commit_id":"1154a8e9214d6bd9bd75f320e8fb8bf8381230cd"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"eee54b5cab046ada532a45bc28fc413f0007983b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"147c340e_d41b9716","updated":"2022-01-25 11:02:54.000000000","message":"Just one comment.","commit_id":"17d8953ab7fec987010b7744a5bb581fcb477f08"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"40b213bafa90c4c5fb2bd5abd444e31801c79315","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"1bfe1277_5e8875b3","updated":"2021-12-24 10:04:14.000000000","message":"run-IBM Storage CI","commit_id":"17d8953ab7fec987010b7744a5bb581fcb477f08"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"b0fe6f72118a3b7ee7e2ca2b36b2f79a787c29ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"56225de3_430ba128","updated":"2021-12-23 16:58:55.000000000","message":"run-IBM Storage CI","commit_id":"17d8953ab7fec987010b7744a5bb581fcb477f08"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"1be4dd6bc7bf9315b76c8359e732b64abb5fecf8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ec2d0729_1f3270d6","updated":"2022-01-25 20:23:35.000000000","message":"Hello reviewers,\nThanks for your insight on this review. I have addressed all the comments by Helen, Eric and Raghavendra.\nRequesting you all to please review the changes and provide your inputs.","commit_id":"c59d78216db0a90bfe04ec0ab9202f823fdb97f4"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"50b12a4d66ca8fff957f3eefa55f2f133205bb01","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"06f742ce_0792b9df","updated":"2022-01-26 08:44:42.000000000","message":"run-IBM Storage CI","commit_id":"c59d78216db0a90bfe04ec0ab9202f823fdb97f4"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"666fa41e3ee232b6b295befaa5b509a913335558","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"30a19f20_28230b0a","updated":"2022-01-26 09:58:51.000000000","message":"run-IBM Storage CI","commit_id":"c59d78216db0a90bfe04ec0ab9202f823fdb97f4"},{"author":{"_account_id":32036,"name":"katari manoj kumar","email":"katkumar@in.ibm.com","username":"katarimanojkumar"},"change_message_id":"47bf3d2b71a548b4911e1b084240d8276aed06c2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"6eb9a4cb_c7e4834c","updated":"2022-01-28 10:33:03.000000000","message":"run-IBM Storage CI","commit_id":"c59d78216db0a90bfe04ec0ab9202f823fdb97f4"},{"author":{"_account_id":32036,"name":"katari manoj kumar","email":"katkumar@in.ibm.com","username":"katarimanojkumar"},"change_message_id":"e97752a70b9e51bf69c0d98d087d46dafecd7bdd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"abf35cf6_11718966","updated":"2022-01-28 07:18:45.000000000","message":"run-IBM Storage CI","commit_id":"c59d78216db0a90bfe04ec0ab9202f823fdb97f4"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"a7bf320b39e3563eb3eaa0f4a09ee3eaf4df9717","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"cc4a1bba_312cceb6","updated":"2022-01-27 19:40:50.000000000","message":"run-IBM Storage CI","commit_id":"c59d78216db0a90bfe04ec0ab9202f823fdb97f4"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"24da7a5e17eaac6411d39086ebd1666a24ee3e03","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"3a5d7c01_a8b723ec","updated":"2022-02-03 16:33:22.000000000","message":"Looks good otherwise.","commit_id":"bbaa3d7a2d8274bb19ceaf0cf69cca6f1b4efe9e"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c8f25dd5703ca4131c1f8d3a9296cd878269ab73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4d7d5bd1_a7213f65","updated":"2022-01-31 12:09:41.000000000","message":"My comment from previous PS has been addressed. Zuul passed. So +1.\n","commit_id":"bbaa3d7a2d8274bb19ceaf0cf69cca6f1b4efe9e"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"998cae31a47d960de8fbfe9d7371adae01bf3d27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"fee90ac3_5ade47e9","updated":"2022-02-03 16:40:46.000000000","message":"Thanks Eric. I have addressed the latest comment.","commit_id":"46c9c47342e68e25f56624cc6724c28597438353"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"29c542eb37ec3d4ab5385a3666b9226648d3150a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"a6156de3_aeca5bd9","updated":"2022-02-03 16:41:26.000000000","message":"run-IBM Storage CI","commit_id":"46c9c47342e68e25f56624cc6724c28597438353"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"e08d19b72e9a12d4fe354adc42687c514571dd4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"b4e4d196_4dd0f3f0","updated":"2022-02-09 16:00:25.000000000","message":"I think the key issues have been resolved.  Hope to see some clean-up patches in the future.","commit_id":"c569b7f22575ef22f9d0d2af512b31c27ca0ccbe"},{"author":{"_account_id":32036,"name":"katari manoj kumar","email":"katkumar@in.ibm.com","username":"katarimanojkumar"},"change_message_id":"e73b7c931d51618e7736e043d35ea48fa1d71903","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"1eede651_f8dee3a8","updated":"2022-02-10 06:10:26.000000000","message":"recheck","commit_id":"c569b7f22575ef22f9d0d2af512b31c27ca0ccbe"},{"author":{"_account_id":32036,"name":"katari manoj kumar","email":"katkumar@in.ibm.com","username":"katarimanojkumar"},"change_message_id":"702c7e1fa258daa08b6796b3c151d3395752d3a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"5c6b3b71_25d540dd","updated":"2022-02-10 09:22:46.000000000","message":"recheck","commit_id":"c569b7f22575ef22f9d0d2af512b31c27ca0ccbe"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"8050ccee5c59cca4a381fbdf92de7845e270e23f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"dcfd3495_89c9e4d2","updated":"2022-02-04 12:07:52.000000000","message":"run-IBM Storage CI","commit_id":"c569b7f22575ef22f9d0d2af512b31c27ca0ccbe"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"6aecc942573702f65df466ddaf55b33c719066de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"f0abf054_752fbf10","updated":"2022-02-04 10:18:23.000000000","message":"run-IBM Storage CI","commit_id":"c569b7f22575ef22f9d0d2af512b31c27ca0ccbe"}],"cinder/tests/unit/volume/drivers/ibm/test_storwize_svc.py":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"eee54b5cab046ada532a45bc28fc413f0007983b","unresolved":true,"context_lines":[{"line_number":3305,"context_line":"                pass"},{"line_number":3306,"context_line":"            if attachment_count \u003d\u003d 1:"},{"line_number":3307,"context_line":"                self.assertEqual(1, do_term_conn.call_count)"},{"line_number":3308,"context_line":""},{"line_number":3309,"context_line":"    def test_storwize_get_host_from_connector_with_both_fc_iscsi_host(self):"},{"line_number":3310,"context_line":"        volume_iSCSI \u003d self._create_volume()"},{"line_number":3311,"context_line":"        extra_spec \u003d {\u0027capabilities:storage_protocol\u0027: \u0027\u003cin\u003e iSCSI\u0027}"}],"source_content_type":"text/x-python","patch_set":9,"id":"f952c86b_8ab8186a","line":3308,"updated":"2022-01-25 11:02:54.000000000","message":"This patch is submitted to handle multi-attach scenario.\nSo in my opinion, here an if statement should be added (something like below):\n\nif attachment_count \u003e 1:\n    # skip terminate volume connection\n    # example: self.assertEqual(0, do_term_conn.call_count)","commit_id":"17d8953ab7fec987010b7744a5bb581fcb477f08"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"1be4dd6bc7bf9315b76c8359e732b64abb5fecf8","unresolved":true,"context_lines":[{"line_number":3305,"context_line":"                pass"},{"line_number":3306,"context_line":"            if attachment_count \u003d\u003d 1:"},{"line_number":3307,"context_line":"                self.assertEqual(1, do_term_conn.call_count)"},{"line_number":3308,"context_line":""},{"line_number":3309,"context_line":"    def test_storwize_get_host_from_connector_with_both_fc_iscsi_host(self):"},{"line_number":3310,"context_line":"        volume_iSCSI \u003d self._create_volume()"},{"line_number":3311,"context_line":"        extra_spec \u003d {\u0027capabilities:storage_protocol\u0027: \u0027\u003cin\u003e iSCSI\u0027}"}],"source_content_type":"text/x-python","patch_set":9,"id":"f66e72cf_7a7ac721","line":3308,"in_reply_to":"f952c86b_8ab8186a","updated":"2022-01-25 20:23:35.000000000","message":"I have corrected the TC according to the new code.\nAdded the attach_status and attached_host in the attachment_update dict and corrected the attachment_count condition.","commit_id":"17d8953ab7fec987010b7744a5bb581fcb477f08"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"eee54b5cab046ada532a45bc28fc413f0007983b","unresolved":true,"context_lines":[{"line_number":4349,"context_line":"                pass"},{"line_number":4350,"context_line":"            if attachment_count \u003d\u003d 1:"},{"line_number":4351,"context_line":"                self.assertEqual(1, do_term_conn.call_count)"},{"line_number":4352,"context_line":""},{"line_number":4353,"context_line":"    def test_storwize_terminate_fc_connection_multi_attach(self):"},{"line_number":4354,"context_line":"        # create a FC volume"},{"line_number":4355,"context_line":"        volume_fc \u003d self._create_volume()"}],"source_content_type":"text/x-python","patch_set":9,"id":"1cb29915_01f5ff41","line":4352,"updated":"2022-01-25 11:02:54.000000000","message":"same comment as mentioned in line 3308","commit_id":"17d8953ab7fec987010b7744a5bb581fcb477f08"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"1be4dd6bc7bf9315b76c8359e732b64abb5fecf8","unresolved":true,"context_lines":[{"line_number":4349,"context_line":"                pass"},{"line_number":4350,"context_line":"            if attachment_count \u003d\u003d 1:"},{"line_number":4351,"context_line":"                self.assertEqual(1, do_term_conn.call_count)"},{"line_number":4352,"context_line":""},{"line_number":4353,"context_line":"    def test_storwize_terminate_fc_connection_multi_attach(self):"},{"line_number":4354,"context_line":"        # create a FC volume"},{"line_number":4355,"context_line":"        volume_fc \u003d self._create_volume()"}],"source_content_type":"text/x-python","patch_set":9,"id":"b1ac1dc8_23822449","line":4352,"in_reply_to":"1cb29915_01f5ff41","updated":"2022-01-25 20:23:35.000000000","message":"I have corrected the TC according to the new code.\nAdded the attach_status and attached_host in the attachment_update dict and corrected the attachment_count condition.","commit_id":"17d8953ab7fec987010b7744a5bb581fcb477f08"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_fc.py":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"6abbb51b015c0efec3e9558254059b9107c359f5","unresolved":true,"context_lines":[{"line_number":330,"context_line":"            volume_id \u003d \u0027-\u0027.join([\u0027volume\u0027, str(volume.id)])"},{"line_number":331,"context_line":"            resp \u003d backend_helper.ssh.lsvdiskhostmap(volume_id)"},{"line_number":332,"context_line":"            hosts_map_info_list \u003d list(resp.select(\u0027host_name\u0027))"},{"line_number":333,"context_line":"            if len(hosts_map_info_list) \u003d\u003d 1:"},{"line_number":334,"context_line":"                attachment_list \u003d volume.volume_attachment"},{"line_number":335,"context_line":"                LOG.debug(\"Volume attachment list: %(atl)s\","},{"line_number":336,"context_line":"                          {\u0027atl\u0027: attachment_list})"}],"source_content_type":"text/x-python","patch_set":6,"id":"fdbfe471_18c45bff","line":333,"updated":"2021-10-12 15:11:30.000000000","message":"If there any actionable condition if the hosts_map_info_list is empty or greater than 1?","commit_id":"1154a8e9214d6bd9bd75f320e8fb8bf8381230cd"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"1be4dd6bc7bf9315b76c8359e732b64abb5fecf8","unresolved":true,"context_lines":[{"line_number":330,"context_line":"            volume_id \u003d \u0027-\u0027.join([\u0027volume\u0027, str(volume.id)])"},{"line_number":331,"context_line":"            resp \u003d backend_helper.ssh.lsvdiskhostmap(volume_id)"},{"line_number":332,"context_line":"            hosts_map_info_list \u003d list(resp.select(\u0027host_name\u0027))"},{"line_number":333,"context_line":"            if len(hosts_map_info_list) \u003d\u003d 1:"},{"line_number":334,"context_line":"                attachment_list \u003d volume.volume_attachment"},{"line_number":335,"context_line":"                LOG.debug(\"Volume attachment list: %(atl)s\","},{"line_number":336,"context_line":"                          {\u0027atl\u0027: attachment_list})"}],"source_content_type":"text/x-python","patch_set":6,"id":"2a40e027_3df50cb0","line":333,"in_reply_to":"fdbfe471_18c45bff","updated":"2022-01-25 20:23:35.000000000","message":"Hello Helen,\nThe old code was not compatible so now i have changed the code design for this issue.","commit_id":"1154a8e9214d6bd9bd75f320e8fb8bf8381230cd"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"24da7a5e17eaac6411d39086ebd1666a24ee3e03","unresolved":true,"context_lines":[{"line_number":336,"context_line":"            except AttributeError:"},{"line_number":337,"context_line":"                pass"},{"line_number":338,"context_line":"            if attachment_count \u003e 1:"},{"line_number":339,"context_line":"                LOG.info(\"Volume %(volume)s is attached to multiple \""},{"line_number":340,"context_line":"                         \"instances on host %(host_name)s, \""},{"line_number":341,"context_line":"                         \"skip terminate volume connection\","},{"line_number":342,"context_line":"                         {\u0027volume\u0027: volume.name,"}],"source_content_type":"text/x-python","patch_set":11,"id":"62ad2c89_49287338","line":339,"range":{"start_line":339,"start_character":20,"end_line":339,"end_character":24},"updated":"2022-02-03 16:33:22.000000000","message":"This should be a debug message rather than info level -- it\u0027s not something that would normally merit attention in the logs.","commit_id":"bbaa3d7a2d8274bb19ceaf0cf69cca6f1b4efe9e"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"998cae31a47d960de8fbfe9d7371adae01bf3d27","unresolved":false,"context_lines":[{"line_number":336,"context_line":"            except AttributeError:"},{"line_number":337,"context_line":"                pass"},{"line_number":338,"context_line":"            if attachment_count \u003e 1:"},{"line_number":339,"context_line":"                LOG.info(\"Volume %(volume)s is attached to multiple \""},{"line_number":340,"context_line":"                         \"instances on host %(host_name)s, \""},{"line_number":341,"context_line":"                         \"skip terminate volume connection\","},{"line_number":342,"context_line":"                         {\u0027volume\u0027: volume.name,"}],"source_content_type":"text/x-python","patch_set":11,"id":"92a0eed8_5816db75","line":339,"range":{"start_line":339,"start_character":20,"end_line":339,"end_character":24},"in_reply_to":"62ad2c89_49287338","updated":"2022-02-03 16:40:46.000000000","message":"I have addressed this in both fc.py and iscsi.py","commit_id":"bbaa3d7a2d8274bb19ceaf0cf69cca6f1b4efe9e"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_iscsi.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"0debec10fa35b171529d334b255fface686ec045","unresolved":true,"context_lines":[{"line_number":396,"context_line":"        # so that all the fake connectors to an SVC are serialized"},{"line_number":397,"context_line":"        host \u003d connector[\u0027host\u0027] if \u0027host\u0027 in connector else \"\""},{"line_number":398,"context_line":"        attachment_count \u003d 0"},{"line_number":399,"context_line":"        if hasattr(volume, \u0027multiattach\u0027) and volume.multiattach:"},{"line_number":400,"context_line":"            try:"},{"line_number":401,"context_line":"                attachment_list \u003d volume.volume_attachment"},{"line_number":402,"context_line":"                for attachment in attachment_list:"}],"source_content_type":"text/x-python","patch_set":9,"id":"53d9dcdd_6d596a97","line":399,"range":{"start_line":399,"start_character":11,"end_line":399,"end_character":41},"updated":"2022-01-24 18:01:51.000000000","message":"Is the hasattr check necessary here?  Do we still pass in volumes that aren\u0027t volume objects to this method?","commit_id":"17d8953ab7fec987010b7744a5bb581fcb477f08"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"667682fa7a3c46056fadb196ec4b2871c6ea00b5","unresolved":true,"context_lines":[{"line_number":396,"context_line":"        # so that all the fake connectors to an SVC are serialized"},{"line_number":397,"context_line":"        host \u003d connector[\u0027host\u0027] if \u0027host\u0027 in connector else \"\""},{"line_number":398,"context_line":"        attachment_count \u003d 0"},{"line_number":399,"context_line":"        if hasattr(volume, \u0027multiattach\u0027) and volume.multiattach:"},{"line_number":400,"context_line":"            try:"},{"line_number":401,"context_line":"                attachment_list \u003d volume.volume_attachment"},{"line_number":402,"context_line":"                for attachment in attachment_list:"}],"source_content_type":"text/x-python","patch_set":9,"id":"ad240314_ad7f5bd9","line":399,"range":{"start_line":399,"start_character":11,"end_line":399,"end_character":41},"in_reply_to":"53d9dcdd_6d596a97","updated":"2022-01-25 19:18:53.000000000","message":"Ok, terminate_connection_snapshot() above calls this with a namedtuple that isn\u0027t a proper Volume object, so this check is needed for that case.\n\n(This should probably be cleaned up in the future.)","commit_id":"17d8953ab7fec987010b7744a5bb581fcb477f08"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"1be4dd6bc7bf9315b76c8359e732b64abb5fecf8","unresolved":true,"context_lines":[{"line_number":396,"context_line":"        # so that all the fake connectors to an SVC are serialized"},{"line_number":397,"context_line":"        host \u003d connector[\u0027host\u0027] if \u0027host\u0027 in connector else \"\""},{"line_number":398,"context_line":"        attachment_count \u003d 0"},{"line_number":399,"context_line":"        if hasattr(volume, \u0027multiattach\u0027) and volume.multiattach:"},{"line_number":400,"context_line":"            try:"},{"line_number":401,"context_line":"                attachment_list \u003d volume.volume_attachment"},{"line_number":402,"context_line":"                for attachment in attachment_list:"}],"source_content_type":"text/x-python","patch_set":9,"id":"47768396_1e382441","line":399,"range":{"start_line":399,"start_character":11,"end_line":399,"end_character":41},"in_reply_to":"ad240314_ad7f5bd9","updated":"2022-01-25 20:23:35.000000000","message":"As per our discussion we see that both checks are necessary as per the current code because terminate_connection() is called for volume object and for a namedtuple.","commit_id":"17d8953ab7fec987010b7744a5bb581fcb477f08"}],"releasenotes/notes/bug-1941694-svc_detach_second_instance_for_multi_attach_type_volume_fix-b9a882a7faa8eed6.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"76b9edb60c3a1bc84eb8cb19c95c13aa3f71609f","unresolved":true,"context_lines":[{"line_number":1,"context_line":"fixes:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    IBM Spectrum Virtualize Family driver: `Bug #1941694"},{"line_number":4,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/1941694`_:"},{"line_number":5,"context_line":"    Fixed detaching volume from second instance for"},{"line_number":6,"context_line":"    multi-attach type volumes."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"402dca0e_38908c8b","line":4,"range":{"start_line":4,"start_character":51,"end_line":4,"end_character":52},"updated":"2021-10-11 15:19:47.000000000","message":"You\u0027re missing the closing \u0027\u003e\u0027 for the hyperlink before this backtick.\n\nWhile you\u0027re at it, I think the correct format is:\n\n    IBM Spectrum Virtualize Family driver `bug #123456 ...\n\nSee https://docs.openstack.org/cinder/latest/contributor/releasenotes.html","commit_id":"416fb3589b37126187eb435b625585bfd072fc3f"},{"author":{"_account_id":32425,"name":"saikrishnagk","email":"gopalakrishna.krishna@ibm.com","username":"gksk"},"change_message_id":"2ba54868871e31f78d1a94fe982da16cc51d7c78","unresolved":false,"context_lines":[{"line_number":1,"context_line":"fixes:"},{"line_number":2,"context_line":"  - |"},{"line_number":3,"context_line":"    IBM Spectrum Virtualize Family driver: `Bug #1941694"},{"line_number":4,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/1941694`_:"},{"line_number":5,"context_line":"    Fixed detaching volume from second instance for"},{"line_number":6,"context_line":"    multi-attach type volumes."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"9b598345_12454d8a","line":4,"range":{"start_line":4,"start_character":51,"end_line":4,"end_character":52},"in_reply_to":"402dca0e_38908c8b","updated":"2021-10-11 16:04:23.000000000","message":"Thanks you so much","commit_id":"416fb3589b37126187eb435b625585bfd072fc3f"}]}