)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"7b605e0bc85fc1f3ee1054f9052ef7062bf09313","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f3de417d_84d3f99f","updated":"2021-10-28 18:03:19.000000000","message":"LGTM","commit_id":"35c07883772d30a383f19b6f03ee0b81e9f537f0"}],"cinder/volume/drivers/pure.py":[{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"5a42c0cadb73b716eac6e756dc55b96c404ff038","unresolved":true,"context_lines":[{"line_number":1032,"context_line":"            vol_models \u003d self._create_cg_from_cg(group, source_cg,"},{"line_number":1033,"context_line":"                                                 volumes, source_vols)"},{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"        return model_update, vol_models"},{"line_number":1036,"context_line":""},{"line_number":1037,"context_line":"    @pure_driver_debug_trace"},{"line_number":1038,"context_line":"    def delete_consistencygroup(self, context, group, volumes):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9ceb95f6_b786ae74","line":1035,"range":{"start_line":1035,"start_character":29,"end_line":1035,"end_character":39},"updated":"2021-10-04 18:03:32.000000000","message":"I believe this would return an error in case `vol_models` is not defined. Wouldn\u0027t be better to initialize this variable?","commit_id":"35c07883772d30a383f19b6f03ee0b81e9f537f0"},{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"86d728404a279d273a1d2d4aed3eba2bb4438779","unresolved":false,"context_lines":[{"line_number":1032,"context_line":"            vol_models \u003d self._create_cg_from_cg(group, source_cg,"},{"line_number":1033,"context_line":"                                                 volumes, source_vols)"},{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"        return model_update, vol_models"},{"line_number":1036,"context_line":""},{"line_number":1037,"context_line":"    @pure_driver_debug_trace"},{"line_number":1038,"context_line":"    def delete_consistencygroup(self, context, group, volumes):"}],"source_content_type":"text/x-python","patch_set":3,"id":"0c9f19b8_1d156a7c","line":1035,"range":{"start_line":1035,"start_character":29,"end_line":1035,"end_character":39},"in_reply_to":"26a8de08_0979e05a","updated":"2021-10-04 19:31:46.000000000","message":"Ok, I got it. Thanks for explaining.","commit_id":"35c07883772d30a383f19b6f03ee0b81e9f537f0"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"64a8a1d6a0ff8c4452dcd1ae9c273c2a57fe0b74","unresolved":true,"context_lines":[{"line_number":1032,"context_line":"            vol_models \u003d self._create_cg_from_cg(group, source_cg,"},{"line_number":1033,"context_line":"                                                 volumes, source_vols)"},{"line_number":1034,"context_line":""},{"line_number":1035,"context_line":"        return model_update, vol_models"},{"line_number":1036,"context_line":""},{"line_number":1037,"context_line":"    @pure_driver_debug_trace"},{"line_number":1038,"context_line":"    def delete_consistencygroup(self, context, group, volumes):"}],"source_content_type":"text/x-python","patch_set":3,"id":"26a8de08_0979e05a","line":1035,"range":{"start_line":1035,"start_character":29,"end_line":1035,"end_character":39},"in_reply_to":"9ceb95f6_b786ae74","updated":"2021-10-04 18:39:48.000000000","message":"This is always set by the virtue of the return data from the routines called. They have to return a value as a source consistency group already exists with volumes, therefore a successful copy will populate `vol_models`.","commit_id":"35c07883772d30a383f19b6f03ee0b81e9f537f0"}]}