)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"29bc4e5bb93797bb49cc37b6d757642c6ba581e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0828e6cd_4e4e5a2b","updated":"2021-10-15 14:23:46.000000000","message":"Changes the file and also update the tests.\nThe bug description is also direct about what has to be done.\nThank you! LGTM.","commit_id":"b7e294599047188a04f91dda53537b262d2b3f8d"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"9174a122d92e8caba774d0be2e5a795d74331b7c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"19d49ad8_cc7b59c7","updated":"2021-10-15 15:02:59.000000000","message":"Greetings,\nDismiss my last comment pls.\nI\u0027ve reported this because I was having the warning message \u0027rbd: -p [ --pool ] is deprecated, use --dest-pool\u0027 in the logs all the time. However, I\u0027m not sure why Ceph hasn\u0027t update their documentation regarding this and still uses --pool [1].\nDespite that, this change looks correct to me, this is a valid way to go and avoid warning msg, but I\u0027m open to discussion:\n```\ndevstack$ rbd help import\nusage: rbd import [--path \u003cpath\u003e] [--dest-pool \u003cdest-pool\u003e]\n                  [--dest-namespace \u003cdest-namespace\u003e] [--dest \u003cdest\u003e]\n                  [--image-format \u003cimage-format\u003e] [--new-format]\n                  [--order \u003corder\u003e] [--object-size \u003cobject-size\u003e]\n                  [--image-feature \u003cimage-feature\u003e] [--image-shared]\n                  [--stripe-unit \u003cstripe-unit\u003e]\n                  [--stripe-count \u003cstripe-count\u003e] [--data-pool \u003cdata-pool\u003e]\n                  [--mirror-image-mode \u003cmirror-image-mode\u003e]\n                  [--journal-splay-width \u003cjournal-splay-width\u003e]\n                  [--journal-object-size \u003cjournal-object-size\u003e]\n                  [--journal-pool \u003cjournal-pool\u003e]\n                  [--sparse-size \u003csparse-size\u003e] [--no-progress]\n                  [--export-format \u003cexport-format\u003e] [--pool \u003cpool\u003e]\n                  [--image \u003cimage\u003e]\n                  \u003cpath-name\u003e \u003cdest-image-spec\u003e\n\nImport image from file.\n\nOptional arguments\n  --path arg                import file (or \u0027-\u0027 for stdin)\n  --dest-pool arg           destination pool name\n\n  \ndevstack$ ceph --version\nceph version 16.2.6 (ee28fb57e47e9f88813e24bbf4c14496ca299d31) pacific (stable)\n```\n\n[1 ]https://docs.ceph.com/en/pacific/man/8/rbd/","commit_id":"b7e294599047188a04f91dda53537b262d2b3f8d"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"ef1557293e8bee7e0bec63f4d61bcc0c373606a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"af5408f8_23f24f7c","updated":"2021-10-15 14:11:49.000000000","message":"LGTM","commit_id":"b7e294599047188a04f91dda53537b262d2b3f8d"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"e2612fe4af6082c30986799a2991f63b9a3aaa3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"7bb5e470_ce67a38a","updated":"2021-10-15 14:38:05.000000000","message":"Looks good to me, I\u0027m not sure why ceph hasn\u0027t update their documentation regarding this and still use --pool \n","commit_id":"b7e294599047188a04f91dda53537b262d2b3f8d"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"bd8a898bf330e5ef71e5c10b49e27dedacaa4fa9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"791db154_27bf12ff","updated":"2021-10-15 16:08:47.000000000","message":"Thanks brian for let me know, looks like dest-pool is going to be deprecated instead of pool https://github.com/ceph/ceph/blob/master/src/tools/rbd/action/Import.cc#L945-L949","commit_id":"b7e294599047188a04f91dda53537b262d2b3f8d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8f500a48ece68750032d1764c14ba9f7459ecad3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"43046f5c_5a263af4","updated":"2021-10-28 14:23:05.000000000","message":"Thanks for fixing this annoyance.","commit_id":"b7e294599047188a04f91dda53537b262d2b3f8d"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"9d99323ffa4942baa9d623f3f17f33fdef3e9fe1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"659ec1a4_d63ad3c2","updated":"2021-11-01 22:16:37.000000000","message":"recheck","commit_id":"b7e294599047188a04f91dda53537b262d2b3f8d"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"7a4f70e4b07b68791dbc859a5fef416666c5117a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bdfe36b4_ff399a78","in_reply_to":"19d49ad8_cc7b59c7","updated":"2021-10-15 15:15:37.000000000","message":"Bug for ceph doc?","commit_id":"b7e294599047188a04f91dda53537b262d2b3f8d"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"bd8a898bf330e5ef71e5c10b49e27dedacaa4fa9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"2a336532_4d6592b5","in_reply_to":"bdfe36b4_ff399a78","updated":"2021-10-15 16:08:47.000000000","message":"\u003e Bug for ceph doc?\nI think so, I\u0027ll report this and see what they say about it.","commit_id":"b7e294599047188a04f91dda53537b262d2b3f8d"}]}