)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1e3d5092375911fb63b42405f126e9a8505866d5","unresolved":true,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-10-07 17:21:58 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"db: Fix formatting of database models"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"I\u0027m going to do some surgery on these files. Address some formatting"},{"line_number":10,"context_line":"nits now so I don\u0027t end up mixing style and functional changes later."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Idf0d8d5137262835a38f2e9943e15903e5000361"},{"line_number":13,"context_line":"Signed-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"14549f8a_771b5fd9","line":10,"range":{"start_line":8,"start_character":0,"end_line":10,"end_character":69},"updated":"2021-10-18 17:34:49.000000000","message":"nit: The commit message is not self sufficient if other patches merge interleaved with the rest of the patch series. \n\n?: Is this change necessary for some automated tool to work or something like that?  If it\u0027s not, then this may be interpreted as a way of imposing your formatting preferences on the project, since there are a lot of patches that follow the series.","commit_id":"15c29f5b8648e772f2e84eccdab9bf5ce785cd39"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"6ff12ecf55286a76dc10f41d24d56adb5684a0cb","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2021-10-07 17:21:58 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"db: Fix formatting of database models"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"I\u0027m going to do some surgery on these files. Address some formatting"},{"line_number":10,"context_line":"nits now so I don\u0027t end up mixing style and functional changes later."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Idf0d8d5137262835a38f2e9943e15903e5000361"},{"line_number":13,"context_line":"Signed-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"0eda9ad2_0d51b823","line":10,"range":{"start_line":8,"start_character":0,"end_line":10,"end_character":69},"in_reply_to":"14549f8a_771b5fd9","updated":"2021-11-04 11:54:37.000000000","message":"\u003e nit: The commit message is not self sufficient if other patches merge interleaved with the rest of the patch series. \n\nFair point. I\u0027ll reword with a pointer to the blueprint or something if I need to respin.\n\n\u003e ?: Is this change necessary for some automated tool to work or something like that?  If it\u0027s not, then this may be interpreted as a way of imposing your formatting preferences on the project, since there are a lot of patches that follow the series.\n\nSort of? alembic allows you to automatically apply something like black to the automatically-generated migration files that I talked about in the PTG. I haven\u0027t enabled this yet, but I\u0027d like to (the alternative is for the user to manually fix this up). It seems weird to apply the logic to all migrations except the initial one.","commit_id":"15c29f5b8648e772f2e84eccdab9bf5ce785cd39"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"37fed9414a0f44b40c3dd152bcc2ec1eecfa6d37","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ffa561d7_ea855efa","updated":"2022-01-24 15:01:31.000000000","message":"Some of the changes I like, some I don\u0027t, and some I\u0027m indifferent too.  I think the main thing here is that you\u0027re touching a bunch of files, and as long as the style is consistent throughout, that\u0027s OK.  I don\u0027t mind the black-like style, especially if we turn it on for the alembic generated files; this way when someone is reading through the DB stuff, everything will be consistent.","commit_id":"b59de266e34bf2102c2fb1bb7425abc2a9e15c21"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4a481f8e144f71cc54766d00099a9d50e4824dcd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"dea3c34c_9391c9d4","in_reply_to":"ffa561d7_ea855efa","updated":"2022-01-24 16:11:00.000000000","message":"fwiw, I agree and this wouldn\u0027t be my ideal formatter. However, using it means I didn\u0027t need to manually fix up style as I worked on later patches, which saved me enough time to warrant the noise here\n\nThanks for the review!","commit_id":"b59de266e34bf2102c2fb1bb7425abc2a9e15c21"}]}