)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"5606a467dad92adc7f6b5548476df2ce1b9e69d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"f9e2f0d5_f505684b","updated":"2022-02-21 15:38:47.000000000","message":"Are you going to add these indexes back into models and migrations?","commit_id":"1990ce420168ffd6086d00d9441ff5c8e2a3a988"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f072ffedd55d704fccb18558a08e7cf510a1c1c8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e28dbc80_5498a1fe","updated":"2022-03-01 00:12:21.000000000","message":"LGTM.","commit_id":"1990ce420168ffd6086d00d9441ff5c8e2a3a988"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4ee8b35d45566d18b255d521da9e55b3967bfcd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8286e6f1_1523499a","in_reply_to":"f9e2f0d5_f505684b","updated":"2022-02-21 17:13:12.000000000","message":"I can, though it should be a follow-up. To be clear, what I\u0027ve done here doesn\u0027t actually have any real-world impact (i.e. there\u0027s no upgrade impact). To actually resolve the TODOs we\u0027d need a migration, which is definitely worth doing...though maybe not at the end of a cycle? 😄","commit_id":"1990ce420168ffd6086d00d9441ff5c8e2a3a988"}],"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f072ffedd55d704fccb18558a08e7cf510a1c1c8","unresolved":true,"context_lines":[{"line_number":1650,"context_line":"VOLUME_DEPENDENT_MODELS \u003d frozenset(["},{"line_number":1651,"context_line":"    models.VolumeMetadata,"},{"line_number":1652,"context_line":"    models.VolumeAdminMetadata,"},{"line_number":1653,"context_line":"    models.Snapshot,"},{"line_number":1654,"context_line":"    models.Transfer,"},{"line_number":1655,"context_line":"    models.VolumeGlanceMetadata,"},{"line_number":1656,"context_line":"    models.VolumeAttachment,"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85d7b8_f8d96ccf","line":1653,"updated":"2022-03-01 00:12:21.000000000","message":"Note for other reviewers: this frozenset is used in volume_destroy (line 1676 below) to make sure that we don\u0027t leave any \"dead\" stuff around in other tables when a volume is deleted (see Bug #1542169).  We already have a check in the code that won\u0027t allow a volume to be deleted until all its snaps have been deleted, so this won\u0027t break anything.  It\u0027s necessary to add models.Snapshot here so that test_volume_dependent_models_list in VolumeRelationshipsTestCase will pass.","commit_id":"1990ce420168ffd6086d00d9441ff5c8e2a3a988"}]}