)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9250d5581536d6c840c16436316290e5adc90356","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"d21e2e7d_3de3779c","updated":"2022-01-24 23:21:48.000000000","message":"Typo noted inline, and a question about the formatting.","commit_id":"5e79a0ad0d6a93c1c61f359a74cde0a03f789a6d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"275d632c1ec9e05ceae8e3977c0e72342c1a8670","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"026b8ea4_425ca544","updated":"2022-03-08 01:57:43.000000000","message":"Haven\u0027t heard any objections, so ninja-approving a documentation change.","commit_id":"0d7f3ba8625b47aa61d69915b10fd944029eab08"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"2f4d41882be785d0080598f8898f1b42082a4c7d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e9e4e5f9_ca6eba15","updated":"2022-03-02 21:02:19.000000000","message":"Looks good, waiting to see more reviews.","commit_id":"0d7f3ba8625b47aa61d69915b10fd944029eab08"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8a694c7b2a034e7c670c21f15ed417f05bcecee6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0f090f4e_f65e8933","updated":"2022-03-01 03:30:43.000000000","message":"Revisions look good to me.","commit_id":"0d7f3ba8625b47aa61d69915b10fd944029eab08"}],"doc/source/admin/upgrades.rst":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9250d5581536d6c840c16436316290e5adc90356","unresolved":true,"context_lines":[{"line_number":61,"context_line":"and able to be applied to a running system before service code has been"},{"line_number":62,"context_line":"upgraded."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Data migrations are banned from schema migration scripts are are instead"},{"line_number":65,"context_line":"defined in ``cinder/db/api.py``. They are kept separate to make DB schema"},{"line_number":66,"context_line":"migrations less painful to execute. Instead, the migrations are executed by a"},{"line_number":67,"context_line":"background process in a manner that doesn\u0027t interrupt running services (you can"}],"source_content_type":"text/x-rst","patch_set":4,"id":"515f142f_38685adc","line":64,"range":{"start_line":64,"start_character":57,"end_line":64,"end_character":60},"updated":"2022-01-24 23:21:48.000000000","message":"and","commit_id":"5e79a0ad0d6a93c1c61f359a74cde0a03f789a6d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4838845e68b1831245c9d234f9ad3876bd8003c4","unresolved":false,"context_lines":[{"line_number":61,"context_line":"and able to be applied to a running system before service code has been"},{"line_number":62,"context_line":"upgraded."},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"Data migrations are banned from schema migration scripts are are instead"},{"line_number":65,"context_line":"defined in ``cinder/db/api.py``. They are kept separate to make DB schema"},{"line_number":66,"context_line":"migrations less painful to execute. Instead, the migrations are executed by a"},{"line_number":67,"context_line":"background process in a manner that doesn\u0027t interrupt running services (you can"}],"source_content_type":"text/x-rst","patch_set":4,"id":"d0a389fa_3ee99c49","line":64,"range":{"start_line":64,"start_character":57,"end_line":64,"end_character":60},"in_reply_to":"515f142f_38685adc","updated":"2022-01-31 18:19:35.000000000","message":"Done","commit_id":"5e79a0ad0d6a93c1c61f359a74cde0a03f789a6d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9250d5581536d6c840c16436316290e5adc90356","unresolved":true,"context_lines":[{"line_number":141,"context_line":"Cinder deployment, so at the moment a service is upgraded, you\u0027ll keep other"},{"line_number":142,"context_line":"service instances running."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":".. rubric:: Before maintenance window"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"* First you should execute required DB schema migrations. To achieve that"},{"line_number":147,"context_line":"  without interrupting your existing installation, install new Cinder code in"}],"source_content_type":"text/x-rst","patch_set":4,"id":"eb809ec1_1fc4f2b6","line":144,"range":{"start_line":144,"start_character":0,"end_line":144,"end_character":37},"updated":"2022-01-24 23:21:48.000000000","message":"What I don\u0027t like about this change is that as headings, these would show up in the \"Page Contents\" outline in the sidebar; the rubrics don\u0027t.  But that\u0027s a taste issue, let\u0027s see what other reviewers think.","commit_id":"5e79a0ad0d6a93c1c61f359a74cde0a03f789a6d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"4838845e68b1831245c9d234f9ad3876bd8003c4","unresolved":false,"context_lines":[{"line_number":141,"context_line":"Cinder deployment, so at the moment a service is upgraded, you\u0027ll keep other"},{"line_number":142,"context_line":"service instances running."},{"line_number":143,"context_line":""},{"line_number":144,"context_line":".. rubric:: Before maintenance window"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"* First you should execute required DB schema migrations. To achieve that"},{"line_number":147,"context_line":"  without interrupting your existing installation, install new Cinder code in"}],"source_content_type":"text/x-rst","patch_set":4,"id":"103348da_63b10cec","line":144,"range":{"start_line":144,"start_character":0,"end_line":144,"end_character":37},"in_reply_to":"eb809ec1_1fc4f2b6","updated":"2022-01-31 18:19:35.000000000","message":"I did this because these headers didn\u0027t seem important enough to promote in the ToC. I can revert if necessary though","commit_id":"5e79a0ad0d6a93c1c61f359a74cde0a03f789a6d"}]}