)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8a7c34b704d4c016de767aaac22560eb56080b7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"758cc870_569a1de9","updated":"2024-01-12 08:09:23.000000000","message":"changes LGTM.\nsince we are going to update the series, it\u0027s a good opportunity to correct the comments.","commit_id":"5a91f6cc7e0394799469484c0ffae1d39785c79a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e08d4bb65953a4dd013643dd365de3f8f1005108","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"900649d1_618d7a9e","updated":"2023-11-14 16:15:11.000000000","message":"recheck","commit_id":"5a91f6cc7e0394799469484c0ffae1d39785c79a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4ef363beb06b68bf287f567150c67f29e001f8d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"33298d6c_fbc63479","updated":"2024-02-05 23:20:27.000000000","message":"LGTM.","commit_id":"1a9e911ad4903ac5d149372c662e8f83abcf0fcd"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"162be154d2e2c937a80727396764811cdbed60d4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":17,"id":"4c32369a_8237ca4e","updated":"2024-01-12 13:29:57.000000000","message":"my comments are addressed, thanks. LGTM.","commit_id":"1a9e911ad4903ac5d149372c662e8f83abcf0fcd"}],"cinder/tests/unit/db/test_migrations.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8a7c34b704d4c016de767aaac22560eb56080b7a","unresolved":true,"context_lines":[{"line_number":117,"context_line":"        We want to keep the DB ORM (models.py) and DB tables in sync, so the"},{"line_number":118,"context_line":"        test_models_sync test checks for discrepancies between them."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        Due to the rolling upgrades feature there are cases were we will have"},{"line_number":121,"context_line":"        the model and DB out of sync for 1 release, as we stop using it in the"},{"line_number":122,"context_line":"        ORM first and then remove it from the DB in the next, so we use this"},{"line_number":123,"context_line":"        method to allow such discrepancies.  We must add a TODO item on the"}],"source_content_type":"text/x-python","patch_set":15,"id":"19526bfd_9501a383","line":120,"range":{"start_line":120,"start_character":60,"end_line":120,"end_character":64},"updated":"2024-01-12 08:09:23.000000000","message":"nit: where","commit_id":"5a91f6cc7e0394799469484c0ffae1d39785c79a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a2188f0ab4584e9c51c62c6e2e38e4c4276cb81d","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        We want to keep the DB ORM (models.py) and DB tables in sync, so the"},{"line_number":118,"context_line":"        test_models_sync test checks for discrepancies between them."},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"        Due to the rolling upgrades feature there are cases were we will have"},{"line_number":121,"context_line":"        the model and DB out of sync for 1 release, as we stop using it in the"},{"line_number":122,"context_line":"        ORM first and then remove it from the DB in the next, so we use this"},{"line_number":123,"context_line":"        method to allow such discrepancies.  We must add a TODO item on the"}],"source_content_type":"text/x-python","patch_set":15,"id":"bd71d442_d47967ae","line":120,"range":{"start_line":120,"start_character":60,"end_line":120,"end_character":64},"in_reply_to":"19526bfd_9501a383","updated":"2024-01-12 11:20:08.000000000","message":"Done","commit_id":"5a91f6cc7e0394799469484c0ffae1d39785c79a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8a7c34b704d4c016de767aaac22560eb56080b7a","unresolved":true,"context_lines":[{"line_number":127,"context_line":"        or a list of tuples:"},{"line_number":128,"context_line":"        https://alembic.sqlalchemy.org/en/latest/api/autogenerate.html#getting-diffs"},{"line_number":129,"context_line":"        \"\"\""},{"line_number":130,"context_line":"        # TODO: (A Release) Remove this method and its usage"},{"line_number":131,"context_line":"        def ignore_leftover_nested_quota(element):"},{"line_number":132,"context_line":"            operation \u003d element[0]"},{"line_number":133,"context_line":"            if operation \u003d\u003d \u0027remove_column\u0027:"}],"source_content_type":"text/x-python","patch_set":15,"id":"6b22b533_6344cdc2","line":130,"range":{"start_line":130,"start_character":17,"end_line":130,"end_character":18},"updated":"2024-01-12 08:09:23.000000000","message":"this should be D now","commit_id":"5a91f6cc7e0394799469484c0ffae1d39785c79a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a2188f0ab4584e9c51c62c6e2e38e4c4276cb81d","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        or a list of tuples:"},{"line_number":128,"context_line":"        https://alembic.sqlalchemy.org/en/latest/api/autogenerate.html#getting-diffs"},{"line_number":129,"context_line":"        \"\"\""},{"line_number":130,"context_line":"        # TODO: (A Release) Remove this method and its usage"},{"line_number":131,"context_line":"        def ignore_leftover_nested_quota(element):"},{"line_number":132,"context_line":"            operation \u003d element[0]"},{"line_number":133,"context_line":"            if operation \u003d\u003d \u0027remove_column\u0027:"}],"source_content_type":"text/x-python","patch_set":15,"id":"88eda8e1_5001906d","line":130,"range":{"start_line":130,"start_character":17,"end_line":130,"end_character":18},"in_reply_to":"6b22b533_6344cdc2","updated":"2024-01-12 11:20:08.000000000","message":"Done","commit_id":"5a91f6cc7e0394799469484c0ffae1d39785c79a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8a7c34b704d4c016de767aaac22560eb56080b7a","unresolved":true,"context_lines":[{"line_number":238,"context_line":"        \u00279ab1b092a404\u0027,"},{"line_number":239,"context_line":"        # Removing allocated_id and allocated columns is acceptable now since"},{"line_number":240,"context_line":"        # we stopped using them in the code on the previous release."},{"line_number":241,"context_line":"        # TODO: (A Release) Uncomment next line"},{"line_number":242,"context_line":"        # \u0027afd7494d43b7\u0027,"},{"line_number":243,"context_line":"    ]"},{"line_number":244,"context_line":"    FORBIDDEN_METHODS \u003d (\u0027alembic.operations.Operations.alter_column\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"ec7124bc_f922e717","line":241,"range":{"start_line":241,"start_character":17,"end_line":241,"end_character":18},"updated":"2024-01-12 08:09:23.000000000","message":"D","commit_id":"5a91f6cc7e0394799469484c0ffae1d39785c79a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a2188f0ab4584e9c51c62c6e2e38e4c4276cb81d","unresolved":false,"context_lines":[{"line_number":238,"context_line":"        \u00279ab1b092a404\u0027,"},{"line_number":239,"context_line":"        # Removing allocated_id and allocated columns is acceptable now since"},{"line_number":240,"context_line":"        # we stopped using them in the code on the previous release."},{"line_number":241,"context_line":"        # TODO: (A Release) Uncomment next line"},{"line_number":242,"context_line":"        # \u0027afd7494d43b7\u0027,"},{"line_number":243,"context_line":"    ]"},{"line_number":244,"context_line":"    FORBIDDEN_METHODS \u003d (\u0027alembic.operations.Operations.alter_column\u0027,"}],"source_content_type":"text/x-python","patch_set":15,"id":"d05844a9_9bc65c3e","line":241,"range":{"start_line":241,"start_character":17,"end_line":241,"end_character":18},"in_reply_to":"ec7124bc_f922e717","updated":"2024-01-12 11:20:08.000000000","message":"Done","commit_id":"5a91f6cc7e0394799469484c0ffae1d39785c79a"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8a7c34b704d4c016de767aaac22560eb56080b7a","unresolved":true,"context_lines":[{"line_number":366,"context_line":"        snapshots \u003d db_utils.get_table(connection, \u0027snapshots\u0027)"},{"line_number":367,"context_line":"        self.assertFalse(snapshots.c.use_quota.nullable)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    # TODO: (A Release) Uncomment method _check_afd7494d43b7 and create a"},{"line_number":370,"context_line":"    # migration with hash afd7494d43b7 using the following command:"},{"line_number":371,"context_line":"    #   $ tox -e venv -- alembic -c cinder/db/alembic.ini revision \\"},{"line_number":372,"context_line":"    #     --rev-id afd7494d43b7  -m \u0027drop quota leftovers\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"218920eb_7d288346","line":369,"range":{"start_line":369,"start_character":13,"end_line":369,"end_character":14},"updated":"2024-01-12 08:09:23.000000000","message":"D","commit_id":"5a91f6cc7e0394799469484c0ffae1d39785c79a"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"a2188f0ab4584e9c51c62c6e2e38e4c4276cb81d","unresolved":false,"context_lines":[{"line_number":366,"context_line":"        snapshots \u003d db_utils.get_table(connection, \u0027snapshots\u0027)"},{"line_number":367,"context_line":"        self.assertFalse(snapshots.c.use_quota.nullable)"},{"line_number":368,"context_line":""},{"line_number":369,"context_line":"    # TODO: (A Release) Uncomment method _check_afd7494d43b7 and create a"},{"line_number":370,"context_line":"    # migration with hash afd7494d43b7 using the following command:"},{"line_number":371,"context_line":"    #   $ tox -e venv -- alembic -c cinder/db/alembic.ini revision \\"},{"line_number":372,"context_line":"    #     --rev-id afd7494d43b7  -m \u0027drop quota leftovers\u0027"}],"source_content_type":"text/x-python","patch_set":15,"id":"c9e161cc_c2bec411","line":369,"range":{"start_line":369,"start_character":13,"end_line":369,"end_character":14},"in_reply_to":"218920eb_7d288346","updated":"2024-01-12 11:20:08.000000000","message":"Done","commit_id":"5a91f6cc7e0394799469484c0ffae1d39785c79a"}]}