)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e7adf9a3145e87bac76d0947b18ab7cd90c19206","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"b1e44324_64d1f50e","updated":"2024-01-12 08:01:03.000000000","message":"everything looks good, the comments really helped there and we have already merged all the commented code before that will be used now.\nI don\u0027t feel like giving -1 for the release name but it\u0027s crucial to remember when the change needs to be done (although we haven\u0027t done justice to the previous comments)","commit_id":"dc5ad4d93fd7150ca008250447016f8f01377270"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"7e105de9eae1e6fb081e74cf396a6b55a1daf483","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"dd9436da_3609cdcf","updated":"2023-11-14 16:15:03.000000000","message":"recheck","commit_id":"dc5ad4d93fd7150ca008250447016f8f01377270"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5635c0a296bb5b45aa217b3dfa81d528e191b3e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"24c32de8_cc4dc1fb","updated":"2024-01-12 13:29:07.000000000","message":"Thanks for addressing my comments, LGTM.","commit_id":"402787ffcc94392ddc94ecd43750fb36247cd241"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ff70c4577b9c690020387b43ac38ec02601e29c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"a984c281_8d23099e","updated":"2024-02-05 23:17:45.000000000","message":"There are a few other \"remove in A\" that I think should be \u0027D\u0027, but let\u0027s double-check with Gorka and push them in a follow up patch (or just remove them in D, whichever happens first).","commit_id":"402787ffcc94392ddc94ecd43750fb36247cd241"}],"cinder/cmd/manage.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e7adf9a3145e87bac76d0947b18ab7cd90c19206","unresolved":true,"context_lines":[{"line_number":159,"context_line":"    #    db.service_uuids_online_data_migration,"},{"line_number":160,"context_line":"    online_migrations: Tuple[Callable[[context.RequestContext, int],"},{"line_number":161,"context_line":"                                      Tuple[int, int]], ...] \u003d ("},{"line_number":162,"context_line":"        # TODO: (B Release) Remove next line and this comment"},{"line_number":163,"context_line":"        db.remove_temporary_admin_metadata_data_migration,"},{"line_number":164,"context_line":"    )"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"27932dfa_bfd8866b","line":162,"range":{"start_line":162,"start_character":17,"end_line":162,"end_character":18},"updated":"2024-01-12 08:01:03.000000000","message":"this should be D release now","commit_id":"dc5ad4d93fd7150ca008250447016f8f01377270"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d1016a6cf42fe4d0ee823ed639650bace439f453","unresolved":false,"context_lines":[{"line_number":159,"context_line":"    #    db.service_uuids_online_data_migration,"},{"line_number":160,"context_line":"    online_migrations: Tuple[Callable[[context.RequestContext, int],"},{"line_number":161,"context_line":"                                      Tuple[int, int]], ...] \u003d ("},{"line_number":162,"context_line":"        # TODO: (B Release) Remove next line and this comment"},{"line_number":163,"context_line":"        db.remove_temporary_admin_metadata_data_migration,"},{"line_number":164,"context_line":"    )"},{"line_number":165,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"ec1ab71c_9485f2d8","line":162,"range":{"start_line":162,"start_character":17,"end_line":162,"end_character":18},"in_reply_to":"27932dfa_bfd8866b","updated":"2024-01-12 11:20:03.000000000","message":"Done","commit_id":"dc5ad4d93fd7150ca008250447016f8f01377270"}],"cinder/db/api.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d1016a6cf42fe4d0ee823ed639650bace439f453","unresolved":false,"context_lines":[{"line_number":1978,"context_line":"###################"},{"line_number":1979,"context_line":""},{"line_number":1980,"context_line":""},{"line_number":1981,"context_line":"# TODO: (A Release) remove method and this comment"},{"line_number":1982,"context_line":"def remove_temporary_admin_metadata_data_migration(context, max_count):"},{"line_number":1983,"context_line":"    IMPL.remove_temporary_admin_metadata_data_migration(context, max_count)"}],"source_content_type":"text/x-python","patch_set":16,"id":"e83512e9_db478b32","line":1981,"range":{"start_line":1981,"start_character":9,"end_line":1981,"end_character":18},"updated":"2024-01-12 11:20:03.000000000","message":"This should also be D release.","commit_id":"dc5ad4d93fd7150ca008250447016f8f01377270"}],"cinder/objects/volume.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ff70c4577b9c690020387b43ac38ec02601e29c0","unresolved":true,"context_lines":[{"line_number":286,"context_line":"            metadata \u003d db_volume.get(\u0027volume_admin_metadata\u0027, [])"},{"line_number":287,"context_line":"            volume.admin_metadata \u003d {item[\u0027key\u0027]: item[\u0027value\u0027]"},{"line_number":288,"context_line":"                                     for item in metadata}"},{"line_number":289,"context_line":"            # TODO: (A release): Remove code of temporary admin metadata delete"},{"line_number":290,"context_line":"            if \u0027temporary\u0027 in volume.admin_metadata:"},{"line_number":291,"context_line":"                volume.admin_metadata.pop(\u0027temporary\u0027)"},{"line_number":292,"context_line":"                # Admin metadata deletion requires admin context, but since"}],"source_content_type":"text/x-python","patch_set":18,"id":"b3edf9a5_8f275601","line":289,"range":{"start_line":289,"start_character":21,"end_line":289,"end_character":22},"updated":"2024-02-05 23:17:45.000000000","message":"should this be D now (assuming we get this merged during C!)?","commit_id":"402787ffcc94392ddc94ecd43750fb36247cd241"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"8d215b7731e350666a32c91695f744ffcadf15f3","unresolved":true,"context_lines":[{"line_number":286,"context_line":"            metadata \u003d db_volume.get(\u0027volume_admin_metadata\u0027, [])"},{"line_number":287,"context_line":"            volume.admin_metadata \u003d {item[\u0027key\u0027]: item[\u0027value\u0027]"},{"line_number":288,"context_line":"                                     for item in metadata}"},{"line_number":289,"context_line":"            # TODO: (A release): Remove code of temporary admin metadata delete"},{"line_number":290,"context_line":"            if \u0027temporary\u0027 in volume.admin_metadata:"},{"line_number":291,"context_line":"                volume.admin_metadata.pop(\u0027temporary\u0027)"},{"line_number":292,"context_line":"                # Admin metadata deletion requires admin context, but since"}],"source_content_type":"text/x-python","patch_set":18,"id":"65b189e4_0ef91de1","line":289,"range":{"start_line":289,"start_character":21,"end_line":289,"end_character":22},"in_reply_to":"b3edf9a5_8f275601","updated":"2024-02-06 15:36:12.000000000","message":"as per the original patch,\nthe old code was removed in Yoga, this code was added in Zed so this surely points to the N+1 release which was Antelope.\nNow this should be Dalmatian but again do we need to consider the SLURP part when removing this? if we need the removal in SLURP then this will be E.","commit_id":"402787ffcc94392ddc94ecd43750fb36247cd241"}],"cinder/tests/unit/test_db_api.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e7adf9a3145e87bac76d0947b18ab7cd90c19206","unresolved":true,"context_lines":[{"line_number":3938,"context_line":"        self.assertEqual((query.count.return_value, update.return_value),"},{"line_number":3939,"context_line":"                         result)"},{"line_number":3940,"context_line":""},{"line_number":3941,"context_line":"    # TODO: (A Release) remove method and this comment"},{"line_number":3942,"context_line":"    def test_remove_temporary_admin_metadata_data_migration(self):"},{"line_number":3943,"context_line":"        \"\"\"Test migration\u0027s full implementation.\"\"\""},{"line_number":3944,"context_line":"        if not utils.is_db_dialect(\u0027mysql\u0027):"}],"source_content_type":"text/x-python","patch_set":16,"id":"2328da6d_a83d3ecf","line":3941,"range":{"start_line":3941,"start_character":13,"end_line":3941,"end_character":14},"updated":"2024-01-12 08:01:03.000000000","message":"this needs to be updated to D","commit_id":"dc5ad4d93fd7150ca008250447016f8f01377270"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d1016a6cf42fe4d0ee823ed639650bace439f453","unresolved":false,"context_lines":[{"line_number":3938,"context_line":"        self.assertEqual((query.count.return_value, update.return_value),"},{"line_number":3939,"context_line":"                         result)"},{"line_number":3940,"context_line":""},{"line_number":3941,"context_line":"    # TODO: (A Release) remove method and this comment"},{"line_number":3942,"context_line":"    def test_remove_temporary_admin_metadata_data_migration(self):"},{"line_number":3943,"context_line":"        \"\"\"Test migration\u0027s full implementation.\"\"\""},{"line_number":3944,"context_line":"        if not utils.is_db_dialect(\u0027mysql\u0027):"}],"source_content_type":"text/x-python","patch_set":16,"id":"72fb5241_8cebc292","line":3941,"range":{"start_line":3941,"start_character":13,"end_line":3941,"end_character":14},"in_reply_to":"2328da6d_a83d3ecf","updated":"2024-01-12 11:20:03.000000000","message":"Done","commit_id":"dc5ad4d93fd7150ca008250447016f8f01377270"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ff70c4577b9c690020387b43ac38ec02601e29c0","unresolved":true,"context_lines":[{"line_number":3913,"context_line":"        db.remove_temporary_admin_metadata_data_migration(*params)"},{"line_number":3914,"context_line":"        migration_mock.assert_called_once_with(*params)"},{"line_number":3915,"context_line":""},{"line_number":3916,"context_line":"    # TODO: (A Release) remove method and this comment"},{"line_number":3917,"context_line":"    @mock.patch.object(sqlalchemy_api, \u0027models\u0027)"},{"line_number":3918,"context_line":"    @mock.patch.object(sqlalchemy_api, \u0027model_query\u0027)"},{"line_number":3919,"context_line":"    def test_remove_temporary_admin_metadata_data_migration_mocked("}],"source_content_type":"text/x-python","patch_set":18,"id":"b6cb088a_0a89935e","line":3916,"range":{"start_line":3916,"start_character":13,"end_line":3916,"end_character":14},"updated":"2024-02-05 23:17:45.000000000","message":"I\u0027m assuming that this (and line 3906) should be \u0027D\u0027 ?","commit_id":"402787ffcc94392ddc94ecd43750fb36247cd241"}]}