)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"9b4c6f4a66e250b8c630727fbe01fe665eb37cc1","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It\u0027s possible for a volume\u0027s node name to be `None` (because an"},{"line_number":10,"context_line":"API is not present, or the user doesn\u0027t have privileges, for example)."},{"line_number":11,"context_line":"For these cases, computing the QOS name can lead to a TypError, since"},{"line_number":12,"context_line":"it needs to concatenate a prefix to the node name. This patchset fixes"},{"line_number":13,"context_line":"this problem by returning an empty string for the QOS if the node name"},{"line_number":14,"context_line":"is indeed node."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"042bb0d3_0000ccf9","line":11,"updated":"2021-11-19 15:42:04.000000000","message":"nit: TypeError","commit_id":"85597c88f80eaf2fd3aba2b24e5690d69131c892"},{"author":{"_account_id":33717,"name":"Luciano Lo Giudice","email":"luciano.logiudice@canonical.com","username":"lmlg"},"change_message_id":"30cd41be5e39e136444a9d9e7eb243d3ff2e2e4d","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"It\u0027s possible for a volume\u0027s node name to be `None` (because an"},{"line_number":10,"context_line":"API is not present, or the user doesn\u0027t have privileges, for example)."},{"line_number":11,"context_line":"For these cases, computing the QOS name can lead to a TypError, since"},{"line_number":12,"context_line":"it needs to concatenate a prefix to the node name. This patchset fixes"},{"line_number":13,"context_line":"this problem by returning an empty string for the QOS if the node name"},{"line_number":14,"context_line":"is indeed node."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"fe4c532e_8389e22f","line":11,"in_reply_to":"042bb0d3_0000ccf9","updated":"2021-11-19 16:28:49.000000000","message":"Ack","commit_id":"85597c88f80eaf2fd3aba2b24e5690d69131c892"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"32e0052de40974844550d55fb35c58a725b3af6c","unresolved":true,"context_lines":[{"line_number":11,"context_line":"For these cases, computing the QOS name can lead to a TypeError, since"},{"line_number":12,"context_line":"it needs to concatenate a prefix to the node name. This patchset fixes"},{"line_number":13,"context_line":"this problem by returning an empty string for the QOS if the node name"},{"line_number":14,"context_line":"is indeed node."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1948507"},{"line_number":17,"context_line":"Change-Id: I16d7bf9fb023f3bc7be0fc8e3e08421b2754d5a5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"729939f6_49256792","line":14,"range":{"start_line":14,"start_character":10,"end_line":14,"end_character":14},"updated":"2022-03-02 15:02:48.000000000","message":"None","commit_id":"06abbd95775a0af9633efe56c310ddc5272deb64"},{"author":{"_account_id":33717,"name":"Luciano Lo Giudice","email":"luciano.logiudice@canonical.com","username":"lmlg"},"change_message_id":"9c2ef522cf52cdde6e47cad88f90adc3aaf78f8d","unresolved":false,"context_lines":[{"line_number":11,"context_line":"For these cases, computing the QOS name can lead to a TypeError, since"},{"line_number":12,"context_line":"it needs to concatenate a prefix to the node name. This patchset fixes"},{"line_number":13,"context_line":"this problem by returning an empty string for the QOS if the node name"},{"line_number":14,"context_line":"is indeed node."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-Bug: #1948507"},{"line_number":17,"context_line":"Change-Id: I16d7bf9fb023f3bc7be0fc8e3e08421b2754d5a5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a010b6f9_2907cc1c","line":14,"range":{"start_line":14,"start_character":10,"end_line":14,"end_character":14},"in_reply_to":"729939f6_49256792","updated":"2022-03-02 15:20:15.000000000","message":"Done","commit_id":"06abbd95775a0af9633efe56c310ddc5272deb64"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"749968275c6e7db9c955bbf5804368ba78c57039","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"baa0faae_ef5529e0","updated":"2021-11-19 15:27:40.000000000","message":"Looks logical to me","commit_id":"85597c88f80eaf2fd3aba2b24e5690d69131c892"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"9b4c6f4a66e250b8c630727fbe01fe665eb37cc1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6012de30_eb82d407","updated":"2021-11-19 15:42:04.000000000","message":"One typo but other than that LGTM","commit_id":"85597c88f80eaf2fd3aba2b24e5690d69131c892"},{"author":{"_account_id":33717,"name":"Luciano Lo Giudice","email":"luciano.logiudice@canonical.com","username":"lmlg"},"change_message_id":"56bd22cea5e02a27cbeeab7776b2e02063e31ebf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4c81ea7c_b003f7c7","updated":"2021-10-27 00:23:27.000000000","message":"recheck","commit_id":"85597c88f80eaf2fd3aba2b24e5690d69131c892"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"e80a0f7a847ce2b42cec8ff466711a4c9e632efb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"95696460_77bec5c0","updated":"2021-11-19 15:33:25.000000000","message":"run NetApp CI\n","commit_id":"85597c88f80eaf2fd3aba2b24e5690d69131c892"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"b8a4e026c1bf04eddad7df14515d42417b96ba68","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"becd2473_ae33cbac","updated":"2021-11-19 15:33:38.000000000","message":"run NetApp SolidFire CI","commit_id":"85597c88f80eaf2fd3aba2b24e5690d69131c892"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"bdaa0e20bd570aaa63dd12b17242ea8521b4dd1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"76df8f8b_56a586e1","updated":"2021-11-19 16:32:36.000000000","message":"Assuming the NetApp CIs pass then good to go","commit_id":"06abbd95775a0af9633efe56c310ddc5272deb64"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"45af00584415587f5677b099709ebf0f1317025c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d43011dd_940cb991","updated":"2021-12-17 15:50:29.000000000","message":"Greetings Luciano Lo Giudice,\n\n:-1: Is this bug a Netapp only problem? Or a general issue?\n\nThanks ","commit_id":"06abbd95775a0af9633efe56c310ddc5272deb64"},{"author":{"_account_id":11805,"name":"Corey Bryant","email":"corey.bryant@canonical.com","username":"coreycb"},"change_message_id":"d89fef9f10bff7f579962442c212c4190f32f6cf","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1bb1119a_1c2791fc","updated":"2022-02-22 15:01:01.000000000","message":"Hi @Sofia, I\u0027m a little confused on your -1 since you triaged the bug as low which means that you\u0027ve acknowledged it is a bug. Would you be able to provide more guidance on your -1 so that Luciano or others know what is needed to move forward?","commit_id":"06abbd95775a0af9633efe56c310ddc5272deb64"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"4a3ca2ef10f84a0a375e6ca5a1b01925c5393d35","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"32a4e801_cf98c584","updated":"2021-11-25 11:15:34.000000000","message":"LGTM","commit_id":"06abbd95775a0af9633efe56c310ddc5272deb64"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"32e0052de40974844550d55fb35c58a725b3af6c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c9123c4d_c7aec68e","updated":"2022-03-02 15:02:48.000000000","message":"Looks like an actual issue.  Please correct the commit message (note inline) and push up a new patch set.","commit_id":"06abbd95775a0af9633efe56c310ddc5272deb64"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"fb7eee1d4d87793bcc2bb5902506146e3e5c1bb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"45327b68_8e1ad9cf","updated":"2021-11-22 07:17:34.000000000","message":"run-DellEMC SC CI","commit_id":"06abbd95775a0af9633efe56c310ddc5272deb64"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"6a669a7b081fdfefa23aa0bbf7a76553c46bf9e8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c89dcc67_d53bd384","updated":"2021-11-22 07:13:38.000000000","message":"run-DellEMC SC CI","commit_id":"06abbd95775a0af9633efe56c310ddc5272deb64"},{"author":{"_account_id":33717,"name":"Luciano Lo Giudice","email":"luciano.logiudice@canonical.com","username":"lmlg"},"change_message_id":"39fb5a6f420e48f11a6dded310e34497fe91ebda","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cc0f9da9_5e996fa0","in_reply_to":"d43011dd_940cb991","updated":"2021-12-17 16:02:47.000000000","message":"As far as I know, it only affects NetApp, since that\u0027s the only driver that calls into this code.","commit_id":"06abbd95775a0af9633efe56c310ddc5272deb64"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"b4e8f4a891cd579f9199a9636c0e9ea6601c4035","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"286dd824_481f196b","updated":"2022-03-04 09:52:05.000000000","message":"Code changes and UT look good. Zuul and NetApp CI passed. So +1.","commit_id":"1d3f8bca11c8be83b5ec8711afdd2bcf67a4fa16"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"4c4e57a89a1f7a11202a266e250a08d69d45b526","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"49017d13_4d999fc2","updated":"2022-03-18 14:28:08.000000000","message":"I don\u0027t know that code, but shouldn\u0027t the empty string be handled properly later? It seems the value returned here is then used as an index in a dictionary:\n            qos_name \u003d na_utils.qos_min_feature_name(True, node[\u0027name\u0027])\n            self.features.add_feature(qos_name, supported\u003dqos_min_nfs)\n\n    def add_feature(self, name, supported\u003dTrue, min_version\u003dNone):\n        if not isinstance(supported, bool):\n            raise TypeError(\"Feature value must be a bool type.\")\n        self.defined_features.add(name)\n        setattr(self, name, FeatureState(supported, min_version))\n\nShouldn\u0027t this function rather return None *and* that case be handled when calling add_feature?\n","commit_id":"1d3f8bca11c8be83b5ec8711afdd2bcf67a4fa16"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"dad892fbd65e8205a586f1aaedaa990293762106","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a89410ff_6606c3e0","updated":"2022-03-18 14:34:55.000000000","message":"Thank you for working on this Luciano!\nJust added a comment, check it inline.","commit_id":"1d3f8bca11c8be83b5ec8711afdd2bcf67a4fa16"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"4115aa1478c8c2079450bcca2884555740ef21ae","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"16a97462_01b5078c","updated":"2022-04-29 15:32:02.000000000","message":"LGTM. Thank you!","commit_id":"d83a2289d582ad137017f9589c2e42e8d1543c13"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"c02361852c3341ccb29d2ebc73e6b9094b428a44","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"64d2782c_b9b27cef","updated":"2022-05-19 10:21:41.000000000","message":"Looks good","commit_id":"d83a2289d582ad137017f9589c2e42e8d1543c13"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"134a6be43e623b521e63cc9afcc646de5390399e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"672d3c9a_111e86b0","updated":"2022-04-29 15:37:07.000000000","message":"Looks good and has a test!","commit_id":"d83a2289d582ad137017f9589c2e42e8d1543c13"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"6cf6a69f2905f17bfc475be4163995bd6a4c39ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"30f9c08d_c0e5fea5","updated":"2022-05-27 15:10:10.000000000","message":"The code looks good to me and according to the Launchpad bug report it is already included in the Ubuntu packages. Thanks for the work on this.","commit_id":"d83a2289d582ad137017f9589c2e42e8d1543c13"}],"cinder/volume/drivers/netapp/utils.py":[{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"dad892fbd65e8205a586f1aaedaa990293762106","unresolved":true,"context_lines":[{"line_number":542,"context_line":""},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"def qos_min_feature_name(is_nfs, node_name):"},{"line_number":545,"context_line":"    if node_name is None:"},{"line_number":546,"context_line":"        return \u0027\u0027"},{"line_number":547,"context_line":"    elif is_nfs:"},{"line_number":548,"context_line":"        return \u0027QOS_MIN_NFS_\u0027 + node_name"},{"line_number":549,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"c1c4d524_25c74e8c","line":546,"range":{"start_line":545,"start_character":4,"end_line":546,"end_character":17},"updated":"2022-03-18 14:34:55.000000000","message":"would it be better to have the preffix?\ninstead of return \u0027\u0027, assign node_name \u003d \u0027\u0027.\n\nif we look for references of this method [0], we can see that both nfs and iscsi would have the same empty string as name, so we could have the preffix to differ them. What do you think?\n\n[0] https://codesearch.opendev.org/?q\u003dqos_min_feature_name","commit_id":"1d3f8bca11c8be83b5ec8711afdd2bcf67a4fa16"},{"author":{"_account_id":33717,"name":"Luciano Lo Giudice","email":"luciano.logiudice@canonical.com","username":"lmlg"},"change_message_id":"be38dc7d22cbe5498c685505a099b29530a7f814","unresolved":false,"context_lines":[{"line_number":542,"context_line":""},{"line_number":543,"context_line":""},{"line_number":544,"context_line":"def qos_min_feature_name(is_nfs, node_name):"},{"line_number":545,"context_line":"    if node_name is None:"},{"line_number":546,"context_line":"        return \u0027\u0027"},{"line_number":547,"context_line":"    elif is_nfs:"},{"line_number":548,"context_line":"        return \u0027QOS_MIN_NFS_\u0027 + node_name"},{"line_number":549,"context_line":"    else:"}],"source_content_type":"text/x-python","patch_set":3,"id":"805243d8_75a3dd63","line":546,"range":{"start_line":545,"start_character":4,"end_line":546,"end_character":17},"in_reply_to":"c1c4d524_25c74e8c","updated":"2022-03-18 21:41:30.000000000","message":"That\u0027s a fair point, and as far as I can tell, it doesn\u0027t change the idea behind the patch. I\u0027ll change it.","commit_id":"1d3f8bca11c8be83b5ec8711afdd2bcf67a4fa16"}]}