)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"5b4985dc22e83cb1f6819a7661e0cb3d9bdccf4c","unresolved":true,"context_lines":[{"line_number":11,"context_line":"check_for_setup_error in a single method called setup."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The reason to consolidate both methods is that they are always called"},{"line_number":14,"context_line":"one right after the other, os there was no real reason to force the"},{"line_number":15,"context_line":"drivers to split things in a particular way."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch provides a basic backward compatible \"setup\" implementation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6fefb318_e64c8a4b","line":14,"range":{"start_line":14,"start_character":27,"end_line":14,"end_character":29},"updated":"2021-11-15 09:57:56.000000000","message":"as ?","commit_id":"19b115e7d6f8fb8ff17e18249b7041827add8123"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b0deada06df50534c060aed89fdd851cbc3b9356","unresolved":false,"context_lines":[{"line_number":11,"context_line":"check_for_setup_error in a single method called setup."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The reason to consolidate both methods is that they are always called"},{"line_number":14,"context_line":"one right after the other, os there was no real reason to force the"},{"line_number":15,"context_line":"drivers to split things in a particular way."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"This patch provides a basic backward compatible \"setup\" implementation"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2e9124d5_98d871d1","line":14,"range":{"start_line":14,"start_character":27,"end_line":14,"end_character":29},"in_reply_to":"6fefb318_e64c8a4b","updated":"2022-04-06 15:00:00.000000000","message":"Done","commit_id":"19b115e7d6f8fb8ff17e18249b7041827add8123"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"5b4985dc22e83cb1f6819a7661e0cb3d9bdccf4c","unresolved":true,"context_lines":[{"line_number":18,"context_line":"that calls \"do_setup\" and \"check_for_setup_error\" if they exist."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"We could just update the base driver and interface classes, but then we"},{"line_number":21,"context_line":"risk new driver implementations using existing driers as reference and"},{"line_number":22,"context_line":"perpetuating the split of the methods, so the patch actually"},{"line_number":23,"context_line":"consolidates the methods for most (not all) of the drivers."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"a39f6257_d29f54a0","line":21,"range":{"start_line":21,"start_character":47,"end_line":21,"end_character":53},"updated":"2021-11-15 09:57:56.000000000","message":"drivers","commit_id":"19b115e7d6f8fb8ff17e18249b7041827add8123"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b0deada06df50534c060aed89fdd851cbc3b9356","unresolved":false,"context_lines":[{"line_number":18,"context_line":"that calls \"do_setup\" and \"check_for_setup_error\" if they exist."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"We could just update the base driver and interface classes, but then we"},{"line_number":21,"context_line":"risk new driver implementations using existing driers as reference and"},{"line_number":22,"context_line":"perpetuating the split of the methods, so the patch actually"},{"line_number":23,"context_line":"consolidates the methods for most (not all) of the drivers."},{"line_number":24,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4c538cbd_3d8327c2","line":21,"range":{"start_line":21,"start_character":47,"end_line":21,"end_character":53},"in_reply_to":"a39f6257_d29f54a0","updated":"2022-04-06 15:00:00.000000000","message":"Done","commit_id":"19b115e7d6f8fb8ff17e18249b7041827add8123"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"2abd6ee2b9ea6f1ab77d0ad9d4e943c5e1534ddb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"761bda79_162dc318","updated":"2021-10-28 07:53:03.000000000","message":"Failure on tempest-integrated-storage job is unrelated (incorrect public ipv4 on Nova instance) and the error on the LVM job is because this patch breaks cinderlib, so I added a patch to cinderlib (https://review.opendev.org/c/openstack/cinderlib/+/815783) and will set the dependency here now.","commit_id":"bbb315df34e274e5e17cefad3488085834753ea3"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"b5845836a10998102e9f2dc3fa4ae49ee06515ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8bbe9c76_85fe0c02","updated":"2021-10-27 16:20:39.000000000","message":"Looks good for the Pure drivers","commit_id":"bbb315df34e274e5e17cefad3488085834753ea3"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"d21e09c6aa91a6b9abc941c4d3f8c4aa8fa4e31b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b2ad8721_7876e732","updated":"2021-10-27 15:55:15.000000000","message":"recheck","commit_id":"bbb315df34e274e5e17cefad3488085834753ea3"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"466b98156a52c1df4a6d06dd3b043184639a6d87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"89944aa8_f2c83ad0","updated":"2021-11-23 18:41:29.000000000","message":"I was facing the following issues:\n1. SolidFire init was on infinite loop\n    - this patch solves it https://review.opendev.org/c/openstack/cinder/+/802955\n2. do_setup was not implemented\n    - this patch adds the method definition https://review.opendev.org/c/openstack/cinder/+/819007\n    - this is a DNM because can be added on the first patch if it is okay\n\nNow SolidFire seems to be working properly, but I would like to talk about the first patch relation chain, it got a little bit messy.","commit_id":"19b115e7d6f8fb8ff17e18249b7041827add8123"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"5a8307328d6b6a6f991a734c1cd6cfed1fdffa8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"083a37d7_133e2c32","updated":"2021-10-29 08:06:19.000000000","message":"LGTM","commit_id":"19b115e7d6f8fb8ff17e18249b7041827add8123"},{"author":{"_account_id":16721,"name":"Zohar Mamedov","email":"zohar.cloud@gmail.com","username":"zohar"},"change_message_id":"0f29b46cd70bfe0b3f83ae4548c7f0fdddf998d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ca84aa84_c46677f4","updated":"2021-11-10 08:45:35.000000000","message":"LGTM","commit_id":"19b115e7d6f8fb8ff17e18249b7041827add8123"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"012da005c843d91e18c5601b9d8cd1331dcc9d0e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a697e758_3efb63f6","updated":"2021-11-23 06:15:28.000000000","message":"Looks good for hpe_3par_base.py and test_hpe3par.py","commit_id":"19b115e7d6f8fb8ff17e18249b7041827add8123"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a5ebca635da3690549dea31bf6b762b89fd5a5a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"70441ff1_59d9e513","updated":"2021-11-09 00:49:43.000000000","message":"Looks good.  Thanks for the clear commit message.","commit_id":"19b115e7d6f8fb8ff17e18249b7041827add8123"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"5b4985dc22e83cb1f6819a7661e0cb3d9bdccf4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"602436b9_01ebdee0","updated":"2021-11-15 09:57:56.000000000","message":"Minor typos","commit_id":"19b115e7d6f8fb8ff17e18249b7041827add8123"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"fccb2aab72be3b1ae42de8450e02f6d714481d27","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"93a1c3c8_4b82749d","updated":"2021-11-10 09:05:41.000000000","message":"PowerMax patch CI status update","commit_id":"19b115e7d6f8fb8ff17e18249b7041827add8123"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"84d53bdecbfb7323018a36133cd17cbc2f433949","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"726ce84c_c948fbba","updated":"2021-11-23 13:53:00.000000000","message":"Thank you for you effort on this patch. SolidFire driver breaks with this change, I am investigating it and soon I\u0027ll have it working.","commit_id":"19b115e7d6f8fb8ff17e18249b7041827add8123"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"36c32a77f6b7eb6ad43aa4cde0e716195cf15574","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"23a48d27_61786519","updated":"2021-12-02 18:21:44.000000000","message":"Updated the DNM to be able to be merged. Feel fre to review it","commit_id":"19b115e7d6f8fb8ff17e18249b7041827add8123"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"329301f0488f03d32802fc4eac4cb7befdd1a643","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a4311447_ffa8019d","updated":"2021-11-10 09:21:24.000000000","message":"run-DellEMC SC CI","commit_id":"19b115e7d6f8fb8ff17e18249b7041827add8123"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"5b0071ee868a0ce16f611299b9a5c5c9433a8fdb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bfe285db_208a5282","updated":"2021-11-10 09:06:31.000000000","message":"run-DellEMC SC CI","commit_id":"19b115e7d6f8fb8ff17e18249b7041827add8123"},{"author":{"_account_id":22248,"name":"HPE AlletraMP iSCSI CI","email":"hp.cinder.blr.ci@groups.ext.hpe.com","username":"hp-storage-blr-ci","tags":["SERVICE_USER"]},"change_message_id":"bb57f45bdbb9c79563d8f64558357d9d10b2286a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"f4279bb5_42aa65aa","updated":"2021-11-17 11:51:50.000000000","message":"run-HPE Storage CI","commit_id":"19b115e7d6f8fb8ff17e18249b7041827add8123"},{"author":{"_account_id":22248,"name":"HPE AlletraMP iSCSI CI","email":"hp.cinder.blr.ci@groups.ext.hpe.com","username":"hp-storage-blr-ci","tags":["SERVICE_USER"]},"change_message_id":"4dc2567e6cc11714c89a527e1f46ef2541f73006","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0a9b2ff8_7a5f2b08","updated":"2021-11-17 11:50:21.000000000","message":"run-HPE Storage Primera CI","commit_id":"19b115e7d6f8fb8ff17e18249b7041827add8123"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"6383e8009b275b838080769b30ff684c7dc8ef09","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"786b40dd_4be5d854","updated":"2021-12-06 14:52:39.000000000","message":"LGTM","commit_id":"f5956ecd331eb8e0a6d2ebc0e020cc813fb2c7e2"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"62d4341814b53bc2ba42ddf07561d81e00d7fd21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3d923f6f_6610f09c","updated":"2022-02-01 10:03:08.000000000","message":"Probably lightbits cinder driver should also update to the correct interface - should I do it after the merge?","commit_id":"a58bf7c0757a2de9470f3bb7a98898c5b3a3c4bd"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"6b36d1dcacbed627c6b349961b317325ff689ed5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"89e9aa6f_1d535a8d","updated":"2022-02-17 09:44:15.000000000","message":"run-DellEMC Unity CI","commit_id":"a58bf7c0757a2de9470f3bb7a98898c5b3a3c4bd"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"a684ab5c91cca7df5194559f7ada442b550e9e7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"181a6390_76488d8f","updated":"2022-04-06 14:49:50.000000000","message":"I had no comments beyond Rajat\u0027s.  So, once those are addressed I think this is ok.","commit_id":"9521696091e66cbc9190ed7edc4a898ec1c34ff1"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"22ebfae9db3bdf98b6ebfacbc7264338a5ceb7f6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"02ca85da_aa88b5c3","updated":"2022-04-07 07:19:36.000000000","message":"recheck\n\none job timed out other failing due to unrelated reason\n\n2022-04-06 15:58:39.641874 | controller | [ERROR] /opt/stack/devstack/lib/neutron_plugins/ovn_agent:178 Socket /var/run/openvswitch/ovnnb_db.sock not found","commit_id":"9ca667ecd14dbb9b5ad6bbbb9c8e28b9e0b26683"}],"cinder/tests/unit/volume/drivers/hitachi/test_hitachi_hbsd_rest_fc.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6534133ae3705ab862967641ed241a26441d454b","unresolved":true,"context_lines":[{"line_number":612,"context_line":"                               FakeResponse(202, COMPLETED_SUCCEEDED_RESULT),"},{"line_number":613,"context_line":"                               FakeResponse(202, COMPLETED_SUCCEEDED_RESULT),"},{"line_number":614,"context_line":"                               FakeResponse(202, COMPLETED_SUCCEEDED_RESULT)]"},{"line_number":615,"context_line":"        drv.do_setup(None)"},{"line_number":616,"context_line":"        self.assertEqual("},{"line_number":617,"context_line":"            {CONFIG_MAP[\u0027port_id\u0027]: CONFIG_MAP[\u0027target_wwn\u0027]},"},{"line_number":618,"context_line":"            drv.common.storage_info[\u0027wwns\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"5e59e7d2_f4261f6d","line":615,"range":{"start_line":615,"start_character":8,"end_line":615,"end_character":26},"updated":"2022-04-06 14:08:47.000000000","message":"This needs to change as well\n\ndrv.setup(None)","commit_id":"9521696091e66cbc9190ed7edc4a898ec1c34ff1"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b0deada06df50534c060aed89fdd851cbc3b9356","unresolved":false,"context_lines":[{"line_number":612,"context_line":"                               FakeResponse(202, COMPLETED_SUCCEEDED_RESULT),"},{"line_number":613,"context_line":"                               FakeResponse(202, COMPLETED_SUCCEEDED_RESULT),"},{"line_number":614,"context_line":"                               FakeResponse(202, COMPLETED_SUCCEEDED_RESULT)]"},{"line_number":615,"context_line":"        drv.do_setup(None)"},{"line_number":616,"context_line":"        self.assertEqual("},{"line_number":617,"context_line":"            {CONFIG_MAP[\u0027port_id\u0027]: CONFIG_MAP[\u0027target_wwn\u0027]},"},{"line_number":618,"context_line":"            drv.common.storage_info[\u0027wwns\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"6bc7de2c_b1106585","line":615,"range":{"start_line":615,"start_character":8,"end_line":615,"end_character":26},"in_reply_to":"5e59e7d2_f4261f6d","updated":"2022-04-06 15:00:00.000000000","message":"Done","commit_id":"9521696091e66cbc9190ed7edc4a898ec1c34ff1"}],"cinder/tests/unit/volume/drivers/hitachi/test_hitachi_hbsd_rest_iscsi.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6534133ae3705ab862967641ed241a26441d454b","unresolved":true,"context_lines":[{"line_number":519,"context_line":"                               FakeResponse(202, COMPLETED_SUCCEEDED_RESULT),"},{"line_number":520,"context_line":"                               FakeResponse(202, COMPLETED_SUCCEEDED_RESULT),"},{"line_number":521,"context_line":"                               FakeResponse(202, COMPLETED_SUCCEEDED_RESULT)]"},{"line_number":522,"context_line":"        drv.do_setup(None)"},{"line_number":523,"context_line":"        self.assertEqual("},{"line_number":524,"context_line":"            {CONFIG_MAP[\u0027port_id\u0027]:"},{"line_number":525,"context_line":"                \u0027%(ip)s:%(port)s\u0027 % {"}],"source_content_type":"text/x-python","patch_set":5,"id":"53032624_f6259c51","line":522,"range":{"start_line":522,"start_character":8,"end_line":522,"end_character":26},"updated":"2022-04-06 14:08:47.000000000","message":"same, need to change it to drv.setup(None)","commit_id":"9521696091e66cbc9190ed7edc4a898ec1c34ff1"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b0deada06df50534c060aed89fdd851cbc3b9356","unresolved":false,"context_lines":[{"line_number":519,"context_line":"                               FakeResponse(202, COMPLETED_SUCCEEDED_RESULT),"},{"line_number":520,"context_line":"                               FakeResponse(202, COMPLETED_SUCCEEDED_RESULT),"},{"line_number":521,"context_line":"                               FakeResponse(202, COMPLETED_SUCCEEDED_RESULT)]"},{"line_number":522,"context_line":"        drv.do_setup(None)"},{"line_number":523,"context_line":"        self.assertEqual("},{"line_number":524,"context_line":"            {CONFIG_MAP[\u0027port_id\u0027]:"},{"line_number":525,"context_line":"                \u0027%(ip)s:%(port)s\u0027 % {"}],"source_content_type":"text/x-python","patch_set":5,"id":"0ebbf94c_6134e7d1","line":522,"range":{"start_line":522,"start_character":8,"end_line":522,"end_character":26},"in_reply_to":"53032624_f6259c51","updated":"2022-04-06 15:00:00.000000000","message":"Done","commit_id":"9521696091e66cbc9190ed7edc4a898ec1c34ff1"}],"cinder/volume/driver.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a5ebca635da3690549dea31bf6b762b89fd5a5a1","unresolved":true,"context_lines":[{"line_number":1382,"context_line":"    def setup(self, context):"},{"line_number":1383,"context_line":"        \"\"\"Any initialization the volume driver does while starting."},{"line_number":1384,"context_line":""},{"line_number":1385,"context_line":"        Refer to cinder/interface/volume_driver.py for addition info."},{"line_number":1386,"context_line":"        \"\"\""},{"line_number":1387,"context_line":"        # Compatibility code for drivers that still implement the old"},{"line_number":1388,"context_line":"        # initialization interface where the setup was split in 2 methods that"}],"source_content_type":"text/x-python","patch_set":2,"id":"e3631ced_42d0aee2","line":1385,"range":{"start_line":1385,"start_character":55,"end_line":1385,"end_character":63},"updated":"2021-11-09 00:49:43.000000000","message":"nit: additional","commit_id":"19b115e7d6f8fb8ff17e18249b7041827add8123"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"f376db23c166880985dae90dd814e7e2ee5a39a0","unresolved":false,"context_lines":[{"line_number":1382,"context_line":"    def setup(self, context):"},{"line_number":1383,"context_line":"        \"\"\"Any initialization the volume driver does while starting."},{"line_number":1384,"context_line":""},{"line_number":1385,"context_line":"        Refer to cinder/interface/volume_driver.py for addition info."},{"line_number":1386,"context_line":"        \"\"\""},{"line_number":1387,"context_line":"        # Compatibility code for drivers that still implement the old"},{"line_number":1388,"context_line":"        # initialization interface where the setup was split in 2 methods that"}],"source_content_type":"text/x-python","patch_set":2,"id":"dda529d4_56191317","line":1385,"range":{"start_line":1385,"start_character":55,"end_line":1385,"end_character":63},"in_reply_to":"e3631ced_42d0aee2","updated":"2021-12-02 18:33:02.000000000","message":"Done","commit_id":"19b115e7d6f8fb8ff17e18249b7041827add8123"}]}