)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a6f8efca23af595a7b9d957f432798ae3251678b","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     Gorka Eguileor \u003cgeguileo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-11-13 14:40:07 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DB: Set quota resource to 300"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On change I6c30a6be750f6b9ecff7399dbb0aea66cdc097da we increased the"},{"line_number":10,"context_line":"`resource` column of the quota_usages table from 255 to 300, because its"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"422df12f_3f58a4e3","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":22},"updated":"2024-01-12 07:52:24.000000000","message":"nit: on first glance, i thought we are referring to the actual quota resources\nwould\u0027ve been better to say:\nSet quota resource property length to 300","commit_id":"01f4e3aba74ffa04098a63cdd6191bdcb4b69b32"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"136316432544abff2d4012470001095f90d08ead","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gorka Eguileor \u003cgeguileo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-11-13 14:40:07 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DB: Set quota resource to 300"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On change I6c30a6be750f6b9ecff7399dbb0aea66cdc097da we increased the"},{"line_number":10,"context_line":"`resource` column of the quota_usages table from 255 to 300, because its"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"10808171_6398b9cc","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":22},"in_reply_to":"422df12f_3f58a4e3","updated":"2024-01-12 11:19:48.000000000","message":"Done","commit_id":"01f4e3aba74ffa04098a63cdd6191bdcb4b69b32"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"136316432544abff2d4012470001095f90d08ead","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Gorka Eguileor \u003cgeguileo@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2023-11-13 14:40:07 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"DB: Set quota resource to 300"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On change I6c30a6be750f6b9ecff7399dbb0aea66cdc097da we increased the"},{"line_number":10,"context_line":"`resource` column of the quota_usages table from 255 to 300, because its"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"d022e85b_0ec0e20c","line":7,"range":{"start_line":7,"start_character":14,"end_line":7,"end_character":22},"in_reply_to":"422df12f_3f58a4e3","updated":"2024-01-12 11:19:48.000000000","message":"Done","commit_id":"01f4e3aba74ffa04098a63cdd6191bdcb4b69b32"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"045caeb343b75cb559d5d433096345e6f6b3b534","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9730712a_6925987b","updated":"2021-11-01 22:12:11.000000000","message":"Makes complete sense increasing the resource, thanks to this patch the tables will be consistent.","commit_id":"7f076e4f0b4458b47f6f41a836600f5e117ccfff"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"f3447e32dc034c166c7430e505e0e48c52137f78","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"4ba9be89_a649314e","updated":"2023-04-10 15:46:12.000000000","message":"py38 unit tests fail with:\n\ncinder.tests.unit.db.test_migrations.TestModelsSyncMySQL.test_models_sync\n    AssertionError: Models and migration scripts aren\u0027t in sync:","commit_id":"6c4655a2f7e7ef8d921ab2f746207c1b05d83130"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"136316432544abff2d4012470001095f90d08ead","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"db74f048_999a2da2","updated":"2024-01-12 11:19:48.000000000","message":"Good catch on the incorrect changes from 255 to 300 in those checks.","commit_id":"01f4e3aba74ffa04098a63cdd6191bdcb4b69b32"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a6f8efca23af595a7b9d957f432798ae3251678b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"916ccfaa_48b4cdc4","updated":"2024-01-12 07:52:24.000000000","message":"few comments inline","commit_id":"01f4e3aba74ffa04098a63cdd6191bdcb4b69b32"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1b8d3725df21410a7c02c9dbf855b17261e2da58","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"bcec040d_ac0ecbd5","updated":"2023-11-14 16:14:47.000000000","message":"recheck","commit_id":"01f4e3aba74ffa04098a63cdd6191bdcb4b69b32"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e7116fea56db0612c8b2b76570cb6f537899b91f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"01098416_bcaa578d","updated":"2023-11-13 19:14:16.000000000","message":"recheck - tempest-integrated-storage unrelated error in nova not finding instance","commit_id":"01f4e3aba74ffa04098a63cdd6191bdcb4b69b32"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7023aae8754225c9fb5da722ee50166d241c07a1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"e45b082b_92bfd1da","updated":"2024-01-12 13:28:21.000000000","message":"LGTM","commit_id":"3a968212d6fc259f9f5855154a3e5246aa18eb10"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b87caf6b6524b8f38114e97617c93ed379757680","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"a0d31dfe_24c8f5e5","updated":"2024-02-05 22:57:34.000000000","message":"Makes sense that these should all have the same max length.","commit_id":"3a968212d6fc259f9f5855154a3e5246aa18eb10"}],"cinder/api/contrib/quota_classes.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a6f8efca23af595a7b9d957f432798ae3251678b","unresolved":true,"context_lines":[{"line_number":55,"context_line":"    def update(self, req, id, body):"},{"line_number":56,"context_line":"        context \u003d req.environ[\u0027cinder.context\u0027]"},{"line_number":57,"context_line":"        context.authorize(policy.UPDATE_POLICY)"},{"line_number":58,"context_line":"        self.validate_string_length(id, \u0027quota_class_name\u0027,"},{"line_number":59,"context_line":"                                    min_length\u003d1, max_length\u003d300)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        quota_class \u003d id"}],"source_content_type":"text/x-python","patch_set":14,"id":"d6621a46_e533c97f","line":58,"range":{"start_line":58,"start_character":41,"end_line":58,"end_character":57},"updated":"2024-01-12 07:52:24.000000000","message":"I might be missing something but this is an operator defined name right? it doesn\u0027t concatenate any other 255 char string into it?","commit_id":"01f4e3aba74ffa04098a63cdd6191bdcb4b69b32"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"136316432544abff2d4012470001095f90d08ead","unresolved":false,"context_lines":[{"line_number":55,"context_line":"    def update(self, req, id, body):"},{"line_number":56,"context_line":"        context \u003d req.environ[\u0027cinder.context\u0027]"},{"line_number":57,"context_line":"        context.authorize(policy.UPDATE_POLICY)"},{"line_number":58,"context_line":"        self.validate_string_length(id, \u0027quota_class_name\u0027,"},{"line_number":59,"context_line":"                                    min_length\u003d1, max_length\u003d300)"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"        quota_class \u003d id"}],"source_content_type":"text/x-python","patch_set":14,"id":"8dda42c1_c1ba4c0c","line":58,"range":{"start_line":58,"start_character":41,"end_line":58,"end_character":57},"in_reply_to":"d6621a46_e533c97f","updated":"2024-01-12 11:19:48.000000000","message":"This change is wrong, since the quota_class_name hasn\u0027t change its length, it\u0027s still 255.\nThe place to change the check is in the API parameter validation.","commit_id":"01f4e3aba74ffa04098a63cdd6191bdcb4b69b32"}],"cinder/api/contrib/quotas.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a6f8efca23af595a7b9d957f432798ae3251678b","unresolved":true,"context_lines":[{"line_number":99,"context_line":"        target_project_id \u003d id"},{"line_number":100,"context_line":"        context.authorize(policy.UPDATE_POLICY,"},{"line_number":101,"context_line":"                          target\u003d{\u0027project_id\u0027: target_project_id})"},{"line_number":102,"context_line":"        self.validate_string_length(id, \u0027quota_set_name\u0027,"},{"line_number":103,"context_line":"                                    min_length\u003d1, max_length\u003d300)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # NOTE(ankit): Pass #1 - In this loop for body[\u0027quota_set\u0027].keys(),"}],"source_content_type":"text/x-python","patch_set":14,"id":"d74de243_7e3e9215","line":102,"range":{"start_line":102,"start_character":41,"end_line":102,"end_character":55},"updated":"2024-01-12 07:52:24.000000000","message":"same, does this field get concatenated with any other 255 char string field?","commit_id":"01f4e3aba74ffa04098a63cdd6191bdcb4b69b32"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"136316432544abff2d4012470001095f90d08ead","unresolved":false,"context_lines":[{"line_number":99,"context_line":"        target_project_id \u003d id"},{"line_number":100,"context_line":"        context.authorize(policy.UPDATE_POLICY,"},{"line_number":101,"context_line":"                          target\u003d{\u0027project_id\u0027: target_project_id})"},{"line_number":102,"context_line":"        self.validate_string_length(id, \u0027quota_set_name\u0027,"},{"line_number":103,"context_line":"                                    min_length\u003d1, max_length\u003d300)"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"        # NOTE(ankit): Pass #1 - In this loop for body[\u0027quota_set\u0027].keys(),"}],"source_content_type":"text/x-python","patch_set":14,"id":"91ae6176_515d420e","line":102,"range":{"start_line":102,"start_character":41,"end_line":102,"end_character":55},"in_reply_to":"d74de243_7e3e9215","updated":"2024-01-12 11:19:48.000000000","message":"Your are right, this change should not happen, though for different reasons.\nThis is not validating anything about the quota, it\u0027s just checking the project id.","commit_id":"01f4e3aba74ffa04098a63cdd6191bdcb4b69b32"}],"cinder/db/migrations/versions/b8660621f1b9_update_reservations_resource.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a6f8efca23af595a7b9d957f432798ae3251678b","unresolved":true,"context_lines":[{"line_number":55,"context_line":"                # the InnoDB page size [1], so it is possible to have error"},{"line_number":56,"context_line":"                # 1071 (\u0027Specified key was too long; max key length is 767"},{"line_number":57,"context_line":"                # bytes\").  Since this migration is to resolve a corner case,"},{"line_number":58,"context_line":"                # deployments with those DB versions won\u0027t be covered."},{"line_number":59,"context_line":"                # [1]: https://mariadb.com/kb/en/library/innodb-limitations/#page-sizes  # noqa"},{"line_number":60,"context_line":"                if not connection.engine.name \u003d\u003d \u0027mysql\u0027:"},{"line_number":61,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":14,"id":"cde4cf2c_36bee208","line":58,"range":{"start_line":58,"start_character":18,"end_line":58,"end_character":70},"updated":"2024-01-12 07:52:24.000000000","message":"since we are not handling the case for these deployments, would it be good to pass and not raise? since raising will always make their upgrade fail","commit_id":"01f4e3aba74ffa04098a63cdd6191bdcb4b69b32"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"136316432544abff2d4012470001095f90d08ead","unresolved":false,"context_lines":[{"line_number":55,"context_line":"                # the InnoDB page size [1], so it is possible to have error"},{"line_number":56,"context_line":"                # 1071 (\u0027Specified key was too long; max key length is 767"},{"line_number":57,"context_line":"                # bytes\").  Since this migration is to resolve a corner case,"},{"line_number":58,"context_line":"                # deployments with those DB versions won\u0027t be covered."},{"line_number":59,"context_line":"                # [1]: https://mariadb.com/kb/en/library/innodb-limitations/#page-sizes  # noqa"},{"line_number":60,"context_line":"                if not connection.engine.name \u003d\u003d \u0027mysql\u0027:"},{"line_number":61,"context_line":"                    raise"}],"source_content_type":"text/x-python","patch_set":14,"id":"6c72965a_502ee34b","line":58,"range":{"start_line":58,"start_character":18,"end_line":58,"end_character":70},"in_reply_to":"cde4cf2c_36bee208","updated":"2024-01-12 11:19:48.000000000","message":"Normally we wouldn\u0027t have a `try...except` here at all (like in all the other migrations), but because MariaDB has a weird behavior we decide to be prepared for it and ignore those weird errors (a log message could be a good thing to have here).\n\nFor any other erros we\u0027ll raise just like it would have happened in any other migration.","commit_id":"01f4e3aba74ffa04098a63cdd6191bdcb4b69b32"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"39b354e15bf6ce49932286605892e35259d41524","unresolved":true,"context_lines":[{"line_number":63,"context_line":"                # [1]: https://mariadb.com/kb/en/library/innodb-limitations/#page-sizes  # noqa"},{"line_number":64,"context_line":"                if not connection.engine.name \u003d\u003d \u0027mysql\u0027:"},{"line_number":65,"context_line":"                    raise"},{"line_number":66,"context_line":"                LOG.warning(\u0027Error in migration %s, Cinder still affected by\u0027"},{"line_number":67,"context_line":"                            \u0027bug #1948962\u0027, revision)"}],"source_content_type":"text/x-python","patch_set":15,"id":"bb9240c2_31da0cd8","line":66,"range":{"start_line":66,"start_character":76,"end_line":66,"end_character":77},"updated":"2024-01-12 13:24:30.000000000","message":"nit: space needed here\nelse this will be printed as \"bybug #1948962\"","commit_id":"319557ab80ada8bd455c63821859506e669c47ef"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e322efb4cb9f28fe0b64f75e2fbf6fbc0ce4ce9e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                # [1]: https://mariadb.com/kb/en/library/innodb-limitations/#page-sizes  # noqa"},{"line_number":64,"context_line":"                if not connection.engine.name \u003d\u003d \u0027mysql\u0027:"},{"line_number":65,"context_line":"                    raise"},{"line_number":66,"context_line":"                LOG.warning(\u0027Error in migration %s, Cinder still affected by\u0027"},{"line_number":67,"context_line":"                            \u0027bug #1948962\u0027, revision)"}],"source_content_type":"text/x-python","patch_set":15,"id":"8155e32c_c043f0f3","line":66,"range":{"start_line":66,"start_character":76,"end_line":66,"end_character":77},"in_reply_to":"bb9240c2_31da0cd8","updated":"2024-01-12 13:25:56.000000000","message":"Done","commit_id":"319557ab80ada8bd455c63821859506e669c47ef"}]}