)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bb45f1c124e65d268dc3120ee47f648c3cc9665d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f0edf5dc_b0fed8da","updated":"2024-01-12 13:17:59.000000000","message":"LGTM","commit_id":"1c9aac8f5d084b1cb84ae88f476ec957328f76f5"}],"cinder/tests/unit/db/test_migrations.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a211fb0edd72f5c40fe5eabb56b084b5bba7c8b4","unresolved":true,"context_lines":[{"line_number":45,"context_line":"    Dropping and altering should be done in a backward-compatible manner.  A"},{"line_number":46,"context_line":"    more detailed explanation is provided in Cinder\u0027s developer documentation."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    To properly work the first parameter of the decorated method must be a"},{"line_number":49,"context_line":"    class or instance with the DROP_ALTER_EXCEPTIONS and FORBIDDEN_METHODS"},{"line_number":50,"context_line":"    attribute, and the second parameter must be the version (legacy migrations)"},{"line_number":51,"context_line":"    or revision (alembic migrations)."}],"source_content_type":"text/x-python","patch_set":10,"id":"e01c091a_a83e9c42","line":48,"range":{"start_line":48,"start_character":20,"end_line":48,"end_character":21},"updated":"2024-01-11 13:19:48.000000000","message":"nit: comma","commit_id":"a23cd138a5c43ad50c3bdcabd5641129fe77af6c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5af5844a1b70dcdccefe18ea3fe97fa09fdf7228","unresolved":false,"context_lines":[{"line_number":45,"context_line":"    Dropping and altering should be done in a backward-compatible manner.  A"},{"line_number":46,"context_line":"    more detailed explanation is provided in Cinder\u0027s developer documentation."},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    To properly work the first parameter of the decorated method must be a"},{"line_number":49,"context_line":"    class or instance with the DROP_ALTER_EXCEPTIONS and FORBIDDEN_METHODS"},{"line_number":50,"context_line":"    attribute, and the second parameter must be the version (legacy migrations)"},{"line_number":51,"context_line":"    or revision (alembic migrations)."}],"source_content_type":"text/x-python","patch_set":10,"id":"cae6d0be_58d06551","line":48,"range":{"start_line":48,"start_character":20,"end_line":48,"end_character":21},"in_reply_to":"e01c091a_a83e9c42","updated":"2024-01-12 11:19:58.000000000","message":"Done","commit_id":"a23cd138a5c43ad50c3bdcabd5641129fe77af6c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"a211fb0edd72f5c40fe5eabb56b084b5bba7c8b4","unresolved":true,"context_lines":[{"line_number":180,"context_line":"        # Drops and alters from initial migration have already been accepted"},{"line_number":181,"context_line":"        \u0027921e1a36b076\u0027,"},{"line_number":182,"context_line":"        # Making shared_targets explicitly nullable (DB already allowed it)"},{"line_number":183,"context_line":"        \u0027c92a3e68beed\u0027,"},{"line_number":184,"context_line":"    ]"},{"line_number":185,"context_line":"    FORBIDDEN_METHODS \u003d (\u0027alembic.operations.Operations.alter_column\u0027,"},{"line_number":186,"context_line":"                         \u0027alembic.operations.Operations.drop_column\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"5289907d_db2f1100","line":183,"updated":"2024-01-11 13:19:48.000000000","message":"we should also include migration 89aa6f9639f9 added by commit https://github.com/openstack/cinder/commit/171ff11e905a2103443c547d28f84f98a651491c","commit_id":"a23cd138a5c43ad50c3bdcabd5641129fe77af6c"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5af5844a1b70dcdccefe18ea3fe97fa09fdf7228","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        # Drops and alters from initial migration have already been accepted"},{"line_number":181,"context_line":"        \u0027921e1a36b076\u0027,"},{"line_number":182,"context_line":"        # Making shared_targets explicitly nullable (DB already allowed it)"},{"line_number":183,"context_line":"        \u0027c92a3e68beed\u0027,"},{"line_number":184,"context_line":"    ]"},{"line_number":185,"context_line":"    FORBIDDEN_METHODS \u003d (\u0027alembic.operations.Operations.alter_column\u0027,"},{"line_number":186,"context_line":"                         \u0027alembic.operations.Operations.drop_column\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"d2a03c66_aa313ab9","line":183,"in_reply_to":"5289907d_db2f1100","updated":"2024-01-12 11:19:58.000000000","message":"That table is not part of Cinder\u0027s tables, it\u0027s an internal sqlalchemy table.\nIt was used to mark the last migration that had been applied.\nSince it was not part of cinder\u0027s tables it is not walked and checked in the migrations.","commit_id":"a23cd138a5c43ad50c3bdcabd5641129fe77af6c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bb45f1c124e65d268dc3120ee47f648c3cc9665d","unresolved":false,"context_lines":[{"line_number":180,"context_line":"        # Drops and alters from initial migration have already been accepted"},{"line_number":181,"context_line":"        \u0027921e1a36b076\u0027,"},{"line_number":182,"context_line":"        # Making shared_targets explicitly nullable (DB already allowed it)"},{"line_number":183,"context_line":"        \u0027c92a3e68beed\u0027,"},{"line_number":184,"context_line":"    ]"},{"line_number":185,"context_line":"    FORBIDDEN_METHODS \u003d (\u0027alembic.operations.Operations.alter_column\u0027,"},{"line_number":186,"context_line":"                         \u0027alembic.operations.Operations.drop_column\u0027,"}],"source_content_type":"text/x-python","patch_set":10,"id":"9852f71c_2331813a","line":183,"in_reply_to":"d2a03c66_aa313ab9","updated":"2024-01-12 13:17:59.000000000","message":"Ack","commit_id":"a23cd138a5c43ad50c3bdcabd5641129fe77af6c"}]}