)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e5adebe7208141c8866ea9fda2da931527cf8d0f","unresolved":true,"context_lines":[{"line_number":9,"context_line":"This patch adds information regarding the default volume types"},{"line_number":10,"context_line":"(including __DEFAULT__) in the api-ref."},{"line_number":11,"context_line":"The sections modified are volume create, volume type list and show"},{"line_number":12,"context_line":"default volume type."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I896c809bd4ff09e2f26398a1cdaa9a91dc0f8638"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"84cbc2ff_0be3b88c","line":12,"updated":"2021-11-02 14:37:17.000000000","message":"Suggestion inline to also modify Delete a volume type.","commit_id":"a374b0ee7145720989ed6638c370abaf21a3986c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"598b0e0e6b1d2e31a9f6acbfc04cb893fe84bd71","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch adds information regarding the default volume types"},{"line_number":10,"context_line":"(including __DEFAULT__) in the api-ref."},{"line_number":11,"context_line":"The sections modified are volume create, volume type list and show"},{"line_number":12,"context_line":"default volume type."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I896c809bd4ff09e2f26398a1cdaa9a91dc0f8638"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"366fb350_23a5b951","line":12,"in_reply_to":"84cbc2ff_0be3b88c","updated":"2021-11-08 10:22:09.000000000","message":"Done","commit_id":"a374b0ee7145720989ed6638c370abaf21a3986c"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e5adebe7208141c8866ea9fda2da931527cf8d0f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4764fc74_22735c68","updated":"2021-11-02 14:37:17.000000000","message":"Thanks for getting this moving!  Some requests (and suggestions) for revision inline.","commit_id":"a374b0ee7145720989ed6638c370abaf21a3986c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"598b0e0e6b1d2e31a9f6acbfc04cb893fe84bd71","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"1f78283e_7db04881","updated":"2021-11-08 10:22:09.000000000","message":"Thanks Brian for the great review and suggestions, please find my replies inline.","commit_id":"275935c974546abb63ea4bfb60f5ddd4e8ac3447"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"92abaed7617a5edd83bb86608157bc472277b367","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"223768c9_a9d34839","updated":"2021-11-17 14:00:09.000000000","message":"This is looking good.  Suggestion inline about handling the 404/500 get-default-type response.","commit_id":"275935c974546abb63ea4bfb60f5ddd4e8ac3447"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"05883abc172f5a1e42e1898d4561b59ab1ffa313","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"76f10785_7c29cefc","updated":"2021-11-18 15:29:30.000000000","message":"Marking review comments as Done.","commit_id":"ba28f29254319990897a7ce7a5529938f588eb17"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e6e0ec403183510e6a9095e4f523710b4a809791","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6e11faed_b1578a80","updated":"2021-11-18 09:22:05.000000000","message":"Thanks for the review Brian.","commit_id":"ba28f29254319990897a7ce7a5529938f588eb17"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4d66f2a700d21fe3adef31e055aaa9798e99d629","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"85026b9e_c0814e3e","updated":"2021-11-19 16:29:11.000000000","message":"This is a really good improvement.  Text reads well, and the HTML rendering looks good.\n\nNinja-approving a documentation change.","commit_id":"ba28f29254319990897a7ce7a5529938f588eb17"}],"api-ref/source/v3/volumes-v3-types.inc":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e5adebe7208141c8866ea9fda2da931527cf8d0f","unresolved":true,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":".. rest_method::  GET /v3/{project_id}/types/default"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"Shows details for the default volume type if configured. This could be one"},{"line_number":310,"context_line":"of the following:"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"- Project default"},{"line_number":313,"context_line":"- Volume type set as value of default_volume_type parameter in cinder.conf"},{"line_number":314,"context_line":"- ``__DEFAULT__``"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"``__DEFAULT__`` type acts as a placeholder to avoid creation of untyped"},{"line_number":317,"context_line":"volumes."},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"Response codes"},{"line_number":320,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"435051de_0746e35c","line":317,"range":{"start_line":309,"start_character":0,"end_line":317,"end_character":8},"updated":"2021-11-02 14:37:17.000000000","message":"I think we don\u0027t need to discuss __DEFAULT__ here, because if that\u0027s your default, then that\u0027s your default.  But I think you could do something like this for the text in this section:\n\n  Shows details for the default volume type, that is, the volume type that\n  will be used in the `Create a volume`_ request if you do not specify one.\n  This could be one of the following:\n  \n  - Your project\u0027s default volume type *(since microversion 3.62)*\n  - The installation\u0027s default volume type as configured by the operator\n  - A \"Not Found\" response (only in pre-Train versions of the\n    Block Storage service; a configured default volume type has been\n    required since the Train release)","commit_id":"a374b0ee7145720989ed6638c370abaf21a3986c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"05883abc172f5a1e42e1898d4561b59ab1ffa313","unresolved":false,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":".. rest_method::  GET /v3/{project_id}/types/default"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"Shows details for the default volume type if configured. This could be one"},{"line_number":310,"context_line":"of the following:"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"- Project default"},{"line_number":313,"context_line":"- Volume type set as value of default_volume_type parameter in cinder.conf"},{"line_number":314,"context_line":"- ``__DEFAULT__``"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"``__DEFAULT__`` type acts as a placeholder to avoid creation of untyped"},{"line_number":317,"context_line":"volumes."},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"Response codes"},{"line_number":320,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"6360314b_7b324266","line":317,"range":{"start_line":309,"start_character":0,"end_line":317,"end_character":8},"in_reply_to":"2694f42a_f69583c0","updated":"2021-11-18 15:29:30.000000000","message":"Done","commit_id":"a374b0ee7145720989ed6638c370abaf21a3986c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"598b0e0e6b1d2e31a9f6acbfc04cb893fe84bd71","unresolved":true,"context_lines":[{"line_number":306,"context_line":""},{"line_number":307,"context_line":".. rest_method::  GET /v3/{project_id}/types/default"},{"line_number":308,"context_line":""},{"line_number":309,"context_line":"Shows details for the default volume type if configured. This could be one"},{"line_number":310,"context_line":"of the following:"},{"line_number":311,"context_line":""},{"line_number":312,"context_line":"- Project default"},{"line_number":313,"context_line":"- Volume type set as value of default_volume_type parameter in cinder.conf"},{"line_number":314,"context_line":"- ``__DEFAULT__``"},{"line_number":315,"context_line":""},{"line_number":316,"context_line":"``__DEFAULT__`` type acts as a placeholder to avoid creation of untyped"},{"line_number":317,"context_line":"volumes."},{"line_number":318,"context_line":""},{"line_number":319,"context_line":"Response codes"},{"line_number":320,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"2694f42a_f69583c0","line":317,"range":{"start_line":309,"start_character":0,"end_line":317,"end_character":8},"in_reply_to":"435051de_0746e35c","updated":"2021-11-08 10:22:09.000000000","message":"In the third point i think it\u0027s better to mention the current response which is a 500 Internal Server Error response if the default volume type is not configured properly (raised by VolumeTypeDefaultMisconfiguredError)[1]\n\n[1] https://github.com/openstack/cinder/blob/master/cinder/volume/volume_types.py#L226-L227","commit_id":"a374b0ee7145720989ed6638c370abaf21a3986c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e5adebe7208141c8866ea9fda2da931527cf8d0f","unresolved":true,"context_lines":[{"line_number":356,"context_line":""},{"line_number":357,"context_line":".. rest_method::  DELETE /v3/{project_id}/types/{volume_type_id}"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"Deletes a volume type."},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"Response codes"},{"line_number":362,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"00129346_903787de","line":359,"updated":"2021-11-02 14:37:17.000000000","message":"Maybe add:\n\n  *Note to operators:* Since the Train release, untyped volumes are\n  not allowed, and a configured default volume type is required in each\n  deployment.  An attempt to delete the configured default volume type\n  will fail.","commit_id":"a374b0ee7145720989ed6638c370abaf21a3986c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"598b0e0e6b1d2e31a9f6acbfc04cb893fe84bd71","unresolved":false,"context_lines":[{"line_number":356,"context_line":""},{"line_number":357,"context_line":".. rest_method::  DELETE /v3/{project_id}/types/{volume_type_id}"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"Deletes a volume type."},{"line_number":360,"context_line":""},{"line_number":361,"context_line":"Response codes"},{"line_number":362,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"27ccfbfd_bf8e58c0","line":359,"in_reply_to":"00129346_903787de","updated":"2021-11-08 10:22:09.000000000","message":"Done","commit_id":"a374b0ee7145720989ed6638c370abaf21a3986c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e5adebe7208141c8866ea9fda2da931527cf8d0f","unresolved":true,"context_lines":[{"line_number":379,"context_line":"~~~~~~~~~~~~~~~~~~~~~"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":".. rest_method::  GET /v3/{project_id}/types"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"Lists volume types."},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"``NOTE:`` A volume type named ``__DEFAULT__`` will be visible in"},{"line_number":386,"context_line":"the response (if not deleted). ``__DEFAULT__`` type acts as a"},{"line_number":387,"context_line":"placeholder to avoid creation of untyped volumes."},{"line_number":388,"context_line":"If you want to avoid ``__DEFAULT__`` to be set as your volume\u0027s type"},{"line_number":389,"context_line":"then configure the default_volume_type parameter to a valid volume type"},{"line_number":390,"context_line":"(other than ``__DEFAULT__``) in the cinder.conf file or set a default"},{"line_number":391,"context_line":"type per project."},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"Response codes"},{"line_number":394,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"c2ff2b20_3a3e6f16","line":391,"range":{"start_line":382,"start_character":0,"end_line":391,"end_character":17},"updated":"2021-11-02 14:37:17.000000000","message":"How about this instead:\n\n  Lists the available volume types.\n  \n  To determine which of these is the default type that will be used if you\n  do not specify one in the `Create a volume`_ request, use the\n  `Show default volume type`_ request.\n  \n  *Note to users:* There may be a volume type named ``__DEFAULT__`` in the\n  list.  Confusingly, it may not be your default volume type.  To create a\n  volume of *your* default volume type, simply omit the ``volume_type``\n  parameter in your `Create a volume`_ request.\n  \n  *Note to operators:* The ``__DEFAULT__`` volume type was introduced in\n  the Train release as a placeholder to prevent the creation of untyped\n  volumes.  Under the proper conditions, it may be removed from your\n  deployment.  Consult the `Cinder Administration Guide\n  \u003chttps://docs.openstack.org/cinder/latest/admin/index.html\u003e`_\n  for details.","commit_id":"a374b0ee7145720989ed6638c370abaf21a3986c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"598b0e0e6b1d2e31a9f6acbfc04cb893fe84bd71","unresolved":true,"context_lines":[{"line_number":379,"context_line":"~~~~~~~~~~~~~~~~~~~~~"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":".. rest_method::  GET /v3/{project_id}/types"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"Lists volume types."},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"``NOTE:`` A volume type named ``__DEFAULT__`` will be visible in"},{"line_number":386,"context_line":"the response (if not deleted). ``__DEFAULT__`` type acts as a"},{"line_number":387,"context_line":"placeholder to avoid creation of untyped volumes."},{"line_number":388,"context_line":"If you want to avoid ``__DEFAULT__`` to be set as your volume\u0027s type"},{"line_number":389,"context_line":"then configure the default_volume_type parameter to a valid volume type"},{"line_number":390,"context_line":"(other than ``__DEFAULT__``) in the cinder.conf file or set a default"},{"line_number":391,"context_line":"type per project."},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"Response codes"},{"line_number":394,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"c77a68bf_38471bfc","line":391,"range":{"start_line":382,"start_character":0,"end_line":391,"end_character":17},"in_reply_to":"c2ff2b20_3a3e6f16","updated":"2021-11-08 10:22:09.000000000","message":"In *Note to users:*, i think we don\u0027t want to promote end users to prefer the default over providing their volume types in request but rather default types are a fail safe mechanism to avoid creating volumes into unwanted backends (decided by scheduler)\nI\u0027ve updated the text, let me know what you think?\n\nIn *Note to operators:*, I\u0027m not sure the admin docs tell a lot about default types and conditions to remove __DEFAULT__, i think [1] would be a better reference?\n\n[1] https://docs.openstack.org/releasenotes/cinder/train.html#other-notes","commit_id":"a374b0ee7145720989ed6638c370abaf21a3986c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"05883abc172f5a1e42e1898d4561b59ab1ffa313","unresolved":false,"context_lines":[{"line_number":379,"context_line":"~~~~~~~~~~~~~~~~~~~~~"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":".. rest_method::  GET /v3/{project_id}/types"},{"line_number":382,"context_line":""},{"line_number":383,"context_line":"Lists volume types."},{"line_number":384,"context_line":""},{"line_number":385,"context_line":"``NOTE:`` A volume type named ``__DEFAULT__`` will be visible in"},{"line_number":386,"context_line":"the response (if not deleted). ``__DEFAULT__`` type acts as a"},{"line_number":387,"context_line":"placeholder to avoid creation of untyped volumes."},{"line_number":388,"context_line":"If you want to avoid ``__DEFAULT__`` to be set as your volume\u0027s type"},{"line_number":389,"context_line":"then configure the default_volume_type parameter to a valid volume type"},{"line_number":390,"context_line":"(other than ``__DEFAULT__``) in the cinder.conf file or set a default"},{"line_number":391,"context_line":"type per project."},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"Response codes"},{"line_number":394,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"3361983c_18663356","line":391,"range":{"start_line":382,"start_character":0,"end_line":391,"end_character":17},"in_reply_to":"c77a68bf_38471bfc","updated":"2021-11-18 15:29:30.000000000","message":"Done","commit_id":"a374b0ee7145720989ed6638c370abaf21a3986c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"92abaed7617a5edd83bb86608157bc472277b367","unresolved":true,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"- Your project\u0027s default volume type *(since microversion 3.62)*"},{"line_number":314,"context_line":"- The installation\u0027s default volume type as configured by the operator"},{"line_number":315,"context_line":"- An Internal Server Error Response (A \"Not Found\" response was returned"},{"line_number":316,"context_line":"  in pre-Train versions of the Block Storage service; a configured default"},{"line_number":317,"context_line":"  volume type has been required since the Train release and not configuring"},{"line_number":318,"context_line":"  it correctly will return the Internal Server Error response)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"Response codes"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"23668963_7c3f7c6e","line":317,"range":{"start_line":315,"start_character":0,"end_line":317,"end_character":75},"updated":"2021-11-17 14:00:09.000000000","message":"You make a good point about this text.  But since the \"This\" at line 311 is referring to the volume type, this third point really shouldn\u0027t be here.  I suggest that we add 404 and 500 to the \"Response codes\" section below, and since we don\u0027t have control over the text that gets displayed there, let\u0027s add something like the following, probably after \"Response codes\" but before \"Request\":\n\n\n  Error conditions\n  ----------------\n  \n  It is only possible to receive a 404 (Not Found) response in pre-Train\n  versions of the Block Storage service, as a configured default volume\n  type has been required since the Train release.\n  \n  If you receive a 500 (Internal Error Response), then the default volume\n  type has not been configured correctly by the operator.  Please contact\n  your cloud provider.\n  \n  * When the default volume type is misconfigured, requests to\n    `Create a volume`_ that do not include a volume type will\n    fail.\n  * The workaround is to include a volume type in your request.  You\n    can `List all volume types`_ to determine a volume type to use.","commit_id":"275935c974546abb63ea4bfb60f5ddd4e8ac3447"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e6e0ec403183510e6a9095e4f523710b4a809791","unresolved":false,"context_lines":[{"line_number":312,"context_line":""},{"line_number":313,"context_line":"- Your project\u0027s default volume type *(since microversion 3.62)*"},{"line_number":314,"context_line":"- The installation\u0027s default volume type as configured by the operator"},{"line_number":315,"context_line":"- An Internal Server Error Response (A \"Not Found\" response was returned"},{"line_number":316,"context_line":"  in pre-Train versions of the Block Storage service; a configured default"},{"line_number":317,"context_line":"  volume type has been required since the Train release and not configuring"},{"line_number":318,"context_line":"  it correctly will return the Internal Server Error response)"},{"line_number":319,"context_line":""},{"line_number":320,"context_line":"Response codes"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"38ff32dd_d329b02d","line":317,"range":{"start_line":315,"start_character":0,"end_line":317,"end_character":75},"in_reply_to":"23668963_7c3f7c6e","updated":"2021-11-18 09:22:05.000000000","message":"Done","commit_id":"275935c974546abb63ea4bfb60f5ddd4e8ac3447"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"92abaed7617a5edd83bb86608157bc472277b367","unresolved":true,"context_lines":[{"line_number":393,"context_line":"`Show default volume type`_ request."},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"*Note to users:* There may be a volume type named ``__DEFAULT__`` in the"},{"line_number":396,"context_line":"list.  Confusingly, it may not be your default volume type. If you omit"},{"line_number":397,"context_line":"the ``volume_type`` parameter in your `Create a volume`_ request, the"},{"line_number":398,"context_line":"volume will be created with *your* default volume type."},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"*Note to operators:* The ``__DEFAULT__`` volume type was introduced in"},{"line_number":401,"context_line":"the Train release as a placeholder to prevent the creation of untyped"},{"line_number":402,"context_line":"volumes.  Under the proper conditions, it may be removed from your"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"ac3aa16a_3a92f6b3","line":399,"range":{"start_line":396,"start_character":7,"end_line":399,"end_character":0},"updated":"2021-11-17 14:00:09.000000000","message":"You make a good point.  Maybe say something like\n\n  Do not use this volume type in a `Create a volume`_ request.  If you\n  wish to create a volume of *your* default volume type, simply omit the\n  ``volume_type`` parameter in your `Create a volume`_ request.\n\nNot sure I really liket that, though.  Hopefully some other reviewer will have a good idea about how to make this point.","commit_id":"275935c974546abb63ea4bfb60f5ddd4e8ac3447"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"05883abc172f5a1e42e1898d4561b59ab1ffa313","unresolved":false,"context_lines":[{"line_number":393,"context_line":"`Show default volume type`_ request."},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"*Note to users:* There may be a volume type named ``__DEFAULT__`` in the"},{"line_number":396,"context_line":"list.  Confusingly, it may not be your default volume type. If you omit"},{"line_number":397,"context_line":"the ``volume_type`` parameter in your `Create a volume`_ request, the"},{"line_number":398,"context_line":"volume will be created with *your* default volume type."},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"*Note to operators:* The ``__DEFAULT__`` volume type was introduced in"},{"line_number":401,"context_line":"the Train release as a placeholder to prevent the creation of untyped"},{"line_number":402,"context_line":"volumes.  Under the proper conditions, it may be removed from your"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"f7fee730_12accca2","line":399,"range":{"start_line":396,"start_character":7,"end_line":399,"end_character":0},"in_reply_to":"1b1febf4_86ced33f","updated":"2021-11-18 15:29:30.000000000","message":"Done","commit_id":"275935c974546abb63ea4bfb60f5ddd4e8ac3447"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e6e0ec403183510e6a9095e4f523710b4a809791","unresolved":true,"context_lines":[{"line_number":393,"context_line":"`Show default volume type`_ request."},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"*Note to users:* There may be a volume type named ``__DEFAULT__`` in the"},{"line_number":396,"context_line":"list.  Confusingly, it may not be your default volume type. If you omit"},{"line_number":397,"context_line":"the ``volume_type`` parameter in your `Create a volume`_ request, the"},{"line_number":398,"context_line":"volume will be created with *your* default volume type."},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"*Note to operators:* The ``__DEFAULT__`` volume type was introduced in"},{"line_number":401,"context_line":"the Train release as a placeholder to prevent the creation of untyped"},{"line_number":402,"context_line":"volumes.  Under the proper conditions, it may be removed from your"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"1b1febf4_86ced33f","line":399,"range":{"start_line":396,"start_character":7,"end_line":399,"end_character":0},"in_reply_to":"ac3aa16a_3a92f6b3","updated":"2021-11-18 09:22:05.000000000","message":"I think it\u0027s too restrictive to say \u0027not to use this type\u0027. There might be a case where operator has used the __DEFAULT__ for a case where the default_volume_type is different and the user needs to use __DEFAULT__ to create volumes in a specific backend. I\u0027ve slightly updated the text. let me know what you think.","commit_id":"275935c974546abb63ea4bfb60f5ddd4e8ac3447"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4d66f2a700d21fe3adef31e055aaa9798e99d629","unresolved":false,"context_lines":[{"line_number":393,"context_line":"`Show default volume type`_ request."},{"line_number":394,"context_line":""},{"line_number":395,"context_line":"*Note to users:* There may be a volume type named ``__DEFAULT__`` in the"},{"line_number":396,"context_line":"list.  Confusingly, it may not be your default volume type. If you omit"},{"line_number":397,"context_line":"the ``volume_type`` parameter in your `Create a volume`_ request, the"},{"line_number":398,"context_line":"volume will be created with *your* default volume type."},{"line_number":399,"context_line":""},{"line_number":400,"context_line":"*Note to operators:* The ``__DEFAULT__`` volume type was introduced in"},{"line_number":401,"context_line":"the Train release as a placeholder to prevent the creation of untyped"},{"line_number":402,"context_line":"volumes.  Under the proper conditions, it may be removed from your"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"27d8c822_f196909d","line":399,"range":{"start_line":396,"start_character":7,"end_line":399,"end_character":0},"in_reply_to":"f7fee730_12accca2","updated":"2021-11-19 16:29:11.000000000","message":"Good point about my suggestion being too restrictive.  I like what you came up with much better!","commit_id":"275935c974546abb63ea4bfb60f5ddd4e8ac3447"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"92abaed7617a5edd83bb86608157bc472277b367","unresolved":true,"context_lines":[{"line_number":400,"context_line":"*Note to operators:* The ``__DEFAULT__`` volume type was introduced in"},{"line_number":401,"context_line":"the Train release as a placeholder to prevent the creation of untyped"},{"line_number":402,"context_line":"volumes.  Under the proper conditions, it may be removed from your"},{"line_number":403,"context_line":"deployment.  Consult the `Train series release notes"},{"line_number":404,"context_line":"\u003chttps://docs.openstack.org/releasenotes/cinder/train.html#other-notes\u003e`_"},{"line_number":405,"context_line":"for details."},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"Response codes"},{"line_number":408,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"071fc464_11ef6947","line":405,"range":{"start_line":403,"start_character":13,"end_line":405,"end_character":12},"updated":"2021-11-17 14:00:09.000000000","message":"You\u0027re right that there\u0027s not much currently in the admin docs.  They need to be updated because we can\u0027t really expect someone installing Xena to read all previous release notes ... they expect that the Xena docs tell them what they need to know.  So I think we should link to the admin docs here, but put up another patch copying the content from the release notes to the admin docs.  (What you have here is fine short-term, though.  You can change this reference as part of the patch that updates/creates the admin doc about volume types.)","commit_id":"275935c974546abb63ea4bfb60f5ddd4e8ac3447"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e6e0ec403183510e6a9095e4f523710b4a809791","unresolved":false,"context_lines":[{"line_number":400,"context_line":"*Note to operators:* The ``__DEFAULT__`` volume type was introduced in"},{"line_number":401,"context_line":"the Train release as a placeholder to prevent the creation of untyped"},{"line_number":402,"context_line":"volumes.  Under the proper conditions, it may be removed from your"},{"line_number":403,"context_line":"deployment.  Consult the `Train series release notes"},{"line_number":404,"context_line":"\u003chttps://docs.openstack.org/releasenotes/cinder/train.html#other-notes\u003e`_"},{"line_number":405,"context_line":"for details."},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"Response codes"},{"line_number":408,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"73763b52_f3c42a00","line":405,"range":{"start_line":403,"start_character":13,"end_line":405,"end_character":12},"in_reply_to":"071fc464_11ef6947","updated":"2021-11-18 09:22:05.000000000","message":"Ack, i will update in a followup patch where i will add the admin documentation as well for the same. Thanks.","commit_id":"275935c974546abb63ea4bfb60f5ddd4e8ac3447"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"635f486b0380c95e2d039ef9d28b5080e18da42f","unresolved":false,"context_lines":[{"line_number":400,"context_line":"*Note to operators:* The ``__DEFAULT__`` volume type was introduced in"},{"line_number":401,"context_line":"the Train release as a placeholder to prevent the creation of untyped"},{"line_number":402,"context_line":"volumes.  Under the proper conditions, it may be removed from your"},{"line_number":403,"context_line":"deployment.  Consult the `Train series release notes"},{"line_number":404,"context_line":"\u003chttps://docs.openstack.org/releasenotes/cinder/train.html#other-notes\u003e`_"},{"line_number":405,"context_line":"for details."},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"Response codes"},{"line_number":408,"context_line":"--------------"}],"source_content_type":"text/x-c++src","patch_set":2,"id":"71c426ec_e35d291c","line":405,"range":{"start_line":403,"start_character":13,"end_line":405,"end_character":12},"in_reply_to":"73763b52_f3c42a00","updated":"2021-11-19 10:15:47.000000000","message":"Updated the admin docs here https://review.opendev.org/c/openstack/cinder/+/818528","commit_id":"275935c974546abb63ea4bfb60f5ddd4e8ac3447"}],"api-ref/source/v3/volumes-v3-volumes.inc":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e5adebe7208141c8866ea9fda2da931527cf8d0f","unresolved":true,"context_lines":[{"line_number":190,"context_line":"- The storage node needs enough free storage space to match the size"},{"line_number":191,"context_line":"  of the volume creation request."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"``NOTE:`` If we don\u0027t pass the volume type parameter, a default volume type"},{"line_number":194,"context_line":"is assigned to the volume. The volume type could be one of the following:"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"- Project default"},{"line_number":197,"context_line":"- Volume type set as value of default_volume_type parameter in cinder.conf"},{"line_number":198,"context_line":"- ``__DEFAULT__``"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"``__DEFAULT__`` is a volume type that acts as a placeholder to avoid creating"},{"line_number":202,"context_line":"untyped volumes."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"Response codes"},{"line_number":205,"context_line":"--------------"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"bc1cf896_94cda074","line":203,"range":{"start_line":193,"start_character":0,"end_line":203,"end_character":0},"updated":"2021-11-02 14:37:17.000000000","message":"Instead of hiding this down here, I suggest adding a new paragraph after line 166:\n\n  Since the Train release, every volume must have a volume type.  It\n  is **optional** to specify a volume type as part of your `Create a\n  volume` request.  If you do not specify one, a default volume type\n  will be supplied for you.  This type may vary according to what\n  project you are in and how the operator has configured the Block\n  Storage service.  Use the `Show default volume type`_ request to\n  determine your effective default volume type.","commit_id":"a374b0ee7145720989ed6638c370abaf21a3986c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"598b0e0e6b1d2e31a9f6acbfc04cb893fe84bd71","unresolved":false,"context_lines":[{"line_number":190,"context_line":"- The storage node needs enough free storage space to match the size"},{"line_number":191,"context_line":"  of the volume creation request."},{"line_number":192,"context_line":""},{"line_number":193,"context_line":"``NOTE:`` If we don\u0027t pass the volume type parameter, a default volume type"},{"line_number":194,"context_line":"is assigned to the volume. The volume type could be one of the following:"},{"line_number":195,"context_line":""},{"line_number":196,"context_line":"- Project default"},{"line_number":197,"context_line":"- Volume type set as value of default_volume_type parameter in cinder.conf"},{"line_number":198,"context_line":"- ``__DEFAULT__``"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"``__DEFAULT__`` is a volume type that acts as a placeholder to avoid creating"},{"line_number":202,"context_line":"untyped volumes."},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"Response codes"},{"line_number":205,"context_line":"--------------"},{"line_number":206,"context_line":""}],"source_content_type":"text/x-c++src","patch_set":1,"id":"d85ba420_f8ba1087","line":203,"range":{"start_line":193,"start_character":0,"end_line":203,"end_character":0},"in_reply_to":"bc1cf896_94cda074","updated":"2021-11-08 10:22:09.000000000","message":"Done","commit_id":"a374b0ee7145720989ed6638c370abaf21a3986c"}]}