)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c636aaad99f7b9d9acb7b0fb392f1db697f3c46d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"10ee89ae_65ddfd08","updated":"2021-11-02 16:25:27.000000000","message":"I think you\u0027ve found an appropriate place for this statement.  Some suggestions for clarification are noted inline.","commit_id":"8301490823e1c0cb43cbffe2f76ee78bf91ce45f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"391b8c8dee4a38316a4d7770f9491b0fd44e43a4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ef13cfae_e798099e","updated":"2021-11-17 16:31:30.000000000","message":"Looks good, though there\u0027s a point noted inline I\u0027d like you to think about.","commit_id":"0e31b0379f1d34c3ac22028d439e33ad9375aa29"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e945229b4e495f4635f31f4004768f0c54fe27d5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0e9eb429_50a0d288","updated":"2021-11-08 15:33:17.000000000","message":"Thanks Brian for the suggestions on these doc improvements. Please see my reply inline.","commit_id":"0e31b0379f1d34c3ac22028d439e33ad9375aa29"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"005838cd2efd67f14f7bc9d9f643356ea8a781ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5cc87e29_b48bc2df","updated":"2021-11-18 15:30:13.000000000","message":"Marking review comments as Done.","commit_id":"d259197c24e5376ce701d3d6510ba6d78023a194"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0c37c81325305b1d8f804f7d419360ab9175b677","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"959f71ff_419fe6ae","updated":"2021-11-18 07:59:40.000000000","message":"Thanks for the review Brian. Updated the text with your suggestion.","commit_id":"d259197c24e5376ce701d3d6510ba6d78023a194"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ab038a723e51795efb02627c68d87e5edcdac4b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"075da43a_2055db75","updated":"2021-11-19 16:12:38.000000000","message":"This reads well, and is a good addition to our docs.\n\nNinja-approving a documentation change.","commit_id":"d259197c24e5376ce701d3d6510ba6d78023a194"}],"doc/source/install/get-started-block-storage.rst":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c636aaad99f7b9d9acb7b0fb392f1db697f3c46d","unresolved":true,"context_lines":[{"line_number":7,"context_line":"volumes, and interacts with OpenStack Compute to provide volumes for"},{"line_number":8,"context_line":"instances. The service also enables management of volume snapshots, and"},{"line_number":9,"context_line":"volume types."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The Block Storage service consists of the following components:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"cinder-api"}],"source_content_type":"text/x-rst","patch_set":1,"id":"1b6f223a_13cc0e33","line":10,"updated":"2021-11-02 16:25:27.000000000","message":"I suggest adding a heading here (because I\u0027m going to suggest adding another one below):\n\n  Components\n  ----------","commit_id":"8301490823e1c0cb43cbffe2f76ee78bf91ce45f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"005838cd2efd67f14f7bc9d9f643356ea8a781ee","unresolved":false,"context_lines":[{"line_number":7,"context_line":"volumes, and interacts with OpenStack Compute to provide volumes for"},{"line_number":8,"context_line":"instances. The service also enables management of volume snapshots, and"},{"line_number":9,"context_line":"volume types."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"The Block Storage service consists of the following components:"},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"cinder-api"}],"source_content_type":"text/x-rst","patch_set":1,"id":"85ae9277_33dab3ea","line":10,"in_reply_to":"1b6f223a_13cc0e33","updated":"2021-11-18 15:30:13.000000000","message":"Done","commit_id":"8301490823e1c0cb43cbffe2f76ee78bf91ce45f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"c636aaad99f7b9d9acb7b0fb392f1db697f3c46d","unresolved":true,"context_lines":[{"line_number":35,"context_line":"Messaging queue"},{"line_number":36,"context_line":"  Routes information between the Block Storage processes."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"After installation, a new volume type named ``__DEFAULT__`` will be created"},{"line_number":39,"context_line":"by cinder. This type is used as a placeholder to avoid creating untyped volumes."},{"line_number":40,"context_line":"To avoid your volume\u0027s getting ``__DEFAULT__`` as a type and to be able to delete"},{"line_number":41,"context_line":"the ``__DEFAULT__`` type, the operator should set a valid volume type as value of"},{"line_number":42,"context_line":"default_volume_type config in cinder.conf. By default, it is set as ``__DEFAULT__``."}],"source_content_type":"text/x-rst","patch_set":1,"id":"a3354263_8f4d0865","line":42,"range":{"start_line":38,"start_character":0,"end_line":42,"end_character":84},"updated":"2021-11-02 16:25:27.000000000","message":"I suggest adding a heading here and some more details to make this clear to operators.  Something like:\n\n  The default volume type\n  -----------------------\n  \n  Since the Train release, it is required that each volume must have a\n  *volume type*, and thus the required configuration option\n  ``default_volume_type`` must have a value.  A system-defined volume type\n  named ``__DEFAULT__`` is created in the database during installation and\n  is the default value of the ``default_volume_type`` configuration option.\n  \n  You (or your deployment tool) may wish to have a different volume type that\n  is more suitable for your particular installation as the default type.\n  This can be accomplished by creating the volume type you want using the\n  Block Storage API, and then setting that volume type as the value for\n  the configuration option.  (The latter operation, of course, cannot be\n  done via the Block Storage API.)\n  \n  The system defined ``__DEFAULT__`` volume type is a regular volume type\n  that may be updated or deleted.  There is nothing special about it.  It only\n  exists because there must always be at least one volume type in a cinder\n  deployment, and before the Block Storage API comes up, there is no way for\n  there to be a volume type unless the system creates it.\n  \n  Given that since the Victoria release it is possible to set a default\n  volume type for any project, having a volume type named ``__DEFAULT__``\n  in your deployment may be confusing to your users, leading them to\n  specifically request ``__DEFAULT__`` when creating a volume instead of\n  simply using the default volume type that you have configured for the\n  system or for their project.\n  \n  If you don\u0027t wish to use the ``__DEFAULT__`` type, you may delete it.  The\n  Block Storage API will prevent deletion under these circumstances:\n  \n  * If ``__DEFAULT__`` is the value of the ``default_volume_type`` configuration\n    option then it cannot be deleted.  The solution is to make a different\n    volume type the value of that configuration option.\n  * If there are volumes in the deployment of the ``__DEFAULT__`` type, then\n    it cannot be deleted.  The solution is to retype those volumes to some\n    other appropriate volume type.","commit_id":"8301490823e1c0cb43cbffe2f76ee78bf91ce45f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fa278d5a93fd13d2eb3cadda50b90f738f86b840","unresolved":true,"context_lines":[{"line_number":35,"context_line":"Messaging queue"},{"line_number":36,"context_line":"  Routes information between the Block Storage processes."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"After installation, a new volume type named ``__DEFAULT__`` will be created"},{"line_number":39,"context_line":"by cinder. This type is used as a placeholder to avoid creating untyped volumes."},{"line_number":40,"context_line":"To avoid your volume\u0027s getting ``__DEFAULT__`` as a type and to be able to delete"},{"line_number":41,"context_line":"the ``__DEFAULT__`` type, the operator should set a valid volume type as value of"},{"line_number":42,"context_line":"default_volume_type config in cinder.conf. By default, it is set as ``__DEFAULT__``."}],"source_content_type":"text/x-rst","patch_set":1,"id":"d25454ae_a8aeb3fa","line":42,"range":{"start_line":38,"start_character":0,"end_line":42,"end_character":84},"in_reply_to":"a3354263_8f4d0865","updated":"2021-11-02 16:27:41.000000000","message":"(BTW, the pep8 failure was that there wasn\u0027t a newline at end of the file, so watch for that when you update your patch.)","commit_id":"8301490823e1c0cb43cbffe2f76ee78bf91ce45f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"005838cd2efd67f14f7bc9d9f643356ea8a781ee","unresolved":false,"context_lines":[{"line_number":35,"context_line":"Messaging queue"},{"line_number":36,"context_line":"  Routes information between the Block Storage processes."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"After installation, a new volume type named ``__DEFAULT__`` will be created"},{"line_number":39,"context_line":"by cinder. This type is used as a placeholder to avoid creating untyped volumes."},{"line_number":40,"context_line":"To avoid your volume\u0027s getting ``__DEFAULT__`` as a type and to be able to delete"},{"line_number":41,"context_line":"the ``__DEFAULT__`` type, the operator should set a valid volume type as value of"},{"line_number":42,"context_line":"default_volume_type config in cinder.conf. By default, it is set as ``__DEFAULT__``."}],"source_content_type":"text/x-rst","patch_set":1,"id":"0ce5130d_4180505a","line":42,"range":{"start_line":38,"start_character":0,"end_line":42,"end_character":84},"in_reply_to":"c02d40ab_71d7a303","updated":"2021-11-18 15:30:13.000000000","message":"Done","commit_id":"8301490823e1c0cb43cbffe2f76ee78bf91ce45f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e945229b4e495f4635f31f4004768f0c54fe27d5","unresolved":true,"context_lines":[{"line_number":35,"context_line":"Messaging queue"},{"line_number":36,"context_line":"  Routes information between the Block Storage processes."},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"After installation, a new volume type named ``__DEFAULT__`` will be created"},{"line_number":39,"context_line":"by cinder. This type is used as a placeholder to avoid creating untyped volumes."},{"line_number":40,"context_line":"To avoid your volume\u0027s getting ``__DEFAULT__`` as a type and to be able to delete"},{"line_number":41,"context_line":"the ``__DEFAULT__`` type, the operator should set a valid volume type as value of"},{"line_number":42,"context_line":"default_volume_type config in cinder.conf. By default, it is set as ``__DEFAULT__``."}],"source_content_type":"text/x-rst","patch_set":1,"id":"c02d40ab_71d7a303","line":42,"range":{"start_line":38,"start_character":0,"end_line":42,"end_character":84},"in_reply_to":"d25454ae_a8aeb3fa","updated":"2021-11-08 15:33:17.000000000","message":"Thanks for the detailed doc! I\u0027ve changed the fourth paragraph a bit since default types are not something user requests but a fail safe mechanism when no type is provided by the user.\n(Also thanks for pointing out the pep8 failure)","commit_id":"8301490823e1c0cb43cbffe2f76ee78bf91ce45f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"391b8c8dee4a38316a4d7770f9491b0fd44e43a4","unresolved":true,"context_lines":[{"line_number":61,"context_line":"volume type for any project, having a volume type named ``__DEFAULT__``"},{"line_number":62,"context_line":"in your deployment may be confusing to your users, leading them to think this"},{"line_number":63,"context_line":"is the type that will be assigned while creating volumes instead of the actual"},{"line_number":64,"context_line":"configured default type for the system or their project."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"If you don\u0027t wish to use the ``__DEFAULT__`` type, you may delete it.  The"},{"line_number":67,"context_line":"Block Storage API will prevent deletion under these circumstances:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"2e2b89bf_8e92a4bb","line":64,"updated":"2021-11-17 16:31:30.000000000","message":"What you say here is correct, but I think the source of https://bugs.launchpad.net/cinder/+bug/1886632 was that users would do\n\n  cinder type-list\n\nsee __DEFAULT__ in there, and then do\n\n  cinder create --volume-type __DEFAULT__ 22\n\nwhich would mean that the actually configured default type was not being used to create the requested volume.  It\u0027s kind of an obvious point, but I think it\u0027s worth pointing out, so that operators realize the implications of not deleting __DEFAULT__.","commit_id":"0e31b0379f1d34c3ac22028d439e33ad9375aa29"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0c37c81325305b1d8f804f7d419360ab9175b677","unresolved":false,"context_lines":[{"line_number":61,"context_line":"volume type for any project, having a volume type named ``__DEFAULT__``"},{"line_number":62,"context_line":"in your deployment may be confusing to your users, leading them to think this"},{"line_number":63,"context_line":"is the type that will be assigned while creating volumes instead of the actual"},{"line_number":64,"context_line":"configured default type for the system or their project."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"If you don\u0027t wish to use the ``__DEFAULT__`` type, you may delete it.  The"},{"line_number":67,"context_line":"Block Storage API will prevent deletion under these circumstances:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"e02a2379_e808236f","line":64,"in_reply_to":"2e2b89bf_8e92a4bb","updated":"2021-11-18 07:59:40.000000000","message":"I\u0027m not too sure as i couldn\u0027t find a similar reference in the reported bug when we are creating a volume with the __DEFAULT__ type. I see the intention there is to delete the __DEFAULT__ when we already have another default configured via default_volume_type.\nHaving said that, I understand your point and it\u0027s no harm providing extra information so i will update the text to reflect that as well.","commit_id":"0e31b0379f1d34c3ac22028d439e33ad9375aa29"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ab038a723e51795efb02627c68d87e5edcdac4b8","unresolved":false,"context_lines":[{"line_number":61,"context_line":"volume type for any project, having a volume type named ``__DEFAULT__``"},{"line_number":62,"context_line":"in your deployment may be confusing to your users, leading them to think this"},{"line_number":63,"context_line":"is the type that will be assigned while creating volumes instead of the actual"},{"line_number":64,"context_line":"configured default type for the system or their project."},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"If you don\u0027t wish to use the ``__DEFAULT__`` type, you may delete it.  The"},{"line_number":67,"context_line":"Block Storage API will prevent deletion under these circumstances:"}],"source_content_type":"text/x-rst","patch_set":2,"id":"891897bc_1e89ad33","line":64,"in_reply_to":"e02a2379_e808236f","updated":"2021-11-19 16:12:38.000000000","message":"You are correct, it\u0027s not explicitly stated in the bug.  I was just imagining this was what the problem was! Thanks for making the update, though, I think it\u0027s an improvement.","commit_id":"0e31b0379f1d34c3ac22028d439e33ad9375aa29"}]}