)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"229861c46ab1e7475f724aec51a17355a80e4401","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"60525a6a_4b6ed38c","updated":"2021-12-22 23:26:55.000000000","message":"Agree with Walt\u0027s suggestion inline.  Otherwise, everything looks good.  Excellent unit test coverage and the documentation looks fine when rendered into HTML.\n\nMake sure you rebase your patch on master after making the change.  (I was getting unit test failures before rebasing.)","commit_id":"a7addcfc99c42916d49c205d180a855566a5e323"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"cf2b77bd39b3158c71ee1b4d77769fca5e67a5cb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f82236d9_5be92ee0","updated":"2021-11-23 15:57:18.000000000","message":"I\u0027m not an expert on this driver so I\u0027m okay with this path.\n\nBe careful because the revert snapshot tests don\u0027t run on dsvm-tempest-TOYOU-ACS5000-driver so as long as you tested  revert to Snapshot functionality yourself I\u0027m fine with it. ","commit_id":"a7addcfc99c42916d49c205d180a855566a5e323"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"75b9f98b082912872e5948baf6c27a112fbc0222","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eabcc65e_2086cab3","updated":"2021-12-02 06:57:34.000000000","message":"LGTM","commit_id":"a7addcfc99c42916d49c205d180a855566a5e323"},{"author":{"_account_id":32833,"name":"yangheng","email":"yangheng@toyou.com.cn","username":"yangheng"},"change_message_id":"22eeceafebd29221af6a4b7d88b1ec460704b801","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"58cde146_50bb621b","updated":"2021-11-24 01:18:34.000000000","message":"Reply to comment.","commit_id":"a7addcfc99c42916d49c205d180a855566a5e323"},{"author":{"_account_id":14624,"name":"Sam Wan","email":"sam.wan@emc.com","username":"samwan"},"change_message_id":"280613de6ca88139506846a3f146192b07202f00","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"072a195c_9c91c198","updated":"2021-11-19 04:57:08.000000000","message":"run-DellEMC SC CI","commit_id":"a7addcfc99c42916d49c205d180a855566a5e323"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"30438f485a846356a06522e1c7f4776016cd7ec8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"75b6eb89_0e2687cc","updated":"2021-11-19 03:49:34.000000000","message":"run-TOYOU ACS5000 CI","commit_id":"a7addcfc99c42916d49c205d180a855566a5e323"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"524049afe5f52859a9b2e4164562abb85f2a1399","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"5aed5d58_63563716","in_reply_to":"60525a6a_4b6ed38c","updated":"2021-12-23 15:02:27.000000000","message":"thanks for your suggestion. I will delete it.","commit_id":"a7addcfc99c42916d49c205d180a855566a5e323"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"62b91cd426c4f9c7bdca116dac37bff274a3b8f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"09d4f646_ec7b8c58","in_reply_to":"eabcc65e_2086cab3","updated":"2021-12-02 07:39:06.000000000","message":"thanks for your code review","commit_id":"a7addcfc99c42916d49c205d180a855566a5e323"},{"author":{"_account_id":32833,"name":"yangheng","email":"yangheng@toyou.com.cn","username":"yangheng"},"change_message_id":"22eeceafebd29221af6a4b7d88b1ec460704b801","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a8a075e5_7e2915cf","in_reply_to":"f82236d9_5be92ee0","updated":"2021-11-24 01:18:34.000000000","message":"Thank you for your review. \n\nWe have tested the revert to snapshot by validating data against the block and the file system on the block.","commit_id":"a7addcfc99c42916d49c205d180a855566a5e323"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"7ce441c465dbfab68954ed5980729b8bd6e81b57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9fd88113_ad591b95","updated":"2021-12-24 04:18:31.000000000","message":"recheck","commit_id":"27a81fe41c57f1a02d3a36119b4104a5d5ba6c9f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1947f8d059d210d6bf498975fb9339bf4ff38f63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6dfd09c0_a8b03a68","updated":"2022-01-10 15:20:44.000000000","message":"Code and tests look good and 3rd party CI is running the appropriate tests (including cinder-tempest-plugin) and passing.","commit_id":"2bdc0867839ae7c2ca8a669a137c270413ec38d3"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"258ef935df0f4dcb7743dd99cf0208344a5d6364","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"eca276d1_cd4fb9d7","updated":"2021-12-28 15:17:04.000000000","message":"TOYOU ACS5000 CI passed and code looks good. However, I think this is going to be on hold until the end of the holiday season. ","commit_id":"2bdc0867839ae7c2ca8a669a137c270413ec38d3"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"c7a0f71e5d3540c137a76026789f684f8fbd293a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0044a021_29974bd3","updated":"2023-06-25 05:24:22.000000000","message":"run-TOYOU ACS5000 CI","commit_id":"2bdc0867839ae7c2ca8a669a137c270413ec38d3"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"971bd371be2c4b008dbc830611d36e2057d9a015","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"0e9094df_18c9be5e","updated":"2023-06-24 14:31:53.000000000","message":"run-TOYOU ACS5000 CI","commit_id":"2bdc0867839ae7c2ca8a669a137c270413ec38d3"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"0cbd552617bbbb5ab9992abb6c615dcce9f3a5e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1e2adab9_b6f665c7","updated":"2023-06-25 05:20:51.000000000","message":"run-TOYOU ACS5000 CI","commit_id":"2bdc0867839ae7c2ca8a669a137c270413ec38d3"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"8b3b22e8f46a1307550a2ffa9915961553b186c1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1eaf318c_92038f8b","updated":"2023-06-24 13:37:53.000000000","message":"run-TOYOU ACS5000 CI","commit_id":"2bdc0867839ae7c2ca8a669a137c270413ec38d3"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"69629a279b35fd985d0bc72e2831863e700f8340","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"20f21907_31b72ee1","updated":"2023-06-24 13:12:38.000000000","message":"run-TOYOU ACS5000 CI","commit_id":"2bdc0867839ae7c2ca8a669a137c270413ec38d3"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"9775fbbe7dfd420ec83993bf3b89cd2a98c4ba63","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"224ba4cc_ce0ab8c5","updated":"2023-06-24 15:18:50.000000000","message":"run-TOYOU ACS5000 CI","commit_id":"2bdc0867839ae7c2ca8a669a137c270413ec38d3"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"2c8062c82781d9f447f6b8f2875e5795412965db","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2ce66469_b74dec96","updated":"2023-06-25 05:14:33.000000000","message":"run-TOYOU ACS5000 CI","commit_id":"2bdc0867839ae7c2ca8a669a137c270413ec38d3"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"4dc52cae50fe5bce640513770bcea12bc2c8ea4e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"54f26fc8_5d83b23e","updated":"2023-06-25 05:34:59.000000000","message":"run-TOYOU ACS5000 CI","commit_id":"2bdc0867839ae7c2ca8a669a137c270413ec38d3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"58b39e68b1640af541dd4df502ac624c4da0ddfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6140e3e8_6a543dc6","updated":"2021-12-24 22:33:08.000000000","message":"run-TOYOU ACS5000 CI","commit_id":"2bdc0867839ae7c2ca8a669a137c270413ec38d3"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"fd4ed7105cae1bc729292d67edf073d92d6e6253","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6a01c2cb_4d9959d0","updated":"2023-06-24 14:08:24.000000000","message":"run-TOYOU ACS5000 CI","commit_id":"2bdc0867839ae7c2ca8a669a137c270413ec38d3"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"c1062e4004ab9e6958cfdcb4504774e27644359c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9a6563fa_58e0065b","updated":"2023-06-24 10:01:47.000000000","message":"run-TOYOU ACS5000 CI","commit_id":"2bdc0867839ae7c2ca8a669a137c270413ec38d3"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"1b8e2cb0e638bd1a5c7186c76a5d6043822b29de","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a7228ad2_36250bd0","updated":"2023-06-24 16:00:37.000000000","message":"run-TOYOU ACS5000 CI","commit_id":"2bdc0867839ae7c2ca8a669a137c270413ec38d3"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"d3694c493b437f5a11f2357fc0a6371bb15fe7fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b0d91936_b4af9eca","updated":"2023-06-25 05:31:37.000000000","message":"run-TOYOU ACS5000 CI","commit_id":"2bdc0867839ae7c2ca8a669a137c270413ec38d3"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"5d4f76d260b820f1fdd49292cc395d5b36d6e8b0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cad9d26b_53355121","updated":"2023-06-25 05:11:38.000000000","message":"run-TOYOU ACS5000 CI","commit_id":"2bdc0867839ae7c2ca8a669a137c270413ec38d3"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"e25e8b18f6e2f637ae5ce53583447c73a972f107","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"cd252b88_8a88efd1","updated":"2023-06-25 03:56:09.000000000","message":"run-TOYOU ACS5000 CI","commit_id":"2bdc0867839ae7c2ca8a669a137c270413ec38d3"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"02efd301c640a7fb9134fbd1528a2f1909381deb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"fe2fac60_51e149b0","updated":"2023-06-24 13:46:44.000000000","message":"run-TOYOU ACS5000 CI","commit_id":"2bdc0867839ae7c2ca8a669a137c270413ec38d3"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"2db8f5e3f706eb6fe1f4fa8a7c2b70fe7a4df50a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"6916cca4_86de9d5c","in_reply_to":"6dfd09c0_a8b03a68","updated":"2022-01-10 16:24:35.000000000","message":"Thanks for your reviewing.","commit_id":"2bdc0867839ae7c2ca8a669a137c270413ec38d3"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"617a1150e64adc647a146a7c4653d4a00c247999","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d2c758d3_2fd9b08b","in_reply_to":"eca276d1_cd4fb9d7","updated":"2021-12-29 01:28:36.000000000","message":"Thanks for your comment. Congratulations on your pleasant holiday. By the way, when is the end of the holiday?","commit_id":"2bdc0867839ae7c2ca8a669a137c270413ec38d3"}],"cinder/volume/drivers/toyou/acs5000/acs5000_common.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"21cbeae2a1e0555e6e181106e258bef7c33a7448","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        default\u003dFalse,"},{"line_number":61,"context_line":"        help\u003d\u0027A volume can be attached to multiple hosts with \u0027"},{"line_number":62,"context_line":"             \u0027no limit on back-end storage, which is controlled \u0027"},{"line_number":63,"context_line":"             \u0027by the cinder.conf.\u0027),"},{"line_number":64,"context_line":"]"},{"line_number":65,"context_line":"CONF \u003d cfg.CONF"},{"line_number":66,"context_line":"CONF.register_opts(acs5000c_opts)"}],"source_content_type":"text/x-python","patch_set":1,"id":"2549e162_b34a6303","line":63,"updated":"2021-12-22 15:53:50.000000000","message":"I would reword this to.\n\nEnable to allow volumes attaching to multiple hosts with no limit.\n\nI\u0027m not sure what is meant by \"which is controlled by the cinder.conf\" ?","commit_id":"a7addcfc99c42916d49c205d180a855566a5e323"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"229861c46ab1e7475f724aec51a17355a80e4401","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        default\u003dFalse,"},{"line_number":61,"context_line":"        help\u003d\u0027A volume can be attached to multiple hosts with \u0027"},{"line_number":62,"context_line":"             \u0027no limit on back-end storage, which is controlled \u0027"},{"line_number":63,"context_line":"             \u0027by the cinder.conf.\u0027),"},{"line_number":64,"context_line":"]"},{"line_number":65,"context_line":"CONF \u003d cfg.CONF"},{"line_number":66,"context_line":"CONF.register_opts(acs5000c_opts)"}],"source_content_type":"text/x-python","patch_set":1,"id":"eac218a8_862dac27","line":63,"in_reply_to":"2549e162_b34a6303","updated":"2021-12-22 23:26:55.000000000","message":"I agree with Walt\u0027s suggestion.  (The help text is displayed in the sample cinder.conf and in the generated parts of the documentation where it\u0027s clearly identified as a configuration option, so you don\u0027t need to say anything about cinder.conf in the help text.)","commit_id":"a7addcfc99c42916d49c205d180a855566a5e323"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"65a96bb9f5b46afc29c6f437c7006cb5e5a5b3dc","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        default\u003dFalse,"},{"line_number":61,"context_line":"        help\u003d\u0027A volume can be attached to multiple hosts with \u0027"},{"line_number":62,"context_line":"             \u0027no limit on back-end storage, which is controlled \u0027"},{"line_number":63,"context_line":"             \u0027by the cinder.conf.\u0027),"},{"line_number":64,"context_line":"]"},{"line_number":65,"context_line":"CONF \u003d cfg.CONF"},{"line_number":66,"context_line":"CONF.register_opts(acs5000c_opts)"}],"source_content_type":"text/x-python","patch_set":1,"id":"ab18efde_0915ac1b","line":63,"in_reply_to":"2ff3d4e3_8ce2766c","updated":"2021-12-23 15:08:44.000000000","message":"Done","commit_id":"a7addcfc99c42916d49c205d180a855566a5e323"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"524049afe5f52859a9b2e4164562abb85f2a1399","unresolved":true,"context_lines":[{"line_number":60,"context_line":"        default\u003dFalse,"},{"line_number":61,"context_line":"        help\u003d\u0027A volume can be attached to multiple hosts with \u0027"},{"line_number":62,"context_line":"             \u0027no limit on back-end storage, which is controlled \u0027"},{"line_number":63,"context_line":"             \u0027by the cinder.conf.\u0027),"},{"line_number":64,"context_line":"]"},{"line_number":65,"context_line":"CONF \u003d cfg.CONF"},{"line_number":66,"context_line":"CONF.register_opts(acs5000c_opts)"}],"source_content_type":"text/x-python","patch_set":1,"id":"2ff3d4e3_8ce2766c","line":63,"in_reply_to":"eac218a8_862dac27","updated":"2021-12-23 15:02:27.000000000","message":"thanks for your review. My describe not properly. The \"which is controlled by the cinder.conf\" means users could set volume multiattach to True or False by themselves in cinder.conf file. According to Rosmaita\u0027s suggestion, I will delete it. And change the describe.","commit_id":"a7addcfc99c42916d49c205d180a855566a5e323"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"12b3456d091bbca266352d2e2d41eff90823682c","unresolved":true,"context_lines":[{"line_number":486,"context_line":"                LOG.error(\u0027Error running SSH command: %s\u0027, command)"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"    def create_volume(self, volume):"},{"line_number":489,"context_line":"        LOG.debug(\u0027create_volume, volume %s.\u0027, volume[\u0027id\u0027])"},{"line_number":490,"context_line":"        volume_name \u003d self._convert_name(volume.name)"},{"line_number":491,"context_line":"        pool_name \u003d volume_utils.extract_host(volume[\u0027host\u0027], \u0027pool\u0027)"},{"line_number":492,"context_line":"        ret \u003d self._cmd.create_volume("}],"source_content_type":"text/x-python","patch_set":3,"id":"f6c85184_cbe6545e","line":489,"updated":"2022-01-10 15:52:03.000000000","message":"Instead of doing this manually, I would suggest using the trace facility like:\n\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/hpe/hpe_3par_fc.py#L167","commit_id":"2bdc0867839ae7c2ca8a669a137c270413ec38d3"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"2db8f5e3f706eb6fe1f4fa8a7c2b70fe7a4df50a","unresolved":false,"context_lines":[{"line_number":486,"context_line":"                LOG.error(\u0027Error running SSH command: %s\u0027, command)"},{"line_number":487,"context_line":""},{"line_number":488,"context_line":"    def create_volume(self, volume):"},{"line_number":489,"context_line":"        LOG.debug(\u0027create_volume, volume %s.\u0027, volume[\u0027id\u0027])"},{"line_number":490,"context_line":"        volume_name \u003d self._convert_name(volume.name)"},{"line_number":491,"context_line":"        pool_name \u003d volume_utils.extract_host(volume[\u0027host\u0027], \u0027pool\u0027)"},{"line_number":492,"context_line":"        ret \u003d self._cmd.create_volume("}],"source_content_type":"text/x-python","patch_set":3,"id":"6d52d4bd_9eb48c94","line":489,"in_reply_to":"f6c85184_cbe6545e","updated":"2022-01-10 16:24:35.000000000","message":"Thanks for your reviewing. I will fix this using the trace facility from volume_utils according to your provided example in a future new patch.","commit_id":"2bdc0867839ae7c2ca8a669a137c270413ec38d3"}]}