)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"6b53895cc3ca6b428b9a740b2357b96b773da1fb","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[Spectrum Virtualize Family] Add/Remove volumes (group-update) from the group does not show proper error or log messages."},{"line_number":10,"context_line":"When list of volumes are given to add them to the group, if a volume is already exists in the group"},{"line_number":11,"context_line":"then it just silently removes the volumes from the list to be added (add_volumes_list) to the group without giving an error/warning mesaage."},{"line_number":12,"context_line":"Updating the cinder code to  print a message in logs that the given volume already exists hence"},{"line_number":13,"context_line":"the add volume operation for this volume is not required ."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"ebd6947e_bd0af4fd","line":11,"updated":"2021-11-19 14:10:15.000000000","message":"nit: message","commit_id":"bdab8f8b93786bbb15e0a96918662bf52da6c219"},{"author":{"_account_id":34106,"name":"Prajakta","email":"prajakta.ambulkar@ibm.com","username":"prajaktab"},"change_message_id":"97a3cc52d3b5be19850be69d7c0257e5ef312109","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[Spectrum Virtualize Family] Add/Remove volumes (group-update) from the group does not show proper error or log messages."},{"line_number":10,"context_line":"When list of volumes are given to add them to the group, if a volume is already exists in the group"},{"line_number":11,"context_line":"then it just silently removes the volumes from the list to be added (add_volumes_list) to the group without giving an error/warning mesaage."},{"line_number":12,"context_line":"Updating the cinder code to  print a message in logs that the given volume already exists hence"},{"line_number":13,"context_line":"the add volume operation for this volume is not required ."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3188b68d_e817e0a3","line":11,"in_reply_to":"ebd6947e_bd0af4fd","updated":"2021-11-30 10:38:36.000000000","message":"Ack","commit_id":"bdab8f8b93786bbb15e0a96918662bf52da6c219"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"6b53895cc3ca6b428b9a740b2357b96b773da1fb","unresolved":true,"context_lines":[{"line_number":9,"context_line":"[Spectrum Virtualize Family] Add/Remove volumes (group-update) from the group does not show proper error or log messages."},{"line_number":10,"context_line":"When list of volumes are given to add them to the group, if a volume is already exists in the group"},{"line_number":11,"context_line":"then it just silently removes the volumes from the list to be added (add_volumes_list) to the group without giving an error/warning mesaage."},{"line_number":12,"context_line":"Updating the cinder code to  print a message in logs that the given volume already exists hence"},{"line_number":13,"context_line":"the add volume operation for this volume is not required ."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1946618"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"4ee6f998_0fae8ad4","line":12,"updated":"2021-11-19 14:10:15.000000000","message":"nit: extra space","commit_id":"bdab8f8b93786bbb15e0a96918662bf52da6c219"},{"author":{"_account_id":34106,"name":"Prajakta","email":"prajakta.ambulkar@ibm.com","username":"prajaktab"},"change_message_id":"97a3cc52d3b5be19850be69d7c0257e5ef312109","unresolved":true,"context_lines":[{"line_number":9,"context_line":"[Spectrum Virtualize Family] Add/Remove volumes (group-update) from the group does not show proper error or log messages."},{"line_number":10,"context_line":"When list of volumes are given to add them to the group, if a volume is already exists in the group"},{"line_number":11,"context_line":"then it just silently removes the volumes from the list to be added (add_volumes_list) to the group without giving an error/warning mesaage."},{"line_number":12,"context_line":"Updating the cinder code to  print a message in logs that the given volume already exists hence"},{"line_number":13,"context_line":"the add volume operation for this volume is not required ."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1946618"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"6be46581_19e7253f","line":12,"in_reply_to":"4ee6f998_0fae8ad4","updated":"2021-11-30 10:38:36.000000000","message":"Ack","commit_id":"bdab8f8b93786bbb15e0a96918662bf52da6c219"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fbca3d4e26b79877e4ee0db025d34a6584f0f66d","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     PrajaktaB \u003cprajakta.ambulkar@ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2021-12-30 10:52:41 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"[SVF] Update correct Error message for add/remove volumes operation in  group-update"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"[Spectrum Virtualize Family] Add/Remove volumes (group-update) operation for  group does not show correct error or log message."},{"line_number":10,"context_line":"If a volume is already present in the group and is still passed in the list of volumes(add_volumes_list) to be added to the group ,then"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"70eb4f2c_931b38ae","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"updated":"2022-01-18 14:32:56.000000000","message":"Please remove the SVF-specific stuff ... this is a fix to the main cinder code, not the SVF driver.","commit_id":"23665c2119a73d8b54e0b52109607977c83c90e7"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"6b53895cc3ca6b428b9a740b2357b96b773da1fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d599dfcf_6d2e2dbe","updated":"2021-11-19 14:10:15.000000000","message":"Just a few queries","commit_id":"bdab8f8b93786bbb15e0a96918662bf52da6c219"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fbca3d4e26b79877e4ee0db025d34a6584f0f66d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"75023912_257f508d","updated":"2022-01-18 14:32:56.000000000","message":"This does not fix the bug, which is that a 400 is being returned when it shouldn\u0027t be.  All you are doing is adding a warning message that will show up in the log (which the end user cannot see) and the call will still fail (which the end user will see).\n\nI think what\u0027s going on here is that if you have a group containing volumes V1, V2, V3, and then you do a group-update that only adds V1, V2, V3 to the group, you get a 400 because the code can\u0027t tell if the add list is empty because it is empty in the request, or if it\u0027s empty because the validation code removed all the volumes because they were all already in the group.  See comments inline.\n\nI\u0027m not in favor of adding a warning log message for something that\u0027s not an error condition.  I think you should just fix the root cause.","commit_id":"23665c2119a73d8b54e0b52109607977c83c90e7"},{"author":{"_account_id":34106,"name":"Prajakta","email":"prajakta.ambulkar@ibm.com","username":"prajaktab"},"change_message_id":"d4d2f4230307541bd631e8f7a10fc20a91a96bb3","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c76100b1_3b82a886","updated":"2021-12-31 05:13:15.000000000","message":"recheck","commit_id":"23665c2119a73d8b54e0b52109607977c83c90e7"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"cb87901082be44fe3a0e3d19f7d88c7b6c8c1c8d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"b302fa69_833cfa21","updated":"2021-12-31 04:29:53.000000000","message":"run-DellEMC XtremIO CI","commit_id":"23665c2119a73d8b54e0b52109607977c83c90e7"},{"author":{"_account_id":34106,"name":"Prajakta","email":"prajakta.ambulkar@ibm.com","username":"prajaktab"},"change_message_id":"f322e51b5ddd30e8e1790b39e442059edeb0cab3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"54068965_e0537859","updated":"2022-01-03 04:48:37.000000000","message":"run-IBM Storage CI","commit_id":"23665c2119a73d8b54e0b52109607977c83c90e7"},{"author":{"_account_id":32036,"name":"katari manoj kumar","email":"katkumar@in.ibm.com","username":"katarimanojkumar"},"change_message_id":"aeaa5c150e9737d6bd694b9bd0b3d553cd4fb395","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"f1fb1470_70cfa20b","updated":"2022-02-09 07:49:03.000000000","message":"run-IBM Storage CI","commit_id":"23665c2119a73d8b54e0b52109607977c83c90e7"},{"author":{"_account_id":32464,"name":"caiqilong","email":"406454833@qq.com","username":"cccqqqlll"},"change_message_id":"9a17283beef38f44acf86e20b3e11dc74978c5fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"131f080b_34478868","updated":"2022-01-04 16:42:13.000000000","message":"run-TOYOU ACS5000 CI","commit_id":"23665c2119a73d8b54e0b52109607977c83c90e7"}],"cinder/group/api.py":[{"author":{"_account_id":34106,"name":"Prajakta","email":"prajakta.ambulkar@ibm.com","username":"prajaktab"},"change_message_id":"ca05d504be7c4b17b89f74eac57937f20564a120","unresolved":false,"context_lines":[{"line_number":721,"context_line":"                # Volume already in group. Remove from add_volumes."},{"line_number":722,"context_line":"                msg \u003d (_(\"Volume %(volume_id)s from \""},{"line_number":723,"context_line":"                         \"group %(group_id)s  \""},{"line_number":724,"context_line":"                         \"is already  present in the group so add operation is not reqd for thsi volume\") %"},{"line_number":725,"context_line":"                       {\u0027volume_id\u0027: volume,"},{"line_number":726,"context_line":"                        \u0027group_id\u0027: group.id})"},{"line_number":727,"context_line":"                add_volumes_list.remove(volume[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"72929084_4cfff1d6","line":724,"in_reply_to":"b2f742eb_83726497","updated":"2021-11-30 10:07:28.000000000","message":"\u003e pep8: E501 line too long (107 \u003e 79 characters)\n\nPlease fix.","commit_id":"a9adb7ac3489b59aa07a69685857e180a2b83586"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"6b53895cc3ca6b428b9a740b2357b96b773da1fb","unresolved":true,"context_lines":[{"line_number":725,"context_line":"                         \"so add operation is not reqd \""},{"line_number":726,"context_line":"                         \"for that volume \") %"},{"line_number":727,"context_line":"                       {\u0027volume_id\u0027: volume,"},{"line_number":728,"context_line":"                        \u0027group_id\u0027: group.id})"},{"line_number":729,"context_line":"                add_volumes_list.remove(volume[\u0027id\u0027])"},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"        for add_vol in add_volumes_list:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3dc8291f_581cc7fc","line":728,"updated":"2021-11-19 14:10:15.000000000","message":"those this msg ever get used or logged?","commit_id":"bdab8f8b93786bbb15e0a96918662bf52da6c219"},{"author":{"_account_id":34106,"name":"Prajakta","email":"prajakta.ambulkar@ibm.com","username":"prajaktab"},"change_message_id":"ca05d504be7c4b17b89f74eac57937f20564a120","unresolved":false,"context_lines":[{"line_number":725,"context_line":"                         \"so add operation is not reqd \""},{"line_number":726,"context_line":"                         \"for that volume \") %"},{"line_number":727,"context_line":"                       {\u0027volume_id\u0027: volume,"},{"line_number":728,"context_line":"                        \u0027group_id\u0027: group.id})"},{"line_number":729,"context_line":"                add_volumes_list.remove(volume[\u0027id\u0027])"},{"line_number":730,"context_line":""},{"line_number":731,"context_line":"        for add_vol in add_volumes_list:"}],"source_content_type":"text/x-python","patch_set":2,"id":"ee79b72e_f7224412","line":728,"in_reply_to":"3dc8291f_581cc7fc","updated":"2021-11-30 10:07:28.000000000","message":"This msg is displayed on console when the user tries to add a  already-added volume to a group.","commit_id":"bdab8f8b93786bbb15e0a96918662bf52da6c219"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fbca3d4e26b79877e4ee0db025d34a6584f0f66d","unresolved":true,"context_lines":[{"line_number":645,"context_line":"            remove_volumes_new \u003d self._validate_remove_volumes("},{"line_number":646,"context_line":"                volumes, remove_volumes_list, group)"},{"line_number":647,"context_line":""},{"line_number":648,"context_line":"        if (name is None and description is None and not add_volumes_new and"},{"line_number":649,"context_line":"                not remove_volumes_new):"},{"line_number":650,"context_line":"            msg \u003d (_(\"Cannot update group %(group_id)s \""},{"line_number":651,"context_line":"                     \"because no valid name, description, add_volumes, \""}],"source_content_type":"text/x-python","patch_set":8,"id":"07453161_7c2e881c","line":648,"range":{"start_line":648,"start_character":53,"end_line":648,"end_character":72},"updated":"2022-01-18 14:32:56.000000000","message":"The problem is that we can\u0027t tell if this evaluates to True because the request did not contain any volumes to add, or because it only contained volumes that were already in the group.  (See comment in _validate_add_volumes() below.)","commit_id":"23665c2119a73d8b54e0b52109607977c83c90e7"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fbca3d4e26b79877e4ee0db025d34a6584f0f66d","unresolved":true,"context_lines":[{"line_number":726,"context_line":"                            \"for this volume \","},{"line_number":727,"context_line":"                            {\u0027volume_id\u0027: volume[\u0027id\u0027],"},{"line_number":728,"context_line":"                             \u0027group_id\u0027: group.id})"},{"line_number":729,"context_line":"                add_volumes_list.remove(volume[\u0027id\u0027])"},{"line_number":730,"context_line":"        for add_vol in add_volumes_list:"},{"line_number":731,"context_line":"            try:"},{"line_number":732,"context_line":"                add_vol_ref \u003d objects.Volume.get_by_id(context, add_vol)"}],"source_content_type":"text/x-python","patch_set":8,"id":"b2879ba9_322ec9dd","line":729,"updated":"2022-01-18 14:32:56.000000000","message":"Suppose that the add_volumes_list only contains volumes that are already in the group.  After this loop is done, add_volumes_list will be empty.  We won\u0027t execute the \u0027for\u0027 loop at line 730 and go directly to line 814 where we return add_volumes_new, which will have the value set at line 718 (empty string).","commit_id":"23665c2119a73d8b54e0b52109607977c83c90e7"}]}