)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":33986,"name":"Lucas Morais de oliveira","email":"lucasmoliveira059@gmail.com","username":"lucasmoliveira059"},"change_message_id":"d869995b22687141cc4ce644897f8eb98d5adffe","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"API-REF: Add volume_id at snapshot list and detail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added the paremeter volume_id at v3 api documentation on paths"},{"line_number":10,"context_line":"/snapshots and /snapshots/detail."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: 1943689"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"7f108749_8edb89cc","line":9,"range":{"start_line":9,"start_character":10,"end_line":9,"end_character":19},"updated":"2022-01-21 14:41:17.000000000","message":"nit: parameter","commit_id":"14ea23c7c8f4d9e1bad2d8342c50ab2383f536d6"},{"author":{"_account_id":33986,"name":"Lucas Morais de oliveira","email":"lucasmoliveira059@gmail.com","username":"lucasmoliveira059"},"change_message_id":"c4c29245c329eba54f96241e2fb438bbce50c72a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"API-REF: Add volume_id at snapshot list and detail"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Added the paremeter volume_id at v3 api documentation on paths"},{"line_number":10,"context_line":"/snapshots and /snapshots/detail."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Closes-Bug: 1943689"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"990dd79c_c3e9d7e0","line":9,"range":{"start_line":9,"start_character":10,"end_line":9,"end_character":19},"in_reply_to":"7f108749_8edb89cc","updated":"2022-06-13 12:37:33.000000000","message":"Done","commit_id":"14ea23c7c8f4d9e1bad2d8342c50ab2383f536d6"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":33648,"name":"Nahim Alves de Souza","email":"nahimsouza@outlook.com","username":"nahimsouza"},"change_message_id":"e0620ab345703816e5cc605d243f25092de3fb1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e14c8d2a_79cf2a59","updated":"2021-12-02 20:20:59.000000000","message":"LGTM, Thank you Leonardo!","commit_id":"e1797edda6d37008a1e050cdf24bae27dc3c2f43"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"bfc12186f4c55577f39e75d3a30bbd0cc6ce534a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"88f4881c_0cf29506","updated":"2021-12-17 15:44:09.000000000","message":"Thanks for working on this!\n\n```\nusage: openstack volume snapshot list [-h] [-f {csv,json,table,value,yaml}] [-c COLUMN] [--quote {all,minimal,none,nonnumeric}] [--noindent] [--max-width \u003cinteger\u003e] [--fit-width] [--print-empty] [--sort-column SORT_COLUMN]\n                                      [--sort-ascending | --sort-descending] [--all-projects] [--project \u003cproject\u003e] [--project-domain \u003cproject-domain\u003e] [--long] [--marker \u003cvolume-snapshot\u003e] [--limit \u003cnum-snapshots\u003e] [--name \u003cname\u003e]\n                                      [--status \u003cstatus\u003e] [--volume \u003cvolume\u003e]\n```","commit_id":"e1797edda6d37008a1e050cdf24bae27dc3c2f43"},{"author":{"_account_id":33986,"name":"Lucas Morais de oliveira","email":"lucasmoliveira059@gmail.com","username":"lucasmoliveira059"},"change_message_id":"d869995b22687141cc4ce644897f8eb98d5adffe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"37c6873b_5ec8084e","updated":"2022-01-21 14:41:17.000000000","message":"Great Job Leonardo!\nI just found a typo but feel free to fix it only if you need to upload a new patch set.\nThank you.","commit_id":"14ea23c7c8f4d9e1bad2d8342c50ab2383f536d6"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"31efb5f295b7e46c0af245238c83b814046c7983","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ef952122_878b1e82","updated":"2021-12-28 14:19:38.000000000","message":"Hi Leonardo, thank you for this work. LGTM! ","commit_id":"14ea23c7c8f4d9e1bad2d8342c50ab2383f536d6"},{"author":{"_account_id":12670,"name":"Helen Walsh","email":"helen.walsh@emc.com","username":"walshh2"},"change_message_id":"41c02915e3c3b6b7da2090c5ebe83f47197c637c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"62ce1570_37b98a49","updated":"2022-01-21 14:34:26.000000000","message":"LGTM","commit_id":"14ea23c7c8f4d9e1bad2d8342c50ab2383f536d6"},{"author":{"_account_id":34110,"name":"Leonardo Campelo","email":"leocampelo16@gmail.com","username":"LeoCampelo"},"change_message_id":"30be2ba3d5450ef1beeb6a0f7446a9424a71cdd2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1916cb3d_56329b87","updated":"2021-12-28 14:22:27.000000000","message":"Thank you Sofia for the review. ","commit_id":"14ea23c7c8f4d9e1bad2d8342c50ab2383f536d6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"eb3da9508fa9b7132b94ccca0944952f9503b7c9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"34a99ee1_f628fab4","updated":"2022-02-18 14:44:58.000000000","message":"What filters can be applied to the list-{volume,snapshot,backup} calls are controlled by how the API is configured by the resource_query_filters_file set in cinder.conf.  See\nhttps://docs.openstack.org/api-ref/block-storage/v3/#resource-filters-resource-filters\n\nSo I don\u0027t think you can just add the volume_id as you do here.  What you could do is add some language to the list-whatever descriptions pointing out that there may be further filtering available on these calls and referring to the resource-filters call to see what\u0027s available in the particular cloud they\u0027re using.","commit_id":"14ea23c7c8f4d9e1bad2d8342c50ab2383f536d6"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"40c44f6f54105edfb0777e79f3df739ed3a22574","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"35e69407_9d98fe9e","updated":"2022-07-15 15:22:10.000000000","message":"Looks OK, but I agree with Gorka...","commit_id":"3a3cdef773684c11a9f50d3bf02fc97ae32349cc"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1f704d8861243d17be1c31a9bd0d1f94712fe585","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2058e7e0_fa7e93f7","updated":"2022-07-15 14:36:15.000000000","message":"Patch looks good, but it would be better if we added some more of the missing fields.","commit_id":"3a3cdef773684c11a9f50d3bf02fc97ae32349cc"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"95534d72dde13eda3cf71968ac0aef6594fb7ce3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"9a651343_5079c4b0","updated":"2026-05-04 19:11:14.000000000","message":"What fields are available depends on the resource_filters that are enabled, so this should be documented to refer to resource filters instead of adding the individual filters to each API call (especially since the filters can be configured by an operator, and hence a particular filter might not be available)","commit_id":"3a3cdef773684c11a9f50d3bf02fc97ae32349cc"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a6b6e8dc587b265441c5371ceb2e986890c7d80f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"854245dd_c106c0eb","updated":"2026-05-04 23:10:23.000000000","message":"When I said \"over 5 years\", I should have said \"almost 4 years\".  It\u0027s still a long time without a response.","commit_id":"3a3cdef773684c11a9f50d3bf02fc97ae32349cc"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"a9bf3da127ff2f835546bab8cea38d65914c059d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"49f4be6d_b15c9150","updated":"2022-07-12 05:54:51.000000000","message":"looks good","commit_id":"3a3cdef773684c11a9f50d3bf02fc97ae32349cc"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"c3a5e0bc03ba17a802bc3ae89a9f046e715970d1","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e54267a7_ec34887a","in_reply_to":"2058e7e0_fa7e93f7","updated":"2022-07-15 15:50:17.000000000","message":":-1: I think it would be nice to complete this patch instead of making a sequel with the missing parts.","commit_id":"3a3cdef773684c11a9f50d3bf02fc97ae32349cc"}],"api-ref/source/v3/volumes-v3-snapshots.inc":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"bfc12186f4c55577f39e75d3a30bbd0cc6ce534a","unresolved":true,"context_lines":[{"line_number":68,"context_line":"   - marker: marker"},{"line_number":69,"context_line":"   - with_count: with_count"},{"line_number":70,"context_line":"   - consumes_quota: filter_consumes_quota"},{"line_number":71,"context_line":"   - volume_id: volume_id_snap"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Response Parameters"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"ec178154_0912ab89","line":71,"range":{"start_line":71,"start_character":16,"end_line":71,"end_character":30},"updated":"2021-12-17 15:44:09.000000000","message":":-1: this should be volume_id to keep consistency with the others *.inc . i.e https://opendev.org/openstack/cinder/src/branch/master/api-ref/source/v3/ext-backups.inc#L90","commit_id":"e1797edda6d37008a1e050cdf24bae27dc3c2f43"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"f3c1912521512378c459193055a8e0ee7ba7a6dc","unresolved":false,"context_lines":[{"line_number":68,"context_line":"   - marker: marker"},{"line_number":69,"context_line":"   - with_count: with_count"},{"line_number":70,"context_line":"   - consumes_quota: filter_consumes_quota"},{"line_number":71,"context_line":"   - volume_id: volume_id_snap"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Response Parameters"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"177fb696_d781af17","line":71,"range":{"start_line":71,"start_character":16,"end_line":71,"end_character":30},"in_reply_to":"e0ee8a48_6750d45f","updated":"2022-02-18 14:26:53.000000000","message":"Shouldn\u0027t the other volume_id_snap be changed as well then?","commit_id":"e1797edda6d37008a1e050cdf24bae27dc3c2f43"},{"author":{"_account_id":34110,"name":"Leonardo Campelo","email":"leocampelo16@gmail.com","username":"LeoCampelo"},"change_message_id":"30be2ba3d5450ef1beeb6a0f7446a9424a71cdd2","unresolved":false,"context_lines":[{"line_number":68,"context_line":"   - marker: marker"},{"line_number":69,"context_line":"   - with_count: with_count"},{"line_number":70,"context_line":"   - consumes_quota: filter_consumes_quota"},{"line_number":71,"context_line":"   - volume_id: volume_id_snap"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Response Parameters"}],"source_content_type":"text/x-c++src","patch_set":1,"id":"e0ee8a48_6750d45f","line":71,"range":{"start_line":71,"start_character":16,"end_line":71,"end_character":30},"in_reply_to":"ec178154_0912ab89","updated":"2021-12-28 14:22:27.000000000","message":"Done","commit_id":"e1797edda6d37008a1e050cdf24bae27dc3c2f43"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"f3c1912521512378c459193055a8e0ee7ba7a6dc","unresolved":true,"context_lines":[{"line_number":201,"context_line":"   - marker: marker"},{"line_number":202,"context_line":"   - consumes_quota: filter_consumes_quota"},{"line_number":203,"context_line":"   - with_count: with_count"},{"line_number":204,"context_line":"   - volume_id: volume_id_snap"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Response Parameters"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"dbd0da00_584f4c01","line":204,"updated":"2022-02-18 14:26:53.000000000","message":"This is a request too like the change on line 71 - shouldn\u0027t this be \nvolume_id: volume_id\n?\n\nI\u0027m not too much into this part of code but the semantic of the two API calls ( /v3/{project_id}/snapshots/detail and  GET /v3/{project_id}/snapshots ) looks similar )","commit_id":"14ea23c7c8f4d9e1bad2d8342c50ab2383f536d6"},{"author":{"_account_id":33986,"name":"Lucas Morais de oliveira","email":"lucasmoliveira059@gmail.com","username":"lucasmoliveira059"},"change_message_id":"c4c29245c329eba54f96241e2fb438bbce50c72a","unresolved":false,"context_lines":[{"line_number":201,"context_line":"   - marker: marker"},{"line_number":202,"context_line":"   - consumes_quota: filter_consumes_quota"},{"line_number":203,"context_line":"   - with_count: with_count"},{"line_number":204,"context_line":"   - volume_id: volume_id_snap"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Response Parameters"}],"source_content_type":"text/x-c++src","patch_set":3,"id":"51ea9cbe_be2d1e21","line":204,"in_reply_to":"dbd0da00_584f4c01","updated":"2022-06-13 12:37:33.000000000","message":"Thanks, Luigi, for the review. Yes, I guess this item in the requests will be a volume_id. As for the path, we followed the pattern in the Cinder docs, it\u0027s similar, but one is a list of accessible snapshots, while \"details\" shows a list of all block storage snapshots.","commit_id":"14ea23c7c8f4d9e1bad2d8342c50ab2383f536d6"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1f704d8861243d17be1c31a9bd0d1f94712fe585","unresolved":true,"context_lines":[{"line_number":68,"context_line":"   - marker: marker"},{"line_number":69,"context_line":"   - with_count: with_count"},{"line_number":70,"context_line":"   - consumes_quota: filter_consumes_quota"},{"line_number":71,"context_line":"   - volume_id: volume_id"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"Response Parameters"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"ca2c4c39_1c7cffe1","line":71,"updated":"2022-07-15 14:36:15.000000000","message":"nit: we are also missing status, name, metadata...","commit_id":"3a3cdef773684c11a9f50d3bf02fc97ae32349cc"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"1f704d8861243d17be1c31a9bd0d1f94712fe585","unresolved":true,"context_lines":[{"line_number":201,"context_line":"   - marker: marker"},{"line_number":202,"context_line":"   - consumes_quota: filter_consumes_quota"},{"line_number":203,"context_line":"   - with_count: with_count"},{"line_number":204,"context_line":"   - volume_id: volume_id"},{"line_number":205,"context_line":""},{"line_number":206,"context_line":""},{"line_number":207,"context_line":"Response Parameters"}],"source_content_type":"text/x-c++src","patch_set":4,"id":"a7894e59_e449ab42","line":204,"updated":"2022-07-15 14:36:15.000000000","message":"nit: we are also missing status, name, metadata...","commit_id":"3a3cdef773684c11a9f50d3bf02fc97ae32349cc"}]}