)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"961968f288bf88d7a7825c39d21cb04310f06aaa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4802e915_6d6fa1ac","updated":"2021-11-24 17:03:21.000000000","message":"Requesting your review","commit_id":"3a879a28917c52a4d0dab7004a992771bd89fa42"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"8fd1fdb176b4de4685f9ed1c792623efde2fa6f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"51633307_d821fb3b","updated":"2021-12-16 09:03:58.000000000","message":"LGTM","commit_id":"0a155ce802e10160cea645472d9bacf85fad8858"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"829305753fa2c78ef0430e91204ec381c77d0f87","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"5ec96e07_8cdec015","updated":"2021-11-25 10:02:31.000000000","message":"need to setup CI, otherwise looks good","commit_id":"0a155ce802e10160cea645472d9bacf85fad8858"},{"author":{"_account_id":13671,"name":"Vladislav Belogrudov","email":"v.belogrudov@yadro.com","username":"vb"},"change_message_id":"6c499c8c777e6c585d095caff73b96f9e76e22a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ce51530d_52b5c9f6","updated":"2022-01-31 09:17:07.000000000","message":"recheck","commit_id":"0a155ce802e10160cea645472d9bacf85fad8858"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"ab5013381728d7fb811169656bb9ea9db4d269d1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"e9e13ede_01174559","updated":"2022-06-08 12:24:10.000000000","message":"recheck","commit_id":"412c13e6f7459dd23712e389f22832fe792a3a5c"},{"author":{"_account_id":34298,"name":"Marco Li","email":"liijuun@163.com"},"change_message_id":"ee7b222590e5e142890aff44504e981fb7e1fa1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c6bfdde4_da2d70fd","updated":"2022-06-15 09:52:25.000000000","message":"run-DellEMC PowerMAX CI","commit_id":"8ad51e69fef04add31756a3a47e9a2891775120d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"76010dcbb8e6ed7b3b9716ea82f82b471c5e5706","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"b69e2aa0_4ca49388","updated":"2022-07-13 02:15:32.000000000","message":"CI check results: please address items with \u0027?\u0027 and \u0027x\u0027:\n\n🗸 CI_WIKI_NAME correct in driver properties: DellEMC_PowerStore_CI\n🗸 CI wiki page is there: https://wiki.openstack.org/wiki/ThirdPartySystems/DellEMC_PowerStore_CI\n  🗸 email ping to contact info on the wiki\n  🗸 received pong\n🗸 checked recheck trigger\n  * trigger: \"run-DellEMC PowerStore CI\"\n? CI is responding on the new driver patch\n  not obvious that it\u0027s responding without a recheck trigger\n  * successful run comment link: (can\u0027t find any nvme results)\n𐄂 CI is responding on other patches\n  * https://review.opendev.org/q/reviewedby:dellemc.powerstore.ci%2540dell.com+project:openstack/cinder+-dir:cinder/volume/drivers/dell_emc/powerstore\n  see PowerStore CI, but not nvme results\n𐄂 CI is responding on os-brick patches\n  * https://review.opendev.org/q/reviewedby:dellemc.powerstore.ci%2540dell.com+project:openstack/os-brick\n  see PowerStore CI, but not nvme results\n𐄂 CI results\n  no results to analyze","commit_id":"564d2c3a75c05a6ebb6ae5b91b6fd65dce5492f1"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"2937eded6137ffa5b3f8b9fabb3eb9b8c6b4cd6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"aa908fa7_c9e66546","updated":"2022-07-12 11:27:17.000000000","message":"LGTM! Waiting when CI will passed","commit_id":"564d2c3a75c05a6ebb6ae5b91b6fd65dce5492f1"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"3f4e35fb866e0ec496ac1320a5e4224e4fc059bd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"3394b45c_eb41673b","updated":"2022-07-12 11:39:20.000000000","message":"Looks good to me","commit_id":"564d2c3a75c05a6ebb6ae5b91b6fd65dce5492f1"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"659cc5346538e165774e3eba6cc3c1627368b1d2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"4e4e7c96_915bea7a","updated":"2022-07-20 07:32:22.000000000","message":"Need to add release note","commit_id":"564d2c3a75c05a6ebb6ae5b91b6fd65dce5492f1"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"575f4558d42781afc7186bd12db7af72b4053f98","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"220f4638_c4cdc041","updated":"2022-07-12 06:44:59.000000000","message":"Overall code changes look good. Zuul has passed.\nWill wait for \"DellEMC PowerStore CI\" results.\n","commit_id":"564d2c3a75c05a6ebb6ae5b91b6fd65dce5492f1"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"08758673eadf0b2b3d11d3cb03713e00b643079e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"0e683803_5e131862","updated":"2022-07-12 09:53:58.000000000","message":"looks good to merge","commit_id":"564d2c3a75c05a6ebb6ae5b91b6fd65dce5492f1"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"19a275d9e22d57f6e7c989421998ebc355d277f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2e1f481e_95780990","updated":"2022-07-11 13:31:41.000000000","message":"recheck","commit_id":"564d2c3a75c05a6ebb6ae5b91b6fd65dce5492f1"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"f9a7f36a89952f6e6a9db96b3f08005b5e805a51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"aaacf6b0_d42ce5d4","updated":"2022-07-11 08:26:38.000000000","message":"recheck","commit_id":"564d2c3a75c05a6ebb6ae5b91b6fd65dce5492f1"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"d8c6390deafbb469223bba235e708d2d0697cb3e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"bb054b29_a08777b8","updated":"2022-07-08 13:40:55.000000000","message":"recheck","commit_id":"564d2c3a75c05a6ebb6ae5b91b6fd65dce5492f1"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"c473ebc869e1783d86a435a8f62bda4d9b0de0a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"2eb1638f_dd0aaec0","updated":"2022-07-20 11:03:17.000000000","message":"run-DellEMC PowerStore CI","commit_id":"564d2c3a75c05a6ebb6ae5b91b6fd65dce5492f1"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"ef3aa107dc0cc8cf8d7265976fb51bf007371c49","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"ae575627_8bbbcb46","updated":"2022-07-08 13:18:01.000000000","message":"run-DellEMC PowerStore CI","commit_id":"564d2c3a75c05a6ebb6ae5b91b6fd65dce5492f1"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"57aacbb393b81c56c990e417b478bbb9cd07c919","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f24ac2b4_c0669b8b","updated":"2022-07-12 07:49:47.000000000","message":"run-DellEMC PowerStore CI","commit_id":"564d2c3a75c05a6ebb6ae5b91b6fd65dce5492f1"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"95d07ff805334cf1533877b03e8b624e62d33793","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"d266bf71_04375c5b","in_reply_to":"b69e2aa0_4ca49388","updated":"2022-07-21 08:50:55.000000000","message":"Hi Brian, NVMe CI is responding now and have been passed","commit_id":"564d2c3a75c05a6ebb6ae5b91b6fd65dce5492f1"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"0d6fb44fa9563abcdf8da707211a45dfe6b627b2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"4deca6d5_70eb9c6e","updated":"2022-07-20 11:56:54.000000000","message":"run-DellEMC PowerStore CI","commit_id":"59b9daa456e4e30f93c4d4656bc27f7346348733"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"fba556116521945744663c30c74f5f95d02a3f1f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"ace0c0b2_3163d864","updated":"2022-07-20 14:46:57.000000000","message":"run-DellEMC PowerStore CI","commit_id":"720c63d077fca1b0ffe1e07cfa7813ff7b07406c"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"f1707cf80a5b154964ee61fdafba424de31d2656","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"8f6a6740_eabfa32e","updated":"2022-07-28 05:45:10.000000000","message":"Couldn\u0027t find more issues in the code except from client test coverage that seems low to me. Would like to mention that the driver\u0027s code is pretty well organized and I had a good time reviewing this. :)","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"61594c13525e6d769ed9752accbcc479c62379e4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"ee9beefe_055c073c","updated":"2022-07-26 20:37:22.000000000","message":"Glad to see the CI running!  Question about they way it\u0027s configured:\netc/cinder.conf has:\n\n  [backend_defaults]\n  volume_driver \u003d cinder.volume.drivers.dell_emc.powerstore.driver.PowerStoreDriver\n  san_ip \u003d \u003cip\u003e\n  san_login \u003d admin\n  san_\n  powerstore_nvme \u003d True\n\nwhich does sort of match what the docs on this patch say for how to configure the driver, except \u0027san_\u0027 should be \u0027san_password\u0027 and I\u0027d expect an actual IP for san_ip, but maybe that\u0027s ok in the testing backend?\n\nThe config file I\u0027m looking at is here:\nhttps://elab-os-logsrv.delllabs.net/49/819149/14/check/DellEMC_PowerStore_NVMeTCP/94b95e1/DellEMC_PowerStore_NVMeTCP/33/logs/etc/cinder/cinder.conf.txt.gz\n","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"6ae7b814fc58e8ccc7804e7cec140431550a4e45","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"5ce7ecd7_976f2b68","updated":"2022-07-25 15:09:13.000000000","message":"LGTM","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"f02c933f37fbf3e9ecb67da6aeaabb65108a6960","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"7a40fd57_5d65cc30","updated":"2022-07-25 15:07:37.000000000","message":"The code looks good to me.  Has necessary documentation and it is passing CI.  So, if others\u0027 concerns are addressed then I am ok with this merging.","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"54845d820ddfa3064a86c8e979284d27c672faa8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"0614c1cb_564994d1","updated":"2022-07-28 02:21:50.000000000","message":"run-DellEMC PowerStore CI","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"a668da560d281691c7e033d6725e11d0bef574aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"0d251842_489363e4","updated":"2022-07-27 09:45:03.000000000","message":"run-DellEMC PowerStore CI","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"b8f4ead9d5637e786094906b88c19db7f5e51b4c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"1e01e147_4e9e4ea1","updated":"2022-07-28 13:33:33.000000000","message":"run-DellEMC PowerStore CI","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"1d674c2661bd3dddfa08fc58dd97c4236ef7fd42","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"392eef1c_a2463e5a","updated":"2022-07-27 15:02:37.000000000","message":"run-DellEMC PowerStore CI","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"cc5feb46d2fcf9abc562c62fbcb438a96117ebb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"3b40bfe1_bc585901","updated":"2022-07-28 15:34:46.000000000","message":"run-DellEMC PowerStore CI","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"d9396fe051c6c55e38fc1cd9e3933cfb34911a74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"6b3a6408_d2a57e2b","updated":"2022-07-28 15:32:36.000000000","message":"run-DellEMC PowerStore CI","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"66ac134b7a72c03dfd99b19dbee1d983e5ad45ff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"7e7004ca_2210783b","updated":"2022-07-25 04:58:26.000000000","message":"run-DellEMC PowerStore CI","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"026c4fae4887d45aae7d059d470cd67270d3da91","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"7fe05788_98f8e56a","updated":"2022-07-20 22:45:31.000000000","message":"run-DellEMC PowerStore CI","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"0a58d254ed19706a38438c731976e77ce7db79b5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"a9ae9cc2_f15b6ca2","updated":"2022-07-28 17:43:06.000000000","message":"run-DellEMC PowerStore CI","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"e6bd4c7456528b7ef06fe5e3ac49c11a39f4a27f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"adeb794d_8f72ec05","updated":"2022-07-27 13:18:20.000000000","message":"run-DellEMC PowerStore CI","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"53fedd6806f1380c70e1b43e3316647b53740eb2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"c1a486f2_4647e09b","updated":"2022-07-28 03:56:22.000000000","message":"run-DellEMC PowerStore CI","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"db555bb9fbdcaac786e22a48e66dd39faa37dbfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"dfceb782_28937a8b","updated":"2022-07-25 02:41:00.000000000","message":"run-DellEMC PowerStore CI","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"94485515a46e0ffe8786deda61bfff30c63e2e5d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"e8f87f76_57b3524c","updated":"2022-07-27 14:32:33.000000000","message":"run-DellEMC PowerStore CI","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"1cf1f4daea911770d8bf3f0408723075ea1482aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"81402a06_a24352cc","in_reply_to":"7076bbed_afd50d6c","updated":"2022-07-27 09:41:39.000000000","message":"Replaced the param\u0027s name, waiting for a CI recheck","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"b1e6e0f03f506d8c849c716ca3c8bdaa1a34d776","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"7076bbed_afd50d6c","in_reply_to":"ee9beefe_055c073c","updated":"2022-07-27 09:08:29.000000000","message":"Hi Brian, due to the security policy of our organization, we can\u0027t share some critical creds such as IP and password of an array, but it\u0027s ok in the testing backend.","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"07b64a7d3f8e84125afd0e4aed255a04533529e3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ec5aa9e7_6072cbb0","updated":"2022-07-29 10:10:02.000000000","message":"LGTM","commit_id":"48be0bd320ac8de45f228cde43b5b4887a4f6b7b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cf2cbe2250b5f3550efbaeeb393460ababbc7008","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"61964b04_ad9adb89","updated":"2022-07-29 11:16:58.000000000","message":"One concern inline. Not sure the need of a new config option and storage protocol should be one of the constants instead of defining new constants.","commit_id":"48be0bd320ac8de45f228cde43b5b4887a4f6b7b"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"7d9ffae76fca22470b7eaec17c282272b0a8a04b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"34eaecdb_3ee6c16d","updated":"2022-07-29 07:41:52.000000000","message":"recheck","commit_id":"48be0bd320ac8de45f228cde43b5b4887a4f6b7b"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"f81ee85cf6aadd536f14634cc392f91b33c7234e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"6ba7b5e3_780c0a36","updated":"2022-07-29 07:41:10.000000000","message":"recheck - cinder-grenade-mn-sub-volbak FAILURE","commit_id":"48be0bd320ac8de45f228cde43b5b4887a4f6b7b"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"2c822b7ea1ba8740020638ae9474fe35fbe4dae3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"c910dcc2_a4cf1978","updated":"2022-07-29 05:04:40.000000000","message":"run-DellEMC PowerStore CI","commit_id":"48be0bd320ac8de45f228cde43b5b4887a4f6b7b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c9a8cb0d3bc030e7fa32ee4f27fa74620b234da6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"b5f180e3_6a8abd9d","updated":"2022-07-29 12:33:50.000000000","message":"Not very happy about the current state of changes but we can\u0027t do much about it. I think we can refine things throughout the cycle.\nCI passed on last patchset and there are no changes that should break it in the subsequent run. LGTM.","commit_id":"dd2980e634ea14fb45b428aae68dce0f81b025ac"},{"author":{"_account_id":31779,"name":"Jean Pierre Roquesalane","display_name":"happystacker","email":"jeanpierre.roquesalane@dell.com","username":"happystacker"},"change_message_id":"d4c82f214cf7537c423e628a8c7e996a1ec9a140","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"bbffa9b2_c84f5ef8","updated":"2022-07-29 15:24:14.000000000","message":"run-DellEMC PowerFlex C","commit_id":"dd2980e634ea14fb45b428aae68dce0f81b025ac"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"da2692a11bf94fe4ea08e3b39335d0be2c8690b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"4302878d_eb5a8f1b","updated":"2022-07-29 12:11:43.000000000","message":"run-DellEMC PowerStore CI","commit_id":"dd2980e634ea14fb45b428aae68dce0f81b025ac"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4c2d3c433a35dc9dc1d48e93859480faadb4ca2c","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":16,"id":"d5bdedb2_aaef847e","in_reply_to":"b5f180e3_6a8abd9d","updated":"2022-07-29 15:31:57.000000000","message":"There are unresolved comments but as Rajat mentioned the CI passed. Today is the deadline so a follow up patch is expected from this driver 😊","commit_id":"dd2980e634ea14fb45b428aae68dce0f81b025ac"}],"cinder/volume/drivers/dell_emc/powerstore/adapter.py":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"f8102dac95f12ff088d9df1c298306e4dd5ec0f7","unresolved":true,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":"PROTOCOL_FC \u003d \"FC\""},{"line_number":35,"context_line":"PROTOCOL_ISCSI \u003d \"iSCSI\""},{"line_number":36,"context_line":"PROTOCOL_NVME \u003d \"NVMe\""},{"line_number":37,"context_line":"CHAP_MODE_SINGLE \u003d \"Single\""}],"source_content_type":"text/x-python","patch_set":8,"id":"988f250e_5bdada6c","line":34,"updated":"2022-07-06 20:54:29.000000000","message":"Are you sure that you want to back this out?\n\nSee also: https://review.opendev.org/c/openstack/cinder/+/839063","commit_id":"7f5f7f4e52f94dcc697deb25383de8d6b26b1152"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"26c3e9b588bc09db0efcc31db9508f714d58633c","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":34,"context_line":"PROTOCOL_FC \u003d \"FC\""},{"line_number":35,"context_line":"PROTOCOL_ISCSI \u003d \"iSCSI\""},{"line_number":36,"context_line":"PROTOCOL_NVME \u003d \"NVMe\""},{"line_number":37,"context_line":"CHAP_MODE_SINGLE \u003d \"Single\""}],"source_content_type":"text/x-python","patch_set":8,"id":"cf751931_fc85619b","line":34,"in_reply_to":"988f250e_5bdada6c","updated":"2022-07-12 07:48:55.000000000","message":"Thanks for the comment. Since this patch was initiated in October when 839063 was not merged, we made these changes to make the variables in the same format. However, it is now possible to go back to the original form.\n\nDone.","commit_id":"7f5f7f4e52f94dcc697deb25383de8d6b26b1152"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"336d1823b0d7d893859b50e2c90921d46a966e3a","unresolved":true,"context_lines":[{"line_number":1146,"context_line":"                      \"current_version\": array_version, })"},{"line_number":1147,"context_line":"            LOG.error(msg)"},{"line_number":1148,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":1149,"context_line":"        super(NVMEoFAdapter, self).check_for_setup_error()"},{"line_number":1150,"context_line":""},{"line_number":1151,"context_line":"    def _get_nvme_targets(self):"},{"line_number":1152,"context_line":"        portals \u003d []"}],"source_content_type":"text/x-python","patch_set":9,"id":"e849843d_7934281f","line":1149,"updated":"2022-07-08 10:31:38.000000000","message":"Why we should use check_for_setup_error() if in basic class we are checking iscsi protocol?","commit_id":"0b2f7f9cd037d236c9bef5a4d9c0d6a111cd757e"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"26c3e9b588bc09db0efcc31db9508f714d58633c","unresolved":false,"context_lines":[{"line_number":1146,"context_line":"                      \"current_version\": array_version, })"},{"line_number":1147,"context_line":"            LOG.error(msg)"},{"line_number":1148,"context_line":"            raise exception.InvalidInput(reason\u003dmsg)"},{"line_number":1149,"context_line":"        super(NVMEoFAdapter, self).check_for_setup_error()"},{"line_number":1150,"context_line":""},{"line_number":1151,"context_line":"    def _get_nvme_targets(self):"},{"line_number":1152,"context_line":"        portals \u003d []"}],"source_content_type":"text/x-python","patch_set":9,"id":"04d39d46_c652e6f2","line":1149,"in_reply_to":"e849843d_7934281f","updated":"2022-07-12 07:48:55.000000000","message":"Thanks for your comment. Yes, in the base class we check for iscsi protocol, but we also have another check for client creation and logging of new backend creation. It could be done here, but we decided to call the base constructor to save code lines.","commit_id":"0b2f7f9cd037d236c9bef5a4d9c0d6a111cd757e"},{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"336d1823b0d7d893859b50e2c90921d46a966e3a","unresolved":true,"context_lines":[{"line_number":1160,"context_line":"            msg \u003d _(\"There are no accessible NVMe targets on the \""},{"line_number":1161,"context_line":"                    \"system.\")"},{"line_number":1162,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":1163,"context_line":"        nqn \u003d self.client.get_subsystem_nqn()[0].get(\"nvm_subsystem_nqn\")"},{"line_number":1164,"context_line":"        return portals, nqn"},{"line_number":1165,"context_line":""},{"line_number":1166,"context_line":"    def _get_connection_properties(self, volume_identifier):"}],"source_content_type":"text/x-python","patch_set":9,"id":"8492e9b9_ae146907","line":1163,"updated":"2022-07-08 10:31:38.000000000","message":"When get_subsystem_nqn() will be updated need to delete data unpacking.","commit_id":"0b2f7f9cd037d236c9bef5a4d9c0d6a111cd757e"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"26c3e9b588bc09db0efcc31db9508f714d58633c","unresolved":false,"context_lines":[{"line_number":1160,"context_line":"            msg \u003d _(\"There are no accessible NVMe targets on the \""},{"line_number":1161,"context_line":"                    \"system.\")"},{"line_number":1162,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":1163,"context_line":"        nqn \u003d self.client.get_subsystem_nqn()[0].get(\"nvm_subsystem_nqn\")"},{"line_number":1164,"context_line":"        return portals, nqn"},{"line_number":1165,"context_line":""},{"line_number":1166,"context_line":"    def _get_connection_properties(self, volume_identifier):"}],"source_content_type":"text/x-python","patch_set":9,"id":"2965ff7f_b6b6a3e0","line":1163,"in_reply_to":"8492e9b9_ae146907","updated":"2022-07-12 07:48:55.000000000","message":"Done","commit_id":"0b2f7f9cd037d236c9bef5a4d9c0d6a111cd757e"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c4ccb936df77800c9f8db483786ec9592bf182c3","unresolved":true,"context_lines":[{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":"PROTOCOL_FC \u003d constants.FC"},{"line_number":36,"context_line":"PROTOCOL_ISCSI \u003d constants.ISCSI"},{"line_number":37,"context_line":"PROTOCOL_NVME \u003d constants.NVMEOF"},{"line_number":38,"context_line":"CHAP_MODE_SINGLE \u003d \"Single\""},{"line_number":39,"context_line":"POWERSTORE_NVME_VERSION_SUPPORT \u003d \"3.0\""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"bcfab1e3_c98da404","line":37,"updated":"2022-07-19 19:07:45.000000000","message":"Please be more specific. There are multiple types of NVMe-oF. You are NVMe-TC so that is what you should use as the protocol name. \nCheck out https://review.opendev.org/c/openstack/cinder/+/849690","commit_id":"564d2c3a75c05a6ebb6ae5b91b6fd65dce5492f1"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"3f68860dd33ea305f31ebca378cb104fb3d43603","unresolved":false,"context_lines":[{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":"PROTOCOL_FC \u003d constants.FC"},{"line_number":36,"context_line":"PROTOCOL_ISCSI \u003d constants.ISCSI"},{"line_number":37,"context_line":"PROTOCOL_NVME \u003d constants.NVMEOF"},{"line_number":38,"context_line":"CHAP_MODE_SINGLE \u003d \"Single\""},{"line_number":39,"context_line":"POWERSTORE_NVME_VERSION_SUPPORT \u003d \"3.0\""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"fd2ad0f0_8cc21bee","line":37,"in_reply_to":"bcfab1e3_c98da404","updated":"2022-07-20 22:45:53.000000000","message":"Ack","commit_id":"564d2c3a75c05a6ebb6ae5b91b6fd65dce5492f1"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"bc5c3cbc47b5d30642405e684a0344ce4aa88ab2","unresolved":true,"context_lines":[{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":"PROTOCOL_FC \u003d constants.FC"},{"line_number":36,"context_line":"PROTOCOL_ISCSI \u003d constants.ISCSI"},{"line_number":37,"context_line":"PROTOCOL_NVME \u003d \"NVMe\""},{"line_number":38,"context_line":"CHAP_MODE_SINGLE \u003d \"Single\""},{"line_number":39,"context_line":"POWERSTORE_NVME_VERSION_SUPPORT \u003d \"3.0\""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"0844e745_39d17e08","line":37,"updated":"2022-07-20 12:03:11.000000000","message":"Nope - you need to use the constants and depend on the new patch that provides the TCP constant.\nThere is also an associated tempest patch to use these new constants","commit_id":"59b9daa456e4e30f93c4d4656bc27f7346348733"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"3f68860dd33ea305f31ebca378cb104fb3d43603","unresolved":false,"context_lines":[{"line_number":34,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":35,"context_line":"PROTOCOL_FC \u003d constants.FC"},{"line_number":36,"context_line":"PROTOCOL_ISCSI \u003d constants.ISCSI"},{"line_number":37,"context_line":"PROTOCOL_NVME \u003d \"NVMe\""},{"line_number":38,"context_line":"CHAP_MODE_SINGLE \u003d \"Single\""},{"line_number":39,"context_line":"POWERSTORE_NVME_VERSION_SUPPORT \u003d \"3.0\""},{"line_number":40,"context_line":""}],"source_content_type":"text/x-python","patch_set":11,"id":"4ff96406_8481533d","line":37,"in_reply_to":"0844e745_39d17e08","updated":"2022-07-20 22:45:53.000000000","message":"Ack","commit_id":"59b9daa456e4e30f93c4d4656bc27f7346348733"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cf2cbe2250b5f3550efbaeeb393460ababbc7008","unresolved":true,"context_lines":[{"line_number":573,"context_line":"                      \"host_provider_id\": host[\"id\"],"},{"line_number":574,"context_line":"                  })"},{"line_number":575,"context_line":"        self.client.attach_volume_to_host(host[\"id\"], provider_id)"},{"line_number":576,"context_line":"        if self.storage_protocol \u003d\u003d utils.PROTOCOL_NVME:"},{"line_number":577,"context_line":"            volume_identifier \u003d self.client.get_volume_nguid(provider_id)"},{"line_number":578,"context_line":"        else:"},{"line_number":579,"context_line":"            volume_identifier \u003d self.client.get_volume_lun(host[\"id\"],"}],"source_content_type":"text/x-python","patch_set":15,"id":"6b2c94c5_106ec2fe","line":576,"range":{"start_line":576,"start_character":36,"end_line":576,"end_character":55},"updated":"2022-07-29 11:16:58.000000000","message":"we should use NVMe-oF constants[1] instead of defining our new constants\n\n[1] https://github.com/openstack/cinder/blob/master/cinder/common/constants.py#L46-L48","commit_id":"48be0bd320ac8de45f228cde43b5b4887a4f6b7b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c9a8cb0d3bc030e7fa32ee4f27fa74620b234da6","unresolved":false,"context_lines":[{"line_number":573,"context_line":"                      \"host_provider_id\": host[\"id\"],"},{"line_number":574,"context_line":"                  })"},{"line_number":575,"context_line":"        self.client.attach_volume_to_host(host[\"id\"], provider_id)"},{"line_number":576,"context_line":"        if self.storage_protocol \u003d\u003d utils.PROTOCOL_NVME:"},{"line_number":577,"context_line":"            volume_identifier \u003d self.client.get_volume_nguid(provider_id)"},{"line_number":578,"context_line":"        else:"},{"line_number":579,"context_line":"            volume_identifier \u003d self.client.get_volume_lun(host[\"id\"],"}],"source_content_type":"text/x-python","patch_set":15,"id":"dd13217a_a721b82d","line":576,"range":{"start_line":576,"start_character":36,"end_line":576,"end_character":55},"in_reply_to":"11d96213_09ade8f7","updated":"2022-07-29 12:33:50.000000000","message":"Ack, if it\u0027s used as a standard for the backend API calls then there is very little about it that we can do.","commit_id":"48be0bd320ac8de45f228cde43b5b4887a4f6b7b"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"e9e50bd935af0a12e87e29e19931a14e90062951","unresolved":true,"context_lines":[{"line_number":573,"context_line":"                      \"host_provider_id\": host[\"id\"],"},{"line_number":574,"context_line":"                  })"},{"line_number":575,"context_line":"        self.client.attach_volume_to_host(host[\"id\"], provider_id)"},{"line_number":576,"context_line":"        if self.storage_protocol \u003d\u003d utils.PROTOCOL_NVME:"},{"line_number":577,"context_line":"            volume_identifier \u003d self.client.get_volume_nguid(provider_id)"},{"line_number":578,"context_line":"        else:"},{"line_number":579,"context_line":"            volume_identifier \u003d self.client.get_volume_lun(host[\"id\"],"}],"source_content_type":"text/x-python","patch_set":15,"id":"11d96213_09ade8f7","line":576,"range":{"start_line":576,"start_character":36,"end_line":576,"end_character":55},"in_reply_to":"6b2c94c5_106ec2fe","updated":"2022-07-29 11:27:31.000000000","message":"From the dicussion with Simon Dodsley:\n\n\"Unfortunately, we can not use it because of specifics of the storage backend. We use this parameter for the most part to create a connection with storage and for some REST methods, where the parameter name is set by the API developers.\n\nSo, if we will use new constants we always have to parse it for \"NVMe\", what is not correct in my opinion. Please, correct if I am wrong.\"","commit_id":"48be0bd320ac8de45f228cde43b5b4887a4f6b7b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cf2cbe2250b5f3550efbaeeb393460ababbc7008","unresolved":true,"context_lines":[{"line_number":1177,"context_line":"            \"driver_volume_type\": self.driver_volume_type,"},{"line_number":1178,"context_line":"            \"data\": {"},{"line_number":1179,"context_line":"                \"target_portal\": portals[0],"},{"line_number":1180,"context_line":"                \"target_portals\": portals,"},{"line_number":1181,"context_line":"                \"nqn\": nqn,"},{"line_number":1182,"context_line":"                \"target_port\": 4420,"},{"line_number":1183,"context_line":"                \"transport_type\": \"tcp\","}],"source_content_type":"text/x-python","patch_set":15,"id":"11bf1ba8_803b731c","line":1180,"range":{"start_line":1180,"start_character":16,"end_line":1180,"end_character":42},"updated":"2022-07-29 11:16:58.000000000","message":"not sure if this will be acceptable with the new changes to the nvmeof connector\n\nhttps://github.com/openstack/os-brick/blob/master/os_brick/initiator/connectors/nvmeof.py#L627","commit_id":"48be0bd320ac8de45f228cde43b5b4887a4f6b7b"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"d74a65e791b446eee9c6a6a9e735c39ce5979f5a","unresolved":false,"context_lines":[{"line_number":1177,"context_line":"            \"driver_volume_type\": self.driver_volume_type,"},{"line_number":1178,"context_line":"            \"data\": {"},{"line_number":1179,"context_line":"                \"target_portal\": portals[0],"},{"line_number":1180,"context_line":"                \"target_portals\": portals,"},{"line_number":1181,"context_line":"                \"nqn\": nqn,"},{"line_number":1182,"context_line":"                \"target_port\": 4420,"},{"line_number":1183,"context_line":"                \"transport_type\": \"tcp\","}],"source_content_type":"text/x-python","patch_set":15,"id":"35116d14_9bb6d280","line":1180,"range":{"start_line":1180,"start_character":16,"end_line":1180,"end_character":42},"in_reply_to":"11bf1ba8_803b731c","updated":"2022-07-29 12:09:32.000000000","message":"Removed it. Due to the upcoming code-freeze we set the old format of the connection_properties, but we will update it in the follow up patch.","commit_id":"48be0bd320ac8de45f228cde43b5b4887a4f6b7b"}],"cinder/volume/drivers/dell_emc/powerstore/client.py":[{"author":{"_account_id":34290,"name":"Alexander Malashenko","email":"alexander.malashenko@dell.com","username":"amalashenko"},"change_message_id":"336d1823b0d7d893859b50e2c90921d46a966e3a","unresolved":true,"context_lines":[{"line_number":396,"context_line":"        if r.status_code not in self.ok_codes:"},{"line_number":397,"context_line":"            msg \u003d _(\"Failed to query PowerStore NVMe subsystem nqn.\")"},{"line_number":398,"context_line":"            LOG.error(msg)"},{"line_number":399,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":400,"context_line":"        return response"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def get_ip_pool_address(self, protocol):"}],"source_content_type":"text/x-python","patch_set":9,"id":"a591ff5c_8a914b09","line":399,"updated":"2022-07-08 10:31:38.000000000","message":"Need to add response validation and unpacking data before we will return nqn to driver.","commit_id":"0b2f7f9cd037d236c9bef5a4d9c0d6a111cd757e"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"26c3e9b588bc09db0efcc31db9508f714d58633c","unresolved":false,"context_lines":[{"line_number":396,"context_line":"        if r.status_code not in self.ok_codes:"},{"line_number":397,"context_line":"            msg \u003d _(\"Failed to query PowerStore NVMe subsystem nqn.\")"},{"line_number":398,"context_line":"            LOG.error(msg)"},{"line_number":399,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":400,"context_line":"        return response"},{"line_number":401,"context_line":""},{"line_number":402,"context_line":"    def get_ip_pool_address(self, protocol):"}],"source_content_type":"text/x-python","patch_set":9,"id":"605470cb_370f137f","line":399,"in_reply_to":"a591ff5c_8a914b09","updated":"2022-07-12 07:48:55.000000000","message":"Done","commit_id":"0b2f7f9cd037d236c9bef5a4d9c0d6a111cd757e"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"bc5c3cbc47b5d30642405e684a0344ce4aa88ab2","unresolved":true,"context_lines":[{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":"VOLUME_NOT_MAPPED_ERROR \u003d \"0xE0A08001000F\""},{"line_number":33,"context_line":"SESSION_ALREADY_FAILED_OVER_ERROR \u003d \"0xE0201005000C\""},{"line_number":34,"context_line":"PROTOCOL_NVME \u003d \"NVMe\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class PowerStoreClient(object):"}],"source_content_type":"text/x-python","patch_set":11,"id":"c03799df_dff26f94","line":34,"updated":"2022-07-20 12:03:11.000000000","message":"No - you need to use the new constants - see previous comment","commit_id":"59b9daa456e4e30f93c4d4656bc27f7346348733"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"1b45fa39ed9609be3a66efecc242e1d20fefcb05","unresolved":true,"context_lines":[{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":"VOLUME_NOT_MAPPED_ERROR \u003d \"0xE0A08001000F\""},{"line_number":33,"context_line":"SESSION_ALREADY_FAILED_OVER_ERROR \u003d \"0xE0201005000C\""},{"line_number":34,"context_line":"PROTOCOL_NVME \u003d \"NVMe\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class PowerStoreClient(object):"}],"source_content_type":"text/x-python","patch_set":11,"id":"f5bc05a5_84748c27","line":34,"in_reply_to":"c03799df_dff26f94","updated":"2022-07-20 14:45:04.000000000","message":"Unfortunately, we can not use it because of specifics of the storage backend. We use this parameter for the most part to create a connection with storage and for some REST methods, where the parameter name is set by the API developers.\n\nSo, if we will use new constants we always have to parse it for \"NVMe\", what is not correct in my opinion. Please, correct if I am wrong.","commit_id":"59b9daa456e4e30f93c4d4656bc27f7346348733"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"26715c20c2044bc5998a7427d736219f88d4bcfa","unresolved":false,"context_lines":[{"line_number":31,"context_line":"LOG \u003d logging.getLogger(__name__)"},{"line_number":32,"context_line":"VOLUME_NOT_MAPPED_ERROR \u003d \"0xE0A08001000F\""},{"line_number":33,"context_line":"SESSION_ALREADY_FAILED_OVER_ERROR \u003d \"0xE0201005000C\""},{"line_number":34,"context_line":"PROTOCOL_NVME \u003d \"NVMe\""},{"line_number":35,"context_line":""},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"class PowerStoreClient(object):"}],"source_content_type":"text/x-python","patch_set":11,"id":"3ce41c33_4135baee","line":34,"in_reply_to":"f5bc05a5_84748c27","updated":"2022-07-20 15:24:52.000000000","message":"Understood that this is limited by your backend.","commit_id":"59b9daa456e4e30f93c4d4656bc27f7346348733"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"f1707cf80a5b154964ee61fdafba424de31d2656","unresolved":true,"context_lines":[{"line_number":406,"context_line":"            LOG.error(msg)"},{"line_number":407,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"    def get_ip_pool_address(self, protocol):"},{"line_number":410,"context_line":"        params \u003d {}"},{"line_number":411,"context_line":"        if protocol \u003d\u003d utils.PROTOCOL_ISCSI:"},{"line_number":412,"context_line":"            params \u003d {"}],"source_content_type":"text/x-python","patch_set":14,"id":"888d601e_a6d8be9e","line":409,"updated":"2022-07-28 05:45:10.000000000","message":"-1: I\u0027m wondering why don\u0027t your client functions deserve unit tests? In this function for example you are making changes to a function already used in other places and unit test might help prevent introducing bugs. I don\u0027t think this is a blocker, but I would like to add a -1 just to raise the discussion and if we find it necessary we can improve test coverage in a follow up patch.","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"b02ad24973221de8b401e8427c4e991e9e4a29c0","unresolved":true,"context_lines":[{"line_number":406,"context_line":"            LOG.error(msg)"},{"line_number":407,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"    def get_ip_pool_address(self, protocol):"},{"line_number":410,"context_line":"        params \u003d {}"},{"line_number":411,"context_line":"        if protocol \u003d\u003d utils.PROTOCOL_ISCSI:"},{"line_number":412,"context_line":"            params \u003d {"}],"source_content_type":"text/x-python","patch_set":14,"id":"af5cc989_1e54d80d","line":409,"in_reply_to":"888d601e_a6d8be9e","updated":"2022-07-28 11:04:35.000000000","message":"Hi Fernando, totally agree with you that client should be tested. But as you can see, this driver doesn\u0027t test the client at all. We want to add it, but I think it should be a different patch because there will be many new test cases added that are not related to the NVMe driver. Is it OK or we should create test only for these methods and add others in a follow up patch?","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"b3463dd66b88422a1a7e3a0f6ae70e626c4a2fb0","unresolved":false,"context_lines":[{"line_number":406,"context_line":"            LOG.error(msg)"},{"line_number":407,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"    def get_ip_pool_address(self, protocol):"},{"line_number":410,"context_line":"        params \u003d {}"},{"line_number":411,"context_line":"        if protocol \u003d\u003d utils.PROTOCOL_ISCSI:"},{"line_number":412,"context_line":"            params \u003d {"}],"source_content_type":"text/x-python","patch_set":14,"id":"fc306872_697fd6b8","line":409,"in_reply_to":"8add4582_f57efeb6","updated":"2022-07-29 07:59:39.000000000","message":"Done.","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"8bb70282ff206e44b6cadda89b6636887f07ef37","unresolved":true,"context_lines":[{"line_number":406,"context_line":"            LOG.error(msg)"},{"line_number":407,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"    def get_ip_pool_address(self, protocol):"},{"line_number":410,"context_line":"        params \u003d {}"},{"line_number":411,"context_line":"        if protocol \u003d\u003d utils.PROTOCOL_ISCSI:"},{"line_number":412,"context_line":"            params \u003d {"}],"source_content_type":"text/x-python","patch_set":14,"id":"8add4582_f57efeb6","line":409,"in_reply_to":"af5cc989_1e54d80d","updated":"2022-07-28 12:59:06.000000000","message":"Hi Oleg, having a separate patch to added 5k lines of test cases is the way to go. I would recomend to create test cases only for these methods for now, so we start moving towards this goal.","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"f1707cf80a5b154964ee61fdafba424de31d2656","unresolved":true,"context_lines":[{"line_number":771,"context_line":"            LOG.error(msg)"},{"line_number":772,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":773,"context_line":""},{"line_number":774,"context_line":"    def get_array_version(self):"},{"line_number":775,"context_line":"        r, response \u003d self._send_get_request("},{"line_number":776,"context_line":"            \"/software_installed\","},{"line_number":777,"context_line":"            params\u003d{"}],"source_content_type":"text/x-python","patch_set":14,"id":"3c75f28f_f3782e9c","line":774,"updated":"2022-07-28 05:45:10.000000000","message":"same as above","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"b3463dd66b88422a1a7e3a0f6ae70e626c4a2fb0","unresolved":false,"context_lines":[{"line_number":771,"context_line":"            LOG.error(msg)"},{"line_number":772,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":773,"context_line":""},{"line_number":774,"context_line":"    def get_array_version(self):"},{"line_number":775,"context_line":"        r, response \u003d self._send_get_request("},{"line_number":776,"context_line":"            \"/software_installed\","},{"line_number":777,"context_line":"            params\u003d{"}],"source_content_type":"text/x-python","patch_set":14,"id":"2036294d_8f84d7e1","line":774,"in_reply_to":"3c75f28f_f3782e9c","updated":"2022-07-29 07:59:39.000000000","message":"Done.","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":30555,"name":"Fernando Ferraz","display_name":"Fernando Ferraz","email":"fesilva@redhat.com","username":"fernandoperches"},"change_message_id":"f1707cf80a5b154964ee61fdafba424de31d2656","unresolved":true,"context_lines":[{"line_number":785,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":786,"context_line":"        return response[0].get(\"release_version\")"},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"    def get_volume_nguid(self, volume_id):"},{"line_number":789,"context_line":"        r, response \u003d self._send_get_request("},{"line_number":790,"context_line":"            \"/volume/%s\" % volume_id,"},{"line_number":791,"context_line":"            params\u003d{"}],"source_content_type":"text/x-python","patch_set":14,"id":"6427a21c_06ccd672","line":788,"updated":"2022-07-28 05:45:10.000000000","message":"same as above","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"b3463dd66b88422a1a7e3a0f6ae70e626c4a2fb0","unresolved":false,"context_lines":[{"line_number":785,"context_line":"            raise exception.VolumeBackendAPIException(data\u003dmsg)"},{"line_number":786,"context_line":"        return response[0].get(\"release_version\")"},{"line_number":787,"context_line":""},{"line_number":788,"context_line":"    def get_volume_nguid(self, volume_id):"},{"line_number":789,"context_line":"        r, response \u003d self._send_get_request("},{"line_number":790,"context_line":"            \"/volume/%s\" % volume_id,"},{"line_number":791,"context_line":"            params\u003d{"}],"source_content_type":"text/x-python","patch_set":14,"id":"2939e29c_ae325e2a","line":788,"in_reply_to":"6427a21c_06ccd672","updated":"2022-07-29 07:59:39.000000000","message":"Done.","commit_id":"83fbea75d9aafbdc7eab18a6864cd9def018ea1a"}],"cinder/volume/drivers/dell_emc/powerstore/driver.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cf2cbe2250b5f3550efbaeeb393460ababbc7008","unresolved":true,"context_lines":[{"line_number":91,"context_line":"        if not self.active_backend_id:"},{"line_number":92,"context_line":"            self.active_backend_id \u003d manager.VolumeManager.FAILBACK_SENTINEL"},{"line_number":93,"context_line":"        storage_protocol \u003d self.configuration.safe_get(\"storage_protocol\")"},{"line_number":94,"context_line":"        if self.configuration.safe_get(options.POWERSTORE_NVME):"},{"line_number":95,"context_line":"            adapter_class \u003d adapter.NVMEoFAdapter"},{"line_number":96,"context_line":"        elif ("},{"line_number":97,"context_line":"                storage_protocol and"}],"source_content_type":"text/x-python","patch_set":15,"id":"5336dfac_73a1d419","line":94,"range":{"start_line":94,"start_character":11,"end_line":94,"end_character":64},"updated":"2022-07-29 11:16:58.000000000","message":"Why are we introducing a new config option here and not assigning adapter based on the storage_protocol config option? similar to how we do it in FC","commit_id":"48be0bd320ac8de45f228cde43b5b4887a4f6b7b"}],"cinder/volume/drivers/dell_emc/powerstore/options.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cf2cbe2250b5f3550efbaeeb393460ababbc7008","unresolved":true,"context_lines":[{"line_number":37,"context_line":"                     \"iSCSI IPs or FC WWNs (ex. 58:cc:f0:98:49:22:07:02) \""},{"line_number":38,"context_line":"                     \"to be used. If option is not set all ports are allowed.\""},{"line_number":39,"context_line":"                ),"},{"line_number":40,"context_line":"    cfg.BoolOpt(POWERSTORE_NVME,"},{"line_number":41,"context_line":"                default\u003dFalse,"},{"line_number":42,"context_line":"                help\u003d\"Connect PowerStore volumes using NVMe-OF.\")"},{"line_number":43,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":15,"id":"b5bc7d56_137cff66","line":42,"range":{"start_line":40,"start_character":0,"end_line":42,"end_character":65},"updated":"2022-07-29 11:16:58.000000000","message":"I don\u0027t think this is needed, can\u0027t we use storage_protocol to see if the configured backend is for nvme protocol?","commit_id":"48be0bd320ac8de45f228cde43b5b4887a4f6b7b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"c9a8cb0d3bc030e7fa32ee4f27fa74620b234da6","unresolved":false,"context_lines":[{"line_number":37,"context_line":"                     \"iSCSI IPs or FC WWNs (ex. 58:cc:f0:98:49:22:07:02) \""},{"line_number":38,"context_line":"                     \"to be used. If option is not set all ports are allowed.\""},{"line_number":39,"context_line":"                ),"},{"line_number":40,"context_line":"    cfg.BoolOpt(POWERSTORE_NVME,"},{"line_number":41,"context_line":"                default\u003dFalse,"},{"line_number":42,"context_line":"                help\u003d\"Connect PowerStore volumes using NVMe-OF.\")"},{"line_number":43,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":15,"id":"afcf1388_92dffed5","line":42,"range":{"start_line":40,"start_character":0,"end_line":42,"end_character":65},"in_reply_to":"b5996ee6_9d623479","updated":"2022-07-29 12:33:50.000000000","message":"That\u0027s actually true, we don\u0027t have a base class for NVMe[1] but looks like we require one. Anyway, it\u0027s unrelated to the powerstore driver.\n\n[1] https://github.com/openstack/cinder/blob/master/cinder/volume/driver.py","commit_id":"48be0bd320ac8de45f228cde43b5b4887a4f6b7b"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"e9e50bd935af0a12e87e29e19931a14e90062951","unresolved":true,"context_lines":[{"line_number":37,"context_line":"                     \"iSCSI IPs or FC WWNs (ex. 58:cc:f0:98:49:22:07:02) \""},{"line_number":38,"context_line":"                     \"to be used. If option is not set all ports are allowed.\""},{"line_number":39,"context_line":"                ),"},{"line_number":40,"context_line":"    cfg.BoolOpt(POWERSTORE_NVME,"},{"line_number":41,"context_line":"                default\u003dFalse,"},{"line_number":42,"context_line":"                help\u003d\"Connect PowerStore volumes using NVMe-OF.\")"},{"line_number":43,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":15,"id":"b5996ee6_9d623479","line":42,"range":{"start_line":40,"start_character":0,"end_line":42,"end_character":65},"in_reply_to":"b5bc7d56_137cff66","updated":"2022-07-29 11:27:31.000000000","message":"storage_protocol has no NVMe option, only FC/iSCSI. I asked on IRC if we could put it in the list of options. Gorka Eguileor said that NVMe doesn\u0027t have a common class yet, so we can\u0027t.","commit_id":"48be0bd320ac8de45f228cde43b5b4887a4f6b7b"}],"cinder/volume/drivers/dell_emc/powerstore/utils.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cf2cbe2250b5f3550efbaeeb393460ababbc7008","unresolved":true,"context_lines":[{"line_number":35,"context_line":"CHAP_DEFAULT_SECRET_LENGTH \u003d 60"},{"line_number":36,"context_line":"PROTOCOL_FC \u003d constants.FC"},{"line_number":37,"context_line":"PROTOCOL_ISCSI \u003d constants.ISCSI"},{"line_number":38,"context_line":"PROTOCOL_NVME \u003d \"NVMe\""},{"line_number":39,"context_line":""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"def bytes_to_gib(size_in_bytes):"}],"source_content_type":"text/x-python","patch_set":15,"id":"6c5d5fc3_1635e405","line":38,"range":{"start_line":38,"start_character":16,"end_line":38,"end_character":22},"updated":"2022-07-29 11:16:58.000000000","message":"this should be one of the NVMe variants and we should use the same in storage_protocol config option else cinder scheduler won\u0027t be able to use this backend for scheduling/weighing\nhttps://github.com/openstack/cinder/blob/master/cinder/common/constants.py#L46-L48","commit_id":"48be0bd320ac8de45f228cde43b5b4887a4f6b7b"}],"doc/source/configuration/block-storage/drivers/dell-emc-powerstore-driver.rst":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"cf2cbe2250b5f3550efbaeeb393460ababbc7008","unresolved":true,"context_lines":[{"line_number":75,"context_line":"  # Backend name"},{"line_number":76,"context_line":"  volume_backend_name \u003d \u003cBackend name\u003e"},{"line_number":77,"context_line":"  powerstore_nvme \u003d True"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"Driver options"},{"line_number":80,"context_line":"~~~~~~~~~~~~~~"},{"line_number":81,"context_line":""}],"source_content_type":"text/x-rst","patch_set":15,"id":"d6eac1ae_53cbfce7","line":78,"updated":"2022-07-29 11:16:58.000000000","message":"storage_protocol is not defined here","commit_id":"48be0bd320ac8de45f228cde43b5b4887a4f6b7b"}],"doc/source/reference/support-matrix.ini":[{"author":{"_account_id":597,"name":"Pete Zaitcev","email":"zaitcev@kotori.zaitcev.us","username":"zaitcev"},"change_message_id":"f8102dac95f12ff088d9df1c298306e4dd5ec0f7","unresolved":true,"context_lines":[{"line_number":25,"context_line":"title\u003dDell PowerMax (2000, 8000) Storage Driver (iSCSI, FC)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[driver.dell_emc_powerstore]"},{"line_number":28,"context_line":"title\u003dDell PowerStore Storage Driver (iSCSI, FC, NVMe-OF)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"[driver.dell_emc_sc]"},{"line_number":31,"context_line":"title\u003dDell SC Series Storage Driver (iSCSI, FC)"}],"source_content_type":"text/x-properties","patch_set":8,"id":"f7aa08da_039f6bc6","line":28,"updated":"2022-07-06 20:54:29.000000000","message":"I don\u0027t want to be too picky, but the it\u0027s NVMe-oF.","commit_id":"7f5f7f4e52f94dcc697deb25383de8d6b26b1152"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"26c3e9b588bc09db0efcc31db9508f714d58633c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"title\u003dDell PowerMax (2000, 8000) Storage Driver (iSCSI, FC)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[driver.dell_emc_powerstore]"},{"line_number":28,"context_line":"title\u003dDell PowerStore Storage Driver (iSCSI, FC, NVMe-OF)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"[driver.dell_emc_sc]"},{"line_number":31,"context_line":"title\u003dDell SC Series Storage Driver (iSCSI, FC)"}],"source_content_type":"text/x-properties","patch_set":8,"id":"b332b464_e5f23844","line":28,"in_reply_to":"f7aa08da_039f6bc6","updated":"2022-07-12 07:48:55.000000000","message":"Done","commit_id":"7f5f7f4e52f94dcc697deb25383de8d6b26b1152"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"c4ccb936df77800c9f8db483786ec9592bf182c3","unresolved":true,"context_lines":[{"line_number":25,"context_line":"title\u003dDell PowerMax (2000, 8000) Storage Driver (iSCSI, FC)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[driver.dell_emc_powerstore]"},{"line_number":28,"context_line":"title\u003dDell PowerStore Storage Driver (iSCSI, FC, NVMe-oF)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"[driver.dell_emc_sc]"},{"line_number":31,"context_line":"title\u003dDell SC Series Storage Driver (iSCSI, FC)"}],"source_content_type":"text/x-properties","patch_set":10,"id":"a8f9a1c0_a9fdc791","line":28,"updated":"2022-07-19 19:07:45.000000000","message":"I think you should be specific here - this is a NVMe-TCP driver. NVMe-oF is a pretty generic term and can be also applied to NVMe-Fc and NVMe-RoCE","commit_id":"564d2c3a75c05a6ebb6ae5b91b6fd65dce5492f1"},{"author":{"_account_id":33502,"name":"Oleg","display_name":"Oleg Nesterenkov","email":"Oleg_Nesterenkov@Dell.com","username":"olegnest"},"change_message_id":"985b75e1cc9841231390fa13cd80353a8b0c740a","unresolved":false,"context_lines":[{"line_number":25,"context_line":"title\u003dDell PowerMax (2000, 8000) Storage Driver (iSCSI, FC)"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"[driver.dell_emc_powerstore]"},{"line_number":28,"context_line":"title\u003dDell PowerStore Storage Driver (iSCSI, FC, NVMe-oF)"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"[driver.dell_emc_sc]"},{"line_number":31,"context_line":"title\u003dDell SC Series Storage Driver (iSCSI, FC)"}],"source_content_type":"text/x-properties","patch_set":10,"id":"5d9a9163_4015c842","line":28,"in_reply_to":"a8f9a1c0_a9fdc791","updated":"2022-07-20 14:32:35.000000000","message":"Agree with you. \nDone.","commit_id":"564d2c3a75c05a6ebb6ae5b91b6fd65dce5492f1"}]}