)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"4eebc48e551c841e411817d4e599a0fac3e57b51","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7873e16f_31de3c68","updated":"2021-12-02 17:55:11.000000000","message":"Gate errors come from the different syntax between MySQL and MariaDB for the table value construct.  MySQL needs the ROW keyword.","commit_id":"6435e74663bc5421bcb78b063bc1b0a5b0c572f8"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d2b19f2f50e039c0d33c885546ac8b780e589947","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"6439dc90_2a7cdd76","updated":"2021-12-03 15:08:02.000000000","message":"There was another discrepancy between MySQL and MariaDB in how they name the columns of the VALUES SQL clause as noted in the new patchset comments.","commit_id":"5ad15b5a60db3dd56cf3a59825d92409373bef8f"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"63ba7ae437c73ecbe57516199c34fccb978d9b90","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f40f8089_4e2a06d4","updated":"2021-12-07 17:58:17.000000000","message":"These failures come from MySQL 8.0.2 making groups a reserved word: https://dev.mysql.com/doc/refman/8.0/en/keywords.html","commit_id":"45dcf9dcc5f56bdd81357cb95fb0a5a1576ce796"},{"author":{"_account_id":32755,"name":"Christian Rohmann","email":"christian.rohmann@inovex.de","username":"frittentheke"},"change_message_id":"359cc7b94b9881fe6bbcb9e37ff71b0fbfe166be","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":8,"id":"10681f8a_ed122da4","updated":"2023-05-25 14:11:10.000000000","message":"We see quite a bit of quota corruption on Yoga regularly and would love to see this change to the quota system. May I ask what the current status of this code / change is? If there were any contributions to this change addressing the missing things, does it have a chance to make it into Bobcat or the following release? Or does it need further thoughts and refinements?\n\nMaybe a rebase would be nice to make it easier to start contributing to this patchset?","commit_id":"c3aa8c9e9c68db847e95f1205e4754ddb6ab4dc4"}],"cinder/api/v2/limits.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"60103e35902e0237e6c640406794f44cff105196","unresolved":true,"context_lines":[{"line_number":52,"context_line":"        \"\"\"Return all global and rate limit information.\"\"\""},{"line_number":53,"context_line":"        context \u003d req.environ[\u0027cinder.context\u0027]"},{"line_number":54,"context_line":"        # TODO: Not sure this is doing the same thing it did before"},{"line_number":55,"context_line":"        quotas \u003d quota.driver.get_limits_and_usage(context,"},{"line_number":56,"context_line":"                                                   usages\u003dFalse)"},{"line_number":57,"context_line":"        rate_limits \u003d req.environ.get(\"cinder.limits\", [])"},{"line_number":58,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"bf045a52_8b144f9c","line":55,"range":{"start_line":55,"start_character":8,"end_line":55,"end_character":14},"updated":"2024-01-29 22:52:59.000000000","message":"this isn\u0027t used anywhere, we shouldn\u0027t be removing this line?\n\n    abs_limits \u003d {k: v[\u0027limit\u0027] for k, v in quotas.items()}","commit_id":"c3aa8c9e9c68db847e95f1205e4754ddb6ab4dc4"}],"cinder/api/v3/limits.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"60103e35902e0237e6c640406794f44cff105196","unresolved":true,"context_lines":[{"line_number":39,"context_line":"        project_id \u003d params.get("},{"line_number":40,"context_line":"            \u0027project_id\u0027, params.get(\u0027tenant_id\u0027, context.project_id))"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"        quotas \u003d quota.driver.get_limits_and_usage(context,"},{"line_number":43,"context_line":"                                                   project_id,"},{"line_number":44,"context_line":"                                                   usages\u003dFalse)"},{"line_number":45,"context_line":"        rate_limits \u003d req.environ.get(\"cinder.limits\", [])"}],"source_content_type":"text/x-python","patch_set":8,"id":"89f91703_2c30444e","line":42,"range":{"start_line":42,"start_character":8,"end_line":42,"end_character":14},"updated":"2024-01-29 22:52:59.000000000","message":"same, this isn\u0027t used anywhere and we are removing the line that fetches absolute limits used on L#48","commit_id":"c3aa8c9e9c68db847e95f1205e4754ddb6ab4dc4"}],"cinder/group/api.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"60103e35902e0237e6c640406794f44cff105196","unresolved":true,"context_lines":[{"line_number":285,"context_line":"                # Since group snapshot is passed in, the following call will"},{"line_number":286,"context_line":"                # create a db entry for the volume, but will not call the"},{"line_number":287,"context_line":"                # volume manager to create a real volume in the backend yet."},{"line_number":288,"context_line":"                # If error happens, taskflow will quota and removal of volume"},{"line_number":289,"context_line":"                # entry in the db."},{"line_number":290,"context_line":"                try:"},{"line_number":291,"context_line":"                    self.volume_api.create(context,"}],"source_content_type":"text/x-python","patch_set":8,"id":"f260eed9_81b6c747","line":288,"range":{"start_line":288,"start_character":50,"end_line":288,"end_character":55},"updated":"2024-01-29 22:52:59.000000000","message":"nit: handle quota","commit_id":"c3aa8c9e9c68db847e95f1205e4754ddb6ab4dc4"}],"cinder/objects/volume.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"60103e35902e0237e6c640406794f44cff105196","unresolved":true,"context_lines":[{"line_number":479,"context_line":"                # Metadata items that are not specified in the"},{"line_number":480,"context_line":"                # self.metadata will be deleted"},{"line_number":481,"context_line":"                metadata \u003d updates.pop(\u0027metadata\u0027, None)"},{"line_number":482,"context_line":"                # TODO: Change DB methods to use the context session"},{"line_number":483,"context_line":"                self.metadata \u003d db.volume_metadata_update(self._context,"},{"line_number":484,"context_line":"                                                          self.id, metadata,"},{"line_number":485,"context_line":"                                                          True)"}],"source_content_type":"text/x-python","patch_set":8,"id":"bec5e8a1_3357b50e","line":482,"range":{"start_line":482,"start_character":16,"end_line":482,"end_character":68},"updated":"2024-01-29 22:52:59.000000000","message":"not needed anymore","commit_id":"c3aa8c9e9c68db847e95f1205e4754ddb6ab4dc4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"60103e35902e0237e6c640406794f44cff105196","unresolved":true,"context_lines":[{"line_number":485,"context_line":"                                                          True)"},{"line_number":486,"context_line":"            if self._context.is_admin and \u0027admin_metadata\u0027 in updates:"},{"line_number":487,"context_line":"                metadata \u003d updates.pop(\u0027admin_metadata\u0027, None)"},{"line_number":488,"context_line":"                # TODO: Change DB methods to use the context session"},{"line_number":489,"context_line":"                self.admin_metadata \u003d db.volume_admin_metadata_update("},{"line_number":490,"context_line":"                    self._context, self.id, metadata, True)"},{"line_number":491,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"1a36aa28_1dff46c3","line":488,"range":{"start_line":488,"start_character":16,"end_line":488,"end_character":68},"updated":"2024-01-29 22:52:59.000000000","message":"same","commit_id":"c3aa8c9e9c68db847e95f1205e4754ddb6ab4dc4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"60103e35902e0237e6c640406794f44cff105196","unresolved":true,"context_lines":[{"line_number":495,"context_line":"            # not be performed as it will be mistaken for a volume that has"},{"line_number":496,"context_line":"            # been somehow changed (reset status, forced operation...)"},{"line_number":497,"context_line":"            if updates.get(\u0027status\u0027) \u003d\u003d \u0027downloading\u0027:"},{"line_number":498,"context_line":"                # TODO: Change DB methods to use the context session"},{"line_number":499,"context_line":"                self.set_worker()"},{"line_number":500,"context_line":""},{"line_number":501,"context_line":"            # updates are changed after popping out metadata."}],"source_content_type":"text/x-python","patch_set":8,"id":"c458e01d_4769e456","line":498,"range":{"start_line":498,"start_character":16,"end_line":498,"end_character":68},"updated":"2024-01-29 22:52:59.000000000","message":"same","commit_id":"c3aa8c9e9c68db847e95f1205e4754ddb6ab4dc4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"60103e35902e0237e6c640406794f44cff105196","unresolved":true,"context_lines":[{"line_number":501,"context_line":"            # updates are changed after popping out metadata."},{"line_number":502,"context_line":"            if updates:"},{"line_number":503,"context_line":"                vol_gbs \u003d self.size - self._previous_size"},{"line_number":504,"context_line":"                # Extend reserved the size, but manage doesn\u0027t as it was unkown"},{"line_number":505,"context_line":"                if vol_gbs and not size_reserved:"},{"line_number":506,"context_line":"                    quota_checker \u003d self.quota_check"},{"line_number":507,"context_line":"                else:"}],"source_content_type":"text/x-python","patch_set":8,"id":"9f2a3f8a_23bb8065","line":504,"range":{"start_line":504,"start_character":73,"end_line":504,"end_character":79},"updated":"2024-01-29 22:52:59.000000000","message":"nit: unknown","commit_id":"c3aa8c9e9c68db847e95f1205e4754ddb6ab4dc4"}],"cinder/volume/api.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"60103e35902e0237e6c640406794f44cff105196","unresolved":true,"context_lines":[{"line_number":850,"context_line":"                              cgsnapshot_id,"},{"line_number":851,"context_line":"                              group_snapshot_id\u003dNone,"},{"line_number":852,"context_line":"                              allow_in_use\u003dFalse,"},{"line_number":853,"context_line":"                              forzed_size\u003dNone):"},{"line_number":854,"context_line":"        \"\"\"forzed_size allows creating snapshot record with 0 size for manage"},{"line_number":855,"context_line":"        operation.\"\"\""},{"line_number":856,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"d12d4b01_5189ecd0","line":853,"range":{"start_line":853,"start_character":30,"end_line":853,"end_character":41},"updated":"2024-01-29 22:52:59.000000000","message":"forced or forged?","commit_id":"c3aa8c9e9c68db847e95f1205e4754ddb6ab4dc4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"60103e35902e0237e6c640406794f44cff105196","unresolved":true,"context_lines":[{"line_number":909,"context_line":"                               group_snapshot):"},{"line_number":910,"context_line":"        \"\"\""},{"line_number":911,"context_line":"        This is only called from create_group_snapshot withing a DB"},{"line_number":912,"context_line":"        transaction, if we ever call it from somewhere elese outside of a"},{"line_number":913,"context_line":"        transaction we\u0027ll have to add a db transaction context manager to do"},{"line_number":914,"context_line":"        all the snapshot creation within the same transaction"},{"line_number":915,"context_line":"        \"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"372ad1be_abe03c85","line":912,"range":{"start_line":912,"start_character":55,"end_line":912,"end_character":60},"updated":"2024-01-29 22:52:59.000000000","message":"nit: else","commit_id":"c3aa8c9e9c68db847e95f1205e4754ddb6ab4dc4"}],"cinder/volume/rpcapi.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"60103e35902e0237e6c640406794f44cff105196","unresolved":true,"context_lines":[{"line_number":135,"context_line":"        3.17 - Remove reservations from extend_volume"},{"line_number":136,"context_line":"    \"\"\""},{"line_number":137,"context_line":""},{"line_number":138,"context_line":"    RPC_API_VERSION \u003d \u00273.17\u0027"},{"line_number":139,"context_line":"    RPC_DEFAULT_VERSION \u003d \u00273.0\u0027"},{"line_number":140,"context_line":"    TOPIC \u003d constants.VOLUME_TOPIC"},{"line_number":141,"context_line":"    BINARY \u003d constants.VOLUME_BINARY"}],"source_content_type":"text/x-python","patch_set":8,"id":"399cbf66_2a0a14a9","line":138,"range":{"start_line":138,"start_character":25,"end_line":138,"end_character":27},"updated":"2024-01-29 22:52:59.000000000","message":"3.19","commit_id":"c3aa8c9e9c68db847e95f1205e4754ddb6ab4dc4"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"60103e35902e0237e6c640406794f44cff105196","unresolved":true,"context_lines":[{"line_number":270,"context_line":"    # TODO: (Z release) drop reservations parameter and always send with 3.17"},{"line_number":271,"context_line":"    def extend_volume(self, ctxt, volume, new_size):"},{"line_number":272,"context_line":"        extra_args \u003d {}"},{"line_number":273,"context_line":"        version \u003d \u00273.17\u0027"},{"line_number":274,"context_line":"        if not self.client.can_send_version(version):"},{"line_number":275,"context_line":"            version \u003d \u00273.0\u0027"},{"line_number":276,"context_line":"            extra_args[\u0027reservations\u0027] \u003d []"}],"source_content_type":"text/x-python","patch_set":8,"id":"f452a55c_127b56a6","line":273,"range":{"start_line":273,"start_character":21,"end_line":273,"end_character":23},"updated":"2024-01-29 22:52:59.000000000","message":"3.19","commit_id":"c3aa8c9e9c68db847e95f1205e4754ddb6ab4dc4"}]}