)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0e085594c75e636de61c8ac50cc878edb9373291","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"22048ef2_28e398f0","updated":"2021-12-03 15:42:34.000000000","message":"Thank you for the fix!\nThe downvote is for the missing release note ( https://docs.openstack.org/cinder/latest/contributor/releasenotes.html ) not for the nit in the inline comment, which you should feel free to ignore since my complaint is from earlier code and not your fix.","commit_id":"87eaa264b9ecb3a1b1c25648519f2621d0978be5"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"fb1a347db9ca62dcda802f9e7b652f71b9ddf5b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"530d027c_d052a0f3","in_reply_to":"22048ef2_28e398f0","updated":"2021-12-03 17:48:44.000000000","message":"Done.","commit_id":"87eaa264b9ecb3a1b1c25648519f2621d0978be5"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"fb1a347db9ca62dcda802f9e7b652f71b9ddf5b9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6f56776d_758f6256","updated":"2021-12-03 17:48:44.000000000","message":"Hi Gorka!\nThank you for the review. I\u0027ve already uploaded a new PS. ","commit_id":"4ddf135d32ed2594f61de4fc81927eeaaf14f239"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"fde83b3fbd0c019c9dbf9b9bf292c97543c9bd7f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f850dd09_a05a3661","updated":"2021-12-09 20:06:23.000000000","message":"Hi Caique, LGTM! Thank you for this fix. ","commit_id":"18687a383bdd99ceab5060e4741e98e955df1564"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"72b5e339d8cd1d501245ba2448dbf84f3e9ce93e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"31ed2c43_6b9c30a3","updated":"2022-02-16 16:47:17.000000000","message":"If you propose a backport, please squash in change I6976569ac3617c that corrects a typo in the release note.","commit_id":"18687a383bdd99ceab5060e4741e98e955df1564"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"a0e2e752db7cf548bb4de7991510d7a20da69689","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"ccc94463_2825d332","updated":"2021-12-08 18:21:10.000000000","message":"LGTM. Straight forward fix and has clear commit message and release notes.\nThank you, Caique!","commit_id":"18687a383bdd99ceab5060e4741e98e955df1564"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"e270a635b8729fc122320a552532bd76f54f4dd8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"db950c2e_abf66bba","updated":"2021-12-07 19:09:12.000000000","message":"Release note added and comments addressed. Looks good to me. ","commit_id":"18687a383bdd99ceab5060e4741e98e955df1564"}],"cinder/scheduler/filters/capacity_filter.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"0e085594c75e636de61c8ac50cc878edb9373291","unresolved":true,"context_lines":[{"line_number":155,"context_line":"                # of reserved space) which we can over-subscribe."},{"line_number":156,"context_line":"                adjusted_free_virtual \u003d ("},{"line_number":157,"context_line":"                    free * backend_state.max_over_subscription_ratio)"},{"line_number":158,"context_line":"                msg_args \u003d {\"available\": adjusted_free_virtual,"},{"line_number":159,"context_line":"                            \"size\": requested_size,"},{"line_number":160,"context_line":"                            \"grouping\": grouping,"},{"line_number":161,"context_line":"                            \"grouping_name\": backend_state.backend_id}"},{"line_number":162,"context_line":"                res \u003d adjusted_free_virtual \u003e\u003d requested_size"},{"line_number":163,"context_line":"                if not res:"},{"line_number":164,"context_line":"                    LOG.warning(\"Insufficient free virtual space \""}],"source_content_type":"text/x-python","patch_set":1,"id":"55e648f6_0bbcf6fe","line":161,"range":{"start_line":158,"start_character":0,"end_line":161,"end_character":70},"updated":"2021-12-03 15:42:34.000000000","message":"nit: I would prefer if we didn\u0027t change the whole msg_args that was set on L121-124, and instead we just changed the `available` key.\n\n    msg_args[\u0027available\u0027] \u003d adjusted_free_virtual\n\nAnd then changed on L166 from %(size)s to %(requested)s","commit_id":"87eaa264b9ecb3a1b1c25648519f2621d0978be5"},{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"fb1a347db9ca62dcda802f9e7b652f71b9ddf5b9","unresolved":false,"context_lines":[{"line_number":155,"context_line":"                # of reserved space) which we can over-subscribe."},{"line_number":156,"context_line":"                adjusted_free_virtual \u003d ("},{"line_number":157,"context_line":"                    free * backend_state.max_over_subscription_ratio)"},{"line_number":158,"context_line":"                msg_args \u003d {\"available\": adjusted_free_virtual,"},{"line_number":159,"context_line":"                            \"size\": requested_size,"},{"line_number":160,"context_line":"                            \"grouping\": grouping,"},{"line_number":161,"context_line":"                            \"grouping_name\": backend_state.backend_id}"},{"line_number":162,"context_line":"                res \u003d adjusted_free_virtual \u003e\u003d requested_size"},{"line_number":163,"context_line":"                if not res:"},{"line_number":164,"context_line":"                    LOG.warning(\"Insufficient free virtual space \""}],"source_content_type":"text/x-python","patch_set":1,"id":"28c8de21_e8bbe875","line":161,"range":{"start_line":158,"start_character":0,"end_line":161,"end_character":70},"in_reply_to":"55e648f6_0bbcf6fe","updated":"2021-12-03 17:48:44.000000000","message":"Done. Thank you!","commit_id":"87eaa264b9ecb3a1b1c25648519f2621d0978be5"}]}
