)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":819,"name":"Adrien Cunin","email":"adrien@adriencunin.fr","username":"adri2000"},"change_message_id":"43e1d113d1db4476009e423ee9a3441fa807d03e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"6ac5e216_60e42707","updated":"2022-01-13 11:27:11.000000000","message":"Thanks for the patch, I tested it on a Victoria deployment, and it works as expected.","commit_id":"cd1655d3a0fc513a8eb8512e802b704f7693bbf7"},{"author":{"_account_id":31721,"name":"Felipe Rodrigues","email":"felipefuty01@gmail.com","username":"felipefutty"},"change_message_id":"0e6bb5d2881dac64bba8c7487f78e0053579e382","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b9025179_144fe0f7","updated":"2021-12-07 11:44:50.000000000","message":"recheck","commit_id":"cd1655d3a0fc513a8eb8512e802b704f7693bbf7"},{"author":{"_account_id":28801,"name":"Cisco Cinder CI","email":"cisco-cinder-ci@cisco.com","username":"cisco-cinder-ci"},"change_message_id":"b42a243eed1b28b41e9df2bcfb7d9507afa7fecd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"187b6fbb_8dc6352b","updated":"2022-03-11 08:29:10.000000000","message":"cisco-cinder-ci","commit_id":"b57deaecd98cbb684806f89883435dc5b541fd2f"},{"author":{"_account_id":28801,"name":"Cisco Cinder CI","email":"cisco-cinder-ci@cisco.com","username":"cisco-cinder-ci"},"change_message_id":"6dff73bd23d38e2c48527f763ba39ccdd63cbaeb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"6b88b9e1_80dd6a28","updated":"2022-03-11 07:45:33.000000000","message":"cisco-cinder-ci","commit_id":"b57deaecd98cbb684806f89883435dc5b541fd2f"},{"author":{"_account_id":28801,"name":"Cisco Cinder CI","email":"cisco-cinder-ci@cisco.com","username":"cisco-cinder-ci"},"change_message_id":"c95953c9dad3a7b2f0fff7be629ba3124f546e2b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"70350b89_77f37656","updated":"2022-03-11 09:07:08.000000000","message":"cisco-cinder-ci","commit_id":"b57deaecd98cbb684806f89883435dc5b541fd2f"},{"author":{"_account_id":38059,"name":"Anoop Kumar Shukla","display_name":"Anoop Shukla","email":"anoop.shukla@netapp.com","username":"anoop2","status":"NetApp"},"change_message_id":"ee1cdaafeb25e4c10e7aa16421e60259f4777628","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"604daf01_42ee342d","updated":"2026-03-10 16:32:35.000000000","message":"Adding NetApp reviewers.","commit_id":"0c07e6e0983f1188302c892d3371e23842260cd2"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"06958182e737726c7158f515cce8271d4c26b332","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"798c1b91_c139f344","updated":"2022-04-01 15:24:22.000000000","message":"Hi Erlon, thank you for the review. See my comments inline. ","commit_id":"0c07e6e0983f1188302c892d3371e23842260cd2"}],"cinder/volume/drivers/netapp/dataontap/nfs_base.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"5755a21bf57bb759521207760c8b6b6027fe0c0b","unresolved":true,"context_lines":[{"line_number":941,"context_line":"                   % volume[\u0027id\u0027])"},{"line_number":942,"context_line":"            raise exception.ExtendVolumeError(msg)"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"        LOG.info(\u0027Extending volume %s.\u0027, volume[\u0027name\u0027])"},{"line_number":945,"context_line":""},{"line_number":946,"context_line":"        try:"},{"line_number":947,"context_line":"            path \u003d self.local_path(volume)"}],"source_content_type":"text/x-python","patch_set":4,"id":"796003e8_aee2922b","line":944,"range":{"start_line":944,"start_character":8,"end_line":944,"end_character":48},"updated":"2022-03-23 15:28:14.000000000","message":"Check if the local fs has space then return if attached. See my comments on https://review.opendev.org/c/openstack/cinder/+/739079","commit_id":"0c07e6e0983f1188302c892d3371e23842260cd2"},{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"6d98db9d44e82d5b7b0411ee829ca2e8aeeb823f","unresolved":true,"context_lines":[{"line_number":941,"context_line":"                   % volume[\u0027id\u0027])"},{"line_number":942,"context_line":"            raise exception.ExtendVolumeError(msg)"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"        LOG.info(\u0027Extending volume %s.\u0027, volume[\u0027name\u0027])"},{"line_number":945,"context_line":""},{"line_number":946,"context_line":"        try:"},{"line_number":947,"context_line":"            path \u003d self.local_path(volume)"}],"source_content_type":"text/x-python","patch_set":4,"id":"0ab29acf_70030613","line":944,"range":{"start_line":944,"start_character":8,"end_line":944,"end_character":48},"in_reply_to":"09ec6aa6_722f710d","updated":"2022-04-03 10:48:53.000000000","message":"I was thinking about something like that but doesn\u0027t need to be that complex. In that function, the NFS Generic driver does the checking for a series of situations using allocation rations, reserved percentage, oversubscription, etc. That is not necessary since the scheduler filter already does that (that code predates the scheduler checks so still there).\n\nBut now that I\u0027m rethinking, I realize that you not even need to check if the storage has space since the scheduler will have done that check and this operation will never fail due to space restrictions on the storage since the volume is just extended virtually.\n\nSo, it would be as simple as, \u0027if attached: LOG.info(\u0027...\u0027) return\u0027","commit_id":"0c07e6e0983f1188302c892d3371e23842260cd2"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"06958182e737726c7158f515cce8271d4c26b332","unresolved":true,"context_lines":[{"line_number":941,"context_line":"                   % volume[\u0027id\u0027])"},{"line_number":942,"context_line":"            raise exception.ExtendVolumeError(msg)"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"        LOG.info(\u0027Extending volume %s.\u0027, volume[\u0027name\u0027])"},{"line_number":945,"context_line":""},{"line_number":946,"context_line":"        try:"},{"line_number":947,"context_line":"            path \u003d self.local_path(volume)"}],"source_content_type":"text/x-python","patch_set":4,"id":"09ec6aa6_722f710d","line":944,"range":{"start_line":944,"start_character":8,"end_line":944,"end_character":48},"in_reply_to":"796003e8_aee2922b","updated":"2022-04-01 15:24:22.000000000","message":"Hi Erlon, only to understand better your suggestion. Do you mean something like the nfs driver does as shown below. Or I\u0027m missing something?\n\nhttps://github.com/openstack/cinder/blob/master/cinder/volume/drivers/nfs.py#L278","commit_id":"0c07e6e0983f1188302c892d3371e23842260cd2"}],"cinder/volume/drivers/netapp/dataontap/nfs_cmode.py":[{"author":{"_account_id":10058,"name":"Erlon R. Cruz","email":"erlon.rodrigues.cruz@canonical.com","username":"sombrafam"},"change_message_id":"5755a21bf57bb759521207760c8b6b6027fe0c0b","unresolved":true,"context_lines":[{"line_number":379,"context_line":"            pool[\u0027consistencygroup_support\u0027] \u003d True"},{"line_number":380,"context_line":"            pool[\u0027consistent_group_snapshot_enabled\u0027] \u003d True"},{"line_number":381,"context_line":"            pool[\u0027multiattach\u0027] \u003d True"},{"line_number":382,"context_line":"            pool[\u0027online_extend_support\u0027] \u003d True"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"            is_flexgroup \u003d ssc_vol_info.get(\u0027netapp_is_flexgroup\u0027) \u003d\u003d \u0027true\u0027"},{"line_number":385,"context_line":"            if is_flexgroup:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f7aae60_46312749","line":382,"range":{"start_line":382,"start_character":12,"end_line":382,"end_character":48},"updated":"2022-03-23 15:28:14.000000000","message":"So, this flag was added only with the netapp c_mode in mind as it didn\u0027t  supported online extend by the time while other volume driver supported. It was the only driver on Cinder not to support. Now, that all remotefs based drivers support, we should remove all related code including the capability fitering in the scheduler:\ncinder/scheduler/filters/capabilities_filter.py:40\n\nPlease grep for online_extend_support and you will have a better idea of what I mean.","commit_id":"0c07e6e0983f1188302c892d3371e23842260cd2"},{"author":{"_account_id":30998,"name":"Andre Luiz Beltrami Rocha","display_name":"Andre Beltrami","email":"debeltrami@gmail.com","username":"andrebeltrami"},"change_message_id":"06958182e737726c7158f515cce8271d4c26b332","unresolved":true,"context_lines":[{"line_number":379,"context_line":"            pool[\u0027consistencygroup_support\u0027] \u003d True"},{"line_number":380,"context_line":"            pool[\u0027consistent_group_snapshot_enabled\u0027] \u003d True"},{"line_number":381,"context_line":"            pool[\u0027multiattach\u0027] \u003d True"},{"line_number":382,"context_line":"            pool[\u0027online_extend_support\u0027] \u003d True"},{"line_number":383,"context_line":""},{"line_number":384,"context_line":"            is_flexgroup \u003d ssc_vol_info.get(\u0027netapp_is_flexgroup\u0027) \u003d\u003d \u0027true\u0027"},{"line_number":385,"context_line":"            if is_flexgroup:"}],"source_content_type":"text/x-python","patch_set":4,"id":"233a71bf_47b2135f","line":382,"range":{"start_line":382,"start_character":12,"end_line":382,"end_character":48},"in_reply_to":"7f7aae60_46312749","updated":"2022-04-01 15:24:22.000000000","message":"Hi Erlon, I got your point, but thinking that effort was already done and working, and also that a further driver/vendor couldn\u0027t support the online extend feature. In my opinion, would be better to doesn\u0027t change this. WDYT?","commit_id":"0c07e6e0983f1188302c892d3371e23842260cd2"}]}