)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"6943cc6da904adf0e07d96af893248edfd2cb556","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"096615a7_0bf33898","updated":"2021-12-17 14:23:00.000000000","message":"devstack does it in a slightly different way, maybe it\u0027s better to keep it consistent but it needs to be rechecked. Please see my comment in the bug.","commit_id":"215b9344e6df446e3fb3361d01a9634d8ca00380"},{"author":{"_account_id":32966,"name":"jiang guodao","email":"jguodao@vmware.com","username":"jguodao"},"change_message_id":"ae2bc0ae6b4d1544f821ca8d0e04462f201c3e55","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fec5029e_5bfa6597","updated":"2021-12-23 02:56:14.000000000","message":"vmware-recheck-patch","commit_id":"215b9344e6df446e3fb3361d01a9634d8ca00380"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"69ad22fad0b9bfaf4a150bf3f111056b44042361","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"66e038fd_e84e3f1b","updated":"2022-09-16 15:22:33.000000000","message":"Thanks for working on this!  Some questions inline.","commit_id":"b514ceed4bbb6a7eab25ef36655fc52bd472d442"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b0b1e7ded135a422592a0c1e3d7aafad40783fb1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"cfe2a61c_2501f87c","updated":"2023-01-20 15:39:05.000000000","message":"one correction to mention that this is for tgt target only","commit_id":"de2979ac14156884640fe5f81677dbfde5753bbe"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"26048bb1bab4aef46787860b2767693b17f445f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"f8c26f00_db838ca0","updated":"2023-03-03 06:29:34.000000000","message":"this looks ready, minor spelling correction inline.","commit_id":"3cd75c9fe1af458ccc3b8776a8ff9d3ba62e2e31"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"44dfab9cfe352ccfebb63c2f15dfe4d081d5d26b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":12,"id":"3f5ae0d5_5aa1a903","updated":"2023-03-03 11:29:10.000000000","message":"LGTM","commit_id":"dd8fa9c294ddbe94c214ffc4103bd5a68be28a22"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9e75df64138dfdd225b341bc9e8552acd7f0de39","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"4ea61c07_66c3c8fa","updated":"2023-03-03 16:45:51.000000000","message":"Good catch Gorka, forgot to see the rendering for the latest PS","commit_id":"6693c3707d0e2e0a8ff432dae089b5098945efee"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"81d49f6c0e8ed5abf75d88b8c7e17f8f464de248","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"583118bc_ea34680c","updated":"2023-03-03 15:26:57.000000000","message":"Output looks weird because the step is not withing the note box: https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_564/820994/13/check/openstack-tox-docs/564c17c/docs/install/cinder-storage-install-ubuntu.html","commit_id":"6693c3707d0e2e0a8ff432dae089b5098945efee"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"25c134e044aff36cae5d614b067d06196c44015a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":13,"id":"9f31a1bc_1334a38e","in_reply_to":"583118bc_ea34680c","updated":"2023-03-04 03:28:17.000000000","message":"see now it look point no 3.\nhttps://4e5ec2ca134a121acd29-76b8ff4c2a9c5ff54963c666a21f5048.ssl.cf2.rackcdn.com/820994/14/check/openstack-tox-docs/700b322/docs/install/cinder-storage-install-ubuntu.html","commit_id":"6693c3707d0e2e0a8ff432dae089b5098945efee"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"58eb54bffb923567c5c28e9a96f0afa7e7eb658e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"6f86c344_a42d532b","updated":"2023-03-08 14:07:47.000000000","message":"It still looks a bit awkward that the note is between the data and \"data:\", but I think it\u0027s good enough.","commit_id":"89de47b0d6354318f3775839c01dddac67d1961c"},{"author":{"_account_id":5689,"name":"Masayuki Igawa","email":"masayuki@igawa.io","username":"igawa"},"change_message_id":"d9f19b13388e89b99ac6706dd4a5f153694cc9d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"ed8f76be_4191e3fe","updated":"2023-03-09 05:29:15.000000000","message":"lgtm. I can see the description in both pdf[0] and html[1].\n\nBTW, just my curiosity, don\u0027t we need this note for RHEL/CentOS, too? though it\u0027s out of scope for this patch, of course.\n\n[0] https://32765642782fd47cbefb-da3f8077deb18415bd477eebc664cf39.ssl.cf5.rackcdn.com/820994/15/check/openstack-tox-docs/f641ea0/pdf/doc-cinder.pdf\n[1] https://32765642782fd47cbefb-da3f8077deb18415bd477eebc664cf39.ssl.cf5.rackcdn.com/820994/15/check/openstack-tox-docs/f641ea0/docs/install/cinder-storage-install-ubuntu.html#install-and-configure-components","commit_id":"89de47b0d6354318f3775839c01dddac67d1961c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"90b9fc2c542424e64b283f1a2bf89d98a0ec8054","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"f2c83736_44c53dac","updated":"2023-03-09 07:59:49.000000000","message":"rendering looks good now. thanks!","commit_id":"89de47b0d6354318f3775839c01dddac67d1961c"}],"doc/source/install/cinder-storage-install-ubuntu.rst":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9b57e9e6c175c89b1f884b5e03e5696931a0347b","unresolved":true,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"   .. code-block:: shell"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"      include /etc/tgt/stack.d/*"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"   .. end"},{"line_number":260,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"80cca1b7_de948f37","line":257,"updated":"2022-07-15 14:55:55.000000000","message":"? I don\u0027t know anything about tgt, but is this solution wrong or is the referenced one wrong [1]?  Because the other one has a space between the last / and the *\n\n\n[1]: https://docs.openstack.org/cinder/xena/admin/ts-cinder-config.html#id2","commit_id":"d8dc98dc80f2b0c65b91aa449a678eac9e628c8a"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"e46a134da4d5948b946480b25ac518e556851058","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"   .. code-block:: shell"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"      include /etc/tgt/stack.d/*"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"   .. end"},{"line_number":260,"context_line":""}],"source_content_type":"text/x-rst","patch_set":3,"id":"69a948ec_a214c5c2","line":257,"in_reply_to":"80cca1b7_de948f37","updated":"2022-07-20 04:13:18.000000000","message":"Done","commit_id":"d8dc98dc80f2b0c65b91aa449a678eac9e628c8a"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"69ad22fad0b9bfaf4a150bf3f111056b44042361","unresolved":true,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"   .. code-block:: shell"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"      include /etc/tgt/stack.d/ *"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"   .. end"},{"line_number":260,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"4bfa4e04_7ccca3ca","line":257,"range":{"start_line":257,"start_character":6,"end_line":257,"end_character":33},"updated":"2022-09-16 15:22:33.000000000","message":"Two things:\n\n1. I don\u0027t think the space between \u0027/\u0027 and \u0027*\u0027 is correct.  (The only place I\u0027ve seen it is that doc that Gorka pointed out, where he was asking which is correct, space or no space?).\n\n2. It looks like you\u0027re getting this from comment #4 in the bug report, but that also includes the step of creating the /etc/tgt/stack.d as a symlink of /var/lib/cinder/volumes (which I don\u0027t think is done earlier in this document?).  Also, since what\u0027s added to the /etc/tgt/targets.conf file in the bug report is \u0027include /etc/tgt/stack.d/*\u0027, i don\u0027t see why not just add \u0027include /var/lib/cinder/volumes/*\u0027 directly and don\u0027t bother with the symlink.\n\nBut I\u0027m really not familiar with this, so don\u0027t just do what I say here.  Looks like this requires a bit more research/experimentation.","commit_id":"b514ceed4bbb6a7eab25ef36655fc52bd472d442"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"2b1386b082f29995ae5f1c827106e3ec9ed54de0","unresolved":true,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"   .. code-block:: shell"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"      include /etc/tgt/stack.d/ *"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"   .. end"},{"line_number":260,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"91a0345e_5fdbed7d","line":257,"range":{"start_line":257,"start_character":6,"end_line":257,"end_character":33},"in_reply_to":"4bfa4e04_7ccca3ca","updated":"2022-10-10 11:37:07.000000000","message":"ok i\u0027ll reinstall storage node with your suggestion and we\u0027ll see","commit_id":"b514ceed4bbb6a7eab25ef36655fc52bd472d442"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"07f1bb2b80946ad3184ae715fc922c7216505589","unresolved":false,"context_lines":[{"line_number":254,"context_line":""},{"line_number":255,"context_line":"   .. code-block:: shell"},{"line_number":256,"context_line":""},{"line_number":257,"context_line":"      include /etc/tgt/stack.d/ *"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"   .. end"},{"line_number":260,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"949ef69c_85111526","line":257,"range":{"start_line":257,"start_character":6,"end_line":257,"end_character":33},"in_reply_to":"91a0345e_5fdbed7d","updated":"2023-01-12 10:02:00.000000000","message":"Done","commit_id":"b514ceed4bbb6a7eab25ef36655fc52bd472d442"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b0b1e7ded135a422592a0c1e3d7aafad40783fb1","unresolved":true,"context_lines":[{"line_number":249,"context_line":"     .. end"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"#. Create the ``/etc/tgt/conf.d/cinder.conf`` file"},{"line_number":253,"context_line":"   with the following data:"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"   .. code-block:: shell"},{"line_number":256,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"7e26b8b9_ddfbdbf0","line":253,"range":{"start_line":252,"start_character":3,"end_line":253,"end_character":27},"updated":"2023-01-20 15:39:05.000000000","message":"this only needs to be configured if we\u0027re using the tgt target\nit is default iscsi target[1] in cinder but if someone configures a different target like using nvme or lio for iscsi, then this is optional\n\nhttps://github.com/openstack/cinder/blob/bc9910f0409c60d82788b9ad248327b377439c3a/cinder/volume/driver.py#L88","commit_id":"de2979ac14156884640fe5f81677dbfde5753bbe"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"26048bb1bab4aef46787860b2767693b17f445f9","unresolved":false,"context_lines":[{"line_number":249,"context_line":"     .. end"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"#. Create the ``/etc/tgt/conf.d/cinder.conf`` file"},{"line_number":253,"context_line":"   with the following data:"},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"   .. code-block:: shell"},{"line_number":256,"context_line":""}],"source_content_type":"text/x-rst","patch_set":8,"id":"72b36a2c_b615aa88","line":253,"range":{"start_line":252,"start_character":3,"end_line":253,"end_character":27},"in_reply_to":"7e26b8b9_ddfbdbf0","updated":"2023-03-03 06:29:34.000000000","message":"Done","commit_id":"de2979ac14156884640fe5f81677dbfde5753bbe"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"26048bb1bab4aef46787860b2767693b17f445f9","unresolved":true,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":".. note::"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"   Perform these steps when using tgt targets only."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"#. Create the ``/etc/tgt/conf.d/cinder.conf`` file"},{"line_number":257,"context_line":"   with the following data:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"8ec6ad5d_89aa23ea","line":254,"range":{"start_line":254,"start_character":38,"end_line":254,"end_character":45},"updated":"2023-03-03 06:29:34.000000000","message":"target","commit_id":"3cd75c9fe1af458ccc3b8776a8ff9d3ba62e2e31"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"26048bb1bab4aef46787860b2767693b17f445f9","unresolved":true,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":".. note::"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"   Perform these steps when using tgt targets only."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"#. Create the ``/etc/tgt/conf.d/cinder.conf`` file"},{"line_number":257,"context_line":"   with the following data:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"9eda38aa_27d34470","line":254,"range":{"start_line":254,"start_character":11,"end_line":254,"end_character":16},"updated":"2023-03-03 06:29:34.000000000","message":"this","commit_id":"3cd75c9fe1af458ccc3b8776a8ff9d3ba62e2e31"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"6da2d0e19ee65a28a331f4269a8eaa53e1c34357","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":".. note::"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"   Perform these steps when using tgt targets only."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"#. Create the ``/etc/tgt/conf.d/cinder.conf`` file"},{"line_number":257,"context_line":"   with the following data:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"6d87f60a_6665c473","line":254,"range":{"start_line":254,"start_character":38,"end_line":254,"end_character":45},"in_reply_to":"8ec6ad5d_89aa23ea","updated":"2023-03-03 08:29:55.000000000","message":"Done","commit_id":"3cd75c9fe1af458ccc3b8776a8ff9d3ba62e2e31"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"6da2d0e19ee65a28a331f4269a8eaa53e1c34357","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":".. note::"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"   Perform these steps when using tgt targets only."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"#. Create the ``/etc/tgt/conf.d/cinder.conf`` file"},{"line_number":257,"context_line":"   with the following data:"}],"source_content_type":"text/x-rst","patch_set":10,"id":"3bbe6157_8c2c4c0f","line":254,"range":{"start_line":254,"start_character":11,"end_line":254,"end_character":16},"in_reply_to":"9eda38aa_27d34470","updated":"2023-03-03 08:29:55.000000000","message":"Done","commit_id":"3cd75c9fe1af458ccc3b8776a8ff9d3ba62e2e31"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"776480746d09f78c3e824fb716d067621bea401f","unresolved":true,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":".. note::"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"   Perform this steps when using tgt target only."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"#. Create the ``/etc/tgt/conf.d/cinder.conf`` file"},{"line_number":257,"context_line":"   with the following data:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"1878ecbe_168a9ecc","line":254,"range":{"start_line":254,"start_character":44,"end_line":254,"end_character":48},"updated":"2023-03-03 11:28:16.000000000","message":"nit: not needed","commit_id":"3f8282fe5db0211de59990a9362e0553e3aa9a63"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"776480746d09f78c3e824fb716d067621bea401f","unresolved":true,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":".. note::"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"   Perform this steps when using tgt target only."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"#. Create the ``/etc/tgt/conf.d/cinder.conf`` file"},{"line_number":257,"context_line":"   with the following data:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"75293784_efcd53ec","line":254,"range":{"start_line":254,"start_character":16,"end_line":254,"end_character":21},"updated":"2023-03-03 11:28:16.000000000","message":"nit: step","commit_id":"3f8282fe5db0211de59990a9362e0553e3aa9a63"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"44dfab9cfe352ccfebb63c2f15dfe4d081d5d26b","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":".. note::"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"   Perform this steps when using tgt target only."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"#. Create the ``/etc/tgt/conf.d/cinder.conf`` file"},{"line_number":257,"context_line":"   with the following data:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"135e08c0_2ac15a65","line":254,"range":{"start_line":254,"start_character":44,"end_line":254,"end_character":48},"in_reply_to":"1878ecbe_168a9ecc","updated":"2023-03-03 11:29:10.000000000","message":"Done","commit_id":"3f8282fe5db0211de59990a9362e0553e3aa9a63"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"44dfab9cfe352ccfebb63c2f15dfe4d081d5d26b","unresolved":false,"context_lines":[{"line_number":251,"context_line":""},{"line_number":252,"context_line":".. note::"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"   Perform this steps when using tgt target only."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"#. Create the ``/etc/tgt/conf.d/cinder.conf`` file"},{"line_number":257,"context_line":"   with the following data:"}],"source_content_type":"text/x-rst","patch_set":11,"id":"9a2f1595_3a8e13ac","line":254,"range":{"start_line":254,"start_character":16,"end_line":254,"end_character":21},"in_reply_to":"75293784_efcd53ec","updated":"2023-03-03 11:29:10.000000000","message":"Done","commit_id":"3f8282fe5db0211de59990a9362e0553e3aa9a63"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9e75df64138dfdd225b341bc9e8552acd7f0de39","unresolved":true,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"   Perform this step when using tgt target."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"#. Create the ``/etc/tgt/conf.d/cinder.conf`` file"},{"line_number":257,"context_line":"   with the following data:"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"   .. code-block:: shell"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"      include /var/lib/cinder/volumes/*"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"   .. end"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"Finalize installation"},{"line_number":267,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"e1b3ed95_07cef7bc","line":264,"range":{"start_line":256,"start_character":0,"end_line":264,"end_character":0},"updated":"2023-03-03 16:45:51.000000000","message":"we need to move this before the note so it becomes point 3","commit_id":"6693c3707d0e2e0a8ff432dae089b5098945efee"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"419db506aebd1359c8ac91ab310a98b008129ac2","unresolved":false,"context_lines":[{"line_number":253,"context_line":""},{"line_number":254,"context_line":"   Perform this step when using tgt target."},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"#. Create the ``/etc/tgt/conf.d/cinder.conf`` file"},{"line_number":257,"context_line":"   with the following data:"},{"line_number":258,"context_line":""},{"line_number":259,"context_line":"   .. code-block:: shell"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"      include /var/lib/cinder/volumes/*"},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"   .. end"},{"line_number":264,"context_line":""},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"Finalize installation"},{"line_number":267,"context_line":"---------------------"}],"source_content_type":"text/x-rst","patch_set":13,"id":"07ef3a4a_2d7c545d","line":264,"range":{"start_line":256,"start_character":0,"end_line":264,"end_character":0},"in_reply_to":"e1b3ed95_07cef7bc","updated":"2023-03-04 03:24:48.000000000","message":"Done","commit_id":"6693c3707d0e2e0a8ff432dae089b5098945efee"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"27d00a67d373d10df6eda5d2875a614e0902c3fc","unresolved":true,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"     .. end"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"   .. note::"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"      Perform this step when using tgt target."},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"#. Create the ``/etc/tgt/conf.d/cinder.conf`` file"},{"line_number":256,"context_line":"   with the following data:"}],"source_content_type":"text/x-rst","patch_set":14,"id":"35083f87_97c7d828","line":253,"range":{"start_line":251,"start_character":0,"end_line":253,"end_character":46},"updated":"2023-03-06 09:16:11.000000000","message":"would\u0027ve been better to have the note inside the point","commit_id":"a704c57925a76506e6dcd98a93b067253a157413"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e04fb8a7700844bf9df3704c321ea7962585eab6","unresolved":true,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"     .. end"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"   .. note::"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"      Perform this step when using tgt target."},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"#. Create the ``/etc/tgt/conf.d/cinder.conf`` file"},{"line_number":256,"context_line":"   with the following data:"}],"source_content_type":"text/x-rst","patch_set":14,"id":"4dfb114a_96c87608","line":253,"range":{"start_line":251,"start_character":0,"end_line":253,"end_character":46},"in_reply_to":"35083f87_97c7d828","updated":"2023-03-06 13:57:23.000000000","message":"Yes this still looks weird.\nAs I see it we have 2 ways to make this look good:\n- The code block is in the note\n- There is no note and the Step description includes the text about the step only being needed for tgt","commit_id":"a704c57925a76506e6dcd98a93b067253a157413"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"9dcefef1aee861f824ac44ce829977d3a6c9ceaf","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"     .. end"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"   .. note::"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"      Perform this step when using tgt target."},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"#. Create the ``/etc/tgt/conf.d/cinder.conf`` file"},{"line_number":256,"context_line":"   with the following data:"}],"source_content_type":"text/x-rst","patch_set":14,"id":"7740af7f_95c882d3","line":253,"range":{"start_line":251,"start_character":0,"end_line":253,"end_character":46},"in_reply_to":"4dfb114a_96c87608","updated":"2023-03-08 02:56:22.000000000","message":"Done","commit_id":"a704c57925a76506e6dcd98a93b067253a157413"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"9dcefef1aee861f824ac44ce829977d3a6c9ceaf","unresolved":false,"context_lines":[{"line_number":248,"context_line":""},{"line_number":249,"context_line":"     .. end"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"   .. note::"},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"      Perform this step when using tgt target."},{"line_number":254,"context_line":""},{"line_number":255,"context_line":"#. Create the ``/etc/tgt/conf.d/cinder.conf`` file"},{"line_number":256,"context_line":"   with the following data:"}],"source_content_type":"text/x-rst","patch_set":14,"id":"a434248f_e2acc3d6","line":253,"range":{"start_line":251,"start_character":0,"end_line":253,"end_character":46},"in_reply_to":"4dfb114a_96c87608","updated":"2023-03-08 02:56:22.000000000","message":"Done","commit_id":"a704c57925a76506e6dcd98a93b067253a157413"}]}