)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b898dd9122525813c9e2590d6a2269dda4c657df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d41096b0_84ef7666","updated":"2022-02-06 17:39:03.000000000","message":"This looks good!  Suggestions inline for revising the release note, otherwise, just nits.","commit_id":"52d1071155650a853fbfaf0bac1c62d1e93072e3"},{"author":{"_account_id":28801,"name":"Cisco Cinder CI","email":"cisco-cinder-ci@cisco.com","username":"cisco-cinder-ci"},"change_message_id":"21126d8dfd948e2f172561e4462a1c886852edd2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"bafabf3e_3ca07650","updated":"2021-12-17 05:27:55.000000000","message":"cisco-cinder-ci","commit_id":"52d1071155650a853fbfaf0bac1c62d1e93072e3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1545c1e4037dc471a8122c855b26967fce1ac4b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"fd80d257_576e7392","updated":"2022-02-03 15:47:45.000000000","message":"recheck","commit_id":"52d1071155650a853fbfaf0bac1c62d1e93072e3"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"bcee83ed5de4dbf4e2c96f617126ad3f61826cbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"a1eaac58_bafa304e","updated":"2022-02-16 18:19:02.000000000","message":"I agree with the use of \u0027match\u0027 but waiting to see more comments. ","commit_id":"31b34e91e0fe1fdc813a09b3c46a880b8d0e571f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"10b614ed0a8d7e7bb6f974ca739e14d30ca158ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"80092071_3faa1522","updated":"2022-02-15 23:19:52.000000000","message":"Looks great, Alan!  One minor concern noted inline, but otherwise this LGTM.","commit_id":"31b34e91e0fe1fdc813a09b3c46a880b8d0e571f"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"e03d6fea263c441ca331c06dc396a977b7b70207","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"cf311c4e_a73c6734","updated":"2022-02-23 14:21:19.000000000","message":"Thanks for working on this","commit_id":"31b34e91e0fe1fdc813a09b3c46a880b8d0e571f"}],"cinder/api/microversions.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2bd34a910706d7ad16427fe218c5d8b3ca69433a","unresolved":true,"context_lines":[{"line_number":171,"context_line":""},{"line_number":172,"context_line":"SNAPSHOT_IN_USE \u003d \u00273.66\u0027"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"def get_mv_header(version):"},{"line_number":176,"context_line":"    \"\"\"Gets a formatted HTTP microversion header."},{"line_number":177,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"4fd2d419_ce652e13","line":174,"updated":"2022-02-23 17:09:40.000000000","message":"This is missing an entry here for MV 3.67","commit_id":"31b34e91e0fe1fdc813a09b3c46a880b8d0e571f"}],"cinder/api/openstack/__init__.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"10b614ed0a8d7e7bb6f974ca739e14d30ca158ea","unresolved":true,"context_lines":[{"line_number":32,"context_line":"               default\u003dr\"[0-9a-f\\-]+\","},{"line_number":33,"context_line":"               help\u003dr\u0027The validation regex for project_ids used in urls. \u0027"},{"line_number":34,"context_line":"                    r\u0027This defaults to [0-9a-f\\\\-]+ if not set, \u0027"},{"line_number":35,"context_line":"                    r\u0027which matches normal uuids created by keystone.\u0027),"},{"line_number":36,"context_line":"]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":2,"id":"9c4413f1_9735c8f1","line":35,"range":{"start_line":35,"start_character":22,"end_line":35,"end_character":68},"updated":"2022-02-15 23:19:52.000000000","message":"It also matches a lot more (e.g., a string representation of any integer, any word that only contains a through f, \u0027------\u0027).  Luckily, none of our resource names are in [a-f]+\n\nLet\u0027s see if anyone else has an issue here.  I think \"match\" is a bit strong, because colloquially it implies all-and-only uuids, whereas this will allow more than that.  But we also don\u0027t want to make this help text overly complicated.","commit_id":"31b34e91e0fe1fdc813a09b3c46a880b8d0e571f"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"81d18480ea997e0ce3129bc442cda63ac21328d3","unresolved":true,"context_lines":[{"line_number":32,"context_line":"               default\u003dr\"[0-9a-f\\-]+\","},{"line_number":33,"context_line":"               help\u003dr\u0027The validation regex for project_ids used in urls. \u0027"},{"line_number":34,"context_line":"                    r\u0027This defaults to [0-9a-f\\\\-]+ if not set, \u0027"},{"line_number":35,"context_line":"                    r\u0027which matches normal uuids created by keystone.\u0027),"},{"line_number":36,"context_line":"]"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":2,"id":"06f526f3_686faa22","line":35,"range":{"start_line":35,"start_character":22,"end_line":35,"end_character":68},"in_reply_to":"9c4413f1_9735c8f1","updated":"2022-02-16 19:13:05.000000000","message":"I think folks know I \"borrowed\" the code (including this text) from manila, and confess that I didn\u0027t review this text in case I wanted to reword it.\n\nThat said, I don\u0027t agree the text implies the \"-and-only\" portion. It says that it matches uuids created by keystone, which it does. I would be more concerned if the text stated that it _exclusively_ matches a uuid, because that would be incorrect.","commit_id":"31b34e91e0fe1fdc813a09b3c46a880b8d0e571f"}],"cinder/api/openstack/rest_api_version_history.rst":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b898dd9122525813c9e2590d6a2269dda4c657df","unresolved":true,"context_lines":[{"line_number":509,"context_line":"3.67"},{"line_number":510,"context_line":"----"},{"line_number":511,"context_line":"API URLs no longer need a \"project_id\" argument in them. For example, the API"},{"line_number":512,"context_line":"route: https://$(controller)s/volume/v3/$(project_id)s/volumes is equivalent"},{"line_number":513,"context_line":"to https://$(controller)s/volume/v3/volumes. When interacting with the cinder"},{"line_number":514,"context_line":"service as system or domain scoped users, project_id should not be specified"},{"line_number":515,"context_line":"in the API path."}],"source_content_type":"text/x-rst","patch_set":1,"id":"acecc188_15863c20","line":512,"range":{"start_line":512,"start_character":7,"end_line":512,"end_character":62},"updated":"2022-02-06 17:39:03.000000000","message":"nit: could put this in double-backticks to make it monospace font.","commit_id":"52d1071155650a853fbfaf0bac1c62d1e93072e3"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"10ce3059e8d6c3e07caf9536ab2414e440eb38c0","unresolved":false,"context_lines":[{"line_number":509,"context_line":"3.67"},{"line_number":510,"context_line":"----"},{"line_number":511,"context_line":"API URLs no longer need a \"project_id\" argument in them. For example, the API"},{"line_number":512,"context_line":"route: https://$(controller)s/volume/v3/$(project_id)s/volumes is equivalent"},{"line_number":513,"context_line":"to https://$(controller)s/volume/v3/volumes. When interacting with the cinder"},{"line_number":514,"context_line":"service as system or domain scoped users, project_id should not be specified"},{"line_number":515,"context_line":"in the API path."}],"source_content_type":"text/x-rst","patch_set":1,"id":"ee3d1dae_3821a32f","line":512,"range":{"start_line":512,"start_character":7,"end_line":512,"end_character":62},"in_reply_to":"acecc188_15863c20","updated":"2022-02-08 16:32:55.000000000","message":"Done","commit_id":"52d1071155650a853fbfaf0bac1c62d1e93072e3"}],"cinder/tests/unit/api/v2/test_volumes.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b898dd9122525813c9e2590d6a2269dda4c657df","unresolved":true,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        vol \u003d self._vol_in_request_body()"},{"line_number":95,"context_line":"        body \u003d {\"volume\": vol}"},{"line_number":96,"context_line":"        # ASB req \u003d fakes.HTTPRequest.blank(\u0027/v3/%s/volumes\u0027 % fake.PROJECT_ID)"},{"line_number":97,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v3/volumes\u0027)"},{"line_number":98,"context_line":"        res_dict \u003d self.controller.create(req, body\u003dbody)"},{"line_number":99,"context_line":"        ex \u003d self._expected_vol_from_controller()"}],"source_content_type":"text/x-python","patch_set":1,"id":"63a83bc7_8c13b252","line":96,"range":{"start_line":96,"start_character":8,"end_line":96,"end_character":79},"updated":"2022-02-06 17:39:03.000000000","message":"did you mean to leave this in?","commit_id":"52d1071155650a853fbfaf0bac1c62d1e93072e3"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"10ce3059e8d6c3e07caf9536ab2414e440eb38c0","unresolved":false,"context_lines":[{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        vol \u003d self._vol_in_request_body()"},{"line_number":95,"context_line":"        body \u003d {\"volume\": vol}"},{"line_number":96,"context_line":"        # ASB req \u003d fakes.HTTPRequest.blank(\u0027/v3/%s/volumes\u0027 % fake.PROJECT_ID)"},{"line_number":97,"context_line":"        req \u003d fakes.HTTPRequest.blank(\u0027/v3/volumes\u0027)"},{"line_number":98,"context_line":"        res_dict \u003d self.controller.create(req, body\u003dbody)"},{"line_number":99,"context_line":"        ex \u003d self._expected_vol_from_controller()"}],"source_content_type":"text/x-python","patch_set":1,"id":"dbade4c1_275442ba","line":96,"range":{"start_line":96,"start_character":8,"end_line":96,"end_character":79},"in_reply_to":"63a83bc7_8c13b252","updated":"2022-02-08 16:32:55.000000000","message":"Whoops, no.","commit_id":"52d1071155650a853fbfaf0bac1c62d1e93072e3"}],"releasenotes/notes/project-id-optional-in-urls-db97e2c447167853.yaml":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b898dd9122525813c9e2590d6a2269dda4c657df","unresolved":true,"context_lines":[{"line_number":4,"context_line":"    Inclusion of a project_id in API URLs is now optional. The `Block Storage"},{"line_number":5,"context_line":"    API V3 \u003chttps://docs.openstack.org/api-ref/block-storage/v3\u003e`_ reference"},{"line_number":6,"context_line":"    guide continues to show URLs with a project_id because the legacy behavior"},{"line_number":7,"context_line":"    continues to be supported."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Upgrades are not affected by the new functionality whereby a project_id"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"87a6f389_05627410","line":7,"updated":"2022-02-06 17:39:03.000000000","message":"You should say something here about new mv 3.67 and how it\u0027s just being used as a way for a client to determine whether the API server supports no-project-id-in-the-URL or not.","commit_id":"52d1071155650a853fbfaf0bac1c62d1e93072e3"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"10ce3059e8d6c3e07caf9536ab2414e440eb38c0","unresolved":false,"context_lines":[{"line_number":4,"context_line":"    Inclusion of a project_id in API URLs is now optional. The `Block Storage"},{"line_number":5,"context_line":"    API V3 \u003chttps://docs.openstack.org/api-ref/block-storage/v3\u003e`_ reference"},{"line_number":6,"context_line":"    guide continues to show URLs with a project_id because the legacy behavior"},{"line_number":7,"context_line":"    continues to be supported."},{"line_number":8,"context_line":"upgrade:"},{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Upgrades are not affected by the new functionality whereby a project_id"}],"source_content_type":"text/x-yaml","patch_set":1,"id":"cf0d292d_119d49b0","line":7,"in_reply_to":"87a6f389_05627410","updated":"2022-02-08 16:32:55.000000000","message":"Done. It basically repeats the note added to the API documentation guide.","commit_id":"52d1071155650a853fbfaf0bac1c62d1e93072e3"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b898dd9122525813c9e2590d6a2269dda4c657df","unresolved":true,"context_lines":[{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Upgrades are not affected by the new functionality whereby a project_id"},{"line_number":11,"context_line":"    is no longer required in API URLs. The legacy behavior in which a"},{"line_number":12,"context_line":"    project_id is included in the URL continues to be supported."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"b80bfb00_55f7f600","line":12,"updated":"2022-02-06 17:39:03.000000000","message":"I think you should mention the new config option \u0027project_id_regex\u0027 here.  Probably not many people will need to use it, but worth flagging for those who do.","commit_id":"52d1071155650a853fbfaf0bac1c62d1e93072e3"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"10ce3059e8d6c3e07caf9536ab2414e440eb38c0","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    Upgrades are not affected by the new functionality whereby a project_id"},{"line_number":11,"context_line":"    is no longer required in API URLs. The legacy behavior in which a"},{"line_number":12,"context_line":"    project_id is included in the URL continues to be supported."}],"source_content_type":"text/x-yaml","patch_set":1,"id":"0852ba2a_b96aa8b4","line":12,"in_reply_to":"b80bfb00_55f7f600","updated":"2022-02-08 16:32:55.000000000","message":"Done","commit_id":"52d1071155650a853fbfaf0bac1c62d1e93072e3"}]}