)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"14c49ac5547ce714c72aa497659343190d53efe2","unresolved":true,"context_lines":[{"line_number":16,"context_line":"``cinder-manage volume update_service``"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The service_uuid of volumes associated with old service_uuid"},{"line_number":19,"context_line":"also gets updated when we create a new service."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I0b13c6351733b8163bcf6e73c939c375493dcba5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"57a1adae_65761329","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":32},"updated":"2024-08-19 12:56:55.000000000","message":"nit: `cinder creates`","commit_id":"fb2c6dcaa84cd5e03657a68967ba1eb5fb0c0c6f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ff1b30a689a2b7efb0cc8f36cbfac5c11fef2018","unresolved":false,"context_lines":[{"line_number":16,"context_line":"``cinder-manage volume update_service``"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"The service_uuid of volumes associated with old service_uuid"},{"line_number":19,"context_line":"also gets updated when we create a new service."},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I0b13c6351733b8163bcf6e73c939c375493dcba5"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"90484980_4073673c","line":19,"range":{"start_line":19,"start_character":23,"end_line":19,"end_character":32},"in_reply_to":"57a1adae_65761329","updated":"2024-08-21 11:25:09.000000000","message":"Done","commit_id":"fb2c6dcaa84cd5e03657a68967ba1eb5fb0c0c6f"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"bd1eec048452f62301ce00d1c6f6a3fecac8e61a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"68bb846d_d24ec478","updated":"2021-12-30 06:29:21.000000000","message":"recheck","commit_id":"face126698f44c97335bb5ceee6b924e4048a198"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ef1f9f421b95475b8c20b468b4d4ba1b0f437d4a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a96dc15c_8b81d399","updated":"2021-12-29 04:48:20.000000000","message":"recheck","commit_id":"face126698f44c97335bb5ceee6b924e4048a198"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"e8151af499f9926347d067a4cbf7b7a2e4b2ad7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bb19472a_9c9ec145","updated":"2021-12-31 04:32:01.000000000","message":"run-DellEMC VNX CI","commit_id":"fb47b4f229e959fc2baa76adfb448eb891cd6696"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d97fabf110e9cd149fb0937c74f5881110318f28","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e2722a55_a9e4ded1","updated":"2024-03-06 11:48:52.000000000","message":"I believe this is not the right approach.\n\nThis is something that:\n- Should be done automagically when recreating the service_uuid\n- Have the equivalent cinder-manage command that does this automagically\n\nWhen I talk about automagically I mean this can be done without parameters:\n\n```\nUPDATE cinder.volumes vol\nJOIN cinder.services serv ON\n  NOT serv.deleted AND\n  SUBSTRING_INDEX(vol.host,\u0027#\u0027,1) \u003d serv.host\nSET vol.service_uuid \u003d serv.uuid\nWHERE NOT vol.deleted AND vol.service_uuid !\u003d serv.uuid;\n```\n\nWhen I talk about doint it when recreating the service_uuid I mean around here: https://github.com/openstack/cinder/blob/b5d08a53abad849dbaf09a16323e5f72f5913d7c/cinder/service.py#L348","commit_id":"1ef6efd7f5a10c8539d5c55a4ab6d906a5cc0703"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"31600078396a82ce847db041b27622cc833e95f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"2c72aac4_c00af7cd","in_reply_to":"e2722a55_a9e4ded1","updated":"2024-08-08 20:53:09.000000000","message":"Done","commit_id":"1ef6efd7f5a10c8539d5c55a4ab6d906a5cc0703"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"31600078396a82ce847db041b27622cc833e95f1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"794edd8b_aa2da6e7","updated":"2024-08-08 20:53:09.000000000","message":"Thanks Gorka!","commit_id":"b897a30f8c80e1a7e1f7b8ffc8c26f9cbdc30dda"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"5a92943838711d4b387c619967f5ef0b8cd82430","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"32a9588e_26e886eb","updated":"2024-08-09 05:40:07.000000000","message":"recheck grenade failed on unrelated test\n\ntest_role_create_update_show_list\n\n2024-08-08 21:20:27.085 |     testtools.matchers._impl.MismatchError: \u0027tempest-NewRole-1435751679\u0027 !\u003d \u0027tempest-Role-108175141\u0027","commit_id":"b897a30f8c80e1a7e1f7b8ffc8c26f9cbdc30dda"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"14c49ac5547ce714c72aa497659343190d53efe2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"382b4e29_aaebb9bf","updated":"2024-08-19 12:56:55.000000000","message":"-1: Please update `doc/source/cli/cinder-manage.rst` with the new command.","commit_id":"fb2c6dcaa84cd5e03657a68967ba1eb5fb0c0c6f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"827ef84503313a4d291076fd0fa1e90b733497c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"bf4ab613_c4ea6e84","updated":"2024-08-19 07:26:15.000000000","message":"recheck the failures should be fixed now as the dependent patch is merged","commit_id":"fb2c6dcaa84cd5e03657a68967ba1eb5fb0c0c6f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"158da53c4c429013504f5bbb9b7bc8e989743096","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"250ac421_6bdcabd8","updated":"2024-08-16 14:41:40.000000000","message":"tempest.api.image.v2.test_images_formats.ImagesFormatTest failed which should be fixed by https://review.opendev.org/c/openstack/cinder/+/926287","commit_id":"fb2c6dcaa84cd5e03657a68967ba1eb5fb0c0c6f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ff1b30a689a2b7efb0cc8f36cbfac5c11fef2018","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3a6e3e40_887dc845","in_reply_to":"382b4e29_aaebb9bf","updated":"2024-08-21 11:25:09.000000000","message":"Done","commit_id":"fb2c6dcaa84cd5e03657a68967ba1eb5fb0c0c6f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7a1c4246e432c278380f692277e19e3e871f1089","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"8eca85c4_2cfe71d6","updated":"2024-08-29 17:20:45.000000000","message":"Mostly looks good, but some suggestions inline for making the release note and docs a bit more clear.","commit_id":"9465669d937b767681259112868f7b8ef9f76a81"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ff1b30a689a2b7efb0cc8f36cbfac5c11fef2018","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"815a0f0d_b8c51dd6","updated":"2024-08-21 11:25:09.000000000","message":"Thanks Gorka!","commit_id":"9465669d937b767681259112868f7b8ef9f76a81"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2d295db0be40c79451fbe78fdbc10afa533cafc2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4a508028_09cb1906","updated":"2024-09-02 05:17:50.000000000","message":"Thanks Brian for the great recommendations on docs and test.","commit_id":"296e866f871fbea45794ddb7ee6434bf81ea084c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5e41a9e267e73b7715453215dbc0f801d52592aa","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"8a221ad2_69414cdd","updated":"2024-09-17 12:50:37.000000000","message":"Revisions LGTM.","commit_id":"edeac132a19dc05a4108c630ebdfd02de9fd92ef"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"7f7f7f2d67be81125c1e5b04f991478dfaaddb3b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"e4dee339_7d5976e3","updated":"2024-09-03 14:08:11.000000000","message":"The pep8 failure was unrelated but I\u0027ve fixed it here[1] and rebased on top of it\n\n2024-09-03 04:55:29.286355 | ubuntu-jammy | /home/zuul/src/opendev.org/openstack/cinder/doc/source/configuration/block-storage/drivers/dell-emc-vnx-driver.rst:1083: D001 Line too long\n2024-09-03 04:55:29.286379 | ubuntu-jammy | /home/zuul/src/opendev.org/openstack/cinder/doc/source/configuration/block-storage/drivers/hpe-3par-driver.rst:348: D001 Line too long\n\n[1] https://review.opendev.org/c/openstack/cinder/+/927825","commit_id":"edeac132a19dc05a4108c630ebdfd02de9fd92ef"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"d8f8fbe761eb46d960a94a20bcb5842ea1182472","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"bfb10e85_9d14c78d","updated":"2024-09-05 05:14:01.000000000","message":"recheck nfs job failed with unrelated test failure\n\ntempest.api.compute.servers.test_create_server.ServersV294TestFqdnHostnames","commit_id":"edeac132a19dc05a4108c630ebdfd02de9fd92ef"}],"cinder/cmd/manage.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"b70b215abd2e49db82b00447fcba548afcac5a1c","unresolved":true,"context_lines":[{"line_number":587,"context_line":"    @args(\u0027--currentservice\u0027, required\u003dTrue, help\u003d\u0027Existing service name\u0027)"},{"line_number":588,"context_line":"    @args(\u0027--newservice\u0027, required\u003dTrue, help\u003d\u0027New service name\u0027)"},{"line_number":589,"context_line":"    def update_service(self, currentservice, newservice):"},{"line_number":590,"context_line":"        \"\"\"Modify the service name associated with a volume."},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        In certain upgrade cases, we create new cinder services and delete the"},{"line_number":593,"context_line":"        records of old ones, however, the volumes created with old service"}],"source_content_type":"text/x-python","patch_set":1,"id":"2ece453e_e6580706","line":590,"range":{"start_line":590,"start_character":30,"end_line":590,"end_character":34},"updated":"2021-12-28 12:59:29.000000000","message":"uuid","commit_id":"face126698f44c97335bb5ceee6b924e4048a198"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"10c9f3039cbe9f4ef90270797bacb1e6ce3925cb","unresolved":false,"context_lines":[{"line_number":587,"context_line":"    @args(\u0027--currentservice\u0027, required\u003dTrue, help\u003d\u0027Existing service name\u0027)"},{"line_number":588,"context_line":"    @args(\u0027--newservice\u0027, required\u003dTrue, help\u003d\u0027New service name\u0027)"},{"line_number":589,"context_line":"    def update_service(self, currentservice, newservice):"},{"line_number":590,"context_line":"        \"\"\"Modify the service name associated with a volume."},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        In certain upgrade cases, we create new cinder services and delete the"},{"line_number":593,"context_line":"        records of old ones, however, the volumes created with old service"}],"source_content_type":"text/x-python","patch_set":1,"id":"6ee4ea81_7cabf0a9","line":590,"range":{"start_line":590,"start_character":30,"end_line":590,"end_character":34},"in_reply_to":"2ece453e_e6580706","updated":"2021-12-30 11:26:47.000000000","message":"Done","commit_id":"face126698f44c97335bb5ceee6b924e4048a198"}],"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"eff3d5308621c1363b5afe87e93a3d808fef89b5","unresolved":true,"context_lines":[{"line_number":2284,"context_line":"    \"\"\"Retrieves all volumes associated with the service."},{"line_number":2285,"context_line":""},{"line_number":2286,"context_line":"    :param context: context to query under"},{"line_number":2287,"context_line":"    :param serice: service_uuid for all volumes being retrieved"},{"line_number":2288,"context_line":"    :param filters: dictionary of filters; values that are in lists, tuples,"},{"line_number":2289,"context_line":"                    or sets cause an \u0027IN\u0027 operation, while exact matching"},{"line_number":2290,"context_line":"                    is used for other values, see _process_volume_filters"}],"source_content_type":"text/x-python","patch_set":2,"id":"9c1aa6f6_8d4d6766","line":2287,"range":{"start_line":2287,"start_character":11,"end_line":2287,"end_character":17},"updated":"2022-01-03 04:59:03.000000000","message":"service","commit_id":"fb47b4f229e959fc2baa76adfb448eb891cd6696"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"aa97a4404ca96c3e88c420933ed6c191d9426782","unresolved":false,"context_lines":[{"line_number":2284,"context_line":"    \"\"\"Retrieves all volumes associated with the service."},{"line_number":2285,"context_line":""},{"line_number":2286,"context_line":"    :param context: context to query under"},{"line_number":2287,"context_line":"    :param serice: service_uuid for all volumes being retrieved"},{"line_number":2288,"context_line":"    :param filters: dictionary of filters; values that are in lists, tuples,"},{"line_number":2289,"context_line":"                    or sets cause an \u0027IN\u0027 operation, while exact matching"},{"line_number":2290,"context_line":"                    is used for other values, see _process_volume_filters"}],"source_content_type":"text/x-python","patch_set":2,"id":"d788ae84_fbfb159e","line":2287,"range":{"start_line":2287,"start_character":11,"end_line":2287,"end_character":17},"in_reply_to":"9c1aa6f6_8d4d6766","updated":"2022-07-20 07:46:58.000000000","message":"Done","commit_id":"fb47b4f229e959fc2baa76adfb448eb891cd6696"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"14c49ac5547ce714c72aa497659343190d53efe2","unresolved":true,"context_lines":[{"line_number":2862,"context_line":"    return query.all()"},{"line_number":2863,"context_line":""},{"line_number":2864,"context_line":""},{"line_number":2865,"context_line":"@require_context"},{"line_number":2866,"context_line":"@main_context_manager.writer"},{"line_number":2867,"context_line":"def volume_update_all_by_service(context):"},{"line_number":2868,"context_line":"    \"\"\"Updates all volumes associated with an old service."}],"source_content_type":"text/x-python","patch_set":5,"id":"8c839d5c_4ca21946","line":2865,"updated":"2024-08-19 12:56:55.000000000","message":"-1: `@require_admin_context`","commit_id":"fb2c6dcaa84cd5e03657a68967ba1eb5fb0c0c6f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ff1b30a689a2b7efb0cc8f36cbfac5c11fef2018","unresolved":false,"context_lines":[{"line_number":2862,"context_line":"    return query.all()"},{"line_number":2863,"context_line":""},{"line_number":2864,"context_line":""},{"line_number":2865,"context_line":"@require_context"},{"line_number":2866,"context_line":"@main_context_manager.writer"},{"line_number":2867,"context_line":"def volume_update_all_by_service(context):"},{"line_number":2868,"context_line":"    \"\"\"Updates all volumes associated with an old service."}],"source_content_type":"text/x-python","patch_set":5,"id":"15498d47_6cd28aa0","line":2865,"in_reply_to":"8c839d5c_4ca21946","updated":"2024-08-21 11:25:09.000000000","message":"Done","commit_id":"fb2c6dcaa84cd5e03657a68967ba1eb5fb0c0c6f"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"14c49ac5547ce714c72aa497659343190d53efe2","unresolved":true,"context_lines":[{"line_number":2870,"context_line":"    :param context: context to query under"},{"line_number":2871,"context_line":"    \"\"\""},{"line_number":2872,"context_line":"    # Get all services"},{"line_number":2873,"context_line":"    services \u003d service_get_all(context)"},{"line_number":2874,"context_line":"    for service in services:"},{"line_number":2875,"context_line":"        query \u003d model_query(context, models.Volume)"},{"line_number":2876,"context_line":"        # match_level\u003dbackend is needed since scheduler service entry contains"}],"source_content_type":"text/x-python","patch_set":5,"id":"43627d34_8425efc0","line":2873,"updated":"2024-08-19 12:56:55.000000000","message":"-1: Why do we get all services instead of just the ones from cinder volume?\n\n```\n    services \u003d service_get(context, binary\u003d\u0027cinder-volume\u0027)\n```","commit_id":"fb2c6dcaa84cd5e03657a68967ba1eb5fb0c0c6f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ff1b30a689a2b7efb0cc8f36cbfac5c11fef2018","unresolved":false,"context_lines":[{"line_number":2870,"context_line":"    :param context: context to query under"},{"line_number":2871,"context_line":"    \"\"\""},{"line_number":2872,"context_line":"    # Get all services"},{"line_number":2873,"context_line":"    services \u003d service_get_all(context)"},{"line_number":2874,"context_line":"    for service in services:"},{"line_number":2875,"context_line":"        query \u003d model_query(context, models.Volume)"},{"line_number":2876,"context_line":"        # match_level\u003dbackend is needed since scheduler service entry contains"}],"source_content_type":"text/x-python","patch_set":5,"id":"23a98db2_5f00c376","line":2873,"in_reply_to":"43627d34_8425efc0","updated":"2024-08-21 11:25:09.000000000","message":"IIUC service_get only returns the first service in the results[1]\nI think you meant\n\n    services \u003d service_get_all(context, binary\u003d\u0027cinder-volume\u0027)\n\n[1] https://opendev.org/openstack/cinder/src/branch/master/cinder/db/sqlalchemy/api.py#L889","commit_id":"fb2c6dcaa84cd5e03657a68967ba1eb5fb0c0c6f"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"14c49ac5547ce714c72aa497659343190d53efe2","unresolved":true,"context_lines":[{"line_number":2873,"context_line":"    services \u003d service_get_all(context)"},{"line_number":2874,"context_line":"    for service in services:"},{"line_number":2875,"context_line":"        query \u003d model_query(context, models.Volume)"},{"line_number":2876,"context_line":"        # match_level\u003dbackend is needed since scheduler service entry contains"},{"line_number":2877,"context_line":"        # only hostname which we don\u0027t want to match with"},{"line_number":2878,"context_line":"        query \u003d query.filter("},{"line_number":2879,"context_line":"            _filter_host("},{"line_number":2880,"context_line":"                models.Volume.host, service.host, match_level\u003d\u0027backend\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"85bd8c5f_eca8e3c1","line":2877,"range":{"start_line":2876,"start_character":0,"end_line":2877,"end_character":57},"updated":"2024-08-19 12:56:55.000000000","message":"We can remove this comment if we only get volume services.","commit_id":"fb2c6dcaa84cd5e03657a68967ba1eb5fb0c0c6f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ff1b30a689a2b7efb0cc8f36cbfac5c11fef2018","unresolved":false,"context_lines":[{"line_number":2873,"context_line":"    services \u003d service_get_all(context)"},{"line_number":2874,"context_line":"    for service in services:"},{"line_number":2875,"context_line":"        query \u003d model_query(context, models.Volume)"},{"line_number":2876,"context_line":"        # match_level\u003dbackend is needed since scheduler service entry contains"},{"line_number":2877,"context_line":"        # only hostname which we don\u0027t want to match with"},{"line_number":2878,"context_line":"        query \u003d query.filter("},{"line_number":2879,"context_line":"            _filter_host("},{"line_number":2880,"context_line":"                models.Volume.host, service.host, match_level\u003d\u0027backend\u0027),"}],"source_content_type":"text/x-python","patch_set":5,"id":"160866ce_e1a69d21","line":2877,"range":{"start_line":2876,"start_character":0,"end_line":2877,"end_character":57},"in_reply_to":"85bd8c5f_eca8e3c1","updated":"2024-08-21 11:25:09.000000000","message":"Done","commit_id":"fb2c6dcaa84cd5e03657a68967ba1eb5fb0c0c6f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7a1c4246e432c278380f692277e19e3e871f1089","unresolved":true,"context_lines":[{"line_number":2865,"context_line":"@require_admin_context"},{"line_number":2866,"context_line":"@main_context_manager.writer"},{"line_number":2867,"context_line":"def volume_update_all_by_service(context):"},{"line_number":2868,"context_line":"    \"\"\"Updates all volumes associated with an old service."},{"line_number":2869,"context_line":""},{"line_number":2870,"context_line":"    :param context: context to query under"},{"line_number":2871,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"557b57a9_805e6945","line":2868,"range":{"start_line":2868,"start_character":38,"end_line":2868,"end_character":57},"updated":"2024-08-29 17:20:45.000000000","message":"This isn\u0027t quite what\u0027s going on here ... it\u0027s more like:\n\n```\nMake sure all volumes have the correct service_uuid value for their host.\n```\n\nand if you want you could give some context, like \"On upgrades, each c-vol service gets a new row in the services table, though its host name is constant.  The volumes table keeps both the host name and service uuid for each volume, so we need to update all volumes to have the new service_uuid.\"","commit_id":"9465669d937b767681259112868f7b8ef9f76a81"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2d295db0be40c79451fbe78fdbc10afa533cafc2","unresolved":false,"context_lines":[{"line_number":2865,"context_line":"@require_admin_context"},{"line_number":2866,"context_line":"@main_context_manager.writer"},{"line_number":2867,"context_line":"def volume_update_all_by_service(context):"},{"line_number":2868,"context_line":"    \"\"\"Updates all volumes associated with an old service."},{"line_number":2869,"context_line":""},{"line_number":2870,"context_line":"    :param context: context to query under"},{"line_number":2871,"context_line":"    \"\"\""}],"source_content_type":"text/x-python","patch_set":6,"id":"80506694_da1445f9","line":2868,"range":{"start_line":2868,"start_character":38,"end_line":2868,"end_character":57},"in_reply_to":"557b57a9_805e6945","updated":"2024-09-02 05:17:50.000000000","message":"Done","commit_id":"9465669d937b767681259112868f7b8ef9f76a81"}],"cinder/tests/unit/test_db_api.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7a1c4246e432c278380f692277e19e3e871f1089","unresolved":true,"context_lines":[{"line_number":925,"context_line":"        db.volume_update_all_by_service(self.ctxt)"},{"line_number":926,"context_line":"        volumes \u003d db.volume_get_all(self.ctxt)"},{"line_number":927,"context_line":"        for volume in volumes:"},{"line_number":928,"context_line":"            self.assertEqual(service_uuid, volume.service_uuid)"},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"    def test_volume_get_all_by_project(self):"},{"line_number":931,"context_line":"        volumes \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"b33937ec_60fb2bdd","line":928,"updated":"2024-08-29 17:20:45.000000000","message":"This test could be enhanced if you add a volume that has a different host and then check to make sure that it does *not* get the new service_uuid, but I don\u0027t think it\u0027s worth holding up this patch over that.","commit_id":"9465669d937b767681259112868f7b8ef9f76a81"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2d295db0be40c79451fbe78fdbc10afa533cafc2","unresolved":false,"context_lines":[{"line_number":925,"context_line":"        db.volume_update_all_by_service(self.ctxt)"},{"line_number":926,"context_line":"        volumes \u003d db.volume_get_all(self.ctxt)"},{"line_number":927,"context_line":"        for volume in volumes:"},{"line_number":928,"context_line":"            self.assertEqual(service_uuid, volume.service_uuid)"},{"line_number":929,"context_line":""},{"line_number":930,"context_line":"    def test_volume_get_all_by_project(self):"},{"line_number":931,"context_line":"        volumes \u003d []"}],"source_content_type":"text/x-python","patch_set":6,"id":"568752f4_16f566fa","line":928,"in_reply_to":"b33937ec_60fb2bdd","updated":"2024-09-02 05:17:50.000000000","message":"Done","commit_id":"9465669d937b767681259112868f7b8ef9f76a81"}],"doc/source/cli/cinder-manage.rst":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7a1c4246e432c278380f692277e19e3e871f1089","unresolved":true,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"``cinder-manage volume update_service``"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Updates the service_uuid of the volumes associated with old service_uuid."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"Cinder Host"},{"line_number":201,"context_line":"~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":6,"id":"6a3daa33_4d5b5b27","line":198,"range":{"start_line":198,"start_character":0,"end_line":198,"end_character":73},"updated":"2024-08-29 17:20:45.000000000","message":"I think this is kind of misleading because the user doesn\u0027t specify any service_uuid when running the command.  Maybe something like:\n\nWhen upgrading cinder, new service entries are created in the database as the existing cinder-volume host(s) are upgraded.  In some cases, rows in the volumes table keep references to the old service, which can prevent the old services from being deleted when the database is purged.  This command makes sure that all volumes have updated service references for all volumes on all cinder-volume hosts.","commit_id":"9465669d937b767681259112868f7b8ef9f76a81"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2d295db0be40c79451fbe78fdbc10afa533cafc2","unresolved":false,"context_lines":[{"line_number":195,"context_line":""},{"line_number":196,"context_line":"``cinder-manage volume update_service``"},{"line_number":197,"context_line":""},{"line_number":198,"context_line":"Updates the service_uuid of the volumes associated with old service_uuid."},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"Cinder Host"},{"line_number":201,"context_line":"~~~~~~~~~~~"}],"source_content_type":"text/x-rst","patch_set":6,"id":"235fb741_68f6d849","line":198,"range":{"start_line":198,"start_character":0,"end_line":198,"end_character":73},"in_reply_to":"6a3daa33_4d5b5b27","updated":"2024-09-02 05:17:50.000000000","message":"Done","commit_id":"9465669d937b767681259112868f7b8ef9f76a81"}],"releasenotes/notes/update-service-uuid-f25dbb05efd45d87.yaml":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"14c49ac5547ce714c72aa497659343190d53efe2","unresolved":true,"context_lines":[{"line_number":5,"context_line":"    service_uuid of the volumes with old service_uuid."},{"line_number":6,"context_line":"    Command: ``cinder-manage volume update_service``"},{"line_number":7,"context_line":"    The service_uuid of volumes associated with an old"},{"line_number":8,"context_line":"    service also get updated when we create a new service."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"f96b4ba1_49deaff3","line":8,"range":{"start_line":8,"start_character":34,"end_line":8,"end_character":36},"updated":"2024-08-19 12:56:55.000000000","message":"nit: Please explicitly state that Cinder creates it automatically, so there is no confusion with who is `we` referring to here.\n\nnit: I would split this as 2 features, one is that it is automatically done, another is the cinder-manage command.","commit_id":"fb2c6dcaa84cd5e03657a68967ba1eb5fb0c0c6f"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"ff1b30a689a2b7efb0cc8f36cbfac5c11fef2018","unresolved":false,"context_lines":[{"line_number":5,"context_line":"    service_uuid of the volumes with old service_uuid."},{"line_number":6,"context_line":"    Command: ``cinder-manage volume update_service``"},{"line_number":7,"context_line":"    The service_uuid of volumes associated with an old"},{"line_number":8,"context_line":"    service also get updated when we create a new service."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"c89bf851_0c8bbbe9","line":8,"range":{"start_line":8,"start_character":34,"end_line":8,"end_character":36},"in_reply_to":"f96b4ba1_49deaff3","updated":"2024-08-21 11:25:09.000000000","message":"Done","commit_id":"fb2c6dcaa84cd5e03657a68967ba1eb5fb0c0c6f"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7a1c4246e432c278380f692277e19e3e871f1089","unresolved":true,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a new cinder-manage command to update"},{"line_number":5,"context_line":"    service_uuid of the volumes associated with old"},{"line_number":6,"context_line":"    service_uuid."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    Command: ``cinder-manage volume update_service``"},{"line_number":9,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"edcb4357_53492f7d","line":6,"updated":"2024-08-29 17:20:45.000000000","message":"Maybe:\n\nAdded a new cinder-manage command to handle the situation where database purges would not complete due to the volumes table holding references to deleted services.  The new command makes sure that all volumes have a reference only to the correct service_uuid, which will allow old services to be purged from the database.","commit_id":"9465669d937b767681259112868f7b8ef9f76a81"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2d295db0be40c79451fbe78fdbc10afa533cafc2","unresolved":false,"context_lines":[{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Added a new cinder-manage command to update"},{"line_number":5,"context_line":"    service_uuid of the volumes associated with old"},{"line_number":6,"context_line":"    service_uuid."},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"    Command: ``cinder-manage volume update_service``"},{"line_number":9,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"84d7df13_b2595fbe","line":6,"in_reply_to":"edcb4357_53492f7d","updated":"2024-09-02 05:17:50.000000000","message":"Done","commit_id":"9465669d937b767681259112868f7b8ef9f76a81"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7a1c4246e432c278380f692277e19e3e871f1089","unresolved":true,"context_lines":[{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    When Cinder creates a new service, it will also"},{"line_number":11,"context_line":"    update the service_uuid of volumes associated with"},{"line_number":12,"context_line":"    the old service."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"1db47982_5d75f850","line":12,"updated":"2024-08-29 17:20:45.000000000","message":"Mabye:\n\nWhen Cinder creates a new cinder-volume service, it now also immediately updates the service_uuid for all volumes associated with that cinder-volume host.  In some cases, this was preventing the database purge operation from completing successfully.","commit_id":"9465669d937b767681259112868f7b8ef9f76a81"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"2d295db0be40c79451fbe78fdbc10afa533cafc2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"  - |"},{"line_number":10,"context_line":"    When Cinder creates a new service, it will also"},{"line_number":11,"context_line":"    update the service_uuid of volumes associated with"},{"line_number":12,"context_line":"    the old service."}],"source_content_type":"text/x-yaml","patch_set":6,"id":"fc598cf5_18bfcef0","line":12,"in_reply_to":"1db47982_5d75f850","updated":"2024-09-02 05:17:50.000000000","message":"Done","commit_id":"9465669d937b767681259112868f7b8ef9f76a81"}]}