)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"42d6d74665b1c365ed0ed8addb30eadb1f2d55dc","unresolved":true,"context_lines":[{"line_number":14,"context_line":"cluster format)."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This change makes the rbd driver to skip updating the source volume"},{"line_number":17,"context_line":"if it doesn\u0027t exist. A warning log is left so that operatos can be"},{"line_number":18,"context_line":"aware of any skip event."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Closes-Bug: #1957073"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"d89864fb_6407fb9b","line":17,"updated":"2022-03-22 11:17:08.000000000","message":"Nit: operators","commit_id":"85020b218bc81e80a00e0d9608ceea9cb5620893"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"3f4b1778d8c2b4280e09b739d9a8b6542a63e3bd","unresolved":false,"context_lines":[{"line_number":14,"context_line":"cluster format)."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This change makes the rbd driver to skip updating the source volume"},{"line_number":17,"context_line":"if it doesn\u0027t exist. A warning log is left so that operatos can be"},{"line_number":18,"context_line":"aware of any skip event."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Closes-Bug: #1957073"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"f47c8cf1_27027dd2","line":17,"in_reply_to":"d89864fb_6407fb9b","updated":"2022-03-22 11:48:11.000000000","message":"Done","commit_id":"85020b218bc81e80a00e0d9608ceea9cb5620893"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d43c1176741d083a8cd3196dc128a74e45ff1652","unresolved":true,"context_lines":[{"line_number":16,"context_line":"if it doesn\u0027t exist. A warning log is left so that operators can be"},{"line_number":17,"context_line":"aware of any skip event."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: #1957073"},{"line_number":20,"context_line":"Change-Id: Icd9dad9ad7b3ad71b3962b078e5b94670ac41c87"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"c2ccd4c8_11379a07","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":20},"updated":"2022-09-16 17:36:40.000000000","message":"Please either change this to \"Partial-Bug:\" or update the bug to only refer to the deletion operation and the create a new one for the unmanage operation.","commit_id":"3ddf7ca9ea9587318b8c903e2c43b1879846d1c2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"a3e9730df684b40daa6f5859e01c89fd9cefb44a","unresolved":false,"context_lines":[{"line_number":16,"context_line":"if it doesn\u0027t exist. A warning log is left so that operators can be"},{"line_number":17,"context_line":"aware of any skip event."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Closes-Bug: #1957073"},{"line_number":20,"context_line":"Change-Id: Icd9dad9ad7b3ad71b3962b078e5b94670ac41c87"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"27c5d0bf_938a8a0e","line":19,"range":{"start_line":19,"start_character":0,"end_line":19,"end_character":20},"in_reply_to":"c2ccd4c8_11379a07","updated":"2022-09-20 01:53:34.000000000","message":"I\u0027ve updated the bug to cover only delete. I left a note about unmanage for future reference but we still need to continue discussion about the desired behavior of unmanage.","commit_id":"3ddf7ca9ea9587318b8c903e2c43b1879846d1c2"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"afae72c35c995d366681ca623d32ff360498e4b4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"bdc61d0e_fa6a68ee","updated":"2022-09-19 10:25:46.000000000","message":"LGTM","commit_id":"3ddf7ca9ea9587318b8c903e2c43b1879846d1c2"}],"cinder/volume/drivers/rbd.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5422fa208009cb22fec9a442beacdc01b1dec3ab","unresolved":true,"context_lines":[{"line_number":1295,"context_line":"                        \"InvalidArgument: Unable to unprotect snapshot %s.\","},{"line_number":1296,"context_line":"                        snap_name)"},{"line_number":1297,"context_line":"                except self.rbd.ImageNotFound:"},{"line_number":1298,"context_line":"                    LOG.info("},{"line_number":1299,"context_line":"                        \"ImageNotFound: Unable to unprotect snapshot %s.\","},{"line_number":1300,"context_line":"                        snap_name)"},{"line_number":1301,"context_line":"                except self.rbd.ImageBusy:"}],"source_content_type":"text/x-python","patch_set":5,"id":"dba46487_86be18d7","line":1298,"updated":"2022-09-09 15:11:28.000000000","message":"nit: Not a problem with your patch, but log message here should be the same as on L1316 and we should just return successfuly.","commit_id":"f75652c499577fac5e98f729ad95b258b4180787"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"db5d81a91410e2a699538a0d49a805ddc71f3f83","unresolved":false,"context_lines":[{"line_number":1295,"context_line":"                        \"InvalidArgument: Unable to unprotect snapshot %s.\","},{"line_number":1296,"context_line":"                        snap_name)"},{"line_number":1297,"context_line":"                except self.rbd.ImageNotFound:"},{"line_number":1298,"context_line":"                    LOG.info("},{"line_number":1299,"context_line":"                        \"ImageNotFound: Unable to unprotect snapshot %s.\","},{"line_number":1300,"context_line":"                        snap_name)"},{"line_number":1301,"context_line":"                except self.rbd.ImageBusy:"}],"source_content_type":"text/x-python","patch_set":5,"id":"4f3a7e7a_911c2e74","line":1298,"in_reply_to":"dba46487_86be18d7","updated":"2022-09-15 07:04:05.000000000","message":"Done","commit_id":"f75652c499577fac5e98f729ad95b258b4180787"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5422fa208009cb22fec9a442beacdc01b1dec3ab","unresolved":true,"context_lines":[{"line_number":2112,"context_line":"                if not children and volume.is_protected_snap(snapshot.name):"},{"line_number":2113,"context_line":"                    volume.unprotect_snap(snapshot.name)"},{"line_number":2114,"context_line":"        except self.rbd.ImageNotFound:"},{"line_number":2115,"context_line":"            LOG.warning(\"Volume %s does not exist in backend.\","},{"line_number":2116,"context_line":"                        snapshot.volume_name)"},{"line_number":2117,"context_line":""},{"line_number":2118,"context_line":"    def get_backup_device(self, context, backup):"}],"source_content_type":"text/x-python","patch_set":5,"id":"39c8dfc3_58ed3bcd","line":2115,"updated":"2022-09-09 15:11:28.000000000","message":"-1: I believe we\u0027ll get ImageNotFound also if the snapshot doesn\u0027t exist, in which case the logging message would be incorrect.","commit_id":"f75652c499577fac5e98f729ad95b258b4180787"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"db5d81a91410e2a699538a0d49a805ddc71f3f83","unresolved":false,"context_lines":[{"line_number":2112,"context_line":"                if not children and volume.is_protected_snap(snapshot.name):"},{"line_number":2113,"context_line":"                    volume.unprotect_snap(snapshot.name)"},{"line_number":2114,"context_line":"        except self.rbd.ImageNotFound:"},{"line_number":2115,"context_line":"            LOG.warning(\"Volume %s does not exist in backend.\","},{"line_number":2116,"context_line":"                        snapshot.volume_name)"},{"line_number":2117,"context_line":""},{"line_number":2118,"context_line":"    def get_backup_device(self, context, backup):"}],"source_content_type":"text/x-python","patch_set":5,"id":"26c95dfa_b974ba5f","line":2115,"in_reply_to":"39c8dfc3_58ed3bcd","updated":"2022-09-15 07:04:05.000000000","message":"That is true.\n\nI was trying to address the comment initially but after giving this a few more thoughts, I\u0027m now unsure whether we should let unmanage succeed in this case, because the volume is not left in the backend.\n\nLooking at a few other drivers, some drivers intentionally make unmanage process fail. Also, current implementation fails even if the snapshot does not exist while the volume exists.\n\nI think we better discuss this as a separate topic so I\u0027ve update my change not to cover this part.","commit_id":"f75652c499577fac5e98f729ad95b258b4180787"}],"releasenotes/notes/bug-1957073-0d1307a8637a62b7.yaml":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"d43c1176741d083a8cd3196dc128a74e45ff1652","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    RBD Driver `bug #1957073"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/1957073\u003e`_: Snapshot delete now"},{"line_number":6,"context_line":"    succeeds and skips updating the source volume image if the image"},{"line_number":7,"context_line":"    does not exist in the backend."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"293b221d_7e855461","line":7,"range":{"start_line":5,"start_character":56,"end_line":7,"end_character":34},"updated":"2022-09-16 17:36:40.000000000","message":"nit: I think we are giving too much low level detail.\n\n  Fixed snapshot deletion failure when its volume doesn\u0027t exist.","commit_id":"3ddf7ca9ea9587318b8c903e2c43b1879846d1c2"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"afae72c35c995d366681ca623d32ff360498e4b4","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    RBD Driver `bug #1957073"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/1957073\u003e`_: Snapshot delete now"},{"line_number":6,"context_line":"    succeeds and skips updating the source volume image if the image"},{"line_number":7,"context_line":"    does not exist in the backend."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"3850fdd6_6be58d68","line":7,"range":{"start_line":5,"start_character":56,"end_line":7,"end_character":34},"in_reply_to":"293b221d_7e855461","updated":"2022-09-19 10:25:46.000000000","message":"+1, we can update in a followup","commit_id":"3ddf7ca9ea9587318b8c903e2c43b1879846d1c2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"89bf999f4ae3521e52cff9114b0b27b4ae5467ba","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    RBD Driver `bug #1957073"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/1957073\u003e`_: Snapshot delete now"},{"line_number":6,"context_line":"    succeeds and skips updating the source volume image if the image"},{"line_number":7,"context_line":"    does not exist in the backend."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"5afe7de1_b5495745","line":7,"range":{"start_line":5,"start_character":56,"end_line":7,"end_character":34},"in_reply_to":"3850fdd6_6be58d68","updated":"2022-09-20 12:13:05.000000000","message":"Hmm.. it seems the fix is released as part of 21.0.0.0rc1 . Should we fix the release note now ? My current concern is that updating a release note in the released version can cause incorrect version associated with the note.","commit_id":"3ddf7ca9ea9587318b8c903e2c43b1879846d1c2"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"0b65897dd7f868294f726d1bcec58baf7aa63a9e","unresolved":true,"context_lines":[{"line_number":2,"context_line":"fixes:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    RBD Driver `bug #1957073"},{"line_number":5,"context_line":"    \u003chttps://bugs.launchpad.net/cinder/+bug/1957073\u003e`_: Snapshot delete now"},{"line_number":6,"context_line":"    succeeds and skips updating the source volume image if the image"},{"line_number":7,"context_line":"    does not exist in the backend."}],"source_content_type":"text/x-yaml","patch_set":8,"id":"20cea8f8_641fbeda","line":7,"range":{"start_line":5,"start_character":56,"end_line":7,"end_character":34},"in_reply_to":"5afe7de1_b5495745","updated":"2022-09-22 01:26:25.000000000","message":"I\u0027m afraid I misunderstood something and the change is not present in stable/zed RC1. maybe we can just fix the release note in master.","commit_id":"3ddf7ca9ea9587318b8c903e2c43b1879846d1c2"}]}