)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"a150017af2a322a13d748299dfb96e6976c07e5e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"f146d84b_d9f0b2e8","updated":"2022-03-30 13:46:03.000000000","message":"HPE STORAGE CI passed and code looks good. ","commit_id":"940264edab7dc01d56853359858ee88ccb46919e"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"18da4783774313796cf8037fec109d7a5c4c7ce4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1c33ed26_0ee0896a","updated":"2022-03-22 11:15:23.000000000","message":"LGTM ","commit_id":"940264edab7dc01d56853359858ee88ccb46919e"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"530820fb4554a0082a585ef7e5e0a61c9c37c7dc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c0834bd4_124acba7","updated":"2022-04-01 11:43:53.000000000","message":"Response inline","commit_id":"940264edab7dc01d56853359858ee88ccb46919e"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"ad7c9bc568745adbb1b91d39d3fce2c991906a1b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"938c8a07_fdc9045b","updated":"2022-03-31 05:01:04.000000000","message":"Thank you Sofia.\n","commit_id":"940264edab7dc01d56853359858ee88ccb46919e"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"b7df8130c9ba8c79a168c7ac3121a03bd8918efd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e7e7b225_9c9adc9b","updated":"2022-03-23 04:49:24.000000000","message":"Thanks Tushar","commit_id":"940264edab7dc01d56853359858ee88ccb46919e"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"0395b645deb879e7ff30894c1849fc3add8260e1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"4e617c39_448634cc","updated":"2022-02-08 10:17:52.000000000","message":"Zuul and HPE Storage CI have passed.","commit_id":"940264edab7dc01d56853359858ee88ccb46919e"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"0b1f157fba13278014af12a5e73149cd0d45bfb2","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"578b54f6_bd302bb5","updated":"2022-02-07 08:56:16.000000000","message":"run-HPE Storage CI","commit_id":"940264edab7dc01d56853359858ee88ccb46919e"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"29f6903c1d99025c19a0d201eb386c95509aa8b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7e4caf9b_84207beb","updated":"2022-02-08 08:36:24.000000000","message":"run-HPE Storage CI","commit_id":"940264edab7dc01d56853359858ee88ccb46919e"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"54a43a40b8b7f3804056d6dc4ae48cc7da7510f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e76230ca_4faf0a46","updated":"2022-03-29 07:07:40.000000000","message":"run-HPE Storage CI\n","commit_id":"940264edab7dc01d56853359858ee88ccb46919e"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"ef05417245ab144cab4b39338e21f50ba4f72aac","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"da95ce32_fe73fcdf","in_reply_to":"578b54f6_bd302bb5","updated":"2022-02-08 08:53:23.000000000","message":"Done","commit_id":"940264edab7dc01d56853359858ee88ccb46919e"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"18dce0197bd281face1dd03b4c205772054b34fd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"146dc2e1_bce57160","updated":"2022-04-19 05:50:43.000000000","message":"Replied inline.","commit_id":"bddf9f9ac92d8d60dbfc3c1472ae8aab2f8be2dc"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"08f20268967caccc5189ecb29db3415d638788e7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"039b86d8_6a956802","updated":"2022-04-22 05:40:59.000000000","message":"recheck [1] openstack-tox-functional-py36 [2] cinder-grenade-mn-sub-volbak [3] tempest-slow-py3. All 3 tests failed due to constraint of oslo.versionedobjects\u003d\u003d\u003d2.6.0","commit_id":"eb4bb27ecb1e3ec94198ecfaa22946d4007dce68"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"c919e8098d5716e1d527bf3014f6b1fcc07749a7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"050579d6_dad49a89","updated":"2022-04-21 12:12:31.000000000","message":"recheck cinder-tempest-plugin-lvm-lio-barbican : tempest.lib.common.ssh socket.timeout [only 1 test failed out of 1026 tests]","commit_id":"eb4bb27ecb1e3ec94198ecfaa22946d4007dce68"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"e0467192287c63e709a7e3f75e913dfed9cf4fd5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"23888b9a_efe1ebc4","updated":"2022-04-21 12:03:03.000000000","message":"run-HPE Storage CI","commit_id":"eb4bb27ecb1e3ec94198ecfaa22946d4007dce68"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"154064657c3bcc01f920a9f2bcf95a0076a0c686","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"b44c780c_873c822d","updated":"2022-04-22 05:35:21.000000000","message":"run-HPE Storage CI","commit_id":"eb4bb27ecb1e3ec94198ecfaa22946d4007dce68"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"810b55bea597e1c331c6b897f50996372e81b6fb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"3f817c92_8462bbc2","updated":"2022-04-27 10:38:12.000000000","message":"run-HPE Storage CI\n","commit_id":"eb4bb27ecb1e3ec94198ecfaa22946d4007dce68"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"7f867afaa9acbfc52a746ffe3f5cc99d79de85b1","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c1c10142_88f558f1","updated":"2022-05-18 08:06:54.000000000","message":"LGTM","commit_id":"3ed2f38e54b84073f03ce1148c6dfcbbd37fc032"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"3a2538e2316a66b1191303fc5062ad1c590d02a9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"93352551_dee82d83","updated":"2022-05-16 11:34:21.000000000","message":"My comments are addressed, LGTM.","commit_id":"3ed2f38e54b84073f03ce1148c6dfcbbd37fc032"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"920a715f837b046f926da97198b17aba2d82c8d9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"821e6a5e_a5258247","updated":"2022-05-20 04:13:57.000000000","message":"Thank you Sofia, Hemna, Manoj \u0026 Tushar. The patch has merged.","commit_id":"3ed2f38e54b84073f03ce1148c6dfcbbd37fc032"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"3ab3ec6d169d365171971eb5f8bc0f5e64985f8a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"8c09cf7e_04d51e9a","updated":"2022-05-09 06:56:52.000000000","message":"run-HPE Storage CI","commit_id":"3ed2f38e54b84073f03ce1148c6dfcbbd37fc032"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"fccf97a833ba3d22642fe235c448ea79d6b06022","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"03e534ac_34b541dc","updated":"2022-05-11 13:20:54.000000000","message":"run-HPE Storage CI passed and looks like previous comments have been addressed. ","commit_id":"3ed2f38e54b84073f03ce1148c6dfcbbd37fc032"}],"cinder/volume/drivers/hpe/hpe_3par_common.py":[{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"2c3cdfd345b803194147984a6dbfca385e1ca22d","unresolved":true,"context_lines":[{"line_number":3228,"context_line":""},{"line_number":3229,"context_line":"                for i in range(1, num_hosts):"},{"line_number":3230,"context_line":"                    other_hostname \u003d attachment_list[i].attached_host"},{"line_number":3231,"context_line":"                    if first_hostname !\u003d other_hostname:"},{"line_number":3232,"context_line":"                        all_hostnames.append(other_hostname)"},{"line_number":3233,"context_line":"                        same_host \u003d False"},{"line_number":3234,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"b25638b6_7e4d238f","line":3231,"range":{"start_line":3231,"start_character":20,"end_line":3231,"end_character":56},"updated":"2022-03-31 16:33:06.000000000","message":"suppose if same volume has 3 attachments\n(i.e  2 attachments from same host and 1 attachment from different host) \nThis logic will go ahead with terminate connection, is it expected ?","commit_id":"940264edab7dc01d56853359858ee88ccb46919e"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"012552d94d49956e7f754f75013d28f2db84904d","unresolved":false,"context_lines":[{"line_number":3228,"context_line":""},{"line_number":3229,"context_line":"                for i in range(1, num_hosts):"},{"line_number":3230,"context_line":"                    other_hostname \u003d attachment_list[i].attached_host"},{"line_number":3231,"context_line":"                    if first_hostname !\u003d other_hostname:"},{"line_number":3232,"context_line":"                        all_hostnames.append(other_hostname)"},{"line_number":3233,"context_line":"                        same_host \u003d False"},{"line_number":3234,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"ce47e946_ab05fb57","line":3231,"range":{"start_line":3231,"start_character":20,"end_line":3231,"end_character":56},"in_reply_to":"0ca06c81_4a34dba9","updated":"2022-04-01 14:55:46.000000000","message":"Every terminate_connection call has connector[host], i see the input parameter hostname points to connector[host] in your case.\ni think the decision to skip delete_vlun should depend on the hostname.\n\nin such a case of volume has 3 attachments (i.e  2 attachments from same host and 1 attachment from different host), if terminate_connection is called for the host which is associated with two instances, you logic will delete the the vlun which puts the second instance into trouble. i mean the behavior contradicts the purpose of fix you are trying to give.","commit_id":"940264edab7dc01d56853359858ee88ccb46919e"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"6b6a611405424b9dd6552f73e663a760723dbb9b","unresolved":false,"context_lines":[{"line_number":3228,"context_line":""},{"line_number":3229,"context_line":"                for i in range(1, num_hosts):"},{"line_number":3230,"context_line":"                    other_hostname \u003d attachment_list[i].attached_host"},{"line_number":3231,"context_line":"                    if first_hostname !\u003d other_hostname:"},{"line_number":3232,"context_line":"                        all_hostnames.append(other_hostname)"},{"line_number":3233,"context_line":"                        same_host \u003d False"},{"line_number":3234,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"d8bb0236_300dbeb0","line":3231,"range":{"start_line":3231,"start_character":20,"end_line":3231,"end_character":56},"in_reply_to":"48916a3e_90d664b4","updated":"2022-04-19 17:47:28.000000000","message":"I am still not convinced with the logic here.\nyou are not considering the host for which terminate connection is called and just iterating though the volume\u0027s attachments to find if first entry repeats again.\n\nThe issue mentioned in my previous comment can still occur.\n\ninstead of first_hostname, search for hostname (input parameter) repetition in the volume attachments to confirm if any other attachment is associated with the current host.","commit_id":"940264edab7dc01d56853359858ee88ccb46919e"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"530820fb4554a0082a585ef7e5e0a61c9c37c7dc","unresolved":false,"context_lines":[{"line_number":3228,"context_line":""},{"line_number":3229,"context_line":"                for i in range(1, num_hosts):"},{"line_number":3230,"context_line":"                    other_hostname \u003d attachment_list[i].attached_host"},{"line_number":3231,"context_line":"                    if first_hostname !\u003d other_hostname:"},{"line_number":3232,"context_line":"                        all_hostnames.append(other_hostname)"},{"line_number":3233,"context_line":"                        same_host \u003d False"},{"line_number":3234,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"0ca06c81_4a34dba9","line":3231,"range":{"start_line":3231,"start_character":20,"end_line":3231,"end_character":56},"in_reply_to":"b25638b6_7e4d238f","updated":"2022-04-01 11:43:53.000000000","message":"Yes. Since there is one attachment with different host,\nlogic will proceed with terminate connection.\nThis is expected behaviour.","commit_id":"940264edab7dc01d56853359858ee88ccb46919e"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"18dce0197bd281face1dd03b4c205772054b34fd","unresolved":false,"context_lines":[{"line_number":3228,"context_line":""},{"line_number":3229,"context_line":"                for i in range(1, num_hosts):"},{"line_number":3230,"context_line":"                    other_hostname \u003d attachment_list[i].attached_host"},{"line_number":3231,"context_line":"                    if first_hostname !\u003d other_hostname:"},{"line_number":3232,"context_line":"                        all_hostnames.append(other_hostname)"},{"line_number":3233,"context_line":"                        same_host \u003d False"},{"line_number":3234,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"48916a3e_90d664b4","line":3231,"range":{"start_line":3231,"start_character":20,"end_line":3231,"end_character":56},"in_reply_to":"ce47e946_ab05fb57","updated":"2022-04-19 05:50:43.000000000","message":"Thanks Manoj.\nThis is resolved in patchset 2.","commit_id":"940264edab7dc01d56853359858ee88ccb46919e"},{"author":{"_account_id":34598,"name":"Manojkatari","email":"mkatari@redhat.com","username":"mkatari"},"change_message_id":"3a2538e2316a66b1191303fc5062ad1c590d02a9","unresolved":false,"context_lines":[{"line_number":3228,"context_line":""},{"line_number":3229,"context_line":"                for i in range(1, num_hosts):"},{"line_number":3230,"context_line":"                    other_hostname \u003d attachment_list[i].attached_host"},{"line_number":3231,"context_line":"                    if first_hostname !\u003d other_hostname:"},{"line_number":3232,"context_line":"                        all_hostnames.append(other_hostname)"},{"line_number":3233,"context_line":"                        same_host \u003d False"},{"line_number":3234,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"cb3dcad9_b59db28b","line":3231,"range":{"start_line":3231,"start_character":20,"end_line":3231,"end_character":56},"in_reply_to":"d8bb0236_300dbeb0","updated":"2022-05-16 11:34:21.000000000","message":"Thanks for addressing my comments.","commit_id":"940264edab7dc01d56853359858ee88ccb46919e"}]}