)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4e173f4232525fc421d901bda7f1491020c5d31c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"de8b5ab3_be40f5b9","updated":"2022-02-08 23:26:42.000000000","message":"See comment inline for a follow-up suggestion.","commit_id":"66fe1c17d9481f2888f73c36bc2edbf47cf2cc82"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"754fabbd680333a94d6e1c94f979f5eca5e7121d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c569427d_4798a8c4","updated":"2022-05-12 13:17:21.000000000","message":"The change to cinder/volume/drivers/open_e/jovian_common/jdss_common.py is to a comment, not code, so I\u0027ll consider this a purely documentation patch, and hence according to Cinder project policy only requiring one +2.","commit_id":"66fe1c17d9481f2888f73c36bc2edbf47cf2cc82"}],"cinder/volume/drivers/open_e/options.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4e173f4232525fc421d901bda7f1491020c5d31c","unresolved":true,"context_lines":[{"line_number":38,"context_line":""},{"line_number":39,"context_line":"jdss_volume_opts \u003d ["},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027jovian_block_size\u0027,"},{"line_number":41,"context_line":"               default\u003d\u002764K\u0027,"},{"line_number":42,"context_line":"               help\u003d\u0027Block size can be: 32K, 64K, 128K, 256K, 512K, 1M\u0027),"},{"line_number":43,"context_line":"]"},{"line_number":44,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fbb386a0_ed6e8411","line":41,"range":{"start_line":41,"start_character":15,"end_line":41,"end_character":28},"updated":"2022-02-08 23:26:42.000000000","message":"The default value is indeed 64K.\n\nYou should think about adding a \u0027choices\u0027 parameter to the option definition (in a followup patch).  See [0] for an example of how to do it.\n\n[0] https://opendev.org/openstack/cinder/src/commit/83194a5f4fcc19b08fc9d0d08210c3eecb938dd4/cinder/backup/chunkeddriver.py#L51-L62","commit_id":"66fe1c17d9481f2888f73c36bc2edbf47cf2cc82"}]}
