)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0fde06ae5665d3f252e7250cad37a8a5f5bbe675","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"10b8c586_83edd865","updated":"2022-03-18 15:46:00.000000000","message":"I think this is OK ...","commit_id":"84e2a47bc375e7a0f40ee10537921ab20956b9f6"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"c832d68f875292e9351447bf3a3aea353cf1a0ed","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c84628f1_3e702069","updated":"2022-03-18 14:57:44.000000000","message":"LGTM","commit_id":"84e2a47bc375e7a0f40ee10537921ab20956b9f6"}],"cinder/volume/drivers/spdk.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0fde06ae5665d3f252e7250cad37a8a5f5bbe675","unresolved":true,"context_lines":[{"line_number":401,"context_line":"    def remove_export(self, context, volume):"},{"line_number":402,"context_line":"        self.target_driver.remove_export(context, volume)"},{"line_number":403,"context_line":""},{"line_number":404,"context_line":"    def initialize_connection(self, volume, connector, **kwargs):"},{"line_number":405,"context_line":"        return self.target_driver.initialize_connection(volume, connector)"},{"line_number":406,"context_line":""},{"line_number":407,"context_line":"    def validate_connector(self, connector):"}],"source_content_type":"text/x-python","patch_set":1,"id":"ec7e1ded_e33343de","line":404,"updated":"2022-03-18 15:46:00.000000000","message":"Was this causing a problem somewhere?  That said, this driver inherits from VolumeDriver, where initialize_connection has this signature [0], so I think this is OK.\n\n[0] https://opendev.org/openstack/cinder/src/commit/4e02f204ff50ffdf3379c5f71e653c6742be2960/cinder/volume/driver.py#L2323","commit_id":"84e2a47bc375e7a0f40ee10537921ab20956b9f6"}]}