)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"6928bd7d92fb764de4f3711ac369c59b85ef4609","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch fixes a problem in attach volume.  The existing logic"},{"line_number":10,"context_line":"doesn\u0027t check whether a volume is already attached to a specific host."},{"line_number":11,"context_line":"This patch adds a check to see if a volume is already attached to a"},{"line_number":12,"context_line":"specific host.  If not, it will do the attach."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I05a2f57cd8708d7fcbe902ec13665a9cfb44db07"},{"line_number":15,"context_line":"Closes-Bug: #1295906"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2BjZA%3D","line":12,"updated":"2014-03-25 23:40:36.000000000","message":"Should probably preface this all with the fact that the volume being attached already could be due to a nova live-migration use case.   Cinder doesn\u0027t support multiple attaches currently, but allows a volume to be attached multiple times from nova during live-migration.","commit_id":"bba4571ac7b2fe629801e7bb977e8c5fbf1d495f"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"9c1d4959930a59ba23c21246eb9f8efa8db06f8f","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch fixes a problem in attach volume.  The existing logic"},{"line_number":10,"context_line":"doesn\u0027t check whether a volume is already attached to a specific host."},{"line_number":11,"context_line":"This patch adds a check to see if a volume is already attached to a"},{"line_number":12,"context_line":"specific host.  If not, it will do the attach."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I05a2f57cd8708d7fcbe902ec13665a9cfb44db07"},{"line_number":15,"context_line":"Closes-Bug: #1295906"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"AAAAWH%2F%2BjMY%3D","line":12,"in_reply_to":"AAAAWH%2F%2BjZA%3D","updated":"2014-03-26 00:38:54.000000000","message":"Done","commit_id":"bba4571ac7b2fe629801e7bb977e8c5fbf1d495f"},{"author":{"_account_id":2759,"name":"Huang Zhiteng","email":"winston.d@gmail.com","username":"zhiteng-huang"},"change_message_id":"945b827f9edcaacf8d6296d9d8eda0775479f148","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch fixes a problem in attach volume.  The existing logic"},{"line_number":10,"context_line":"doesn\u0027t check whether a volume is already attached to a specific host."},{"line_number":11,"context_line":"This patch adds a check to see if a volume is already attached to a"},{"line_number":12,"context_line":"specific host.  If not, it will do the attach.  The reason that the"},{"line_number":13,"context_line":"volume being attached already could be due to a nova live-migration"},{"line_number":14,"context_line":"use case.  Cinder doesn\u0027t support multiple attaches currently, but"},{"line_number":15,"context_line":"allows a volume to be attached multiple times from nova during"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAWH%2F%2Bivw%3D","line":12,"updated":"2014-03-26 02:32:40.000000000","message":"I don\u0027t think this patch actually does attaching, does it?  It appears to me that you adding checks to make sure init_connection returns correct information, nothing more.","commit_id":"3425d5324d0ed634814955139df74615ae901bed"},{"author":{"_account_id":6491,"name":"xing-yang","email":"xingyang105@gmail.com","username":"xing-yang"},"change_message_id":"77c516ffc77cecbf7c806e3aeb2b920e64895f99","unresolved":false,"context_lines":[{"line_number":9,"context_line":"This patch fixes a problem in attach volume.  The existing logic"},{"line_number":10,"context_line":"doesn\u0027t check whether a volume is already attached to a specific host."},{"line_number":11,"context_line":"This patch adds a check to see if a volume is already attached to a"},{"line_number":12,"context_line":"specific host.  If not, it will do the attach.  The reason that the"},{"line_number":13,"context_line":"volume being attached already could be due to a nova live-migration"},{"line_number":14,"context_line":"use case.  Cinder doesn\u0027t support multiple attaches currently, but"},{"line_number":15,"context_line":"allows a volume to be attached multiple times from nova during"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"AAAAWH%2F%2BinI%3D","line":12,"in_reply_to":"AAAAWH%2F%2Bivw%3D","updated":"2014-03-26 02:58:17.000000000","message":"Hi Winston.  Yes, this patch does attaching if the volume is not already attached to the host specified by Nova.  Without this patch, it only checks whether the volume is already attached to any host.  So that is problem during live-migration.  The volume is already attached to the origin host, and Nova wants Cinder to attach the volume to the destination host.  The existing logic skips attaching and therefore the volume won\u0027t get attached to the destination host and live-migration can\u0027t finish.","commit_id":"3425d5324d0ed634814955139df74615ae901bed"}]}
