)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"294533dca8b66ec4ee89d96866fcefdf89a6a8ea","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deleting a volume in \u0027downloading\u0027 state"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Clean up of volume in DB needs if a user change"},{"line_number":10,"context_line":"his mind and run volume-delete command while"},{"line_number":11,"context_line":"volume is in downloading state"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"afb2a13a_2f5cc62c","line":9,"range":{"start_line":9,"start_character":22,"end_line":9,"end_character":31},"updated":"2022-02-18 15:21:40.000000000","message":"the DB needs to be done","commit_id":"c9d4819f5982cc71d43b12f1284a21f9f6e19a82"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"4cae67394eaf7fe87d932c70f39f11e1429eabb7","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Deleting a volume in \u0027downloading\u0027 state"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Clean up of volume in DB needs if a user change"},{"line_number":10,"context_line":"his mind and run volume-delete command while"},{"line_number":11,"context_line":"volume is in downloading state"},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"48470392_68bfc957","line":9,"range":{"start_line":9,"start_character":22,"end_line":9,"end_character":31},"in_reply_to":"afb2a13a_2f5cc62c","updated":"2022-02-18 15:55:37.000000000","message":"Done","commit_id":"c9d4819f5982cc71d43b12f1284a21f9f6e19a82"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"294533dca8b66ec4ee89d96866fcefdf89a6a8ea","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"1aeba691_059ccd2f","updated":"2022-02-18 15:21:40.000000000","message":"nit on the Commit message.  Otherwise I think the logic is ok.","commit_id":"c9d4819f5982cc71d43b12f1284a21f9f6e19a82"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5ec50a56bbbef46ad9126f7a7e02282e0d11750b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1779121f_6c5fa3ab","updated":"2022-05-27 14:35:01.000000000","message":"Question inline.","commit_id":"2aa091ac32bfce97f23f5a5db3795d317f95c8ad"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"0b029019e7ea2b84484e197946a7abc9e5dcd822","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"2e84dd6f_85b6a736","updated":"2022-02-22 10:18:31.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2aa091ac32bfce97f23f5a5db3795d317f95c8ad"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"49bee9bf40c83be67f3a9f4be912a40c68cd8a7e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"53ea399e_39e6e21b","updated":"2022-02-22 10:10:24.000000000","message":"run-DellEMC PowerFlex CI","commit_id":"2aa091ac32bfce97f23f5a5db3795d317f95c8ad"},{"author":{"_account_id":13425,"name":"Simon Dodsley","email":"simon@purestorage.com","username":"sdodsley"},"change_message_id":"a24b2d38bfabd4288a5d2c6fa998ebc84f6b8fcd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"7d0fa277_a6786590","updated":"2022-07-15 14:45:08.000000000","message":"Makes sense","commit_id":"c2d5c4acd901e8f602b7dc8f35e4fe449c788f7c"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e5f3a87ae047541a3e956ae1fd5e3263bad38621","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"a95d1d23_b36a7a83","updated":"2022-07-19 07:50:22.000000000","message":"This doesn\u0027t seem like a good idea since we\u0027ve a whole lot of cases that needs to be addressed at any point of the operation. I think it makes sense to delete the volume if we only have created the DB entry and have not done any work on it, else after that the cleanup isn\u0027t trivial.","commit_id":"c2d5c4acd901e8f602b7dc8f35e4fe449c788f7c"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"27e7eb7e12258b4762979d4ebb3ecf0d80a0b81c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"cf15a6ce_ae033998","updated":"2022-07-20 08:56:52.000000000","message":"ok i\u0027ll rework and update that","commit_id":"c2d5c4acd901e8f602b7dc8f35e4fe449c788f7c"},{"author":{"_account_id":35075,"name":"Alexander Deiter","email":"adeiter@infinidat.com","username":"adeiter"},"change_message_id":"fdde0222677481ed146de36873e08ba402641b23","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":16,"id":"177911f4_411ac80f","updated":"2023-04-03 11:17:45.000000000","message":"run-INFINIDAT","commit_id":"e8408d5f23753fc229cffc3d47b98337d49038fe"}],"cinder/volume/api.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e5f3a87ae047541a3e956ae1fd5e3263bad38621","unresolved":true,"context_lines":[{"line_number":500,"context_line":"            values[\u0027status\u0027] \u003d \u0027unmanaging\u0027"},{"line_number":501,"context_line":"        if volume.status \u003d\u003d \u0027error_managing\u0027:"},{"line_number":502,"context_line":"            values[\u0027status\u0027] \u003d \u0027error_managing_deleting\u0027"},{"line_number":503,"context_line":"        if volume.status \u003d\u003d \u0027downloading\u0027:"},{"line_number":504,"context_line":"            self._clear_db(volume, \u0027error\u0027)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        result \u003d volume.conditional_update(values, expected, filters)"},{"line_number":507,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"73560adc_e8ce8e2b","line":504,"range":{"start_line":503,"start_character":8,"end_line":504,"end_character":43},"updated":"2022-07-19 07:50:22.000000000","message":"we are just updating the volume status to error here which doesn\u0027t seem like a proper cleanup. While creating a bootable volume from image, the volume could be attached to the controller node hence having an attachment record which we should take into account. Also the image is first downloaded into the image_conversion_dir which could have data copied to the dir and is not cleaned up here resulting in space consumption by a stale file. Also just to mention we also have to consider the image cache entry in this.\nI would recommend going through the operation of creating a bootable volume from image and think of possible cases that should be cleaned up if we plan to delete the volume at any stage.","commit_id":"c2d5c4acd901e8f602b7dc8f35e4fe449c788f7c"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"4ce00cb6620f9f9fcc0f65190018cd025bf02059","unresolved":true,"context_lines":[{"line_number":500,"context_line":"            values[\u0027status\u0027] \u003d \u0027unmanaging\u0027"},{"line_number":501,"context_line":"        if volume.status \u003d\u003d \u0027error_managing\u0027:"},{"line_number":502,"context_line":"            values[\u0027status\u0027] \u003d \u0027error_managing_deleting\u0027"},{"line_number":503,"context_line":"        if volume.status \u003d\u003d \u0027downloading\u0027:"},{"line_number":504,"context_line":"            self._clear_db(volume, \u0027error\u0027)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        result \u003d volume.conditional_update(values, expected, filters)"},{"line_number":507,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"e1b92447_d482484a","line":504,"range":{"start_line":503,"start_character":8,"end_line":504,"end_character":43},"in_reply_to":"73560adc_e8ce8e2b","updated":"2022-07-20 08:55:59.000000000","message":"ok i\u0027ll try that.","commit_id":"c2d5c4acd901e8f602b7dc8f35e4fe449c788f7c"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"27e7eb7e12258b4762979d4ebb3ecf0d80a0b81c","unresolved":false,"context_lines":[{"line_number":500,"context_line":"            values[\u0027status\u0027] \u003d \u0027unmanaging\u0027"},{"line_number":501,"context_line":"        if volume.status \u003d\u003d \u0027error_managing\u0027:"},{"line_number":502,"context_line":"            values[\u0027status\u0027] \u003d \u0027error_managing_deleting\u0027"},{"line_number":503,"context_line":"        if volume.status \u003d\u003d \u0027downloading\u0027:"},{"line_number":504,"context_line":"            self._clear_db(volume, \u0027error\u0027)"},{"line_number":505,"context_line":""},{"line_number":506,"context_line":"        result \u003d volume.conditional_update(values, expected, filters)"},{"line_number":507,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"be3aa42d_2de10567","line":504,"range":{"start_line":503,"start_character":8,"end_line":504,"end_character":43},"in_reply_to":"e1b92447_d482484a","updated":"2022-07-20 08:56:52.000000000","message":"Done","commit_id":"c2d5c4acd901e8f602b7dc8f35e4fe449c788f7c"}],"cinder/volume/manager.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"5ec50a56bbbef46ad9126f7a7e02282e0d11750b","unresolved":true,"context_lines":[{"line_number":711,"context_line":"        # statuses we have to set status to error"},{"line_number":712,"context_line":"        if vo_resource.status in (\u0027creating\u0027, \u0027downloading\u0027):"},{"line_number":713,"context_line":"            vo_resource.status \u003d \u0027error\u0027"},{"line_number":714,"context_line":"            self.driver.clear_download(ctxt, vo_resource)"},{"line_number":715,"context_line":"            vo_resource.save()"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"110b45ef_9c61b8f5","line":714,"updated":"2022-05-27 14:35:01.000000000","message":"If it\u0027s a volume, we\u0027ve already called driver.clear_download at line 688.  Could that be a problem for some drivers?  Maybe since you\u0027re adding the clear_download here, you can just remove lines 687-688?","commit_id":"2aa091ac32bfce97f23f5a5db3795d317f95c8ad"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"13b3a37a8106b21b4a0b47fa005ea0a6468499e8","unresolved":false,"context_lines":[{"line_number":711,"context_line":"        # statuses we have to set status to error"},{"line_number":712,"context_line":"        if vo_resource.status in (\u0027creating\u0027, \u0027downloading\u0027):"},{"line_number":713,"context_line":"            vo_resource.status \u003d \u0027error\u0027"},{"line_number":714,"context_line":"            self.driver.clear_download(ctxt, vo_resource)"},{"line_number":715,"context_line":"            vo_resource.save()"},{"line_number":716,"context_line":""},{"line_number":717,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":4,"id":"b6017c03_d674899f","line":714,"in_reply_to":"110b45ef_9c61b8f5","updated":"2022-06-23 10:04:45.000000000","message":"Done","commit_id":"2aa091ac32bfce97f23f5a5db3795d317f95c8ad"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"e5f3a87ae047541a3e956ae1fd5e3263bad38621","unresolved":true,"context_lines":[{"line_number":708,"context_line":"        # statuses we have to set status to error"},{"line_number":709,"context_line":"        if vo_resource.status in (\u0027creating\u0027, \u0027downloading\u0027):"},{"line_number":710,"context_line":"            vo_resource.status \u003d \u0027error\u0027"},{"line_number":711,"context_line":"            self.driver.clear_download(ctxt, vo_resource)"},{"line_number":712,"context_line":"            vo_resource.save()"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":7,"id":"ee9371cb_0abbc7e1","line":711,"range":{"start_line":711,"start_character":12,"end_line":711,"end_character":57},"updated":"2022-07-19 07:50:22.000000000","message":"this method is not implemented by any driver, is this needed anymore?","commit_id":"c2d5c4acd901e8f602b7dc8f35e4fe449c788f7c"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"27e7eb7e12258b4762979d4ebb3ecf0d80a0b81c","unresolved":false,"context_lines":[{"line_number":708,"context_line":"        # statuses we have to set status to error"},{"line_number":709,"context_line":"        if vo_resource.status in (\u0027creating\u0027, \u0027downloading\u0027):"},{"line_number":710,"context_line":"            vo_resource.status \u003d \u0027error\u0027"},{"line_number":711,"context_line":"            self.driver.clear_download(ctxt, vo_resource)"},{"line_number":712,"context_line":"            vo_resource.save()"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"        return False"}],"source_content_type":"text/x-python","patch_set":7,"id":"2aabb5d2_e7449fd7","line":711,"range":{"start_line":711,"start_character":12,"end_line":711,"end_character":57},"in_reply_to":"ee9371cb_0abbc7e1","updated":"2022-07-20 08:56:52.000000000","message":"Done","commit_id":"c2d5c4acd901e8f602b7dc8f35e4fe449c788f7c"}]}