)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"63d44d1ab19efc194ee767ec412310e7e5839617","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c4ad3d4b_e551704d","updated":"2022-02-18 17:03:16.000000000","message":"I want to hold this until someone has a chance to look at the rbd code.  (But I don\u0027t want to hold indefinitely, we need to decide whether we want to use --pool or --dest-pool in Yoga.)\n\nThe question here is whether we should use --dest-pool or --pool in creating the statement we send to the rbd CLI.\n\nThe response to the bug Sofia filed at Ceph says that --pool isn\u0027t mentioned for the \u0027import\u0027 command, but then admits later that yes, it is, because given that the image-spec argument in the form pool/namespace/imagename is not required (though it is preferred), you are allowed to specify each part of the spec individually using the --pool, --namespace, and --image options.  Now when Sofia uses the pacific \u0027rbd import\u0027 using --pool, she is getting the message saying that --pool is deprecated and we should be using --dest-pool instead.\n\nThe output of \u0027rbd help import\u0027 for pacific shows that --dest-pool is valid.  The deprecation warning implies that \"--pool \u003cpool\u003e\" is the same as \"--dest-pool \u003cdest-pool\u003e\", and when you look to the docs to verify this, the word \u0027dest-pool\u0027 does not appear anywhere on https://docs.ceph.com/en/pacific/man/8/rbd/ ... so there is definitely a doc bug, as Sofia said.  (It looks like the responder got caught up in whether this is specifically an import command problem or not, and completely missed the point that the CLI says --pool is deprecated in favor of --dest-pool, and this appears nowhere in the pacific man page for rbd.)\n\n(I\u0027m dumping that here instead of in the Ceph bug because I don\u0027t have a Ceph tracker account, and will not have one for a day or two because of spam problems.)\n\nAnyway ... if --pool is deprecated, it will be removed at some point, so we should start using --dest-pool ... or if that is also going to be deprecated, we need to switch to using the image-spec format of pool/namespace/image.  The primary issue for us is that for Cinder, we claim to support the 2 active releases + the prior 2 releases.  Ceph 17.2.0 (Q) is supposed to be released during march, and the Yoga openstack release is on 30 March.  So the yoga rbd driver code needs to support Q, P, O, and N.  So if --dest-pool is valid back to the Nautilus rbd CLI, I think we should *not* revert this change.  \n\n","commit_id":"082aba21534aa0fe3344b5de5f114087d488c6b9"},{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"f19b7e08f794b0c98ba2c32851486b64492b097b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ba74ca96_35c17911","updated":"2022-02-18 15:58:31.000000000","message":"LGTM\nThank you!","commit_id":"082aba21534aa0fe3344b5de5f114087d488c6b9"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"c15d5a3f216d3c2192f3330b79db202de8272d19","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9b24a229_17bb3e24","updated":"2022-02-18 15:27:55.000000000","message":"Looks like this is ok to do.","commit_id":"082aba21534aa0fe3344b5de5f114087d488c6b9"},{"author":{"_account_id":32594,"name":"Ashley Rodriguez","email":"ashrod98@redhat.com","username":"ashrod98"},"change_message_id":"9e27a5e38d154fb6d1623c916019ccf244d7f430","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"fe795d8a_ff1f47bb","updated":"2022-01-28 18:35:24.000000000","message":"Thanks Sofia, looks good to me.","commit_id":"082aba21534aa0fe3344b5de5f114087d488c6b9"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"532c3320cfef8f762c67c9e3ee83b5f448753221","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"91679a2b_6ff5219e","updated":"2022-02-18 15:24:01.000000000","message":"Yes, the linked ceph bug shows that the rbd import is one of the command which uses --pool instead of --dest-pool...","commit_id":"082aba21534aa0fe3344b5de5f114087d488c6b9"}]}