)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"91743efcca399e5a255e4906cf6b26db59437d92","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Hitachi: bugfix and refactoring for add maintenance parameters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is bugfixing and refactoring for the following patch:"},{"line_number":10,"context_line":"https://review.opendev.org/c/openstack/cinder/+/786873"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Fixing:"},{"line_number":13,"context_line":"- Adding get_driver_options(), to hbsd_fc.py/hbsd_iscsi.py, which was"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"f0d68e53_cdf116fd","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":54},"updated":"2022-03-02 14:44:13.000000000","message":"I\u0027m going over that patch and has some comments, will post them shorty but in the meantime, doesn\u0027t want this to get merged and then you will need to post another patch addressing comments.","commit_id":"be1eb108edf686e3fd8b1e91410e0d6ea5e931d5"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"4a52ea900c4ce1cfdbdae7717bd61a14947c90ef","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Hitachi: bugfix and refactoring for add maintenance parameters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is bugfixing and refactoring for the following patch:"},{"line_number":10,"context_line":"https://review.opendev.org/c/openstack/cinder/+/786873"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Fixing:"},{"line_number":13,"context_line":"- Adding get_driver_options(), to hbsd_fc.py/hbsd_iscsi.py, which was"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"43058abd_e3d3ca99","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":54},"in_reply_to":"194d3969_47739e55","updated":"2022-03-03 23:58:46.000000000","message":"I\u0027ll upload fixed patch along your comments today(Mar 4th).\nWe would like to merge this pacht which is a parent of other new feature patchs.","commit_id":"be1eb108edf686e3fd8b1e91410e0d6ea5e931d5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"6b65beb872457ccccd7c23d37309c456505d2fa4","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Hitachi: bugfix and refactoring for add maintenance parameters"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch is bugfixing and refactoring for the following patch:"},{"line_number":10,"context_line":"https://review.opendev.org/c/openstack/cinder/+/786873"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Fixing:"},{"line_number":13,"context_line":"- Adding get_driver_options(), to hbsd_fc.py/hbsd_iscsi.py, which was"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"194d3969_47739e55","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":54},"in_reply_to":"f0d68e53_cdf116fd","updated":"2022-03-02 15:46:56.000000000","message":"Added few review comments here that will be good to get addressed in this followup\nhttps://review.opendev.org/c/openstack/cinder/+/786873","commit_id":"be1eb108edf686e3fd8b1e91410e0d6ea5e931d5"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"4d84c6b801ed0d985cd4689c05796fabe6607188","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"26feb0f8_4e9986df","updated":"2022-02-25 03:10:10.000000000","message":"Changes look good and CI is green.","commit_id":"be1eb108edf686e3fd8b1e91410e0d6ea5e931d5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2ac7881d2174198b065409a90ceaa6bc60bfb891","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"26003f36_50fa051e","updated":"2022-03-02 15:51:15.000000000","message":"I missed that you didn\u0027t follow up on the integer-list-of-options-issue.  See comment inline.","commit_id":"be1eb108edf686e3fd8b1e91410e0d6ea5e931d5"},{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"189883dd49540a8e3610fff5b7e8de0d3ef9b02f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"c450797a_042c54a2","updated":"2022-02-17 08:41:16.000000000","message":"LGTM","commit_id":"be1eb108edf686e3fd8b1e91410e0d6ea5e931d5"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"e66b6a726a9b0c3656130614bae26ead0f64d392","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"120bdead_5740139b","updated":"2022-02-28 10:44:45.000000000","message":"One minor suggestion (in case another patchset is submitted):\nIn files hbsd_fc.py and hbsd_iscsi.py around line 70,\nnew version may be added (if it helps) eg. 2.2.2 - Refactoring done/Added get_driver_options.\n\nOverall, code changes look good. Zuul \u0026 hitachi_vsp CI passed. So +1.","commit_id":"be1eb108edf686e3fd8b1e91410e0d6ea5e931d5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"91743efcca399e5a255e4906cf6b26db59437d92","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"bde27b5d_570ba9a9","updated":"2022-03-02 14:44:13.000000000","message":"reason inline","commit_id":"be1eb108edf686e3fd8b1e91410e0d6ea5e931d5"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"477d7d611716204ea9ec41a7f247c6ecac6d1578","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"698d480f_00001e6c","updated":"2022-02-02 00:50:03.000000000","message":"recheck","commit_id":"be1eb108edf686e3fd8b1e91410e0d6ea5e931d5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a3d7ebde0bb744bbf67a47196ad377eec14c6958","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"424f6e75_8f0fb405","updated":"2022-03-07 04:01:43.000000000","message":"Comments have been addressed and CI is happy.","commit_id":"11d26b9f591f9c2626d76c2c0d40340ae99d6a64"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0baca183b8aa0182c03dc25c050de34c04af5f56","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bf6b61b7_56201d97","updated":"2022-03-06 12:39:05.000000000","message":"My comments are addressed and hitachi CI is reporting success. LGTM.","commit_id":"11d26b9f591f9c2626d76c2c0d40340ae99d6a64"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"740ddc555c10e1eb20dcd830e53c394ed83cb0ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"83c547db_b3f8a508","updated":"2022-03-05 02:10:17.000000000","message":"recheck","commit_id":"11d26b9f591f9c2626d76c2c0d40340ae99d6a64"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"a62f1c700e549a7ca2642ccf11d582888cdea336","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"e8aa3c3e_d5013dba","updated":"2022-03-04 07:33:21.000000000","message":"recheck","commit_id":"11d26b9f591f9c2626d76c2c0d40340ae99d6a64"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"32573eb5da62514d6c143f14f7c9ecd2b3f0554e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"22268e16_ff2e62ac","updated":"2022-03-04 22:08:55.000000000","message":"recheck tempest-ipv6-only - failure during devstack setup: /opt/stack/devstack/lib/neutron_plugins/ovn_agent:178 Socket /var/run/openvswitch/ovnnb_db.sock not found","commit_id":"11d26b9f591f9c2626d76c2c0d40340ae99d6a64"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"9877dc8fbf90b85adabe322ad84b9861ef5740c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"9ce049ee_8ab39b6c","updated":"2022-03-04 05:07:42.000000000","message":"run-Hitachi VSP CI","commit_id":"11d26b9f591f9c2626d76c2c0d40340ae99d6a64"}],"cinder/volume/drivers/hitachi/hbsd_rest.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"4d3e7dc1b26c3ffb3e7b2eba3bc257bd47c8b87c","unresolved":true,"context_lines":[{"line_number":174,"context_line":"        \u0027hitachi_rest_tcp_keepcnt\u0027,"},{"line_number":175,"context_line":"        default\u003drest_api._TCP_KEEPCNT,"},{"line_number":176,"context_line":"        help\u003d\u0027Maximum number of transmissions for TCP keepalive packet.\u0027),"},{"line_number":177,"context_line":"    cfg.ListOpt("},{"line_number":178,"context_line":"        \u0027hitachi_host_mode_options\u0027,"},{"line_number":179,"context_line":"        default\u003d[],"},{"line_number":180,"context_line":"        help\u003d\u0027Host mode option for host group or iSCSI target.\u0027),"},{"line_number":181,"context_line":"]"},{"line_number":182,"context_line":""},{"line_number":183,"context_line":"_REQUIRED_REST_OPTS \u003d ["}],"source_content_type":"text/x-python","patch_set":2,"id":"10a66276_67abdf03","line":180,"range":{"start_line":177,"start_character":4,"end_line":180,"end_character":65},"updated":"2022-03-02 15:17:19.000000000","message":"As suggested by Brian (and I also insist) on having the item_type option here to check this at service start time rather than at \"when the desired operation is requested\" time.\nRefer to oslo.config\u0027s manual https://docs.openstack.org/oslo.config/4.1.1/opts.html#oslo_config.cfg.ListOpt\n\nIf it\u0027s still confusing, the change we\u0027re looking for is,\n\nfrom oslo_config import types\n\n   cfg.ListOpt(\n        \u0027hitachi_host_mode_options\u0027,\n        item_type\u003dtypes.Integer(),\n        default\u003d[],\n        help\u003d\u0027Host mode option for host group or iSCSI target.\u0027),","commit_id":"be1eb108edf686e3fd8b1e91410e0d6ea5e931d5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0baca183b8aa0182c03dc25c050de34c04af5f56","unresolved":true,"context_lines":[{"line_number":124,"context_line":"    cfg.IntOpt("},{"line_number":125,"context_line":"        \u0027hitachi_lock_timeout\u0027,"},{"line_number":126,"context_line":"        default\u003drest_api._LOCK_TIMEOUT,"},{"line_number":127,"context_line":"        help\u003d\u0027Maximum wait time in seconds for storage to be logined or \u0027"},{"line_number":128,"context_line":"             \u0027unlocked.\u0027),"},{"line_number":129,"context_line":"    cfg.IntOpt("},{"line_number":130,"context_line":"        \u0027hitachi_rest_timeout\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"d2473dca_651504c3","line":127,"range":{"start_line":127,"start_character":61,"end_line":127,"end_character":68},"updated":"2022-03-06 12:39:05.000000000","message":"nit: logged in","commit_id":"11d26b9f591f9c2626d76c2c0d40340ae99d6a64"}],"cinder/volume/drivers/hitachi/hbsd_rest_fc.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2ac7881d2174198b065409a90ceaa6bc60bfb891","unresolved":true,"context_lines":[{"line_number":153,"context_line":"            if \u0027hostModeOptions\u0027 not in body:"},{"line_number":154,"context_line":"                body[\u0027hostModeOptions\u0027] \u003d []"},{"line_number":155,"context_line":"            for opt in self.conf.hitachi_host_mode_options:"},{"line_number":156,"context_line":"                if int(opt) not in body[\u0027hostModeOptions\u0027]:"},{"line_number":157,"context_line":"                    body[\u0027hostModeOptions\u0027].append(int(opt))"},{"line_number":158,"context_line":"        self.client.modify_host_grp(port, gid, body, ignore_all_errors\u003dTrue)"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"c7227e0c_2601016a","line":156,"range":{"start_line":156,"start_character":19,"end_line":156,"end_character":27},"updated":"2022-03-02 15:51:15.000000000","message":"This is going to raise an uncaught exception if opt can\u0027t be converted.  You could add a catch here, but it\u0027s better to make the change in the way the option list is defined so this problem can be caught before the service starts.","commit_id":"be1eb108edf686e3fd8b1e91410e0d6ea5e931d5"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"4a52ea900c4ce1cfdbdae7717bd61a14947c90ef","unresolved":false,"context_lines":[{"line_number":153,"context_line":"            if \u0027hostModeOptions\u0027 not in body:"},{"line_number":154,"context_line":"                body[\u0027hostModeOptions\u0027] \u003d []"},{"line_number":155,"context_line":"            for opt in self.conf.hitachi_host_mode_options:"},{"line_number":156,"context_line":"                if int(opt) not in body[\u0027hostModeOptions\u0027]:"},{"line_number":157,"context_line":"                    body[\u0027hostModeOptions\u0027].append(int(opt))"},{"line_number":158,"context_line":"        self.client.modify_host_grp(port, gid, body, ignore_all_errors\u003dTrue)"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"bedda9c8_a6e919d3","line":156,"range":{"start_line":156,"start_character":19,"end_line":156,"end_character":27},"in_reply_to":"c7227e0c_2601016a","updated":"2022-03-03 23:58:46.000000000","message":"I choose to adding item_type option into cfg.ListOpt.","commit_id":"be1eb108edf686e3fd8b1e91410e0d6ea5e931d5"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0baca183b8aa0182c03dc25c050de34c04af5f56","unresolved":true,"context_lines":[{"line_number":153,"context_line":"            if \u0027hostModeOptions\u0027 not in body:"},{"line_number":154,"context_line":"                body[\u0027hostModeOptions\u0027] \u003d []"},{"line_number":155,"context_line":"            for opt in self.conf.hitachi_host_mode_options:"},{"line_number":156,"context_line":"                if int(opt) not in body[\u0027hostModeOptions\u0027]:"},{"line_number":157,"context_line":"                    body[\u0027hostModeOptions\u0027].append(int(opt))"},{"line_number":158,"context_line":"        self.client.modify_host_grp(port, gid, body, ignore_all_errors\u003dTrue)"},{"line_number":159,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"6ad2ba48_5ca37d54","line":156,"range":{"start_line":156,"start_character":19,"end_line":156,"end_character":27},"updated":"2022-03-06 12:39:05.000000000","message":"the value of opt should be int now so no need of conversion","commit_id":"11d26b9f591f9c2626d76c2c0d40340ae99d6a64"}]}