)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"074ecfe2a158d9fc604fccbed43ecfce0cb0b6fe","unresolved":true,"context_lines":[{"line_number":13,"context_line":"- Wrong request ID in response header when using noauth"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The source of these issues is the fact that the request ID and the"},{"line_number":16,"context_line":"request context are set too late, or not at all, in the paster filter"},{"line_number":17,"context_line":"chain and that it"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"And the last bug is fixed as a freebie when the code in auth.py is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"2445e848_e1e3d863","line":16,"range":{"start_line":16,"start_character":56,"end_line":16,"end_character":62},"updated":"2022-02-08 20:15:59.000000000","message":"paste","commit_id":"d129d04af046a962293aceb64e044a0580417686"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"04c90d960d51544d0e3e5f77922d704f7b5b9c8c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"- Wrong request ID in response header when using noauth"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The source of these issues is the fact that the request ID and the"},{"line_number":16,"context_line":"request context are set too late, or not at all, in the paster filter"},{"line_number":17,"context_line":"chain and that it"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"And the last bug is fixed as a freebie when the code in auth.py is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"09042759_b1a86b0e","line":16,"range":{"start_line":16,"start_character":56,"end_line":16,"end_character":62},"in_reply_to":"2445e848_e1e3d863","updated":"2022-02-09 12:14:53.000000000","message":"Done","commit_id":"d129d04af046a962293aceb64e044a0580417686"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"074ecfe2a158d9fc604fccbed43ecfce0cb0b6fe","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The source of these issues is the fact that the request ID and the"},{"line_number":16,"context_line":"request context are set too late, or not at all, in the paster filter"},{"line_number":17,"context_line":"chain and that it"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"And the last bug is fixed as a freebie when the code in auth.py is"},{"line_number":20,"context_line":"refactored to reduce code duplication on setting the cinder.context key"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"529c3bb1_97a18dbf","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":17},"updated":"2022-02-08 20:15:59.000000000","message":"did you mean to end the sentence after \u0027chain\u0027?","commit_id":"d129d04af046a962293aceb64e044a0580417686"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"04c90d960d51544d0e3e5f77922d704f7b5b9c8c","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"The source of these issues is the fact that the request ID and the"},{"line_number":16,"context_line":"request context are set too late, or not at all, in the paster filter"},{"line_number":17,"context_line":"chain and that it"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"And the last bug is fixed as a freebie when the code in auth.py is"},{"line_number":20,"context_line":"refactored to reduce code duplication on setting the cinder.context key"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"93ee6da8_8b065a17","line":17,"range":{"start_line":17,"start_character":5,"end_line":17,"end_character":17},"in_reply_to":"529c3bb1_97a18dbf","updated":"2022-02-09 12:14:53.000000000","message":"seems like it.","commit_id":"d129d04af046a962293aceb64e044a0580417686"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"074ecfe2a158d9fc604fccbed43ecfce0cb0b6fe","unresolved":true,"context_lines":[{"line_number":25,"context_line":"to ensure that the context is correctly set."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Not sure if values now defined in ENV_OVERWRITES are still necessary,"},{"line_number":28,"context_line":"so the patch preserver current behavior."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Closes-Bug: #1960019"},{"line_number":31,"context_line":"Closes-Bug: #1960020"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"600e81ad_884ffbd9","line":28,"range":{"start_line":28,"start_character":13,"end_line":28,"end_character":22},"updated":"2022-02-08 20:15:59.000000000","message":"preserves","commit_id":"d129d04af046a962293aceb64e044a0580417686"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"04c90d960d51544d0e3e5f77922d704f7b5b9c8c","unresolved":false,"context_lines":[{"line_number":25,"context_line":"to ensure that the context is correctly set."},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Not sure if values now defined in ENV_OVERWRITES are still necessary,"},{"line_number":28,"context_line":"so the patch preserver current behavior."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Closes-Bug: #1960019"},{"line_number":31,"context_line":"Closes-Bug: #1960020"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"20ceb3d0_b62b51e7","line":28,"range":{"start_line":28,"start_character":13,"end_line":28,"end_character":22},"in_reply_to":"600e81ad_884ffbd9","updated":"2022-02-09 12:14:53.000000000","message":"Done","commit_id":"d129d04af046a962293aceb64e044a0580417686"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"cc70f05ffa0d76bbf526dcbf47c5bbe11aaff5c3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"641ef242_b188dc63","updated":"2022-02-08 11:44:53.000000000","message":"Setting patch to WIP as I change it to also fixes other bugs","commit_id":"1563ba634a1352b554af1ac02e27518422a2eed4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"074ecfe2a158d9fc604fccbed43ecfce0cb0b6fe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"ce17d241_15ba2e06","updated":"2022-02-08 20:15:59.000000000","message":"Some typos in the commit message; otherwise code looks fine (and very helpfully commented).","commit_id":"d129d04af046a962293aceb64e044a0580417686"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"04c90d960d51544d0e3e5f77922d704f7b5b9c8c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"d4722205_1def79e0","in_reply_to":"ce17d241_15ba2e06","updated":"2022-02-09 12:14:53.000000000","message":"Thanks, apparently I\u0027ve forgotten how to write  ;-)","commit_id":"d129d04af046a962293aceb64e044a0580417686"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"1233161b7404dece285ec56999cb426ee8d15a1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"28a84e22_03438260","updated":"2022-02-09 13:16:29.000000000","message":"Only changes were to the commit message, so I am confident that Zuul will like PS 3.\n\nRaising the priority because I don\u0027t want this to get missed before release.","commit_id":"141383cff9ab99bb49e2602299b909aa8e00a324"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"a5b3127585606afef16496f03ba64e05bbb166c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9f581456_40e2e505","updated":"2022-02-23 20:27:00.000000000","message":"Bunch of gate failures ... looks like mirror.gra1.ovh.opendev.org doesn\u0027t have a suitable version of google-api-python-client","commit_id":"18b8033b6bd1945bd27b03b779a32a883df5fb10"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"f626e4372cbc2f2fea2d10de2e3e9c122d83923d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"fb3fd542_25b1a75f","updated":"2022-02-23 20:06:36.000000000","message":"LGTM.","commit_id":"18b8033b6bd1945bd27b03b779a32a883df5fb10"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fabc351cd5b7f8bd5128e0171e2b15d17ac42da7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"3e1167c3_0dd46988","updated":"2022-02-23 22:19:10.000000000","message":"failures hit this patch pretty hard, but do not look widespread ... i think we were just unlucky","commit_id":"18b8033b6bd1945bd27b03b779a32a883df5fb10"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6b24a93ad704e26a38048e62005e2a9fd343f76c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"48930186_889a5f4c","updated":"2022-02-23 22:19:16.000000000","message":"recheck","commit_id":"18b8033b6bd1945bd27b03b779a32a883df5fb10"}],"cinder/api/middleware/auth.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"a03607d237c260bbeff6791f5c224ca3da7fbf17","unresolved":true,"context_lines":[{"line_number":114,"context_line":"    @webob.dec.wsgify(RequestClass\u003dbase_wsgi.Request)"},{"line_number":115,"context_line":"    def __call__(self, req):"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        # NOTE(jamielennox): from_environ handles these in newer versions"},{"line_number":118,"context_line":"        params \u003d {\u0027project_name\u0027: req.headers.get(\u0027X_TENANT_NAME\u0027)}"},{"line_number":119,"context_line":"        for env_name, param_name in self.ENV_OVERWRITES.items():"},{"line_number":120,"context_line":"            if req.environ.get(env_name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"e100fed2_3f7e1847","line":117,"updated":"2022-02-22 14:49:42.000000000","message":"Is this comment still applicable?","commit_id":"141383cff9ab99bb49e2602299b909aa8e00a324"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"5d90b4ffd4b01e32796178195f6728de4bb13b45","unresolved":true,"context_lines":[{"line_number":114,"context_line":"    @webob.dec.wsgify(RequestClass\u003dbase_wsgi.Request)"},{"line_number":115,"context_line":"    def __call__(self, req):"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        # NOTE(jamielennox): from_environ handles these in newer versions"},{"line_number":118,"context_line":"        params \u003d {\u0027project_name\u0027: req.headers.get(\u0027X_TENANT_NAME\u0027)}"},{"line_number":119,"context_line":"        for env_name, param_name in self.ENV_OVERWRITES.items():"},{"line_number":120,"context_line":"            if req.environ.get(env_name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"f3ed140a_d20c5286","line":117,"in_reply_to":"e100fed2_3f7e1847","updated":"2022-02-23 14:58:57.000000000","message":"As far as I know it handles HTTP_X_TENANT_NAME not X_TENANT_NAME:\n\nhttps://github.com/openstack/oslo.context/blob/3400cc28719d0fd9765c9e82527cea9fa2f44f6a/oslo_context/context.py#L446\n https://github.com/openstack/oslo.context/blob/3400cc28719d0fd9765c9e82527cea9fa2f44f6a/oslo_context/context.py#L54","commit_id":"141383cff9ab99bb49e2602299b909aa8e00a324"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"9f3f649530ece94ae9bc6c59d2735b47d8464aac","unresolved":false,"context_lines":[{"line_number":114,"context_line":"    @webob.dec.wsgify(RequestClass\u003dbase_wsgi.Request)"},{"line_number":115,"context_line":"    def __call__(self, req):"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        # NOTE(jamielennox): from_environ handles these in newer versions"},{"line_number":118,"context_line":"        params \u003d {\u0027project_name\u0027: req.headers.get(\u0027X_TENANT_NAME\u0027)}"},{"line_number":119,"context_line":"        for env_name, param_name in self.ENV_OVERWRITES.items():"},{"line_number":120,"context_line":"            if req.environ.get(env_name):"}],"source_content_type":"text/x-python","patch_set":3,"id":"9cda8dbf_1ab5cb16","line":117,"in_reply_to":"f3ed140a_d20c5286","updated":"2022-02-23 15:13:23.000000000","message":"Done","commit_id":"141383cff9ab99bb49e2602299b909aa8e00a324"}]}