)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":32966,"name":"jiang guodao","email":"jguodao@vmware.com","username":"jguodao"},"change_message_id":"35950578facf707ce0bcb530410f0e107c5d527e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"50f652fb_35e894b5","updated":"2022-02-07 05:25:50.000000000","message":"vmware-recheck-patch","commit_id":"01158875d53c6864eb91c4208bd6f86feb42efe6"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"6218ac4584e3c9dafe9e22688976c1e1921bc5eb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"0602c8cf_977533ca","updated":"2022-02-11 12:13:43.000000000","message":"1] Query: Would it be good idea to mention spec name \"hbsd:target_ports\":\n[a] either in a release note\n[b] or in commit message\n\n2] minor comment inline.","commit_id":"b1f16fa1cd30e9306fe0716a06a12aa9ff42094c"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"516d3303062f8ab8805fc897e9db18ca565797e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"9cd51df8_4abb37af","updated":"2022-02-11 08:02:17.000000000","message":"lgtm","commit_id":"b1f16fa1cd30e9306fe0716a06a12aa9ff42094c"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"5de7d54a1deca5d6e1e1f0c7b3b5f6071313d129","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"70603c3a_701358d4","updated":"2022-02-10 11:17:29.000000000","message":"run-Hitachi VSP CI","commit_id":"b1f16fa1cd30e9306fe0716a06a12aa9ff42094c"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"8d64d4cde601ea3bece14c8a3c42aa56e5971bbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"93de42f8_0b858a6a","in_reply_to":"0602c8cf_977533ca","updated":"2022-02-12 03:45:59.000000000","message":"Thank you. I update commit message including the spec name.","commit_id":"b1f16fa1cd30e9306fe0716a06a12aa9ff42094c"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"51e6f075e94dfe1fd46672357a1dee030856dda5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a88cbdeb_aff6c467","updated":"2022-02-12 06:08:33.000000000","message":"run Hitachi VSP CI","commit_id":"efda2cc9845c3972f01a8b24fbacc00f3ace16ab"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"4ff89191d989688b5f129bbbc543a153b617a0a3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"63d73207_b8836fba","updated":"2022-02-14 10:24:58.000000000","message":"run-HPE Storage CI","commit_id":"efda2cc9845c3972f01a8b24fbacc00f3ace16ab"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"ae671604ebd46c99733f512d5238a1b92818d750","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"a37258fd_9991c401","updated":"2022-02-16 09:41:13.000000000","message":"My comments have been addressed. Thanks.\nZuul \u0026 Hitachi VSP CI have passed. So +1.","commit_id":"976d3322dce8f74ed25ac06a7a893bac00205c38"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"9f3d96aad496ac49f6a3f4b2f95c105d14c6d40c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7694e6f8_f2c9d64a","updated":"2022-02-17 09:58:21.000000000","message":"run-DellEMC PowerStore CI","commit_id":"976d3322dce8f74ed25ac06a7a893bac00205c38"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"17388d38755c2d2c9ef0c1af7ecc14a39b482872","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"84257f17_9a764ad4","updated":"2022-02-25 03:57:31.000000000","message":"Code and tests look fine and third-party CI reports success.  You should probably add some documentation about the \u0027hbsd:target_ports\u0027 extra_spec (can be done in a followup).  For now, it\u0027s probably worth at least mentioning the extra spec key name in the release note.","commit_id":"3e9ee3bdaab6830f06e19b3f00179a4569544906"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b4fe6800cc5591cdc13a1be33797e4683858d15b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c75fdc1c_64b51c72","updated":"2022-02-25 03:14:24.000000000","message":"Please add a release note announcing this feature.\nhttps://docs.openstack.org/cinder/latest/contributor/releasenotes.html#drivers","commit_id":"3e9ee3bdaab6830f06e19b3f00179a4569544906"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"e9981900762e6be6e010b3ce0bb292891e7bd87a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"947a5617_dd5a1851","in_reply_to":"84257f17_9a764ad4","updated":"2022-02-25 09:35:14.000000000","message":"I added extra_spec name to release note and uploaded as patchset 7","commit_id":"3e9ee3bdaab6830f06e19b3f00179a4569544906"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"e9981900762e6be6e010b3ce0bb292891e7bd87a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"016593b7_52eeb539","in_reply_to":"c75fdc1c_64b51c72","updated":"2022-02-25 09:35:14.000000000","message":"I\u0027ve uploaded patchset7, including release note.","commit_id":"3e9ee3bdaab6830f06e19b3f00179a4569544906"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"79a03ea7c21b90ccdcb526afac56dd1c6f75f32a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"95f281e8_3e50f5cc","updated":"2022-02-25 23:54:26.000000000","message":"Release note looks good.  Only difference between PS7 and PS6 (that had passed third party CI) is the release note, which doesn\u0027t affect third party CI.","commit_id":"64bad3268eaadd2b83abdfa0f4c749aaef140e94"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"c0e667c4e9ed7c74c7cb56ff78a5125257e60d48","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b4d1db80_be5c7208","updated":"2022-02-25 12:18:01.000000000","message":"recheck","commit_id":"64bad3268eaadd2b83abdfa0f4c749aaef140e94"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b960f379c261a1c250d056f668a64b45a9ca2dd7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"35ff2ddb_f9f42065","updated":"2022-02-25 23:53:26.000000000","message":"run-Hitachi VSP CI","commit_id":"64bad3268eaadd2b83abdfa0f4c749aaef140e94"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"7e2dbe3f3678c76754eb2ead5b5f8540b7accc2f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"5538d9f6_0dcecc24","updated":"2022-03-09 15:09:12.000000000","message":"Code looks ok to me.  Will leave it to Rajat or Brian to merge since this is past FF.","commit_id":"1678260539898762dd955bf05241e16fc41769ff"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"ccd53e5787ff5369e7b5bb249fccf54fae47d758","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"980d59bc_9a7cb864","updated":"2022-03-09 22:39:27.000000000","message":"I think it was mostly a reviewing holdup, so I\u0027m ok with merging this.","commit_id":"1678260539898762dd955bf05241e16fc41769ff"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"e30f215aeb5e0e691f5310b7de1a6f0df809ba74","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":10,"id":"afe13b11_55169b43","updated":"2022-03-08 14:02:46.000000000","message":"Only change from my previous review is the version bump for the driver.  Zuul and hitachi CI are green.","commit_id":"1678260539898762dd955bf05241e16fc41769ff"}],"cinder/volume/drivers/hitachi/hbsd_common.py":[{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"326d6857cd2cee0def03d018a0069796c95202dc","unresolved":true,"context_lines":[{"line_number":807,"context_line":""},{"line_number":808,"context_line":"        tpsset \u003d set([s.strip() for s in tps.split(\u0027,\u0027)])"},{"line_number":809,"context_line":"        filtered_tps \u003d list(tpsset.intersection(target_ports))"},{"line_number":810,"context_line":"        for port in tpsset:"},{"line_number":811,"context_line":"            if port not in target_ports:"},{"line_number":812,"context_line":"                if is_snapshot:"},{"line_number":813,"context_line":"                    utils.output_log("}],"source_content_type":"text/x-python","patch_set":1,"id":"265edcc9_e1d78a5d","line":810,"updated":"2022-02-07 14:47:33.000000000","message":"nit:you can check if is_snapshot before the for loop and save checking for each port\n    if is_snapshot:\n        volume \u003d volume[\u0027volume\u0027]\u003e\nthen \n    if port not in target_ports:\n        log the msg","commit_id":"01158875d53c6864eb91c4208bd6f86feb42efe6"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"e17bd07dd41b065669e3645855c77440f259dba7","unresolved":true,"context_lines":[{"line_number":807,"context_line":""},{"line_number":808,"context_line":"        tpsset \u003d set([s.strip() for s in tps.split(\u0027,\u0027)])"},{"line_number":809,"context_line":"        filtered_tps \u003d list(tpsset.intersection(target_ports))"},{"line_number":810,"context_line":"        for port in tpsset:"},{"line_number":811,"context_line":"            if port not in target_ports:"},{"line_number":812,"context_line":"                if is_snapshot:"},{"line_number":813,"context_line":"                    utils.output_log("}],"source_content_type":"text/x-python","patch_set":1,"id":"2f3ca05e_65f0ef03","line":810,"in_reply_to":"265edcc9_e1d78a5d","updated":"2022-02-10 10:52:33.000000000","message":"Thank you for you checking.\nI revised along your comment on patchset2","commit_id":"01158875d53c6864eb91c4208bd6f86feb42efe6"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"6218ac4584e3c9dafe9e22688976c1e1921bc5eb","unresolved":true,"context_lines":[{"line_number":786,"context_line":"    def get_volume_extra_specs(self, volume):"},{"line_number":787,"context_line":"        if volume is None:"},{"line_number":788,"context_line":"            return {}"},{"line_number":789,"context_line":"        type_id \u003d volume.get(\u0027volume_type_id\u0027, None)"},{"line_number":790,"context_line":"        if type_id is None:"},{"line_number":791,"context_line":"            return {}"},{"line_number":792,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"eda2054b_b9e05249","line":789,"updated":"2022-02-11 12:13:43.000000000","message":"nit: default value of dictionary.get() is None. So, this can be simply written as:\ntype_id \u003d volume.get(\u0027volume_type_id\u0027)","commit_id":"b1f16fa1cd30e9306fe0716a06a12aa9ff42094c"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"ae671604ebd46c99733f512d5238a1b92818d750","unresolved":false,"context_lines":[{"line_number":786,"context_line":"    def get_volume_extra_specs(self, volume):"},{"line_number":787,"context_line":"        if volume is None:"},{"line_number":788,"context_line":"            return {}"},{"line_number":789,"context_line":"        type_id \u003d volume.get(\u0027volume_type_id\u0027, None)"},{"line_number":790,"context_line":"        if type_id is None:"},{"line_number":791,"context_line":"            return {}"},{"line_number":792,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"25251a3a_bb54d5e2","line":789,"in_reply_to":"a8289a67_6183ca3a","updated":"2022-02-16 09:41:13.000000000","message":"Done","commit_id":"b1f16fa1cd30e9306fe0716a06a12aa9ff42094c"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"3083ef432a746ddfd5be9ce2dea796f7f6372afa","unresolved":true,"context_lines":[{"line_number":786,"context_line":"    def get_volume_extra_specs(self, volume):"},{"line_number":787,"context_line":"        if volume is None:"},{"line_number":788,"context_line":"            return {}"},{"line_number":789,"context_line":"        type_id \u003d volume.get(\u0027volume_type_id\u0027, None)"},{"line_number":790,"context_line":"        if type_id is None:"},{"line_number":791,"context_line":"            return {}"},{"line_number":792,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"a8289a67_6183ca3a","line":789,"in_reply_to":"eda2054b_b9e05249","updated":"2022-02-15 04:29:54.000000000","message":"Thank you for checking. I revised along your comment as patchset5. Please check it","commit_id":"b1f16fa1cd30e9306fe0716a06a12aa9ff42094c"}],"cinder/volume/drivers/hitachi/hbsd_fc.py":[{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"2fb918353347a92cd09f1f6b6cd5979a9564426c","unresolved":true,"context_lines":[{"line_number":68,"context_line":"                API for communication with the storage backend."},{"line_number":69,"context_line":"        2.1.0 - Add Cinder generic volume groups."},{"line_number":70,"context_line":"        2.2.0 - Add maintenance parameters."},{"line_number":71,"context_line":"        2.2.1 - Make the parameters name variable for supporting OEM storages."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    \"\"\""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"d4a04599_b3428887","line":71,"updated":"2022-03-07 15:44:11.000000000","message":"I would bump the version of the driver with this change","commit_id":"f9fdd0b6e7e3f5b40041c2033999c4c7f7121737"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"124251952c4f4157c75366f3943168fe3e76ade7","unresolved":true,"context_lines":[{"line_number":68,"context_line":"                API for communication with the storage backend."},{"line_number":69,"context_line":"        2.1.0 - Add Cinder generic volume groups."},{"line_number":70,"context_line":"        2.2.0 - Add maintenance parameters."},{"line_number":71,"context_line":"        2.2.1 - Make the parameters name variable for supporting OEM storages."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    \"\"\""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"a9cfd249_9a63a3d5","line":71,"in_reply_to":"056a554a_58c53117","updated":"2022-03-08 05:50:19.000000000","message":"I\u0027ve uploaded following patch because the driver version in the patch had been 2.2.1, either.\n\nhttps://review.opendev.org/c/openstack/cinder/+/828696","commit_id":"f9fdd0b6e7e3f5b40041c2033999c4c7f7121737"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"97c801aea0d99b615dfb665affe8d0342f7be97b","unresolved":true,"context_lines":[{"line_number":68,"context_line":"                API for communication with the storage backend."},{"line_number":69,"context_line":"        2.1.0 - Add Cinder generic volume groups."},{"line_number":70,"context_line":"        2.2.0 - Add maintenance parameters."},{"line_number":71,"context_line":"        2.2.1 - Make the parameters name variable for supporting OEM storages."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    \"\"\""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"056a554a_58c53117","line":71,"in_reply_to":"d4a04599_b3428887","updated":"2022-03-07 23:57:00.000000000","message":"I\u0027ll upload a patchset whose version is 2.2.2","commit_id":"f9fdd0b6e7e3f5b40041c2033999c4c7f7121737"}],"cinder/volume/drivers/hitachi/hbsd_iscsi.py":[{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"326d6857cd2cee0def03d018a0069796c95202dc","unresolved":true,"context_lines":[{"line_number":222,"context_line":"    @volume_utils.trace"},{"line_number":223,"context_line":"    def initialize_connection_snapshot(self, snapshot, connector, **kwargs):"},{"line_number":224,"context_line":"        \"\"\"Initialize connection between the server and the snapshot.\"\"\""},{"line_number":225,"context_line":"        return self.common.initialize_connection(snapshot, connector, True)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    @volume_utils.trace"},{"line_number":228,"context_line":"    def terminate_connection_snapshot(self, snapshot, connector, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"580f7ba3_4c76c4d6","line":225,"updated":"2022-02-07 14:47:33.000000000","message":"nit: it will be more readable to add here is_snapshot\u003dTrue\nto have some context of what is \"True\" stand for","commit_id":"01158875d53c6864eb91c4208bd6f86feb42efe6"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"e17bd07dd41b065669e3645855c77440f259dba7","unresolved":true,"context_lines":[{"line_number":222,"context_line":"    @volume_utils.trace"},{"line_number":223,"context_line":"    def initialize_connection_snapshot(self, snapshot, connector, **kwargs):"},{"line_number":224,"context_line":"        \"\"\"Initialize connection between the server and the snapshot.\"\"\""},{"line_number":225,"context_line":"        return self.common.initialize_connection(snapshot, connector, True)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"    @volume_utils.trace"},{"line_number":228,"context_line":"    def terminate_connection_snapshot(self, snapshot, connector, **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"a3520bed_eb1d6e56","line":225,"in_reply_to":"580f7ba3_4c76c4d6","updated":"2022-02-10 10:52:33.000000000","message":"Thank you for you checking.\nI revised along your comment on patchset2.","commit_id":"01158875d53c6864eb91c4208bd6f86feb42efe6"},{"author":{"_account_id":5997,"name":"Walt","display_name":"Hemna","email":"waboring@hemna.com","username":"walter-boring","status":"SAP"},"change_message_id":"2fb918353347a92cd09f1f6b6cd5979a9564426c","unresolved":true,"context_lines":[{"line_number":68,"context_line":"                API for communication with the storage backend."},{"line_number":69,"context_line":"        2.1.0 - Add Cinder generic volume groups."},{"line_number":70,"context_line":"        2.2.0 - Add maintenance parameters."},{"line_number":71,"context_line":"        2.2.1 - Make the parameters name variable for supporting OEM storages."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    \"\"\""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"afd6979a_3c559c41","line":71,"updated":"2022-03-07 15:44:11.000000000","message":"would bump the version of this driver with this change","commit_id":"f9fdd0b6e7e3f5b40041c2033999c4c7f7121737"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"97c801aea0d99b615dfb665affe8d0342f7be97b","unresolved":true,"context_lines":[{"line_number":68,"context_line":"                API for communication with the storage backend."},{"line_number":69,"context_line":"        2.1.0 - Add Cinder generic volume groups."},{"line_number":70,"context_line":"        2.2.0 - Add maintenance parameters."},{"line_number":71,"context_line":"        2.2.1 - Make the parameters name variable for supporting OEM storages."},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"    \"\"\""},{"line_number":74,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"b2d63b3f_3f627165","line":71,"in_reply_to":"afd6979a_3c559c41","updated":"2022-03-07 23:57:00.000000000","message":"I\u0027ll upload a patchset whose version is 2.2.2","commit_id":"f9fdd0b6e7e3f5b40041c2033999c4c7f7121737"}],"cinder/volume/drivers/hitachi/hbsd_utils.py":[{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"dc1b27efd9739a404a8d351a02354d9dd6967764","unresolved":true,"context_lines":[{"line_number":29,"context_line":"CI_WIKI_NAME \u003d \u0027Hitachi_VSP_CI\u0027"},{"line_number":30,"context_line":"PARAM_PREFIX \u003d \u0027hitachi\u0027"},{"line_number":31,"context_line":"VENDOR_NAME \u003d \u0027Hitachi\u0027"},{"line_number":32,"context_line":"DRIVER_DIR_NAME \u003d \"hbsd\""},{"line_number":33,"context_line":"DRIVER_PREFIX \u003d \u0027HBSD\u0027"},{"line_number":34,"context_line":"DRIVER_FILE_PREFIX \u003d \u0027hbsd\u0027"},{"line_number":35,"context_line":"TARGET_PREFIX \u003d \u0027HBSD-\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"43539322_9b649915","line":32,"updated":"2022-02-18 09:02:36.000000000","message":"Shouldn\u0027t hbsd value be enclosed in \u0027 \u0027? Other parameters are enclosed in \u0027 \u0027.","commit_id":"976d3322dce8f74ed25ac06a7a893bac00205c38"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"b06c5a407e873fd278cfd87c36baf769ae0166ec","unresolved":true,"context_lines":[{"line_number":29,"context_line":"CI_WIKI_NAME \u003d \u0027Hitachi_VSP_CI\u0027"},{"line_number":30,"context_line":"PARAM_PREFIX \u003d \u0027hitachi\u0027"},{"line_number":31,"context_line":"VENDOR_NAME \u003d \u0027Hitachi\u0027"},{"line_number":32,"context_line":"DRIVER_DIR_NAME \u003d \"hbsd\""},{"line_number":33,"context_line":"DRIVER_PREFIX \u003d \u0027HBSD\u0027"},{"line_number":34,"context_line":"DRIVER_FILE_PREFIX \u003d \u0027hbsd\u0027"},{"line_number":35,"context_line":"TARGET_PREFIX \u003d \u0027HBSD-\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"aeedc14a_35fb2822","line":32,"in_reply_to":"43539322_9b649915","updated":"2022-02-21 10:20:13.000000000","message":"Thank you for checking our code.\nI\u0027ve uploaded fixed code along your comment as patchset6.","commit_id":"976d3322dce8f74ed25ac06a7a893bac00205c38"},{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"3595987cd67a813ee2a8491f7c884be7b48d3b72","unresolved":false,"context_lines":[{"line_number":29,"context_line":"CI_WIKI_NAME \u003d \u0027Hitachi_VSP_CI\u0027"},{"line_number":30,"context_line":"PARAM_PREFIX \u003d \u0027hitachi\u0027"},{"line_number":31,"context_line":"VENDOR_NAME \u003d \u0027Hitachi\u0027"},{"line_number":32,"context_line":"DRIVER_DIR_NAME \u003d \"hbsd\""},{"line_number":33,"context_line":"DRIVER_PREFIX \u003d \u0027HBSD\u0027"},{"line_number":34,"context_line":"DRIVER_FILE_PREFIX \u003d \u0027hbsd\u0027"},{"line_number":35,"context_line":"TARGET_PREFIX \u003d \u0027HBSD-\u0027"}],"source_content_type":"text/x-python","patch_set":5,"id":"db2e415c_445a9d5e","line":32,"in_reply_to":"aeedc14a_35fb2822","updated":"2022-02-22 01:15:48.000000000","message":"Done","commit_id":"976d3322dce8f74ed25ac06a7a893bac00205c38"}]}