)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9a004f008bdd0bd6e61e32b0b1d986584ffb0098","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Hitachi: Support AIX as host OS type"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This patch support AIX as host OS type for the Hitachi VSP driver."},{"line_number":10,"context_line":"When running \"cinder attachment-create\" command with the option \"--ostype aix\","},{"line_number":11,"context_line":"\"AIX\" is set as host OS type."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"Implements: blueprint hitachi-vsp-aix-os-type"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"cea01116_afe1d803","line":10,"range":{"start_line":10,"start_character":0,"end_line":10,"end_character":79},"updated":"2022-03-07 15:51:36.000000000","message":"We usually don\u0027t run it directly and most of the times it\u0027s nova doing the attachment create call, since brick detects the os-type, this should be fine but I\u0027m curious about the use case when this command is used in actual deployments?","commit_id":"5c48b6fc32b474b7f6f0995dc24d52aeb282b228"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"70a4cbf00cd3e0cc78752f83deba54b1988a23d4","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b3790aad_77644ac7","updated":"2022-02-18 08:55:16.000000000","message":"You need to add the test code updates to this patch.","commit_id":"07d1e85cf3516059c0d1435dba99170500348efe"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"444c0696ea61202697f5c6f7842dcaf800170970","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"eea39fba_7afb7575","updated":"2022-02-12 06:07:21.000000000","message":"run Hitachi VSP CI","commit_id":"07d1e85cf3516059c0d1435dba99170500348efe"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"4af029f65fa897283e183f9dc64da0f6256f4363","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"58b302bb_b983abcc","updated":"2022-02-10 10:56:54.000000000","message":"run-Hitachi VSP CI","commit_id":"07d1e85cf3516059c0d1435dba99170500348efe"},{"author":{"_account_id":32966,"name":"jiang guodao","email":"jguodao@vmware.com","username":"jguodao"},"change_message_id":"47a2b10b91686f4619c3647e84a6f83d27733199","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e18a8c66_87529a8c","updated":"2022-02-07 05:16:37.000000000","message":"vmware-recheck-patch","commit_id":"07d1e85cf3516059c0d1435dba99170500348efe"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"9eeeaadf882479b4f9df48df1fe3d2e4cc4ea0d8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"05a72abb_3c6b642e","in_reply_to":"b3790aad_77644ac7","updated":"2022-02-21 10:15:01.000000000","message":"Thank you for checking our code.\nI uploaded thest codes as patcheset3.","commit_id":"07d1e85cf3516059c0d1435dba99170500348efe"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"7960d7e037704d3d13181d8513f51b40bf6d06e9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"46399ccb_269f5b77","updated":"2022-02-25 04:57:52.000000000","message":"Needs a release note:\nhttps://docs.openstack.org/cinder/latest/contributor/releasenotes.html#drivers\n\nOtherwise, looks pretty straightforward and the CI is green.","commit_id":"ecfdc3b3b0969deaec078b7a84297e5968a18784"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"fda9570050bae85199c4ce118aac01b35eafc726","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"da21b22a_44c6ada9","in_reply_to":"46399ccb_269f5b77","updated":"2022-02-25 08:05:01.000000000","message":"I\u0027ve uploaded new patchset6 including release note.\n(release note in patchset5 would has CR+LF, and removed one is in patchset6)","commit_id":"ecfdc3b3b0969deaec078b7a84297e5968a18784"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3cad56132c338ba9e2983514b2cdd4791abdd0cd","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"c2d67f8a_82d96d42","updated":"2022-02-25 23:56:01.000000000","message":"Release note looks good, third-party CI is passing.","commit_id":"4e1d35e4dfb822ca870fcf5b54d93cdde9283377"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"ad08d9c7d170317e0cf2b967a429f1e226c4ec0d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"4181ac4e_2444ddc8","updated":"2022-02-25 12:14:49.000000000","message":"recheck","commit_id":"4e1d35e4dfb822ca870fcf5b54d93cdde9283377"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"3255df8e8f4ec45efe81b86543f79df7f0616617","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"e4799954_f297d631","updated":"2022-02-25 08:09:09.000000000","message":"recheck","commit_id":"4e1d35e4dfb822ca870fcf5b54d93cdde9283377"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9a004f008bdd0bd6e61e32b0b1d986584ffb0098","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"22565584_87350429","updated":"2022-03-07 15:51:36.000000000","message":"Question/suggestions inline","commit_id":"5c48b6fc32b474b7f6f0995dc24d52aeb282b228"}],"cinder/volume/drivers/hitachi/hbsd_rest_fc.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9a004f008bdd0bd6e61e32b0b1d986584ffb0098","unresolved":true,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def set_target_mode(self, port, gid, connector):"},{"line_number":148,"context_line":"        \"\"\"Configure the host group to meet the environment.\"\"\""},{"line_number":149,"context_line":"        if connector.get(\u0027os_type\u0027, None) \u003d\u003d \u0027aix\u0027:"},{"line_number":150,"context_line":"            body \u003d {\u0027hostMode\u0027: \u0027AIX\u0027}"},{"line_number":151,"context_line":"        else:"},{"line_number":152,"context_line":"            body \u003d {\u0027hostMode\u0027: \u0027LINUX/IRIX\u0027}"}],"source_content_type":"text/x-python","patch_set":7,"id":"939df7fc_ec68b0f1","line":149,"range":{"start_line":149,"start_character":46,"end_line":149,"end_character":49},"updated":"2022-03-07 15:51:36.000000000","message":"is this guaranteed to be lower case \u0027aix\u0027, if unsure we can convert the os_type value to lowercase first and then compare\n\nif connector.get(\u0027os_type\u0027, \u0027\u0027).lower() \u003d\u003d \u0027aix\u0027","commit_id":"5c48b6fc32b474b7f6f0995dc24d52aeb282b228"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9a004f008bdd0bd6e61e32b0b1d986584ffb0098","unresolved":true,"context_lines":[{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def set_target_mode(self, port, gid, connector):"},{"line_number":148,"context_line":"        \"\"\"Configure the host group to meet the environment.\"\"\""},{"line_number":149,"context_line":"        if connector.get(\u0027os_type\u0027, None) \u003d\u003d \u0027aix\u0027:"},{"line_number":150,"context_line":"            body \u003d {\u0027hostMode\u0027: \u0027AIX\u0027}"},{"line_number":151,"context_line":"        else:"},{"line_number":152,"context_line":"            body \u003d {\u0027hostMode\u0027: \u0027LINUX/IRIX\u0027}"},{"line_number":153,"context_line":"        if self.conf.hitachi_rest_disable_io_wait:"},{"line_number":154,"context_line":"            body[\u0027hostModeOptions\u0027] \u003d [_FC_HMO_DISABLE_IO]"},{"line_number":155,"context_line":"        if self.conf.hitachi_host_mode_options:"}],"source_content_type":"text/x-python","patch_set":7,"id":"942291da_b2d460cd","line":152,"range":{"start_line":149,"start_character":0,"end_line":152,"end_character":45},"updated":"2022-03-07 15:51:36.000000000","message":"body \u003d {\u0027hostMode\u0027: \u0027LINUX/IRIX\u0027}\nif connector.get(\u0027os_type\u0027, None) \u003d\u003d \u0027aix\u0027:\n    body[\u0027hostMode\u0027] \u003d \u0027AIX\u0027","commit_id":"5c48b6fc32b474b7f6f0995dc24d52aeb282b228"}],"cinder/volume/drivers/hitachi/hbsd_rest_iscsi.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9a004f008bdd0bd6e61e32b0b1d986584ffb0098","unresolved":true,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def set_target_mode(self, port, gid, connector):"},{"line_number":120,"context_line":"        \"\"\"Configure the iSCSI target to meet the environment.\"\"\""},{"line_number":121,"context_line":"        if connector.get(\u0027os_type\u0027, None) \u003d\u003d \u0027aix\u0027:"},{"line_number":122,"context_line":"            host_mode \u003d \u0027AIX\u0027"},{"line_number":123,"context_line":"        else:"},{"line_number":124,"context_line":"            host_mode \u003d \u0027LINUX/IRIX\u0027"},{"line_number":125,"context_line":"        body \u003d {\u0027hostMode\u0027: host_mode,"},{"line_number":126,"context_line":"                \u0027hostModeOptions\u0027: [_ISCSI_HMO_REPORT_FULL_PORTAL]}"},{"line_number":127,"context_line":"        if self.conf.hitachi_rest_disable_io_wait:"}],"source_content_type":"text/x-python","patch_set":7,"id":"aab96d7d_e431e392","line":124,"range":{"start_line":121,"start_character":0,"end_line":124,"end_character":36},"updated":"2022-03-07 15:51:36.000000000","message":"better to do it like,\n\nhost_mode \u003d \u0027LINUX/IRIX\u0027\nif connector.get(\u0027os_type\u0027, None) \u003d\u003d \u0027aix\u0027:\n            host_mode \u003d \u0027AIX\u0027","commit_id":"5c48b6fc32b474b7f6f0995dc24d52aeb282b228"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dfc80552b995950bd61a6ff1d3e1ae213a6f7886","unresolved":true,"context_lines":[{"line_number":118,"context_line":""},{"line_number":119,"context_line":"    def set_target_mode(self, port, gid, connector):"},{"line_number":120,"context_line":"        \"\"\"Configure the iSCSI target to meet the environment.\"\"\""},{"line_number":121,"context_line":"        if connector.get(\u0027os_type\u0027, None) \u003d\u003d \u0027aix\u0027:"},{"line_number":122,"context_line":"            host_mode \u003d \u0027AIX\u0027"},{"line_number":123,"context_line":"        else:"},{"line_number":124,"context_line":"            host_mode \u003d \u0027LINUX/IRIX\u0027"},{"line_number":125,"context_line":"        body \u003d {\u0027hostMode\u0027: host_mode,"},{"line_number":126,"context_line":"                \u0027hostModeOptions\u0027: [_ISCSI_HMO_REPORT_FULL_PORTAL]}"},{"line_number":127,"context_line":"        if self.conf.hitachi_rest_disable_io_wait:"}],"source_content_type":"text/x-python","patch_set":7,"id":"294d0227_f6c11693","line":124,"range":{"start_line":121,"start_character":0,"end_line":124,"end_character":36},"in_reply_to":"aab96d7d_e431e392","updated":"2022-03-07 15:53:37.000000000","message":"can even be done as a single liner but would affect readability,\nhost_mode \u003d \u0027AIX\u0027 if connector.get(\u0027os_type\u0027, None) \u003d\u003d \u0027aix\u0027 else \u0027LINUX/IRIX\u0027","commit_id":"5c48b6fc32b474b7f6f0995dc24d52aeb282b228"}]}