)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"082e5ee11f96fb6f4a0b16d3fa631808971ae5bc","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     yuval brave \u003cyuval@lightbitslabs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-02-09 11:34:46 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Followup - remove \"hostnqn\" extra key"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Lightos connector created a new key in the connection_properties dict"},{"line_number":10,"context_line":"called \"hostnqn\" this key is a duplication of the \"nqn\" key created"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"b6c050bf_abd0e1ac","line":7,"updated":"2022-02-09 13:52:17.000000000","message":"For driver patches, it\u0027s helpful to put the driver name in the subject line.  Also, there\u0027s a little more going on in this patch now, so maybe:\n\n[Lightos] standardize connector usage","commit_id":"73de5288704247d6fda6d11d37039603dda82005"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0ec5042d8eea2810ff52fffa9c5f5f67311c0994","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     yuval brave \u003cyuval@lightbitslabs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-02-09 11:34:46 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Followup - remove \"hostnqn\" extra key"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Lightos connector created a new key in the connection_properties dict"},{"line_number":10,"context_line":"called \"hostnqn\" this key is a duplication of the \"nqn\" key created"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"43a69450_c1c05896","line":7,"in_reply_to":"b6c050bf_abd0e1ac","updated":"2022-02-09 21:07:03.000000000","message":"Done","commit_id":"73de5288704247d6fda6d11d37039603dda82005"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"082e5ee11f96fb6f4a0b16d3fa631808971ae5bc","unresolved":true,"context_lines":[{"line_number":10,"context_line":"called \"hostnqn\" this key is a duplication of the \"nqn\" key created"},{"line_number":11,"context_line":"in \"nvmeof\" connector."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This commit remove the use of \"hostnqn\" for \"nqn\"."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"There was a use of the key \"nqn\" in a differen context and it"},{"line_number":16,"context_line":"was change to \"nqn\"-\u003e \"subsysnqn\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"b1dac323_5229af81","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":50},"updated":"2022-02-09 13:52:17.000000000","message":"I suggest moving this into the above paragraph.","commit_id":"73de5288704247d6fda6d11d37039603dda82005"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0ec5042d8eea2810ff52fffa9c5f5f67311c0994","unresolved":false,"context_lines":[{"line_number":10,"context_line":"called \"hostnqn\" this key is a duplication of the \"nqn\" key created"},{"line_number":11,"context_line":"in \"nvmeof\" connector."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"This commit remove the use of \"hostnqn\" for \"nqn\"."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"There was a use of the key \"nqn\" in a differen context and it"},{"line_number":16,"context_line":"was change to \"nqn\"-\u003e \"subsysnqn\""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"ff5a920b_d03ef18a","line":13,"range":{"start_line":13,"start_character":0,"end_line":13,"end_character":50},"in_reply_to":"b1dac323_5229af81","updated":"2022-02-09 21:07:03.000000000","message":"Done","commit_id":"73de5288704247d6fda6d11d37039603dda82005"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"082e5ee11f96fb6f4a0b16d3fa631808971ae5bc","unresolved":true,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"There was a use of the key \"nqn\" in a differen context and it"},{"line_number":16,"context_line":"was change to \"nqn\"-\u003e \"subsysnqn\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Signed-off-by: Yuval Brave  \u003cyuval@lightbitslabs.com\u003e"},{"line_number":19,"context_line":"Depends-On: Ia4d8c6fda875b4f4d32d511ca9282ca0fb5d6f12"},{"line_number":20,"context_line":"Change-Id: I68f6cb9a7da56966827bb8683da44e6852549cc4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"4a3da237_54bfd099","line":17,"updated":"2022-02-09 13:52:17.000000000","message":"Add something like:\n\nThe driver had used a connector function outside the standard connector interface.  It now gets the info supplied by that function from the standard get_connector_properties().","commit_id":"73de5288704247d6fda6d11d37039603dda82005"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0ec5042d8eea2810ff52fffa9c5f5f67311c0994","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"There was a use of the key \"nqn\" in a differen context and it"},{"line_number":16,"context_line":"was change to \"nqn\"-\u003e \"subsysnqn\""},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Signed-off-by: Yuval Brave  \u003cyuval@lightbitslabs.com\u003e"},{"line_number":19,"context_line":"Depends-On: Ia4d8c6fda875b4f4d32d511ca9282ca0fb5d6f12"},{"line_number":20,"context_line":"Change-Id: I68f6cb9a7da56966827bb8683da44e6852549cc4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"2afe6208_a0afec7f","line":17,"in_reply_to":"4a3da237_54bfd099","updated":"2022-02-09 21:07:03.000000000","message":"Done","commit_id":"73de5288704247d6fda6d11d37039603dda82005"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"3be9faa433f8ad4a3bb3094348424e7aa3c47a73","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"893b4c0d_f87641df","updated":"2022-02-07 09:09:18.000000000","message":"LGTM","commit_id":"c42738e73bfa295434bf49ffd0420e0d830dadc7"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"07bc1e575898349e7b7dd3cf80d57546396fda38","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"7a763da0_f2b75e57","updated":"2022-02-07 08:43:52.000000000","message":"recheck 828085","commit_id":"c42738e73bfa295434bf49ffd0420e0d830dadc7"},{"author":{"_account_id":32966,"name":"jiang guodao","email":"jguodao@vmware.com","username":"jguodao"},"change_message_id":"10beca3dd169eaa8b1f73256b1add85a51f13778","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e726bb99_3aaab965","updated":"2022-02-09 02:35:31.000000000","message":"vmware-recheck-patch","commit_id":"8390db1293b9f8970805fd7bd15ac741eaffeeba"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"082e5ee11f96fb6f4a0b16d3fa631808971ae5bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"0fa2d38b_cd01c45e","updated":"2022-02-09 13:52:17.000000000","message":"Some suggestions inline for revising the commit message.  You need to put up a new patch set to address the unit test failures.","commit_id":"73de5288704247d6fda6d11d37039603dda82005"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"e7b21fe1fead23d35f340e7709749cb546e05067","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"66011347_4b5db292","updated":"2022-02-09 13:00:55.000000000","message":"recheck 828085","commit_id":"73de5288704247d6fda6d11d37039603dda82005"},{"author":{"_account_id":34470,"name":"Yan Tseitlin","email":"yan@lightbitslabs.com","username":"yants"},"change_message_id":"deb8cac9c275b13d8ca7575a2639c5fccd8a9bbb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"d9febd0a_e547cc58","updated":"2022-02-09 13:00:01.000000000","message":"run-Lightbits CI","commit_id":"73de5288704247d6fda6d11d37039603dda82005"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"0ec5042d8eea2810ff52fffa9c5f5f67311c0994","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"ac47ed3b_87bac4cb","updated":"2022-02-09 21:07:03.000000000","message":"Changes look good; Zuul and Lightbits CI are green.","commit_id":"2aa10bb68ec8125ba2658f0c6980a570250b8c88"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"142d2c40dd3c2a859d29740b1c0058ca49833d21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"d987ead4_c0147468","updated":"2022-02-10 11:28:39.000000000","message":"Sorry, but I don\u0027t think using \"nqn\" for the connecting host\u0027s nqn in the connection dict makes sense, and I think it can lead to misunderstandings when debugging things.\n\nExisting \"hostnqn\" seems more reasonable to me.","commit_id":"2aa10bb68ec8125ba2658f0c6980a570250b8c88"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"3fd31bc6125d2352a35af3007c595033803e5d62","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"be0e3fb2_c9afd351","updated":"2022-02-10 14:42:46.000000000","message":"removed","commit_id":"2aa10bb68ec8125ba2658f0c6980a570250b8c88"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"b5e1e7f289e2738abd7194aaf7bba110bc1f2187","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"956670f3_7ebfbec7","updated":"2022-02-10 15:06:05.000000000","message":"LGTM","commit_id":"08ce8e43703e796bcf1e614425c735ba1abb2def"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"147531773ea1aca9c94818944a8c745cf5855f4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"000e9d1a_4d6878fd","updated":"2022-02-10 15:14:46.000000000","message":"run-Lightbits CI","commit_id":"08ce8e43703e796bcf1e614425c735ba1abb2def"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"11293c74d725e6f8f46f087938c4a34e06701492","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"f24cc31e_cdd29e0a","updated":"2022-02-14 17:01:05.000000000","message":"Carrying over Gorka\u0027s +2 from PS8.  Zuul and third-party CI are happy.","commit_id":"e0f9e0ce5fd73e4ed3e66f94d45d3a61e5ec6ebe"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"8e1cee4a953f5885c3884d4445acb967f1340db0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"72033806_4877ecb2","updated":"2022-02-15 02:19:09.000000000","message":"Dependency has merged.","commit_id":"e0f9e0ce5fd73e4ed3e66f94d45d3a61e5ec6ebe"},{"author":{"_account_id":7198,"name":"Jay Bryant","email":"jungleboyj@electronicjungle.net","username":"jsbryant"},"change_message_id":"15b361088f41356b59af012ce2bd597b6cf766b7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4290c2c6_11515737","updated":"2022-02-14 15:30:08.000000000","message":"This change looks ok to me.","commit_id":"e0f9e0ce5fd73e4ed3e66f94d45d3a61e5ec6ebe"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"dbf24295f0b9439af2d476a65083af7f293c8c6e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"4315bc98_312e0475","updated":"2022-02-15 02:19:18.000000000","message":"recheck","commit_id":"e0f9e0ce5fd73e4ed3e66f94d45d3a61e5ec6ebe"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"64fe9832ad1c420ddc5b2fc8db4434239f060b21","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"69997629_981e8b6a","updated":"2022-02-11 09:13:44.000000000","message":"recheck","commit_id":"e0f9e0ce5fd73e4ed3e66f94d45d3a61e5ec6ebe"},{"author":{"_account_id":22248,"name":"HPE AlletraMP iSCSI CI","email":"hp.cinder.blr.ci@groups.ext.hpe.com","username":"hp-storage-blr-ci","tags":["SERVICE_USER"]},"change_message_id":"6432f8e0c119334bc0e11cf5a2e89d1bd3534e4d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":9,"id":"3aafe997_4b7c81f4","updated":"2022-02-21 07:04:51.000000000","message":"run-HPE Nimble Storage CI","commit_id":"e0f9e0ce5fd73e4ed3e66f94d45d3a61e5ec6ebe"}],"cinder/volume/drivers/lightos.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e30aa193e5350d41088c6817220719e8480fc1f5","unresolved":true,"context_lines":[{"line_number":1009,"context_line":"        server_properties[\u0027lightos_nodes\u0027] \u003d lightos_targets"},{"line_number":1010,"context_line":"        server_properties[\u0027uuid\u0027] \u003d ("},{"line_number":1011,"context_line":"            self._get_lightos_uuid(project_name, volume))"},{"line_number":1012,"context_line":"        server_properties[\u0027subsysnqn\u0027] \u003d self.cluster.subsystemNQN"},{"line_number":1013,"context_line":""},{"line_number":1014,"context_line":"        return server_properties"},{"line_number":1015,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"437b115b_63a20d56","line":1012,"updated":"2022-02-08 14:56:18.000000000","message":"This would be a breaking change, since a nova service running old os-brick connector would fail to connect with this new connection information.\n\nSince se haven\u0027t actually released os-brick we can just be careful when merging these 2 patches.","commit_id":"7a8957933547b91b5d247501e983d473a468ad7d"},{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"29aead65dc42a8eebcab3c567647e0ba945cba10","unresolved":false,"context_lines":[{"line_number":1009,"context_line":"        server_properties[\u0027lightos_nodes\u0027] \u003d lightos_targets"},{"line_number":1010,"context_line":"        server_properties[\u0027uuid\u0027] \u003d ("},{"line_number":1011,"context_line":"            self._get_lightos_uuid(project_name, volume))"},{"line_number":1012,"context_line":"        server_properties[\u0027subsysnqn\u0027] \u003d self.cluster.subsystemNQN"},{"line_number":1013,"context_line":""},{"line_number":1014,"context_line":"        return server_properties"},{"line_number":1015,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"236a5335_5677a342","line":1012,"in_reply_to":"437b115b_63a20d56","updated":"2022-02-09 08:22:43.000000000","message":"Yes, that\u0027s the plan, merge these before the next release.","commit_id":"7a8957933547b91b5d247501e983d473a468ad7d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e30aa193e5350d41088c6817220719e8480fc1f5","unresolved":true,"context_lines":[{"line_number":1412,"context_line":"            raise exception.VolumeBackendAPIException(message\u003d_(msg))"},{"line_number":1413,"context_line":""},{"line_number":1414,"context_line":"        props \u003d self._get_connection_properties(project_name, volume)"},{"line_number":1415,"context_line":"        props[\u0027nqn\u0027] \u003d hostnqn"},{"line_number":1416,"context_line":"        return {\u0027driver_volume_type\u0027: (\u0027lightos\u0027), \u0027data\u0027: props}"},{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"    def terminate_connection(self, volume, connector, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"a8572082_7da28a08","line":1415,"updated":"2022-02-08 14:56:18.000000000","message":"I liked the hostnqn naming better, because within the connection information the nqn would make sense for refer to the storage system, and so to differentiate things we would need to name the one from the connector as hostnqn","commit_id":"7a8957933547b91b5d247501e983d473a468ad7d"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"3fd31bc6125d2352a35af3007c595033803e5d62","unresolved":false,"context_lines":[{"line_number":1412,"context_line":"            raise exception.VolumeBackendAPIException(message\u003d_(msg))"},{"line_number":1413,"context_line":""},{"line_number":1414,"context_line":"        props \u003d self._get_connection_properties(project_name, volume)"},{"line_number":1415,"context_line":"        props[\u0027nqn\u0027] \u003d hostnqn"},{"line_number":1416,"context_line":"        return {\u0027driver_volume_type\u0027: (\u0027lightos\u0027), \u0027data\u0027: props}"},{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"    def terminate_connection(self, volume, connector, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"6b74e417_ccde354c","line":1415,"in_reply_to":"56a85110_878bd6cf","updated":"2022-02-10 14:42:46.000000000","message":"Done","commit_id":"7a8957933547b91b5d247501e983d473a468ad7d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"e2cb29f96b9d46680f6558786020a48691126b84","unresolved":true,"context_lines":[{"line_number":1412,"context_line":"            raise exception.VolumeBackendAPIException(message\u003d_(msg))"},{"line_number":1413,"context_line":""},{"line_number":1414,"context_line":"        props \u003d self._get_connection_properties(project_name, volume)"},{"line_number":1415,"context_line":"        props[\u0027nqn\u0027] \u003d hostnqn"},{"line_number":1416,"context_line":"        return {\u0027driver_volume_type\u0027: (\u0027lightos\u0027), \u0027data\u0027: props}"},{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"    def terminate_connection(self, volume, connector, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"56a85110_878bd6cf","line":1415,"in_reply_to":"946a40a5_bea380c0","updated":"2022-02-10 12:01:32.000000000","message":"I\u0027m OK with leaving it as it is or removing it.\n\nI assumed you were sending it in the connection info to be able to check, in the future, on the os-brick connector that the connection info was created for the specific host.\n\nIn other words, in the dsc_connect_volume method in os-brick we could have:\n\n hostnqn \u003d self.get_hostnqn()\n if hostnqn !\u003d connection_info[\u0027hostnqn\u0027]:\n     raise exception.Invalid(\"nqn in connection info doesn\u0027t match this host\u0027s\")","commit_id":"7a8957933547b91b5d247501e983d473a468ad7d"},{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"29aead65dc42a8eebcab3c567647e0ba945cba10","unresolved":false,"context_lines":[{"line_number":1412,"context_line":"            raise exception.VolumeBackendAPIException(message\u003d_(msg))"},{"line_number":1413,"context_line":""},{"line_number":1414,"context_line":"        props \u003d self._get_connection_properties(project_name, volume)"},{"line_number":1415,"context_line":"        props[\u0027nqn\u0027] \u003d hostnqn"},{"line_number":1416,"context_line":"        return {\u0027driver_volume_type\u0027: (\u0027lightos\u0027), \u0027data\u0027: props}"},{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"    def terminate_connection(self, volume, connector, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"cb025808_560871d6","line":1415,"in_reply_to":"a8572082_7da28a08","updated":"2022-02-09 08:22:43.000000000","message":"But that would be a breaking change, since nvmeof already uses \u0027nqn\u0027 to refer to hostnqn in released versions. That\u0027s why we went with nqn, although we all agree it would be clearer to distinguish between host and subsys nqn\u0027s.","commit_id":"7a8957933547b91b5d247501e983d473a468ad7d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"142d2c40dd3c2a859d29740b1c0058ca49833d21","unresolved":true,"context_lines":[{"line_number":1412,"context_line":"            raise exception.VolumeBackendAPIException(message\u003d_(msg))"},{"line_number":1413,"context_line":""},{"line_number":1414,"context_line":"        props \u003d self._get_connection_properties(project_name, volume)"},{"line_number":1415,"context_line":"        props[\u0027nqn\u0027] \u003d hostnqn"},{"line_number":1416,"context_line":"        return {\u0027driver_volume_type\u0027: (\u0027lightos\u0027), \u0027data\u0027: props}"},{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"    def terminate_connection(self, volume, connector, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"f986eeb7_c6588d8a","line":1415,"in_reply_to":"cb025808_560871d6","updated":"2022-02-10 11:28:39.000000000","message":"Sorry, I\u0027m missing how my suggestion is a breaking change. We would end up with this:\n\nConnector dictionary:\n  nqn \u003d\u003e connector nqn (ie: nova\u0027s nqn)\n\nConnection dictionary (returned by this method):\n  nqn \u003d\u003e storage nqn\n  hostnqn \u003d\u003e hostnqn (ie: nova\u0027s nqn)\n\n\nAnd actually the proposed renaming from \"hostnqn\" to \"nqn\" would be the breaking change.\n\nThe fact that something is called nqn in the connector properties doesn\u0027t mean that it should have the same name in the connection properties.  In fact, it should be de opposite, since they are looking at things from different perspectives.  The connector info describes the host that is going to connect to the volume, whereas the connection info describes host to connect to the storage.\n\nSo if we have key \"nqn\" in the dictionary that describes how to connect to the storage one would assume that this means that that\u0027s the storage\u0027s nqn, and would be surprised to realize that it\u0027s in fact the connector host\u0027s nqn instead.","commit_id":"7a8957933547b91b5d247501e983d473a468ad7d"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"db514970785e80dae82d85d4f5a15597b2330d95","unresolved":true,"context_lines":[{"line_number":1412,"context_line":"            raise exception.VolumeBackendAPIException(message\u003d_(msg))"},{"line_number":1413,"context_line":""},{"line_number":1414,"context_line":"        props \u003d self._get_connection_properties(project_name, volume)"},{"line_number":1415,"context_line":"        props[\u0027nqn\u0027] \u003d hostnqn"},{"line_number":1416,"context_line":"        return {\u0027driver_volume_type\u0027: (\u0027lightos\u0027), \u0027data\u0027: props}"},{"line_number":1417,"context_line":""},{"line_number":1418,"context_line":"    def terminate_connection(self, volume, connector, **kwargs):"}],"source_content_type":"text/x-python","patch_set":4,"id":"946a40a5_bea380c0","line":1415,"in_reply_to":"f986eeb7_c6588d8a","updated":"2022-02-10 11:54:30.000000000","message":"I understand what you mean, but going over the code, it looks like no one is using it anyway. any use of hostnqn/nqn in the connector is coming from the connector and not the connection properties.\n\nThink its safe to remove it?","commit_id":"7a8957933547b91b5d247501e983d473a468ad7d"}]}