)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"4fdb5b563813bd1a95f861d67d4ef0d48251723e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"cb449337_591168d0","updated":"2022-02-07 14:17:27.000000000","message":"lgtm, see inline ","commit_id":"a8d97b6e97fa9fb78b7e54bd4282de4d58797fe2"}],"cinder/volume/manager.py":[{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"4fdb5b563813bd1a95f861d67d4ef0d48251723e","unresolved":true,"context_lines":[{"line_number":994,"context_line":"                            \"status\": error}"},{"line_number":995,"context_line":"                msg \u003d (\"Failed to delete volume %(id)s \""},{"line_number":996,"context_line":"                       \"status %(status)s.\") % msg_args"},{"line_number":997,"context_line":"                LOG.exception(msg, msg_args)"},{"line_number":998,"context_line":""},{"line_number":999,"context_line":"                self._clear_db(volume, new_status)"},{"line_number":1000,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"db37917e_7aad7527","line":997,"updated":"2022-02-07 14:17:27.000000000","message":"status here is an exception doesn\u0027t it make more sense to describe it as \"error\"\nLOG.exception(\"Failed to delete volume: %(id)s error: %(error)s, dict(error\u003derror, id\u003dvolume.id))","commit_id":"a8d97b6e97fa9fb78b7e54bd4282de4d58797fe2"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"7bed72104e02d377647c56152e6e226bb5fdc4d4","unresolved":false,"context_lines":[{"line_number":994,"context_line":"                            \"status\": error}"},{"line_number":995,"context_line":"                msg \u003d (\"Failed to delete volume %(id)s \""},{"line_number":996,"context_line":"                       \"status %(status)s.\") % msg_args"},{"line_number":997,"context_line":"                LOG.exception(msg, msg_args)"},{"line_number":998,"context_line":""},{"line_number":999,"context_line":"                self._clear_db(volume, new_status)"},{"line_number":1000,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"fa8c4bca_2c552432","line":997,"in_reply_to":"db37917e_7aad7527","updated":"2022-02-07 19:55:08.000000000","message":"Done","commit_id":"a8d97b6e97fa9fb78b7e54bd4282de4d58797fe2"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"bc32d2083283c8d5262e4364bc757321106d4c79","unresolved":true,"context_lines":[{"line_number":994,"context_line":"                            \"error\": error}"},{"line_number":995,"context_line":"                msg \u003d (\"Failed to delete volume %(id)s \""},{"line_number":996,"context_line":"                       \"error %(error)s.\") % msg_args"},{"line_number":997,"context_line":"                LOG.exception(msg, msg_args)"},{"line_number":998,"context_line":""},{"line_number":999,"context_line":"                self._clear_db(volume, new_status)"},{"line_number":1000,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"10e2c7f5_8d854a2a","line":997,"updated":"2022-02-18 15:07:11.000000000","message":"As far as I understand the exception is being re raised in L986 so in this case cinder will show it twice, right? If we still want this maybe we can use LOG.DEBUG.","commit_id":"5310c936906ca65e51cfc62a74bfc1cdde347039"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"6a5b2f620619bb61f82756d2dd4e11eb0eea2719","unresolved":true,"context_lines":[{"line_number":994,"context_line":"                            \"error\": error}"},{"line_number":995,"context_line":"                msg \u003d (\"Failed to delete volume %(id)s \""},{"line_number":996,"context_line":"                       \"error %(error)s.\") % msg_args"},{"line_number":997,"context_line":"                LOG.exception(msg, msg_args)"},{"line_number":998,"context_line":""},{"line_number":999,"context_line":"                self._clear_db(volume, new_status)"},{"line_number":1000,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5d541189_712112c3","line":997,"in_reply_to":"10e2c7f5_8d854a2a","updated":"2022-02-18 15:15:44.000000000","message":"Or maybe not do it at all?\n\nI guess the question is: if it\u0027s logged already, why is another log line needed? Maybe it needs to be fixed in _clear_db? Not sure...","commit_id":"5310c936906ca65e51cfc62a74bfc1cdde347039"},{"author":{"_account_id":33410,"name":"Iago Filipe","email":"IagoFilipe.EstrelaBarros@windriver.com","username":"ifest1"},"change_message_id":"94ea126fac6de86ea375ed876b0f8e5e89fcfaa9","unresolved":false,"context_lines":[{"line_number":994,"context_line":"                            \"error\": error}"},{"line_number":995,"context_line":"                msg \u003d (\"Failed to delete volume %(id)s \""},{"line_number":996,"context_line":"                       \"error %(error)s.\") % msg_args"},{"line_number":997,"context_line":"                LOG.exception(msg, msg_args)"},{"line_number":998,"context_line":""},{"line_number":999,"context_line":"                self._clear_db(volume, new_status)"},{"line_number":1000,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"e7cdc9bb_dda6a7c3","line":997,"in_reply_to":"5d541189_712112c3","updated":"2022-02-24 12:31:37.000000000","message":"Done","commit_id":"5310c936906ca65e51cfc62a74bfc1cdde347039"}]}