)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"a40add35c438d001f0da8c8e80e5f7771233aec2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"71b7ddb4_0867d5d7","updated":"2022-02-10 11:29:16.000000000","message":"run-Hitachi VSP CI","commit_id":"4dbb723e64b7ac27662bd03cb3c1b2683419d6f8"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"d9173738ea9d91d68f465643dba2ac794d566506","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"5d554d32_0e9d1cca","updated":"2022-02-12 06:30:45.000000000","message":"run-Hitachi VSP CI","commit_id":"7f0b23978872254abca1fb47e24224cc2d5ec513"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"7ea8bcf482e3188d852658a913f541d595d27ed6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"685f9ef9_a850b4ce","updated":"2022-02-22 06:27:33.000000000","message":"\u003e Patch Set 6:\n\u003e \n\u003e * hitachi_vsp_fc http://ec2-18-177-230-241.ap-northeast-1.compute.amazonaws.com/refs/changes/96/828696/6/fc : FAILURE in 1h 29m 14s\n\u003e * hitachi_vsp_iscsi http://ec2-18-177-230-241.ap-northeast-1.compute.amazonaws.com/refs/changes/96/828696/6/iscsi : SUCCESS in 1h 38m 31s\n\nI\u0027ve fixed CI logs for FC driver with correct logs.\nCorrect logs and result for FC driver are:\n\n* hitachi_vsp_fc http://ec2-18-177-230-241.ap-northeast-1.compute.amazonaws.com/refs/changes/96/828696/6/fc : SUCCESS in 1h 18m 57s\n","commit_id":"6eb2e04f36bc1e271c94bec31e69b9d24da0ae6c"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b881c6cc7ffe0db71c27a643762af4777973c7c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"665d07ce_875e98ca","updated":"2022-02-25 04:46:50.000000000","message":"Code and tests look mostly fine, and CI is passing.  A few suggestions and questions noted inline.  The -1 is mostly for the missing release note.","commit_id":"7e522292b2aca733847aabf62ba5c81f9df5fb3e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"3946c84555aa180fec5626d295330f117d6f2fc6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"9e33a366_8a9b7092","updated":"2022-02-25 04:00:07.000000000","message":"Please add a release note announcing this feature.\nhttps://docs.openstack.org/cinder/latest/contributor/releasenotes.html#drivers","commit_id":"7e522292b2aca733847aabf62ba5c81f9df5fb3e"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"95da32b582399078068d40dedbf01fe3a38d58d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"621d665f_bb3cc397","in_reply_to":"665d07ce_875e98ca","updated":"2022-03-01 07:26:46.000000000","message":"I\u0027ve uploaded patchset8, including release note.","commit_id":"7e522292b2aca733847aabf62ba5c81f9df5fb3e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"14e0fa624c6f3069b3a5e8aff17038a5a3c6edcb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"e0ec9a4c_f5110ff7","updated":"2022-03-02 13:40:07.000000000","message":"Changes from PS 7 look fine.  Release note is clear and renders OK in HTML.  Hitachi CI is green.","commit_id":"15cd09241a2165f34433784cfb329983f0e748a6"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"c199d1c544fe96c9eb58e47c90daa40170e22eff","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"8d8e27cc_f4c404fd","updated":"2022-03-01 10:48:01.000000000","message":"run-Hitachi VSP CI","commit_id":"15cd09241a2165f34433784cfb329983f0e748a6"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6d9bc96c81985e760a77fd03129f09aaf2008275","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"2162aeb4_f42bcf5f","updated":"2022-09-06 11:56:09.000000000","message":"Changes since PS8 LGTM.","commit_id":"a3256416ce8b9fe55a2cedbdab5964d6f6780c35"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"419378093ddb6eb5f68a554f08aea960ef25d91d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"40903199_e9112a6c","updated":"2022-09-08 18:58:06.000000000","message":"Hitachi CI is passing.\nFew nits but code LGTM. there seems to be lack of test coverage for this feature but since we\u0027re very close to deadline, they could be added as a followup.","commit_id":"a3256416ce8b9fe55a2cedbdab5964d6f6780c35"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"9b1ce472fce5206e4cce6bad99836501067f29f0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"f08e1236_c080c2d6","updated":"2022-09-09 14:17:10.000000000","message":"recheck","commit_id":"a3256416ce8b9fe55a2cedbdab5964d6f6780c35"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"8ce507189a9b0b80be5fc2aeeb92370df878c34d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":11,"id":"17001680_174d23e0","updated":"2022-03-08 23:47:24.000000000","message":"run-Hitachi VSP CI","commit_id":"a3256416ce8b9fe55a2cedbdab5964d6f6780c35"}],"cinder/volume/drivers/hitachi/hbsd_common.py":[{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"02a09fd4d350c5813ebf7b145b28be8a821c0ea9","unresolved":true,"context_lines":[{"line_number":110,"context_line":"    cfg.BoolOpt("},{"line_number":111,"context_line":"        \u0027hitachi_port_scheduler\u0027,"},{"line_number":112,"context_line":"        default\u003dFalse,"},{"line_number":113,"context_line":"        help\u003d\u0027Schedule the port to be assigned wwns\u0027),"},{"line_number":114,"context_line":"]"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":5,"id":"0939c42e_eda15a0d","line":113,"updated":"2022-02-18 08:55:58.000000000","message":"Shouldn\u0027t the \"wwns\" in the help message be \"WWNs\"?","commit_id":"b1eca4d049810f1ba40861f3c7e4fce41770f9da"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"b34a820d3546f227e3ac03a7efe59edff5a2b36b","unresolved":true,"context_lines":[{"line_number":110,"context_line":"    cfg.BoolOpt("},{"line_number":111,"context_line":"        \u0027hitachi_port_scheduler\u0027,"},{"line_number":112,"context_line":"        default\u003dFalse,"},{"line_number":113,"context_line":"        help\u003d\u0027Schedule the port to be assigned wwns\u0027),"},{"line_number":114,"context_line":"]"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":5,"id":"3cc19643_2e0866a4","line":113,"in_reply_to":"0939c42e_eda15a0d","updated":"2022-02-21 10:54:10.000000000","message":"Thank you for checking our code.\nI\u0027ve uploaded fixed code along your comment as patchset6","commit_id":"b1eca4d049810f1ba40861f3c7e4fce41770f9da"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"14e0fa624c6f3069b3a5e8aff17038a5a3c6edcb","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    cfg.BoolOpt("},{"line_number":111,"context_line":"        \u0027hitachi_port_scheduler\u0027,"},{"line_number":112,"context_line":"        default\u003dFalse,"},{"line_number":113,"context_line":"        help\u003d\u0027Schedule the port to be assigned wwns\u0027),"},{"line_number":114,"context_line":"]"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":5,"id":"3b577696_bd9880c1","line":113,"in_reply_to":"3cc19643_2e0866a4","updated":"2022-03-02 13:40:07.000000000","message":"Done","commit_id":"b1eca4d049810f1ba40861f3c7e4fce41770f9da"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b881c6cc7ffe0db71c27a643762af4777973c7c6","unresolved":true,"context_lines":[{"line_number":110,"context_line":"    cfg.BoolOpt("},{"line_number":111,"context_line":"        \u0027hitachi_port_scheduler\u0027,"},{"line_number":112,"context_line":"        default\u003dFalse,"},{"line_number":113,"context_line":"        help\u003d\u0027Schedule the port to be assigned WWNs\u0027),"},{"line_number":114,"context_line":"]"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":7,"id":"8f6581a2_7478e3e0","line":113,"range":{"start_line":113,"start_character":14,"end_line":113,"end_character":51},"updated":"2022-02-25 04:46:50.000000000","message":"I think something like this would be more accurate:\n\n  Enable port scheduling of WWNs to the configured ports so that WWNs are registered to ports in a round-robin fashion.\n\nYou could also say something about what under what conditions an operator would want to enable port scheduling, or at least mention that in the release note.","commit_id":"7e522292b2aca733847aabf62ba5c81f9df5fb3e"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"1875e83221def5836eb45160f4d7c069bbd11b17","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    cfg.BoolOpt("},{"line_number":111,"context_line":"        \u0027hitachi_port_scheduler\u0027,"},{"line_number":112,"context_line":"        default\u003dFalse,"},{"line_number":113,"context_line":"        help\u003d\u0027Schedule the port to be assigned WWNs\u0027),"},{"line_number":114,"context_line":"]"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":7,"id":"bcb22634_6a3b4565","line":113,"range":{"start_line":113,"start_character":14,"end_line":113,"end_character":51},"in_reply_to":"498c49f5_2640d017","updated":"2022-09-02 04:31:31.000000000","message":"Done","commit_id":"7e522292b2aca733847aabf62ba5c81f9df5fb3e"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"95da32b582399078068d40dedbf01fe3a38d58d3","unresolved":true,"context_lines":[{"line_number":110,"context_line":"    cfg.BoolOpt("},{"line_number":111,"context_line":"        \u0027hitachi_port_scheduler\u0027,"},{"line_number":112,"context_line":"        default\u003dFalse,"},{"line_number":113,"context_line":"        help\u003d\u0027Schedule the port to be assigned WWNs\u0027),"},{"line_number":114,"context_line":"]"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"CONF \u003d cfg.CONF"}],"source_content_type":"text/x-python","patch_set":7,"id":"498c49f5_2640d017","line":113,"range":{"start_line":113,"start_character":14,"end_line":113,"end_character":51},"in_reply_to":"8f6581a2_7478e3e0","updated":"2022-03-01 07:26:46.000000000","message":"I\u0027ve fixed the message in patchset8.","commit_id":"7e522292b2aca733847aabf62ba5c81f9df5fb3e"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b881c6cc7ffe0db71c27a643762af4777973c7c6","unresolved":true,"context_lines":[{"line_number":594,"context_line":"        \"\"\"Create a host group or an iSCSI target on the specified port.\"\"\""},{"line_number":595,"context_line":"        raise NotImplementedError()"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    def get_gid_from_targets(self, targets, port):"},{"line_number":598,"context_line":"        for target_port, target_gid in targets[\u0027list\u0027]:"},{"line_number":599,"context_line":"            if target_port \u003d\u003d port:"},{"line_number":600,"context_line":"                return target_gid"}],"source_content_type":"text/x-python","patch_set":7,"id":"0a88d8e6_f4574f60","line":597,"updated":"2022-02-25 04:46:50.000000000","message":"The coverage report shows that this function isn\u0027t being tested.  (I\u0027m not saying that you must add a test--thought that would be fine!--but at least look it over carefully.)","commit_id":"7e522292b2aca733847aabf62ba5c81f9df5fb3e"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"95da32b582399078068d40dedbf01fe3a38d58d3","unresolved":true,"context_lines":[{"line_number":594,"context_line":"        \"\"\"Create a host group or an iSCSI target on the specified port.\"\"\""},{"line_number":595,"context_line":"        raise NotImplementedError()"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    def get_gid_from_targets(self, targets, port):"},{"line_number":598,"context_line":"        for target_port, target_gid in targets[\u0027list\u0027]:"},{"line_number":599,"context_line":"            if target_port \u003d\u003d port:"},{"line_number":600,"context_line":"                return target_gid"}],"source_content_type":"text/x-python","patch_set":7,"id":"2b10d86e_7f002b1f","line":597,"in_reply_to":"0a88d8e6_f4574f60","updated":"2022-03-01 07:26:46.000000000","message":"I\u0027ve add testcase for the function in patchset8","commit_id":"7e522292b2aca733847aabf62ba5c81f9df5fb3e"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"1875e83221def5836eb45160f4d7c069bbd11b17","unresolved":false,"context_lines":[{"line_number":594,"context_line":"        \"\"\"Create a host group or an iSCSI target on the specified port.\"\"\""},{"line_number":595,"context_line":"        raise NotImplementedError()"},{"line_number":596,"context_line":""},{"line_number":597,"context_line":"    def get_gid_from_targets(self, targets, port):"},{"line_number":598,"context_line":"        for target_port, target_gid in targets[\u0027list\u0027]:"},{"line_number":599,"context_line":"            if target_port \u003d\u003d port:"},{"line_number":600,"context_line":"                return target_gid"}],"source_content_type":"text/x-python","patch_set":7,"id":"cd85c11a_f9328dd7","line":597,"in_reply_to":"2b10d86e_7f002b1f","updated":"2022-09-02 04:31:31.000000000","message":"Done","commit_id":"7e522292b2aca733847aabf62ba5c81f9df5fb3e"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"419378093ddb6eb5f68a554f08aea960ef25d91d","unresolved":true,"context_lines":[{"line_number":628,"context_line":"        else:"},{"line_number":629,"context_line":"            gid \u003d self.get_gid_from_targets(targets, port)"},{"line_number":630,"context_line":"        try:"},{"line_number":631,"context_line":"            if port not in targets[\u0027info\u0027] or not targets[\u0027info\u0027][port]:"},{"line_number":632,"context_line":"                self.set_target_mode(port, gid)"},{"line_number":633,"context_line":"            self.set_hba_ids(port, gid, hba_ids)"},{"line_number":634,"context_line":"        except Exception:"}],"source_content_type":"text/x-python","patch_set":11,"id":"8a0ce6a6_e7b54e6e","line":631,"range":{"start_line":631,"start_character":15,"end_line":631,"end_character":71},"updated":"2022-09-08 18:58:06.000000000","message":"to cover both conditions, this can be rewritten as,\n\n    if not targets[\u0027info\u0027].get(port):","commit_id":"a3256416ce8b9fe55a2cedbdab5964d6f6780c35"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"419378093ddb6eb5f68a554f08aea960ef25d91d","unresolved":true,"context_lines":[{"line_number":671,"context_line":"        backend_name \u003d self.conf.safe_get(\u0027volume_backend_name\u0027)"},{"line_number":672,"context_line":"        code \u003d ("},{"line_number":673,"context_line":"            str(self.conf.hitachi_storage_id) + backend_name + network_name)"},{"line_number":674,"context_line":"        if code in self.port_index.keys():"},{"line_number":675,"context_line":"            if self.port_index[code] \u003e\u003d len(ports) - 1:"},{"line_number":676,"context_line":"                self.port_index[code] \u003d 0"},{"line_number":677,"context_line":"            else:"}],"source_content_type":"text/x-python","patch_set":11,"id":"be505dbd_0fe733dd","line":674,"range":{"start_line":674,"start_character":34,"end_line":674,"end_character":41},"updated":"2022-09-08 18:58:06.000000000","message":"nit: this is redundant\n\n\u003e\u003e\u003e test \u003d {\u0027a\u0027: 1, \u0027b\u0027: 2}\n\u003e\u003e\u003e if \u0027b\u0027 in test:\n...     print(True)\n... \nTrue\n\n\n\u003e\u003e\u003e if \u0027b\u0027 in test.keys():\n...     print(True)\n... \nTrue","commit_id":"a3256416ce8b9fe55a2cedbdab5964d6f6780c35"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"419378093ddb6eb5f68a554f08aea960ef25d91d","unresolved":true,"context_lines":[{"line_number":986,"context_line":""},{"line_number":987,"context_line":"    def is_controller(self, connector):"},{"line_number":988,"context_line":"        return True if ("},{"line_number":989,"context_line":"            \u0027ip\u0027 in connector and connector[\u0027ip\u0027] \u003d\u003d CONF.my_ip) else False"}],"source_content_type":"text/x-python","patch_set":11,"id":"1d3b6b60_64062e61","line":989,"range":{"start_line":989,"start_character":12,"end_line":989,"end_character":49},"updated":"2022-09-08 18:58:06.000000000","message":"can be written as,\n    connector.get(\u0027ip\u0027)","commit_id":"a3256416ce8b9fe55a2cedbdab5964d6f6780c35"}],"cinder/volume/drivers/hitachi/hbsd_iscsi.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"b881c6cc7ffe0db71c27a643762af4777973c7c6","unresolved":true,"context_lines":[{"line_number":100,"context_line":"              [\u0027driver_ssl_cert_verify\u0027, \u0027driver_ssl_cert_path\u0027,"},{"line_number":101,"context_line":"               \u0027san_api_port\u0027, ]))"},{"line_number":102,"context_line":"        return (common.COMMON_VOLUME_OPTS +"},{"line_number":103,"context_line":"                common.COMMON_PORT_OPTS +"},{"line_number":104,"context_line":"                rest.REST_VOLUME_OPTS +"},{"line_number":105,"context_line":"                additional_opts)"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"f1254bc0_6014eba2","line":103,"range":{"start_line":103,"start_character":16,"end_line":103,"end_character":39},"updated":"2022-02-25 04:46:50.000000000","message":"The \u0027hitachi_port_scheduler\u0027 is basically a no-op for iscsi, is that correct?  If so, does it make sense to include it in the iscsi driver options?","commit_id":"7e522292b2aca733847aabf62ba5c81f9df5fb3e"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"1875e83221def5836eb45160f4d7c069bbd11b17","unresolved":false,"context_lines":[{"line_number":100,"context_line":"              [\u0027driver_ssl_cert_verify\u0027, \u0027driver_ssl_cert_path\u0027,"},{"line_number":101,"context_line":"               \u0027san_api_port\u0027, ]))"},{"line_number":102,"context_line":"        return (common.COMMON_VOLUME_OPTS +"},{"line_number":103,"context_line":"                common.COMMON_PORT_OPTS +"},{"line_number":104,"context_line":"                rest.REST_VOLUME_OPTS +"},{"line_number":105,"context_line":"                additional_opts)"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"3e2673fe_47dfce55","line":103,"range":{"start_line":103,"start_character":16,"end_line":103,"end_character":39},"in_reply_to":"026040df_f5c50564","updated":"2022-09-02 04:31:31.000000000","message":"Done","commit_id":"7e522292b2aca733847aabf62ba5c81f9df5fb3e"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"95da32b582399078068d40dedbf01fe3a38d58d3","unresolved":true,"context_lines":[{"line_number":100,"context_line":"              [\u0027driver_ssl_cert_verify\u0027, \u0027driver_ssl_cert_path\u0027,"},{"line_number":101,"context_line":"               \u0027san_api_port\u0027, ]))"},{"line_number":102,"context_line":"        return (common.COMMON_VOLUME_OPTS +"},{"line_number":103,"context_line":"                common.COMMON_PORT_OPTS +"},{"line_number":104,"context_line":"                rest.REST_VOLUME_OPTS +"},{"line_number":105,"context_line":"                additional_opts)"},{"line_number":106,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"026040df_f5c50564","line":103,"range":{"start_line":103,"start_character":16,"end_line":103,"end_character":39},"in_reply_to":"f1254bc0_6014eba2","updated":"2022-03-01 07:26:46.000000000","message":"Yes. the feature is supported on Fibre Channel by customer request. I\u0027ve removed related options from iscsi driver in patchset8","commit_id":"7e522292b2aca733847aabf62ba5c81f9df5fb3e"}],"cinder/volume/drivers/hitachi/hbsd_rest_fc.py":[{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"02a09fd4d350c5813ebf7b145b28be8a821c0ea9","unresolved":true,"context_lines":[{"line_number":256,"context_line":"                not_found_count +\u003d 1"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        if self.get_port_scheduler_param():"},{"line_number":259,"context_line":"            return not_found_count \u003d\u003d len(target_ports)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        return not_found_count"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"b9202ba4_ab5138e5","line":259,"updated":"2022-02-18 08:55:58.000000000","message":"Shouldn\u0027t \"\u003d\u003d\" be \"\u003d\"?","commit_id":"b1eca4d049810f1ba40861f3c7e4fce41770f9da"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"b34a820d3546f227e3ac03a7efe59edff5a2b36b","unresolved":true,"context_lines":[{"line_number":256,"context_line":"                not_found_count +\u003d 1"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        if self.get_port_scheduler_param():"},{"line_number":259,"context_line":"            return not_found_count \u003d\u003d len(target_ports)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        return not_found_count"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"d6378b25_eadb9661","line":259,"in_reply_to":"b9202ba4_ab5138e5","updated":"2022-02-21 10:54:10.000000000","message":"Thank you for checking.\n\"\u003d\u003d\" is correct because it is the conditional expression.\nexpected returned value is true(1) or false(0)","commit_id":"b1eca4d049810f1ba40861f3c7e4fce41770f9da"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"aba29f4c09199dba4cb37193a0f5fb182d024bdf","unresolved":true,"context_lines":[{"line_number":256,"context_line":"                not_found_count +\u003d 1"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        if self.get_port_scheduler_param():"},{"line_number":259,"context_line":"            return not_found_count \u003d\u003d len(target_ports)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        return not_found_count"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"db3fa4d4_a4fa290a","line":259,"in_reply_to":"ba79a08f_2c48246a","updated":"2022-02-24 08:10:01.000000000","message":"You are correct. I fixed type of return value line#259 from bool to int, as Patchset7","commit_id":"b1eca4d049810f1ba40861f3c7e4fce41770f9da"},{"author":{"_account_id":28403,"name":"Naoki Saito","email":"nasaito@nec.com","username":"n-saito"},"change_message_id":"72af858767a67e042979a8a5945971533db6a6c0","unresolved":true,"context_lines":[{"line_number":256,"context_line":"                not_found_count +\u003d 1"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        if self.get_port_scheduler_param():"},{"line_number":259,"context_line":"            return not_found_count \u003d\u003d len(target_ports)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        return not_found_count"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"ba79a08f_2c48246a","line":259,"in_reply_to":"d6378b25_eadb9661","updated":"2022-02-22 08:58:20.000000000","message":"In the comment of the \"find_targets_from_storage\" method, it is explained that it returns count. \"true or false\" is not explained, which is not clear. Please make it clear in the variable name and comments.","commit_id":"b1eca4d049810f1ba40861f3c7e4fce41770f9da"},{"author":{"_account_id":33473,"name":"Atsushi Kawai","display_name":"akawai","email":"atsushi.kawai.bu@hitachi.com","username":"akawai"},"change_message_id":"1875e83221def5836eb45160f4d7c069bbd11b17","unresolved":false,"context_lines":[{"line_number":256,"context_line":"                not_found_count +\u003d 1"},{"line_number":257,"context_line":""},{"line_number":258,"context_line":"        if self.get_port_scheduler_param():"},{"line_number":259,"context_line":"            return not_found_count \u003d\u003d len(target_ports)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"        return not_found_count"},{"line_number":262,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"50c41ae2_8cc4f9fc","line":259,"in_reply_to":"db3fa4d4_a4fa290a","updated":"2022-09-02 04:31:31.000000000","message":"Done","commit_id":"b1eca4d049810f1ba40861f3c7e4fce41770f9da"}],"releasenotes/notes/hitachi-vsp-port-scheduler-207e01b3cd13350b.yaml":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"419378093ddb6eb5f68a554f08aea960ef25d91d","unresolved":true,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Hitachi driver: Add a feature ``Port Scheduler``. This feature is enabled"},{"line_number":5,"context_line":"    when specifying ``True`` for the parameter ``hitachi_port_scheduler``."},{"line_number":6,"context_line":"    When this feature is enabled and an attach request is received, the active"},{"line_number":7,"context_line":"    WWNs that are obtained by Fibre Channel Zone Manager will be distributed"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"31298d54_e43d0725","line":4,"range":{"start_line":4,"start_character":20,"end_line":4,"end_character":23},"updated":"2022-09-08 18:58:06.000000000","message":"nit: Added ``Port Scheduler`` feature.","commit_id":"a3256416ce8b9fe55a2cedbdab5964d6f6780c35"}]}