)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33301,"name":"Caique Mello","email":"caiquemellosbo@gmail.com","username":"MelloCaique"},"change_message_id":"800b825910d31ca387dfa84010c7ffe6029e6940","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"226fc4ec_6884faec","updated":"2022-06-17 14:56:31.000000000","message":"LGTM. Tested with my NetApp backend and worked fine. Thank you nahim!","commit_id":"3b13eab894ac878dcb1debedd5bf503c646446d2"},{"author":{"_account_id":26693,"name":"do3meli","email":"info@dominicschlegel.ch","username":"do3meli"},"change_message_id":"b126dc89937385b2cde78f32fb8f0f72b557afa4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"b4c16dd1_09cb12f5","updated":"2022-04-01 07:40:44.000000000","message":"looks good to me. this patch is quite important to make sure version compares still work the right way.","commit_id":"3b13eab894ac878dcb1debedd5bf503c646446d2"},{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"b46e67b8693cc1c75e2fd5d4e442e6f9592cff53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"78a43296_3453c3a5","updated":"2022-05-19 10:30:13.000000000","message":"seems right","commit_id":"3b13eab894ac878dcb1debedd5bf503c646446d2"}],"cinder/volume/drivers/netapp/dataontap/client/client_base.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8db01175852e03163a71c88492671ea0813a9168","unresolved":true,"context_lines":[{"line_number":63,"context_line":"        self.features \u003d na_utils.Features()"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":"    def get_ontap_version(self, cached\u003dTrue):"},{"line_number":66,"context_line":"        \"\"\"Gets the ONTAP version-string and version-tuple\"\"\""},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"        if cached:"},{"line_number":69,"context_line":"            return self.connection.get_ontap_version()"}],"source_content_type":"text/x-python","patch_set":2,"id":"e8c47c86_d272f9da","line":66,"range":{"start_line":66,"start_character":41,"end_line":66,"end_character":44},"updated":"2022-06-17 15:38:08.000000000","message":"nit: as","commit_id":"3b13eab894ac878dcb1debedd5bf503c646446d2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8db01175852e03163a71c88492671ea0813a9168","unresolved":true,"context_lines":[{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        ontap_version \u003d netapp_api.NaElement(\"system-get-version\")"},{"line_number":72,"context_line":"        result \u003d self.connection.invoke_successfully("},{"line_number":73,"context_line":"            ontap_version, enable_tunneling\u003dTrue)"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"        version_tuple \u003d result.get_child_by_name("},{"line_number":76,"context_line":"            \u0027version-tuple\u0027) or netapp_api.NaElement(\u0027none\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"07a0d629_5e08f9a4","line":73,"range":{"start_line":73,"start_character":27,"end_line":73,"end_character":43},"updated":"2022-06-17 15:38:08.000000000","message":"nit: unrelated change","commit_id":"3b13eab894ac878dcb1debedd5bf503c646446d2"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8db01175852e03163a71c88492671ea0813a9168","unresolved":false,"context_lines":[{"line_number":77,"context_line":"        ontap_version_tuple \u003d version_tuple.get_child_by_name("},{"line_number":78,"context_line":"            \u0027system-version-tuple\u0027) or netapp_api.NaElement(\u0027none\u0027)"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"        version \u003d ("},{"line_number":81,"context_line":"            int(ontap_version_tuple.get_child_content(\u0027generation\u0027)),"},{"line_number":82,"context_line":"            int(ontap_version_tuple.get_child_content(\u0027major\u0027)),"},{"line_number":83,"context_line":"            int(ontap_version_tuple.get_child_content(\u0027minor\u0027)))"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        return version"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"ce25983c_a2680bd6","line":83,"range":{"start_line":80,"start_character":0,"end_line":83,"end_character":64},"updated":"2022-06-17 15:38:08.000000000","message":"Usually I would recommend using version.Version from the packaging module, but in your case you wouldn\u0027t gain much here since you don\u0027t have a string it can parse directly.","commit_id":"3b13eab894ac878dcb1debedd5bf503c646446d2"}],"releasenotes/notes/bug-1955057-fix-get-ontap-version-4d9fa1f6c5d2eaf3.yaml":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"8db01175852e03163a71c88492671ea0813a9168","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":2,"id":"39b6f940_6a7c6028","line":8,"range":{"start_line":5,"start_character":56,"end_line":8,"end_character":0},"updated":"2022-06-17 15:38:08.000000000","message":"Release notes are meant for operators, not developers, so they should refer to the effects users will see and not the code changes.","commit_id":"3b13eab894ac878dcb1debedd5bf503c646446d2"}]}
