)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":30615,"name":"Tushar Trambak Gite","email":"tushargite96@gmail.com","username":"tushargite96"},"change_message_id":"cf980833cf29d171b3c8866cf3fa048cf457b57b","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ceph has changed the meaning of the ``bytes_used`` column in the pools"},{"line_number":10,"context_line":"reported by the ``df`` command, which means that in some deployments the"},{"line_number":11,"context_line":"rbd driver is not reporting the expected information ot the schedulers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The information we should be used for the calculations is returned in"},{"line_number":14,"context_line":"the ``stored`` field in those systems."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bb225740_12c7d39e","line":11,"updated":"2022-05-19 10:28:44.000000000","message":"it\u0027s to the schedulers right? patch looks good","commit_id":"86d9ec5d5932557ade18e7893cc2b8f564b5b2d8"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"844e2b107d9baf481bb959169c75c9dfd2c7ff61","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Ceph has changed the meaning of the ``bytes_used`` column in the pools"},{"line_number":10,"context_line":"reported by the ``df`` command, which means that in some deployments the"},{"line_number":11,"context_line":"rbd driver is not reporting the expected information ot the schedulers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The information we should be used for the calculations is returned in"},{"line_number":14,"context_line":"the ``stored`` field in those systems."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"aed224bd_ea9c2c0b","line":11,"in_reply_to":"bb225740_12c7d39e","updated":"2022-06-14 10:43:56.000000000","message":"Thanks.  Will fix it if I update a new patch.","commit_id":"86d9ec5d5932557ade18e7893cc2b8f564b5b2d8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"62b6c8f44c772e8c340105a9b5863ec4686cabca","unresolved":true,"context_lines":[{"line_number":10,"context_line":"reported by the ``df`` command, which means that in some deployments the"},{"line_number":11,"context_line":"rbd driver is not reporting the expected information ot the schedulers."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"The information we should be used for the calculations is returned in"},{"line_number":14,"context_line":"the ``stored`` field in those systems."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"This patch uses ``stored`` when present and fallbacks to ``bytes_used``"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"f6a9a991_c983ef83","line":13,"range":{"start_line":13,"start_character":16,"end_line":13,"end_character":18},"updated":"2023-03-03 12:26:37.000000000","message":"nit: that","commit_id":"86d9ec5d5932557ade18e7893cc2b8f564b5b2d8"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"98435928d2cb0c8e736ddebf963bac1a10183f9f","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e01a16ed_8684756a","updated":"2022-02-16 16:11:12.000000000","message":"-W because I haven\u0027t tested the patch yet on Nautilus ","commit_id":"4224e3775a74f9422dbfdf67c1389d365691aaca"},{"author":{"_account_id":30498,"name":"weisongf","email":"songwei-8@163.com","username":"NealSong"},"change_message_id":"754db04972b67e5d504786121416da916c9de7fc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"745ac809_6e3f828d","updated":"2022-04-01 08:04:39.000000000","message":"We are experiencing this issue and need to merge as soon as possible.","commit_id":"d05a182d175078f5ea05e2b34bf21c3d66432d49"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"e324f592ef9cb8f71d49f62f3dd2c4d601e1ed7a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"321c44f3_74c5797e","updated":"2023-02-15 12:25:10.000000000","message":"+2 Thanks for updating this. LGTM","commit_id":"86d9ec5d5932557ade18e7893cc2b8f564b5b2d8"},{"author":{"_account_id":16198,"name":"Ilya Popov","email":"hebulrih@gmail.com","username":"IPO"},"change_message_id":"4557611324580445bd0fd51d255158fb774d0d3d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"857fda12_0b048623","updated":"2022-11-28 19:37:02.000000000","message":"According to documentation (https://docs.openstack.org/cinder/latest/configuration/block-storage/drivers/ceph-rbd-volume-driver.html), cinder should support 2 active and 2 archived releases of ceph. For master they are nautilus, octopus, pacific and quincy. For all this ceph realeses \"stored\" key exists in df output, so we needn\u0027t to check ceph version to change behavoir to use or not use \"stored\" key instead of \"used_bytes\".\n\nWithout this fix it isn\u0027t possible to setup limits to cinder backend with max_over_subscription_ratio and reserved_percentage configuration options. So it could lead to unintended ceph overflow and IO stop.","commit_id":"86d9ec5d5932557ade18e7893cc2b8f564b5b2d8"},{"author":{"_account_id":16198,"name":"Ilya Popov","email":"hebulrih@gmail.com","username":"IPO"},"change_message_id":"efccf7bbbffc7d00427330ac271c3894f3f98c57","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"f7b92f74_dde74783","updated":"2022-11-28 20:52:41.000000000","message":"So, this fix even supports oldest ceph realeses and keeps compatibility if early release of ceph (without \"stored\" in df output ) is used.","commit_id":"86d9ec5d5932557ade18e7893cc2b8f564b5b2d8"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"62b6c8f44c772e8c340105a9b5863ec4686cabca","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"60726c4a_f55b758b","updated":"2023-03-03 12:26:37.000000000","message":"Verified some of the test calculations manually. RBD job is happy, code, test and releasenote looks good to me.","commit_id":"86d9ec5d5932557ade18e7893cc2b8f564b5b2d8"},{"author":{"_account_id":33543,"name":"liuhuajie","email":"liu.huajie@99cloud.net","username":"liuhuajie"},"change_message_id":"6272762bbe394f2a35e22fbe9067fa7ab8ab6417","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"34ac70b5_3f823ab3","updated":"2022-04-27 14:56:12.000000000","message":"·","commit_id":"86d9ec5d5932557ade18e7893cc2b8f564b5b2d8"}],"cinder/tests/unit/volume/drivers/test_rbd.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"62b6c8f44c772e8c340105a9b5863ec4686cabca","unresolved":true,"context_lines":[{"line_number":1784,"context_line":"        client \u003d self.mock_client.return_value"},{"line_number":1785,"context_line":"        client.__enter__.return_value \u003d client"},{"line_number":1786,"context_line":"        client.cluster.mon_command.side_effect \u003d ["},{"line_number":1787,"context_line":"            (0, \u0027{\"stats\":{\"total_bytes\":64385286144,\u0027"},{"line_number":1788,"context_line":"             \u0027\"total_used_bytes\":3289628672,\"total_avail_bytes\":61095657472},\u0027"},{"line_number":1789,"context_line":"             \u0027\"pools\":[{\"name\":\"rbd\",\"id\":2,\"stats\":{\"kb_used\":1510197,\u0027"},{"line_number":1790,"context_line":"             \u0027\"stored\":1546440971,\"bytes_used\":4639322913,\"max_avail\":%s,\u0027"},{"line_number":1791,"context_line":"             \u0027\"objects\":412}},{\"name\":\"volumes\",\"id\":3,\"stats\":{\"kb_used\":0,\u0027"},{"line_number":1792,"context_line":"             \u0027\"bytes_used\":0,\"max_avail\":28987613184,\"objects\":0}}]}\\n\u0027 %"},{"line_number":1793,"context_line":"             max_avail, \u0027\u0027),"},{"line_number":1794,"context_line":"            (0, \u0027{\"pool_name\":\"volumes\",\"pool_id\":4,\"quota_max_objects\":0,\u0027"},{"line_number":1795,"context_line":"             \u0027\"quota_max_bytes\":%s}\\n\u0027 % quota_max_bytes, \u0027\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"d8097ce9_255e0314","line":1792,"range":{"start_line":1787,"start_character":16,"end_line":1792,"end_character":71},"updated":"2023-03-03 12:26:37.000000000","message":"nit: can be updated to a more readable format in a followup","commit_id":"86d9ec5d5932557ade18e7893cc2b8f564b5b2d8"}]}