)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"23a48ff4c20424c8efdcde0a93d041e1ec593477","unresolved":false,"context_lines":[{"line_number":7,"context_line":"db: Indicate functions that should not be converted yet"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"There are a lot of functions to be converted. Add some TODOs to remind"},{"line_number":10,"context_line":"us that not all of them should be converted immediately."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Idc145655363c99364b182bb5d8e8a204060d19a4"},{"line_number":13,"context_line":"Signed-off-by: Stephen Finucane \u003cstephenfin@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"8ab2b467_33cd1b81","line":10,"updated":"2022-04-08 13:58:12.000000000","message":"This wasn\u0027t as clear as it should have been. You\u0027ll note that through the rest of this series, I\u0027m attempting to make each commit change all functions related to a particular model (DB table). The methods I\u0027ve marked up here do not match that pattern. The reason for this is because they\u0027re not used directly. Rather, they\u0027re used by \"generic\" methods that handle multiple different models. For example, \u0027_volume_get_query\u0027 is used by \u0027_generate_paginate_query\u0027 (via \u0027PAGINATION_HELPERS\u0027), but that method is a generic method also works with \u0027Snapshot\u0027 model entries (via \u0027_snapshot_get_query\u0027), \u0027VolumeType\u0027 model entries (via \u0027_volume_type_get_query\u0027) etc. I found myself erroneously modifying methods like \u0027_volume_get_query\u0027 when modifying other \u0027Volume\u0027 model-related methods, which then caused errors for things like \u0027_generate_paginate_query\u0027 since the signature of \u0027_volume_get_query\u0027 was different to e.g. \u0027_snapshot_get_query\u0027. I stuck in this precursor commit to stop myself making this mistake consistently 😅 They\u0027ll all be converted at the end of the series, don\u0027t worry!","commit_id":"9daef59b06b684dc9040aa8cb12bca9a5eecab27"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"29c35db434a2865b217c9d05da740a19417c8ae3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"4c4690c8_2d996e2b","updated":"2022-03-08 16:17:22.000000000","message":"recheck","commit_id":"595ed2758021a83febf28b30a77a88507989b7d4"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"035ab25dff906adcf382decbd6ad6880ae0fdbb7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"d678dd4c_1ab486f7","updated":"2022-04-08 19:15:49.000000000","message":"Thanks for the explanation, Stephen.  It makes sense as a development strategy!","commit_id":"9daef59b06b684dc9040aa8cb12bca9a5eecab27"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"dc1f8446c875f41420595df0f4696e695491b1df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"770fa74e_01cde524","updated":"2022-04-15 16:11:32.000000000","message":"just adding TODOs for the work items covered in future patches, LGTM.","commit_id":"a805804774c17ae551edc9559d99d119b47ff0e7"}]}