)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"758ca373390b8b264962ea99733274b09188c4c5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"a273310b_0710c784","updated":"2022-04-07 21:51:13.000000000","message":"LGTM; follows the pattern outlined in https://docs.openstack.org/oslo.db/latest/reference/api/oslo_db.sqlalchemy.html#module-oslo_db.sqlalchemy.session","commit_id":"1d7703f08a5c18bc47515a7546ff17221b4b2c45"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"336880a14d86c3f79fca576fe0d1e4fcb3e03cfb","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"a6058b23_ac30a77b","updated":"2022-04-27 08:25:53.000000000","message":"LGTM.","commit_id":"29a43abd589ca8415f26b6890c9e88b4b88a7ae6"}],"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"758ca373390b8b264962ea99733274b09188c4c5","unresolved":true,"context_lines":[{"line_number":1152,"context_line":""},{"line_number":1153,"context_line":"@require_context"},{"line_number":1154,"context_line":"def _quota_get_all_by_resource(context, resource, session\u003dNone):"},{"line_number":1155,"context_line":"    rows \u003d model_query(context, models.Quota,"},{"line_number":1156,"context_line":"                       session\u003dsession,"},{"line_number":1157,"context_line":"                       read_deleted\u003d\u0027no\u0027).filter_by("},{"line_number":1158,"context_line":"        resource\u003dresource).all()"},{"line_number":1159,"context_line":"    return rows"},{"line_number":1160,"context_line":""},{"line_number":1161,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"81f9da64_250e19c3","side":"PARENT","line":1158,"range":{"start_line":1155,"start_character":0,"end_line":1158,"end_character":32},"updated":"2022-04-07 21:51:13.000000000","message":"In the new patch, this is being done directly in quota_update(), which was the only place where this function was called.","commit_id":"7d4a9a2762d81a58031beb2b6495b8aebf716792"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"336880a14d86c3f79fca576fe0d1e4fcb3e03cfb","unresolved":true,"context_lines":[{"line_number":1152,"context_line":""},{"line_number":1153,"context_line":"@require_context"},{"line_number":1154,"context_line":"def _quota_get_all_by_resource(context, resource, session\u003dNone):"},{"line_number":1155,"context_line":"    rows \u003d model_query(context, models.Quota,"},{"line_number":1156,"context_line":"                       session\u003dsession,"},{"line_number":1157,"context_line":"                       read_deleted\u003d\u0027no\u0027).filter_by("},{"line_number":1158,"context_line":"        resource\u003dresource).all()"},{"line_number":1159,"context_line":"    return rows"},{"line_number":1160,"context_line":""},{"line_number":1161,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"8ede7547_6ed7cc9a","side":"PARENT","line":1158,"range":{"start_line":1155,"start_character":0,"end_line":1158,"end_character":32},"in_reply_to":"81f9da64_250e19c3","updated":"2022-04-27 08:25:53.000000000","message":"nit: quota_update_resource() instead of quota_update()","commit_id":"7d4a9a2762d81a58031beb2b6495b8aebf716792"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"336880a14d86c3f79fca576fe0d1e4fcb3e03cfb","unresolved":true,"context_lines":[{"line_number":1134,"context_line":"    return result"},{"line_number":1135,"context_line":""},{"line_number":1136,"context_line":""},{"line_number":1137,"context_line":"@require_context"},{"line_number":1138,"context_line":"@main_context_manager.reader"},{"line_number":1139,"context_line":"def quota_get(context, project_id, resource):"},{"line_number":1140,"context_line":"    return _quota_get(context, project_id, resource)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ec45d545_ccb67204","line":1137,"range":{"start_line":1137,"start_character":0,"end_line":1137,"end_character":16},"updated":"2022-04-27 08:25:53.000000000","message":"are there even cases when no context or a bad context (no user/project id) can be passed deep inside the db layer?","commit_id":"29a43abd589ca8415f26b6890c9e88b4b88a7ae6"}]}