)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"9a3586ab891872704011108fcbb67a1eb5c2c813","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"33f18760_80806760","updated":"2022-04-08 21:21:05.000000000","message":"LGTM.","commit_id":"0cf9917bbfc50f3570beda381cdf49d23a90e70b"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0cbddf907914b0aac7b4e033998ed5db4aea5b86","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"5d29314c_5b13d7df","updated":"2022-04-27 10:41:29.000000000","message":"LGTM","commit_id":"7c3f9b0b1970edf9a93ebaeae1aaece68401563d"}],"cinder/db/sqlalchemy/api.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"fb7233d599f8c5facb8cb39943e5286d38a306a4","unresolved":false,"context_lines":[{"line_number":1215,"context_line":""},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"@require_context"},{"line_number":1218,"context_line":"def quota_class_get(context, class_name, resource):"},{"line_number":1219,"context_line":"    return _quota_class_get(context, class_name, resource)"},{"line_number":1220,"context_line":""},{"line_number":1221,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"50a4cb0a_c7cdbc3c","line":1218,"updated":"2022-04-14 10:29:39.000000000","message":"FYI, I forgot the decorator here but it\u0027s fixed later in the series [1]. This isn\u0027t an issue because the underlying \u0027model_query\u0027 method we\u0027ll eventually use with still handle an unset context.session at this point\n\n[1] https://review.opendev.org/c/openstack/cinder/+/837539/1/cinder/db/sqlalchemy/api.py#1358","commit_id":"7c3f9b0b1970edf9a93ebaeae1aaece68401563d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"534d55e686856a324c848cc12da9036d8b8b6d1a","unresolved":false,"context_lines":[{"line_number":1215,"context_line":""},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"@require_context"},{"line_number":1218,"context_line":"def quota_class_get(context, class_name, resource):"},{"line_number":1219,"context_line":"    return _quota_class_get(context, class_name, resource)"},{"line_number":1220,"context_line":""},{"line_number":1221,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"dcd6d1ac_79e9282e","line":1218,"in_reply_to":"1c6674b7_f39be9d5","updated":"2022-04-29 08:04:01.000000000","message":"I don\u0027t remember exactly why i wrote this, maybe i thought we\u0027re starting a session here and getting a different session in model_query without passing this session but yeah I can\u0027t recall exactly. Thanks for the details anyway, sounds good!","commit_id":"7c3f9b0b1970edf9a93ebaeae1aaece68401563d"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"5efcd68326924a4287164a9b767e96b92980ae18","unresolved":false,"context_lines":[{"line_number":1215,"context_line":""},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"@require_context"},{"line_number":1218,"context_line":"def quota_class_get(context, class_name, resource):"},{"line_number":1219,"context_line":"    return _quota_class_get(context, class_name, resource)"},{"line_number":1220,"context_line":""},{"line_number":1221,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1c6674b7_f39be9d5","line":1218,"in_reply_to":"1d64c0aa_bd2b588d","updated":"2022-04-27 14:28:57.000000000","message":"\u003e It\u0027s good that you mentioned this but the fix is towards the end of the series so we need to merge all the changes in one release, which is the goal but should\u0027ve been better if fixed here.\n\nNo, we could do it in multiple releases. As I said:\n\n\u003e This isn\u0027t an issue because the underlying \u0027model_query\u0027 method we\u0027ll eventually use with [sic: I meant \"will\"] still handle an unset context.session at this point\n\nSo as long as this is done before the fallback code in \u0027model_query\u0027 is removed, we\u0027re good. If we didn\u0027t do that, tests would start failing because context.session would be unset.","commit_id":"7c3f9b0b1970edf9a93ebaeae1aaece68401563d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0cbddf907914b0aac7b4e033998ed5db4aea5b86","unresolved":false,"context_lines":[{"line_number":1215,"context_line":""},{"line_number":1216,"context_line":""},{"line_number":1217,"context_line":"@require_context"},{"line_number":1218,"context_line":"def quota_class_get(context, class_name, resource):"},{"line_number":1219,"context_line":"    return _quota_class_get(context, class_name, resource)"},{"line_number":1220,"context_line":""},{"line_number":1221,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"1d64c0aa_bd2b588d","line":1218,"in_reply_to":"50a4cb0a_c7cdbc3c","updated":"2022-04-27 10:41:29.000000000","message":"It\u0027s good that you mentioned this but the fix is towards the end of the series so we need to merge all the changes in one release, which is the goal but should\u0027ve been better if fixed here.","commit_id":"7c3f9b0b1970edf9a93ebaeae1aaece68401563d"}]}