)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"3e28aa91039832185b3338e5e7d142a936267716","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     yuval brave \u003cyuval@lightbitslabs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-02-23 02:16:02 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"lightos - bugfix compression stats should be True"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the compression value in get_volume_stats should be \"True\""},{"line_number":10,"context_line":"and not dependent on the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"f009d3f3_bdc92fce","line":7,"updated":"2022-02-23 07:13:34.000000000","message":"Subject should be something like \u0027lightos: report compression support correctly\u0027","commit_id":"d4efe223bd09baf9ef6be857d390b146c22f99c1"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"1705f7b3be80ca9b1e4326c9a8cbda542e5ad756","unresolved":true,"context_lines":[{"line_number":4,"context_line":"Commit:     yuval brave \u003cyuval@lightbitslabs.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2022-02-23 02:16:02 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"lightos - bugfix compression stats should be True"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the compression value in get_volume_stats should be \"True\""},{"line_number":10,"context_line":"and not dependent on the"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9ea4af72_45706dc8","line":7,"in_reply_to":"f009d3f3_bdc92fce","updated":"2022-02-23 15:16:57.000000000","message":"commit message will be updated","commit_id":"d4efe223bd09baf9ef6be857d390b146c22f99c1"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4ef366894006ff049958d0edf55cf0cb9ecbeb6d","unresolved":true,"context_lines":[{"line_number":12,"context_line":"if the flag is false, we can not create volume type with"},{"line_number":13,"context_line":"compression\u003dTrue. the backend is filtered in the scheduler."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"bugfix: https://bugs.launchpad.net/cinder/+bug/1962221"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Signed-off-by: Yuval Brave  \u003cyuval@lightbitslabs.com\u003e"},{"line_number":18,"context_line":"Change-Id: I09fe872eca1b112f67bad7297de5893696f83373"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"a7a68e59_473becd4","line":15,"updated":"2022-03-02 13:25:41.000000000","message":":-1: please update this to Closes-Bug: #1962221\n\nhttps://wiki.openstack.org/wiki/GitCommitMessages#Including_external_references","commit_id":"f8cd8d9faa1c6b9d88c5d3c4d88da256e50b028d"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"f6386bf92f0fd64176259ea2da1f657c90ae90a3","unresolved":true,"context_lines":[{"line_number":12,"context_line":"if the flag is false, we can not create volume type with"},{"line_number":13,"context_line":"compression\u003dTrue. the backend is filtered in the scheduler."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"bugfix: https://bugs.launchpad.net/cinder/+bug/1962221"},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Signed-off-by: Yuval Brave  \u003cyuval@lightbitslabs.com\u003e"},{"line_number":18,"context_line":"Change-Id: I09fe872eca1b112f67bad7297de5893696f83373"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"d25e4e3d_29d3c3c3","line":15,"in_reply_to":"a7a68e59_473becd4","updated":"2022-03-03 15:27:19.000000000","message":"thanks!","commit_id":"f8cd8d9faa1c6b9d88c5d3c4d88da256e50b028d"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0d63eeb4e6f90a181e2c8a9890c08fa2177b43c7","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"lightos - bugfix compression stats should be True"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the compression value in get_volume_stats should be \"True\""},{"line_number":10,"context_line":"and not dependent on the"},{"line_number":11,"context_line":"configuration: lightos_default_compression_enabled"},{"line_number":12,"context_line":"if the flag is false, we can not create volume type with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"b4525d3e_69ebcc42","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":58},"updated":"2022-03-10 15:01:12.000000000","message":"This is reported as a list [True, False]","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"17a3b7a68a8e2c54ae33542f4e2c8e54cbb958a8","unresolved":true,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"lightos - bugfix compression stats should be True"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the compression value in get_volume_stats should be \"True\""},{"line_number":10,"context_line":"and not dependent on the"},{"line_number":11,"context_line":"configuration: lightos_default_compression_enabled"},{"line_number":12,"context_line":"if the flag is false, we can not create volume type with"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"0503a4ad_74b05733","line":9,"range":{"start_line":9,"start_character":4,"end_line":9,"end_character":58},"in_reply_to":"b4525d3e_69ebcc42","updated":"2022-03-10 16:36:04.000000000","message":"I will update this","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0d63eeb4e6f90a181e2c8a9890c08fa2177b43c7","unresolved":true,"context_lines":[{"line_number":9,"context_line":"the compression value in get_volume_stats should be \"True\""},{"line_number":10,"context_line":"and not dependent on the"},{"line_number":11,"context_line":"configuration: lightos_default_compression_enabled"},{"line_number":12,"context_line":"if the flag is false, we can not create volume type with"},{"line_number":13,"context_line":"compression\u003dTrue. the backend is filtered in the scheduler."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1962221"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"466f56f2_5e7e9ff1","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":16},"updated":"2022-03-10 15:01:12.000000000","message":"Is this really the case? I think you mean if the flag is False, you will be able to create the volume type (with compression\u003dTrue) but won\u0027t be able to create volumes from it.","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"17a3b7a68a8e2c54ae33542f4e2c8e54cbb958a8","unresolved":true,"context_lines":[{"line_number":9,"context_line":"the compression value in get_volume_stats should be \"True\""},{"line_number":10,"context_line":"and not dependent on the"},{"line_number":11,"context_line":"configuration: lightos_default_compression_enabled"},{"line_number":12,"context_line":"if the flag is false, we can not create volume type with"},{"line_number":13,"context_line":"compression\u003dTrue. the backend is filtered in the scheduler."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1962221"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"b4859e1d_2865f348","line":13,"range":{"start_line":12,"start_character":0,"end_line":13,"end_character":16},"in_reply_to":"466f56f2_5e7e9ff1","updated":"2022-03-10 16:36:04.000000000","message":"the meaning is you cant create volume type with compression\u003dtrue that will eventually be used in the backend","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":34459,"name":"Muli Ben-Yehuda","email":"muli@lightbitslabs.com","username":"muliby"},"change_message_id":"3e28aa91039832185b3338e5e7d142a936267716","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d354985f_a348e4af","updated":"2022-02-23 07:13:34.000000000","message":"Good catch!","commit_id":"d4efe223bd09baf9ef6be857d390b146c22f99c1"},{"author":{"_account_id":34544,"name":"Ronen weiss","email":"ronen@lightbitslabs.com","username":"ronenwe"},"change_message_id":"d5e92aaed5800d2938dfa6abfdcc2e8e65e346f7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4ac40889_fa140982","updated":"2022-02-23 13:54:30.000000000","message":"lgtm","commit_id":"15b76863a256a59e3d6e86d13dffefbc07bc97de"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fcf74d766c6026aa793472549a44d41efdba5085","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"e3beb6fe_13ef56c6","updated":"2022-03-03 13:40:02.000000000","message":"Question about the driver capabilities reporting noted inline.","commit_id":"f8cd8d9faa1c6b9d88c5d3c4d88da256e50b028d"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"0341c843a2ee4ae6ff7ed32ac046832f4b2715c6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"b29c53a1_a2ea582e","updated":"2022-02-25 12:05:35.000000000","message":"This may require release note.\nKindly refer \"Bug Fixes\" in below link:\nhttps://docs.openstack.org/releasenotes/cinder/xena.html","commit_id":"f8cd8d9faa1c6b9d88c5d3c4d88da256e50b028d"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"e36a017ed3da76b1373cd44beca3961a1a579254","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"7500a218_606f0d0a","updated":"2022-02-28 22:00:32.000000000","message":"recheck","commit_id":"f8cd8d9faa1c6b9d88c5d3c4d88da256e50b028d"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"75662c582fc0910c9fe0aa37364b012b39b94602","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c34985a1_c4c030ba","updated":"2022-02-28 22:22:05.000000000","message":"run-Lightbits CI","commit_id":"f8cd8d9faa1c6b9d88c5d3c4d88da256e50b028d"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"ccdec38bbdd4d25124b701fada70b0bd05d579f4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"84096233_d68e9c43","updated":"2022-02-28 21:58:55.000000000","message":"run-Lightbits CI\n\n","commit_id":"f8cd8d9faa1c6b9d88c5d3c4d88da256e50b028d"},{"author":{"_account_id":29122,"name":"Raghavendra Tilay","email":"raghavendra-uddhav.tilay@hpe.com","username":"raghavendrat"},"change_message_id":"dcf9045931af34b1cc74b37430fc7a66404eb3d7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"5af05310_2f954f2c","in_reply_to":"18ce1f13_bf08eeb5","updated":"2022-03-01 13:00:10.000000000","message":"Not sure. I think, let core reviewers decide on release notes.","commit_id":"f8cd8d9faa1c6b9d88c5d3c4d88da256e50b028d"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4ef366894006ff049958d0edf55cf0cb9ecbeb6d","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"6b28a29c_4a8146c6","in_reply_to":"5af05310_2f954f2c","updated":"2022-03-02 13:25:41.000000000","message":"Release notes tell your current users why this new release is important to them and showcase your software to potential users. It\u0027s a nice way to help users to search for fixes. If I were you I\u0027d consider adding a release note to most of relevant bug fixes.","commit_id":"f8cd8d9faa1c6b9d88c5d3c4d88da256e50b028d"},{"author":{"_account_id":20813,"name":"Sofia Enriquez","email":"lsofia.enriquez@gmail.com","username":"enriquetaso"},"change_message_id":"4db0f323cf83d17a4629838f44389f2b3946c2d3","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"02289662_edf7919b","in_reply_to":"6b28a29c_4a8146c6","updated":"2022-03-02 15:17:51.000000000","message":"Ignore my previous comment. Thanks Brian for clarify. This is a special case because it\u0027s a pre-release bug (the lightos driver doesn\u0027t exist officially until the Yoga release) ... so this is one case where we shouldn\u0027t require a release note","commit_id":"f8cd8d9faa1c6b9d88c5d3c4d88da256e50b028d"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"932d9f2db8fb95330822e8e84ae04645823cca1e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"18ce1f13_bf08eeb5","in_reply_to":"b29c53a1_a2ea582e","updated":"2022-02-28 21:59:42.000000000","message":"the lightos driver was not released in xena? I still need release note?","commit_id":"f8cd8d9faa1c6b9d88c5d3c4d88da256e50b028d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"59250768c5f118dcf0e51fb4be422706b513adfe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":6,"id":"34f2bc67_d0827e3c","updated":"2022-03-03 16:07:09.000000000","message":"Looks good, though I think you should address this in the documentation (see comment inline).","commit_id":"cc818ad4105cc234d5d86d7e147695bbc30c5cd5"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"39487c753a740fcedb8ac63cc6cc2f0d97d66bc7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"98521440_d163a60b","updated":"2022-03-10 16:23:25.000000000","message":"A few observations inline.","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0d63eeb4e6f90a181e2c8a9890c08fa2177b43c7","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"994f0110_dbdc1663","updated":"2022-03-10 15:01:12.000000000","message":"Few comments and queries inline. I think the logic to retrieve compression value is wrong and will fail in the cases I\u0027ve mentioned inline.","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"311931b449c03614d2f86732e37c244c824b22b8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"6035d62c_377a97c1","updated":"2022-03-09 14:02:38.000000000","message":"Nits in the help text.  Doc text looks very nice.  We already worked out that the code is correct, so I\u0027m +2 on this.","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"17a3b7a68a8e2c54ae33542f4e2c8e54cbb958a8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"5cc05935_a93396ec","updated":"2022-03-10 16:36:04.000000000","message":"optimisations will be added in a follow up. but currently the compression is broken so I am really prefer to merge this.\n\ncommit msg will be update right now","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"76d905404ec3e1f507ee27dd9fd6ab33c9b6aeec","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"2880c8a1_86295873","updated":"2022-03-07 14:42:45.000000000","message":"recheck","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"e6bbe4a4d0d46bb80d4b2cf796fc933ca783f264","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"66debdaa_232d0b3a","updated":"2022-03-08 13:09:52.000000000","message":"run-Lightbits CI","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"43f288aa3a220538c7f01becd7d2d635bc75862b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"4db52b34_396e1c4e","updated":"2022-03-08 13:43:26.000000000","message":"updated","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"},{"author":{"_account_id":32966,"name":"jiang guodao","email":"jguodao@vmware.com","username":"jguodao"},"change_message_id":"6bfd9eb7e6e7c8b5b95de3b21053c6967ca9c3bc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":7,"id":"b2f0a3cb_5c932811","updated":"2022-03-07 10:18:41.000000000","message":"vmware-recheck-patch","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"6360f3afcd500e4387280c71a7b2994c4da20510","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"c9948301_935781b8","updated":"2022-03-10 19:33:37.000000000","message":"I\u0027m fine with hardening the extra-specs content handling in a followup patch.","commit_id":"c04e2084f366e4728662ea73d9d6dc73b6e5b0e3"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"de7c598f5d9a82351c9faec07fecb26c177b807e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"a57f10c5_5d42aad6","updated":"2022-03-10 20:37:46.000000000","message":"No issues in handling my comments in a followup. LGTM.","commit_id":"c04e2084f366e4728662ea73d9d6dc73b6e5b0e3"},{"author":{"_account_id":22248,"name":"HPE AlletraMP iSCSI CI","email":"hp.cinder.blr.ci@groups.ext.hpe.com","username":"hp-storage-blr-ci","tags":["SERVICE_USER"]},"change_message_id":"2d690c026cf157520d7aac74a2023c27cfb8234e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":8,"id":"2a11f51a_497924ef","updated":"2022-04-29 11:57:36.000000000","message":"run-Nimble Storage Alletra 6k CI","commit_id":"c04e2084f366e4728662ea73d9d6dc73b6e5b0e3"}],"cinder/tests/unit/volume/drivers/lightos/test_lightos_storage.py":[{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0d63eeb4e6f90a181e2c8a9890c08fa2177b43c7","unresolved":true,"context_lines":[{"line_number":480,"context_line":""},{"line_number":481,"context_line":"        vol_type2 \u003d test_utils.create_volume_type("},{"line_number":482,"context_line":"            self.ctxt, self,"},{"line_number":483,"context_line":"            extra_specs\u003d{\u0027compression\u0027: \u0027\u003cis\u003e True\u0027},"},{"line_number":484,"context_line":"            name\u003d\u0027my_vol_type2\u0027)"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"        vol_type3 \u003d test_utils.create_volume_type("}],"source_content_type":"text/x-python","patch_set":7,"id":"332dc1d6_9753fe82","line":483,"range":{"start_line":483,"start_character":12,"end_line":483,"end_character":53},"updated":"2022-03-10 15:01:12.000000000","message":"we should also add negative cases where the compression value is wrong like \"false true\", \"true false\", \"abc true\", \"xyz false\"","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"17a3b7a68a8e2c54ae33542f4e2c8e54cbb958a8","unresolved":true,"context_lines":[{"line_number":480,"context_line":""},{"line_number":481,"context_line":"        vol_type2 \u003d test_utils.create_volume_type("},{"line_number":482,"context_line":"            self.ctxt, self,"},{"line_number":483,"context_line":"            extra_specs\u003d{\u0027compression\u0027: \u0027\u003cis\u003e True\u0027},"},{"line_number":484,"context_line":"            name\u003d\u0027my_vol_type2\u0027)"},{"line_number":485,"context_line":""},{"line_number":486,"context_line":"        vol_type3 \u003d test_utils.create_volume_type("}],"source_content_type":"text/x-python","patch_set":7,"id":"cb1ba3f4_9cd1915b","line":483,"range":{"start_line":483,"start_character":12,"end_line":483,"end_character":53},"in_reply_to":"332dc1d6_9753fe82","updated":"2022-03-10 16:36:04.000000000","message":"I agree will be added in a follow up","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0d63eeb4e6f90a181e2c8a9890c08fa2177b43c7","unresolved":true,"context_lines":[{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        vol_type2 \u003d test_utils.create_volume_type("},{"line_number":516,"context_line":"            self.ctxt, self,"},{"line_number":517,"context_line":"            extra_specs\u003d{\u0027compression\u0027: \u0027\u003cis\u003e False\u0027},"},{"line_number":518,"context_line":"            name\u003d\u0027my_vol_type2\u0027)"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"        vol_type3 \u003d test_utils.create_volume_type("}],"source_content_type":"text/x-python","patch_set":7,"id":"c05b75eb_0d40efa4","line":517,"range":{"start_line":517,"start_character":41,"end_line":517,"end_character":51},"updated":"2022-03-10 15:01:12.000000000","message":"apart from \"False\" and \"\u003cis\u003e False\" (same for True), are there any other valid values for compression? and where are these documented?","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"39487c753a740fcedb8ac63cc6cc2f0d97d66bc7","unresolved":true,"context_lines":[{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        vol_type2 \u003d test_utils.create_volume_type("},{"line_number":516,"context_line":"            self.ctxt, self,"},{"line_number":517,"context_line":"            extra_specs\u003d{\u0027compression\u0027: \u0027\u003cis\u003e False\u0027},"},{"line_number":518,"context_line":"            name\u003d\u0027my_vol_type2\u0027)"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"        vol_type3 \u003d test_utils.create_volume_type("}],"source_content_type":"text/x-python","patch_set":7,"id":"58ffbb2e_ab929bfa","line":517,"range":{"start_line":517,"start_character":41,"end_line":517,"end_character":51},"in_reply_to":"c05b75eb_0d40efa4","updated":"2022-03-10 16:23:25.000000000","message":"\u0027compression\u0027 is one of the generic capabilities reported by the show-capabilities request.  It\u0027s documented as:\n\n        \"compression\": {\n            \"title\": \"Compression\",\n            \"description\": \"Enables compression.\",\n            \"type\": \"boolean\"\n        },\n\nI think it\u0027s also documented here:\nhttps://docs.openstack.org/cinder/latest/admin/get-capabilities.html","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"17a3b7a68a8e2c54ae33542f4e2c8e54cbb958a8","unresolved":true,"context_lines":[{"line_number":514,"context_line":""},{"line_number":515,"context_line":"        vol_type2 \u003d test_utils.create_volume_type("},{"line_number":516,"context_line":"            self.ctxt, self,"},{"line_number":517,"context_line":"            extra_specs\u003d{\u0027compression\u0027: \u0027\u003cis\u003e False\u0027},"},{"line_number":518,"context_line":"            name\u003d\u0027my_vol_type2\u0027)"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"        vol_type3 \u003d test_utils.create_volume_type("}],"source_content_type":"text/x-python","patch_set":7,"id":"bd7654bb_fc66bfec","line":517,"range":{"start_line":517,"start_character":41,"end_line":517,"end_character":51},"in_reply_to":"c05b75eb_0d40efa4","updated":"2022-03-10 16:36:04.000000000","message":"yes, you can check the extra_specs_ops.py file","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"}],"cinder/volume/drivers/lightos.py":[{"author":{"_account_id":34544,"name":"Ronen weiss","email":"ronen@lightbitslabs.com","username":"ronenwe"},"change_message_id":"d5e92aaed5800d2938dfa6abfdcc2e8e65e346f7","unresolved":false,"context_lines":[{"line_number":573,"context_line":""},{"line_number":574,"context_line":"        specs \u003d getattr(volume.volume_type, \u0027extra_specs\u0027, {})"},{"line_number":575,"context_line":"        type_compression \u003d specs.get(\u0027compression\u0027, default_compression)"},{"line_number":576,"context_line":"        compression \u003d self._parse_extra_spec(type_compression,"},{"line_number":577,"context_line":"                                             default_compression)"},{"line_number":578,"context_line":"        num_replicas \u003d str(specs.get(\u0027lightos:num_replicas\u0027, num_replicas))"},{"line_number":579,"context_line":"        project_name \u003d specs.get("}],"source_content_type":"text/x-python","patch_set":3,"id":"a5820795_625c83d6","line":576,"updated":"2022-02-23 13:54:30.000000000","message":"looks legit","commit_id":"15b76863a256a59e3d6e86d13dffefbc07bc97de"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"fcf74d766c6026aa793472549a44d41efdba5085","unresolved":true,"context_lines":[{"line_number":993,"context_line":"                \u0027QoS_support\u0027: False,"},{"line_number":994,"context_line":"                \u0027online_extend_support\u0027: True,"},{"line_number":995,"context_line":"                \u0027thin_provisioning_support\u0027: True,"},{"line_number":996,"context_line":"                \u0027compression\u0027: [True, False],"},{"line_number":997,"context_line":"                \u0027multiattach\u0027: True}"},{"line_number":998,"context_line":"        # data[\u0027total_capacity_gb\u0027] \u003d"},{"line_number":999,"context_line":"        # self.byte_to_gb(cluster_stats[\u0027effectivePhysicalStorage\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"ec00f612_1e013411","line":996,"range":{"start_line":996,"start_character":31,"end_line":996,"end_character":44},"updated":"2022-03-03 13:40:02.000000000","message":"If I understand correctly, the way compression works for lightos is:\n\n- The backend can do compression\n- There\u0027s no special license required or anything like that, that the driver needs to communicate back to cinder for compression to be available\n- The config opt \u0027lightos_default_compression_enabled\u0027 gives the default for whether compression will be used when there\u0027s no extra_spec in the volume type\n- If there\u0027s a compression extra_spec in the volume type, it overrides the config option (so that even if lightos_default_compression_enabled\u003dFalse, if the extra_spec says to use compression, compression is used)\n\nI think under these circumstances, you want to return True here to indicate that compression is available.  (If the opt is False, that\u0027s ok, because you allow the volume-type to override.  So if someone is using a generic volume type that enables compression, the scheduler will know that it can be built on lightos.","commit_id":"f8cd8d9faa1c6b9d88c5d3c4d88da256e50b028d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"59250768c5f118dcf0e51fb4be422706b513adfe","unresolved":true,"context_lines":[{"line_number":993,"context_line":"                \u0027QoS_support\u0027: False,"},{"line_number":994,"context_line":"                \u0027online_extend_support\u0027: True,"},{"line_number":995,"context_line":"                \u0027thin_provisioning_support\u0027: True,"},{"line_number":996,"context_line":"                \u0027compression\u0027: [True, False],"},{"line_number":997,"context_line":"                \u0027multiattach\u0027: True}"},{"line_number":998,"context_line":"        # data[\u0027total_capacity_gb\u0027] \u003d"},{"line_number":999,"context_line":"        # self.byte_to_gb(cluster_stats[\u0027effectivePhysicalStorage\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"cc88e51d_6edbb7c7","line":996,"range":{"start_line":996,"start_character":31,"end_line":996,"end_character":44},"in_reply_to":"bcebadea_de115f50","updated":"2022-03-03 16:07:09.000000000","message":"I looked into this a bit with Gorka and he said the correct thing to do here is the list that you have, so I withdraw my objection.\n\nYou need to document somewhere (one place could be the help text for the lightos_default_compression_enabled option, but also in your driver docs) that operators should always set compression in the volume type extra_specs so that they know what they\u0027re getting.","commit_id":"f8cd8d9faa1c6b9d88c5d3c4d88da256e50b028d"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"43f288aa3a220538c7f01becd7d2d635bc75862b","unresolved":false,"context_lines":[{"line_number":993,"context_line":"                \u0027QoS_support\u0027: False,"},{"line_number":994,"context_line":"                \u0027online_extend_support\u0027: True,"},{"line_number":995,"context_line":"                \u0027thin_provisioning_support\u0027: True,"},{"line_number":996,"context_line":"                \u0027compression\u0027: [True, False],"},{"line_number":997,"context_line":"                \u0027multiattach\u0027: True}"},{"line_number":998,"context_line":"        # data[\u0027total_capacity_gb\u0027] \u003d"},{"line_number":999,"context_line":"        # self.byte_to_gb(cluster_stats[\u0027effectivePhysicalStorage\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"f219538d_8d2ad3f9","line":996,"range":{"start_line":996,"start_character":31,"end_line":996,"end_character":44},"in_reply_to":"cc88e51d_6edbb7c7","updated":"2022-03-08 13:43:26.000000000","message":"Done","commit_id":"f8cd8d9faa1c6b9d88c5d3c4d88da256e50b028d"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"e2098802794d9babaa97a4e832d248e8cb209597","unresolved":true,"context_lines":[{"line_number":993,"context_line":"                \u0027QoS_support\u0027: False,"},{"line_number":994,"context_line":"                \u0027online_extend_support\u0027: True,"},{"line_number":995,"context_line":"                \u0027thin_provisioning_support\u0027: True,"},{"line_number":996,"context_line":"                \u0027compression\u0027: [True, False],"},{"line_number":997,"context_line":"                \u0027multiattach\u0027: True}"},{"line_number":998,"context_line":"        # data[\u0027total_capacity_gb\u0027] \u003d"},{"line_number":999,"context_line":"        # self.byte_to_gb(cluster_stats[\u0027effectivePhysicalStorage\u0027])"}],"source_content_type":"text/x-python","patch_set":5,"id":"bcebadea_de115f50","line":996,"range":{"start_line":996,"start_character":31,"end_line":996,"end_character":44},"in_reply_to":"ec00f612_1e013411","updated":"2022-03-03 15:26:38.000000000","message":"Hey,\n\nFromw my testing, if the compression this line is:\n    compression:True\n\nI cannot create a volume type with \"compression\u003dFalse\"\nso if default_compression is enabled, I can create 1. default volume, 2. volume with type compression\u003dTrue.\nso eventually I cant create volume with compression\u003dFalse","commit_id":"f8cd8d9faa1c6b9d88c5d3c4d88da256e50b028d"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"311931b449c03614d2f86732e37c244c824b22b8","unresolved":true,"context_lines":[{"line_number":69,"context_line":"                    \u0027 volume.\u0027),"},{"line_number":70,"context_line":"    cfg.BoolOpt(\u0027lightos_default_compression_enabled\u0027,"},{"line_number":71,"context_line":"                default\u003dFalse,"},{"line_number":72,"context_line":"                help\u003d\u0027Set to True to create  new volumes compressed assuming\u0027"},{"line_number":73,"context_line":"                     \u0027 no other compression setting is specified via the\u0027"},{"line_number":74,"context_line":"                     \u0027 volumes type.\u0027),"},{"line_number":75,"context_line":"    cfg.IntOpt(\u0027lightos_api_service_timeout\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"92ac1192_25965256","line":72,"range":{"start_line":72,"start_character":43,"end_line":72,"end_character":45},"updated":"2022-03-09 14:02:38.000000000","message":"nit: 2 spaces","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"311931b449c03614d2f86732e37c244c824b22b8","unresolved":true,"context_lines":[{"line_number":71,"context_line":"                default\u003dFalse,"},{"line_number":72,"context_line":"                help\u003d\u0027Set to True to create  new volumes compressed assuming\u0027"},{"line_number":73,"context_line":"                     \u0027 no other compression setting is specified via the\u0027"},{"line_number":74,"context_line":"                     \u0027 volumes type.\u0027),"},{"line_number":75,"context_line":"    cfg.IntOpt(\u0027lightos_api_service_timeout\u0027,"},{"line_number":76,"context_line":"               default\u003d30,"},{"line_number":77,"context_line":"               help\u003d\u0027The default amount of time (in seconds) to wait for\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"32009760_feb0a098","line":74,"range":{"start_line":74,"start_character":23,"end_line":74,"end_character":36},"updated":"2022-03-09 14:02:38.000000000","message":"nit: technically, this should be \" volume\u0027s type.\"","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0d63eeb4e6f90a181e2c8a9890c08fa2177b43c7","unresolved":true,"context_lines":[{"line_number":557,"context_line":"    def _parse_extra_spec(self, extra_spec_value, default_value):"},{"line_number":558,"context_line":"        extra_spec_value \u003d str(extra_spec_value)"},{"line_number":559,"context_line":"        extra_spec_value \u003d extra_spec_value.casefold()"},{"line_number":560,"context_line":"        if \"true\" in extra_spec_value:"},{"line_number":561,"context_line":"            return \"True\""},{"line_number":562,"context_line":"        elif \"false\" in extra_spec_value:"},{"line_number":563,"context_line":"            return \"False\""}],"source_content_type":"text/x-python","patch_set":7,"id":"329a8040_5210f1d8","line":560,"range":{"start_line":560,"start_character":11,"end_line":560,"end_character":37},"updated":"2022-03-10 15:01:12.000000000","message":"what are all the possible values of compression? looking at the tests, i assume it\u0027s \"\u003cis\u003e True\" and \"True\" (same for false)\nIf that\u0027s true then this logic is wrong, an operator could supply a value like compression: \"xyzabc true\" and this will return true which is not correct.","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"17a3b7a68a8e2c54ae33542f4e2c8e54cbb958a8","unresolved":true,"context_lines":[{"line_number":557,"context_line":"    def _parse_extra_spec(self, extra_spec_value, default_value):"},{"line_number":558,"context_line":"        extra_spec_value \u003d str(extra_spec_value)"},{"line_number":559,"context_line":"        extra_spec_value \u003d extra_spec_value.casefold()"},{"line_number":560,"context_line":"        if \"true\" in extra_spec_value:"},{"line_number":561,"context_line":"            return \"True\""},{"line_number":562,"context_line":"        elif \"false\" in extra_spec_value:"},{"line_number":563,"context_line":"            return \"False\""}],"source_content_type":"text/x-python","patch_set":7,"id":"dbbce879_d7a27818","line":560,"range":{"start_line":560,"start_character":11,"end_line":560,"end_character":37},"in_reply_to":"329a8040_5210f1d8","updated":"2022-03-10 16:36:04.000000000","message":"from the sched point of view \"xynz true\" -\u003e True","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0d63eeb4e6f90a181e2c8a9890c08fa2177b43c7","unresolved":true,"context_lines":[{"line_number":555,"context_line":"        return state"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"    def _parse_extra_spec(self, extra_spec_value, default_value):"},{"line_number":558,"context_line":"        extra_spec_value \u003d str(extra_spec_value)"},{"line_number":559,"context_line":"        extra_spec_value \u003d extra_spec_value.casefold()"},{"line_number":560,"context_line":"        if \"true\" in extra_spec_value:"},{"line_number":561,"context_line":"            return \"True\""},{"line_number":562,"context_line":"        elif \"false\" in extra_spec_value:"},{"line_number":563,"context_line":"            return \"False\""},{"line_number":564,"context_line":"        return default_value"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    def _get_volume_specs(self, volume):"},{"line_number":567,"context_line":"        default_compression \u003d \u0027True\u0027 if self.configuration. \\"}],"source_content_type":"text/x-python","patch_set":7,"id":"0686b5a8_3c647e4f","line":564,"range":{"start_line":558,"start_character":0,"end_line":564,"end_character":28},"updated":"2022-03-10 15:01:12.000000000","message":"I think it\u0027s better to map all the possible values rather than just comparing a value inside a string, as mentioned above any wrong string with a substring \"true\" or \"false\" value could break this logic.\nThe mapping could be done efficiently like this:\n\n    isTrue, isFalse \u003d \"True\", \"False\"\n    extra_spec_map \u003d {\"true\": isTrue, \"\u003cis\u003e true\": isTrue, \"false\": isFalse, \"\u003cis\u003e false\": isFalse}\n    extra_spec_value \u003d str(extra_spec_value).casefold()\n    return extra_spec_map.get(extra_spec_value, default_value)","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"39487c753a740fcedb8ac63cc6cc2f0d97d66bc7","unresolved":true,"context_lines":[{"line_number":555,"context_line":"        return state"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"    def _parse_extra_spec(self, extra_spec_value, default_value):"},{"line_number":558,"context_line":"        extra_spec_value \u003d str(extra_spec_value)"},{"line_number":559,"context_line":"        extra_spec_value \u003d extra_spec_value.casefold()"},{"line_number":560,"context_line":"        if \"true\" in extra_spec_value:"},{"line_number":561,"context_line":"            return \"True\""},{"line_number":562,"context_line":"        elif \"false\" in extra_spec_value:"},{"line_number":563,"context_line":"            return \"False\""},{"line_number":564,"context_line":"        return default_value"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    def _get_volume_specs(self, volume):"},{"line_number":567,"context_line":"        default_compression \u003d \u0027True\u0027 if self.configuration. \\"}],"source_content_type":"text/x-python","patch_set":7,"id":"2c79a9b8_ca10afe2","line":564,"range":{"start_line":558,"start_character":0,"end_line":564,"end_character":28},"in_reply_to":"0686b5a8_3c647e4f","updated":"2022-03-10 16:23:25.000000000","message":"either that or you could do something like _parse_boolean_extra_spec() from cinder/volume/drivers/qnap.py  ... from a quick look at the drivers , seems like everyone does their own thing on this","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"17a3b7a68a8e2c54ae33542f4e2c8e54cbb958a8","unresolved":true,"context_lines":[{"line_number":555,"context_line":"        return state"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"    def _parse_extra_spec(self, extra_spec_value, default_value):"},{"line_number":558,"context_line":"        extra_spec_value \u003d str(extra_spec_value)"},{"line_number":559,"context_line":"        extra_spec_value \u003d extra_spec_value.casefold()"},{"line_number":560,"context_line":"        if \"true\" in extra_spec_value:"},{"line_number":561,"context_line":"            return \"True\""},{"line_number":562,"context_line":"        elif \"false\" in extra_spec_value:"},{"line_number":563,"context_line":"            return \"False\""},{"line_number":564,"context_line":"        return default_value"},{"line_number":565,"context_line":""},{"line_number":566,"context_line":"    def _get_volume_specs(self, volume):"},{"line_number":567,"context_line":"        default_compression \u003d \u0027True\u0027 if self.configuration. \\"}],"source_content_type":"text/x-python","patch_set":7,"id":"d1cc57f0_3be9ba02","line":564,"range":{"start_line":558,"start_character":0,"end_line":564,"end_character":28},"in_reply_to":"2c79a9b8_ca10afe2","updated":"2022-03-10 16:36:04.000000000","message":"I will add it in a follow up.","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"0d63eeb4e6f90a181e2c8a9890c08fa2177b43c7","unresolved":true,"context_lines":[{"line_number":994,"context_line":"                \u0027QoS_support\u0027: False,"},{"line_number":995,"context_line":"                \u0027online_extend_support\u0027: True,"},{"line_number":996,"context_line":"                \u0027thin_provisioning_support\u0027: True,"},{"line_number":997,"context_line":"                \u0027compression\u0027: [True, False],"},{"line_number":998,"context_line":"                \u0027multiattach\u0027: True}"},{"line_number":999,"context_line":"        # data[\u0027total_capacity_gb\u0027] \u003d"},{"line_number":1000,"context_line":"        # self.byte_to_gb(cluster_stats[\u0027effectivePhysicalStorage\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"a96dc5ed_fbb205d0","line":997,"range":{"start_line":997,"start_character":31,"end_line":997,"end_character":44},"updated":"2022-03-10 15:01:12.000000000","message":"why is this returned as list and not boolean? shouldn\u0027t this be True according to the reasoning given in commit message.","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"},{"author":{"_account_id":27615,"name":"Rajat Dhasmana","email":"rajatdhasmana@gmail.com","username":"whoami-rajat"},"change_message_id":"de7c598f5d9a82351c9faec07fecb26c177b807e","unresolved":false,"context_lines":[{"line_number":994,"context_line":"                \u0027QoS_support\u0027: False,"},{"line_number":995,"context_line":"                \u0027online_extend_support\u0027: True,"},{"line_number":996,"context_line":"                \u0027thin_provisioning_support\u0027: True,"},{"line_number":997,"context_line":"                \u0027compression\u0027: [True, False],"},{"line_number":998,"context_line":"                \u0027multiattach\u0027: True}"},{"line_number":999,"context_line":"        # data[\u0027total_capacity_gb\u0027] \u003d"},{"line_number":1000,"context_line":"        # self.byte_to_gb(cluster_stats[\u0027effectivePhysicalStorage\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"69e31184_39ecf153","line":997,"range":{"start_line":997,"start_character":31,"end_line":997,"end_character":44},"in_reply_to":"32d3d64e_0db55afe","updated":"2022-03-10 20:37:46.000000000","message":"Ack","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"},{"author":{"_account_id":33612,"name":"yuval","email":"yuval@lightbitslabs.com","username":"yuval"},"change_message_id":"17a3b7a68a8e2c54ae33542f4e2c8e54cbb958a8","unresolved":true,"context_lines":[{"line_number":994,"context_line":"                \u0027QoS_support\u0027: False,"},{"line_number":995,"context_line":"                \u0027online_extend_support\u0027: True,"},{"line_number":996,"context_line":"                \u0027thin_provisioning_support\u0027: True,"},{"line_number":997,"context_line":"                \u0027compression\u0027: [True, False],"},{"line_number":998,"context_line":"                \u0027multiattach\u0027: True}"},{"line_number":999,"context_line":"        # data[\u0027total_capacity_gb\u0027] \u003d"},{"line_number":1000,"context_line":"        # self.byte_to_gb(cluster_stats[\u0027effectivePhysicalStorage\u0027])"}],"source_content_type":"text/x-python","patch_set":7,"id":"32d3d64e_0db55afe","line":997,"range":{"start_line":997,"start_character":31,"end_line":997,"end_character":44},"in_reply_to":"a96dc5ed_fbb205d0","updated":"2022-03-10 16:36:04.000000000","message":"well if this is False, we cannot create volume with type compression\u003d\u003dTrue\nif its True you cannot create volume with type compression\u003d\u003dFalse\nso this is the way to go if you want to do both.","commit_id":"96f3246b7ecb02c82fb30115be206b7c08abccdb"}]}