)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":33431,"name":"Fábio Oliveira","email":"fabioaurelio1269@gmail.com","username":"fabiooliveira1"},"change_message_id":"57f626e4473ce70d51e91157a9503d6a68aff8ee","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"e79708c9_72aee112","updated":"2022-03-18 15:00:09.000000000","message":"LGTM. It does make sense to initiate only where it will be used","commit_id":"373696fd5d489532dcbcdefbe3979f3be2cd65ce"},{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"920e1fe61a70bc36fb63b0b70ec210d24174de67","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"b89e6bce_d5a059d1","updated":"2022-03-18 15:21:17.000000000","message":"Looks worth doing.","commit_id":"373696fd5d489532dcbcdefbe3979f3be2cd65ce"},{"author":{"_account_id":10459,"name":"Luigi Toscano","email":"ltoscano@redhat.com","username":"ltoscano"},"change_message_id":"36e8313b566fbf0f1b4521db564a1ec7ef4c965b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"541a17a0_d8974bdd","updated":"2022-03-18 14:55:12.000000000","message":"Shouldn\u0027t the same approach implemented in https://review.opendev.org/c/openstack/cinder/+/830634/ be applied here too then? Or is the initialization of such objcts (the call to API()) not going to happen so frequently to justify caching the result of foo.API()?","commit_id":"373696fd5d489532dcbcdefbe3979f3be2cd65ce"}],"cinder/volume/flows/manager/create_volume.py":[{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e3d22fbe95126f0928f3fc11a6a049ad638a7d69","unresolved":true,"context_lines":[{"line_number":393,"context_line":"        self.db \u003d db"},{"line_number":394,"context_line":"        self.driver \u003d driver"},{"line_number":395,"context_line":"        self.image_volume_cache \u003d image_volume_cache"},{"line_number":396,"context_line":"        self.message \u003d message_api.API()"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    def _handle_bootable_volume_glance_meta(self, context, volume,"},{"line_number":399,"context_line":"                                            **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"b658ada7_3f7d3292","line":396,"range":{"start_line":396,"start_character":23,"end_line":396,"end_character":40},"updated":"2022-02-23 15:28:45.000000000","message":"A similar but slightly more complicated optimization could be found here -- make a get_message_api() method that only inits the message API when it is needed.  (i.e. when a failure occurs)","commit_id":"373696fd5d489532dcbcdefbe3979f3be2cd65ce"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"e87e9209325887c58569db8b51a076e0f5238cad","unresolved":false,"context_lines":[{"line_number":393,"context_line":"        self.db \u003d db"},{"line_number":394,"context_line":"        self.driver \u003d driver"},{"line_number":395,"context_line":"        self.image_volume_cache \u003d image_volume_cache"},{"line_number":396,"context_line":"        self.message \u003d message_api.API()"},{"line_number":397,"context_line":""},{"line_number":398,"context_line":"    def _handle_bootable_volume_glance_meta(self, context, volume,"},{"line_number":399,"context_line":"                                            **kwargs):"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a7d848b_606f57d5","line":396,"range":{"start_line":396,"start_character":23,"end_line":396,"end_character":40},"in_reply_to":"b658ada7_3f7d3292","updated":"2022-02-23 15:41:43.000000000","message":"Implemented here:\n    https://review.opendev.org/c/openstack/cinder/+/830634","commit_id":"373696fd5d489532dcbcdefbe3979f3be2cd65ce"}]}