)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":5314,"name":"Brian Rosmaita","email":"rosmaita.fossdev@gmail.com","username":"brian-rosmaita"},"change_message_id":"2c649e243c73f597e5fdfff965a7e30f685b1910","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":2,"id":"32a72d29_54c89f2a","updated":"2022-03-16 15:14:55.000000000","message":"Thanks, Eric.  LGTM.","commit_id":"a1e34fc6dcbb515585b8fc37f26766e055c9f3fb"}],"cinder/tests/unit/api/test_versions.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3a5ac1f647cd9b09be58bddf69eb8c3505ce73b6","unresolved":true,"context_lines":[{"line_number":452,"context_line":"        versions_present \u003d list(v for v in a if re.match(r\u0027[A-Z]+[A-Z_]*\u0027, v))"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"        max_mv \u003d api_version_request._MAX_API_VERSION"},{"line_number":455,"context_line":"        count \u003d len(list(v for v in versions_present if"},{"line_number":456,"context_line":"                         getattr(microversions, v) \u003d\u003d max_mv))"},{"line_number":457,"context_line":"        self.assertEqual("},{"line_number":458,"context_line":"            count, 1, max_mv + \u0027 should be present once in microversions.py\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3bab2246_1cc1d48f","line":456,"range":{"start_line":455,"start_character":0,"end_line":456,"end_character":62},"updated":"2022-02-23 18:59:23.000000000","message":"nit: don\u0027t need the list conversion:\n\n        count \u003d len(v for v in versions_present\n                    if getattr(microversions, v) \u003d\u003d max_mv)","commit_id":"186a6d36f73d2da538dd31a4b51a8fc57ea41e1f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"9c55b9fd65fa385a800f540d3f856f73db9bbc1b","unresolved":false,"context_lines":[{"line_number":452,"context_line":"        versions_present \u003d list(v for v in a if re.match(r\u0027[A-Z]+[A-Z_]*\u0027, v))"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"        max_mv \u003d api_version_request._MAX_API_VERSION"},{"line_number":455,"context_line":"        count \u003d len(list(v for v in versions_present if"},{"line_number":456,"context_line":"                         getattr(microversions, v) \u003d\u003d max_mv))"},{"line_number":457,"context_line":"        self.assertEqual("},{"line_number":458,"context_line":"            count, 1, max_mv + \u0027 should be present once in microversions.py\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"79066e9e_b042e3fe","line":456,"range":{"start_line":455,"start_character":0,"end_line":456,"end_character":62},"in_reply_to":"0ebaf828_99aa5059","updated":"2022-02-23 20:54:35.000000000","message":"You actually do -- otherwise you get an error because it\u0027s a generator that doesn\u0027t implement len().","commit_id":"186a6d36f73d2da538dd31a4b51a8fc57ea41e1f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4e34492e305a04a98a2438719037dc7cf114ac4d","unresolved":false,"context_lines":[{"line_number":452,"context_line":"        versions_present \u003d list(v for v in a if re.match(r\u0027[A-Z]+[A-Z_]*\u0027, v))"},{"line_number":453,"context_line":""},{"line_number":454,"context_line":"        max_mv \u003d api_version_request._MAX_API_VERSION"},{"line_number":455,"context_line":"        count \u003d len(list(v for v in versions_present if"},{"line_number":456,"context_line":"                         getattr(microversions, v) \u003d\u003d max_mv))"},{"line_number":457,"context_line":"        self.assertEqual("},{"line_number":458,"context_line":"            count, 1, max_mv + \u0027 should be present once in microversions.py\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"0ebaf828_99aa5059","line":456,"range":{"start_line":455,"start_character":0,"end_line":456,"end_character":62},"in_reply_to":"3bab2246_1cc1d48f","updated":"2022-02-23 20:50:33.000000000","message":"Ack","commit_id":"186a6d36f73d2da538dd31a4b51a8fc57ea41e1f"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3a5ac1f647cd9b09be58bddf69eb8c3505ce73b6","unresolved":true,"context_lines":[{"line_number":455,"context_line":"        count \u003d len(list(v for v in versions_present if"},{"line_number":456,"context_line":"                         getattr(microversions, v) \u003d\u003d max_mv))"},{"line_number":457,"context_line":"        self.assertEqual("},{"line_number":458,"context_line":"            count, 1, max_mv + \u0027 should be present once in microversions.py\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"c2446512_0406fb64","line":458,"updated":"2022-02-23 18:59:23.000000000","message":"-1: Order of parameters is expected, then then value we want to check\n\n  1, count, max_mv + ...","commit_id":"186a6d36f73d2da538dd31a4b51a8fc57ea41e1f"},{"author":{"_account_id":4523,"name":"Eric Harney","email":"eharney@redhat.com","username":"eharney"},"change_message_id":"4e34492e305a04a98a2438719037dc7cf114ac4d","unresolved":true,"context_lines":[{"line_number":455,"context_line":"        count \u003d len(list(v for v in versions_present if"},{"line_number":456,"context_line":"                         getattr(microversions, v) \u003d\u003d max_mv))"},{"line_number":457,"context_line":"        self.assertEqual("},{"line_number":458,"context_line":"            count, 1, max_mv + \u0027 should be present once in microversions.py\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"e14e9561_3652af0e","line":458,"in_reply_to":"c2446512_0406fb64","updated":"2022-02-23 20:50:33.000000000","message":"I will, apparently, never remember this.  Should write a check that looks for constants in these calls...","commit_id":"186a6d36f73d2da538dd31a4b51a8fc57ea41e1f"}]}