)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":34541,"name":"Manish","email":"manish.laddha@ibm.com","username":"manishladdha"},"change_message_id":"1b7b6ec59c63fa9c6ba5725383cdf19ce605ebb9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"d1555d7b_aa08364d","updated":"2022-04-07 13:55:15.000000000","message":"looks good.","commit_id":"f003e00d47c5d086e5fb69bc9395c735ee302f76"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"25a049b448762c6014368996a2d2ad1631db2a89","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"58301500_9aafa278","updated":"2022-03-01 14:52:40.000000000","message":"run-IBM Storage CI","commit_id":"f003e00d47c5d086e5fb69bc9395c735ee302f76"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"bd4fca6045d930e64e1c395175067f0ec899a066","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"b6feef21_f120a1ca","updated":"2022-04-12 04:12:25.000000000","message":"run-IBM Storage CI","commit_id":"8b78e7626b1ac50d2bff5af00561fe01b57a22f4"},{"author":{"_account_id":32966,"name":"jiang guodao","email":"jguodao@vmware.com","username":"jguodao"},"change_message_id":"5abddac917017f9cdebf0d7e02f7ed2a5c95a1f8","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"4b5ea45a_05ebe5de","updated":"2022-04-12 02:13:32.000000000","message":"vmware-recheck-patch","commit_id":"8b78e7626b1ac50d2bff5af00561fe01b57a22f4"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3d1ef50998cb1f841ef32a0758588484406a54b6","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"1931fa1c_ea75bc2d","updated":"2022-04-18 18:42:12.000000000","message":"I admit I don\u0027t fully understand what the code does at the storage array level, since I\u0027m not familiar with this storage system, but the code itself looks ok to me.\n\nThe downvote is because some asserts in the tests are in inverse order, they are (actual, expected) instead of (expected, actual) like they should be.","commit_id":"0d1a50d7288e015cf0b4c25d6c899484504fb04d"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"1a7b11e93ea412067b091040d7ef550b8b967200","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"33faa9e2_bb6beab3","updated":"2022-04-14 05:42:29.000000000","message":"recheck","commit_id":"0d1a50d7288e015cf0b4c25d6c899484504fb04d"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"aada96032a7c10b8e064a4f25374dae2553c06e0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"53e33a68_3241610e","updated":"2022-04-13 14:21:55.000000000","message":"recheck","commit_id":"0d1a50d7288e015cf0b4c25d6c899484504fb04d"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"30eb0b4c8669b91aa1fa0a5c937ba378c0a9dcf4","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"48fce47e_f07605b7","updated":"2022-04-14 09:50:25.000000000","message":"run-DellEMC Unity CI","commit_id":"0d1a50d7288e015cf0b4c25d6c899484504fb04d"},{"author":{"_account_id":33807,"name":"Jacob Wang","email":"jacob_wang1@dell.com","username":"jacob0522"},"change_message_id":"d7972be201295ee8ceab68c3ee355a61c3cc73df","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":4,"id":"af02dda9_af20db61","updated":"2022-04-14 09:19:15.000000000","message":"run-DellEMC Unity CI","commit_id":"0d1a50d7288e015cf0b4c25d6c899484504fb04d"},{"author":{"_account_id":32074,"name":"Harsh Ailani","email":"haailani@in.ibm.com","username":"haailani"},"change_message_id":"7448c5b7348dae0e7305b36997f461136e6fdd3c","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"f846d583_80103e35","updated":"2022-04-20 07:13:40.000000000","message":"Changes look good. Zuul and IBM CI passed as well.","commit_id":"f8f9bfabf9824cd5f9cb12c5368116fcfe0dec83"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"3542f53a8d4b8f6dd74cb2f73e77de2a79440dbe","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"c063c787_2d11f502","updated":"2022-04-20 11:45:38.000000000","message":"LGTM. Thanks for addressing my comments","commit_id":"f8f9bfabf9824cd5f9cb12c5368116fcfe0dec83"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3b803291eb9befa40e0f7932822ed3bbf35a52e5","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"d69d9d4a_0ac590b8","updated":"2022-04-19 15:51:23.000000000","message":"Thanks for addressing my comments.","commit_id":"f8f9bfabf9824cd5f9cb12c5368116fcfe0dec83"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"fe9bcb072383303cb6a96c399b8f42d8e3305788","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"304ec386_9bf230e6","updated":"2022-04-19 14:30:19.000000000","message":"run-IBM Storage CI","commit_id":"f8f9bfabf9824cd5f9cb12c5368116fcfe0dec83"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"21d821de213773b6c62294e48556f45adc11a92a","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"57dc31cd_32d95b5e","updated":"2022-04-19 13:01:25.000000000","message":"run-IBM Storage CI","commit_id":"f8f9bfabf9824cd5f9cb12c5368116fcfe0dec83"}],"cinder/tests/unit/volume/drivers/ibm/test_storwize_svc.py":[{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3d1ef50998cb1f841ef32a0758588484406a54b6","unresolved":true,"context_lines":[{"line_number":12230,"context_line":"                         add_volumes_update)"},{"line_number":12231,"context_line":"        self.assertEqual([], remove_volumes_update)"},{"line_number":12232,"context_line":"        rccg_info \u003d self.driver._helpers.get_rccg(rccg_name)"},{"line_number":12233,"context_line":"        self.assertEqual(rccg_info[\u0027cycling_mode\u0027], \u0027none\u0027)"},{"line_number":12234,"context_line":"        rcrel \u003d self.driver._helpers.get_relationship_info(gm_vol.name)"},{"line_number":12235,"context_line":"        self.assertEqual(rcrel[\u0027master_change_vdisk_name\u0027], \u0027\u0027)"},{"line_number":12236,"context_line":"        self.assertEqual(rcrel[\u0027aux_change_vdisk_name\u0027], \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"099bf569_022bf1ea","line":12233,"updated":"2022-04-18 18:42:12.000000000","message":"-1: Asserts must always be (expected, actual) like you are doing in all the previous ones.\n\n  self.assertEqual(\u0027none\u0027, rccg_info[\u0027cycling_mode\u0027])\n\nSame on L12235, L12236,L12248, L12250, L12252, etc.","commit_id":"0d1a50d7288e015cf0b4c25d6c899484504fb04d"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"a9bfc03db105a9a1c351b4ee9ca76d0ba5f97b5e","unresolved":false,"context_lines":[{"line_number":12230,"context_line":"                         add_volumes_update)"},{"line_number":12231,"context_line":"        self.assertEqual([], remove_volumes_update)"},{"line_number":12232,"context_line":"        rccg_info \u003d self.driver._helpers.get_rccg(rccg_name)"},{"line_number":12233,"context_line":"        self.assertEqual(rccg_info[\u0027cycling_mode\u0027], \u0027none\u0027)"},{"line_number":12234,"context_line":"        rcrel \u003d self.driver._helpers.get_relationship_info(gm_vol.name)"},{"line_number":12235,"context_line":"        self.assertEqual(rcrel[\u0027master_change_vdisk_name\u0027], \u0027\u0027)"},{"line_number":12236,"context_line":"        self.assertEqual(rcrel[\u0027aux_change_vdisk_name\u0027], \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":4,"id":"4d71d0a5_b48350bb","line":12233,"in_reply_to":"099bf569_022bf1ea","updated":"2022-04-19 11:10:10.000000000","message":"Thanks for the comment. Addressed it.","commit_id":"0d1a50d7288e015cf0b4c25d6c899484504fb04d"}],"cinder/volume/drivers/ibm/storwize_svc/storwize_svc_common.py":[{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"ebfc63be540b61024ed23e1c5896bead1b83cbd7","unresolved":true,"context_lines":[{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    def ch_rcconsistgrp_cyclingmode(self, consistgrp,"},{"line_number":376,"context_line":"                                    cyclingmode):"},{"line_number":377,"context_line":"        if cyclingmode:"},{"line_number":378,"context_line":"            ssh_cmd \u003d [\u0027svctask\u0027, \u0027chrcconsistgrp\u0027]"},{"line_number":379,"context_line":"            ssh_cmd.extend([\u0027-cyclingmode\u0027,"},{"line_number":380,"context_line":"                            str(cyclingmode)])"}],"source_content_type":"text/x-python","patch_set":1,"id":"d534e8fe_8a28db85","line":377,"range":{"start_line":377,"start_character":11,"end_line":377,"end_character":22},"updated":"2022-04-08 15:02:36.000000000","message":"With a current implementation this statement will be always True, why do we need it?","commit_id":"f003e00d47c5d086e5fb69bc9395c735ee302f76"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"89ef3fa9bfc9e8489e96be3c36f487f2590a4500","unresolved":false,"context_lines":[{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    def ch_rcconsistgrp_cyclingmode(self, consistgrp,"},{"line_number":376,"context_line":"                                    cyclingmode):"},{"line_number":377,"context_line":"        if cyclingmode:"},{"line_number":378,"context_line":"            ssh_cmd \u003d [\u0027svctask\u0027, \u0027chrcconsistgrp\u0027]"},{"line_number":379,"context_line":"            ssh_cmd.extend([\u0027-cyclingmode\u0027,"},{"line_number":380,"context_line":"                            str(cyclingmode)])"}],"source_content_type":"text/x-python","patch_set":1,"id":"8dc77eb0_51b78647","line":377,"range":{"start_line":377,"start_character":11,"end_line":377,"end_character":22},"in_reply_to":"d534e8fe_8a28db85","updated":"2022-04-12 08:03:14.000000000","message":"Hi Ivan,\n\nRemoved the \"cyclingmode\" condition check as it is always true.\n\nThe default value of cyclingmode is \u0027none\u0027. Made the changes accordingly by setting default value as \u0027none\u0027.","commit_id":"f003e00d47c5d086e5fb69bc9395c735ee302f76"},{"author":{"_account_id":1736,"name":"Ivan Kolodyazhny","email":"e0ne@e0ne.info","username":"e0ne"},"change_message_id":"ebfc63be540b61024ed23e1c5896bead1b83cbd7","unresolved":true,"context_lines":[{"line_number":3995,"context_line":"                        if rccg_name:"},{"line_number":3996,"context_line":"                            master_helper.stop_rccg(rccg_name)"},{"line_number":3997,"context_line":"                            master_helper.change_consistgrp_cyclingmode("},{"line_number":3998,"context_line":"                                rccg_name, \u0027none\u0027)"},{"line_number":3999,"context_line":"                            master_helper.start_rccg(rccg_name)"},{"line_number":4000,"context_line":"                        else:"},{"line_number":4001,"context_line":"                            master_helper.stop_relationship(volume.name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"6164d12b_8faa648d","line":3998,"range":{"start_line":3998,"start_character":44,"end_line":3998,"end_character":48},"updated":"2022-04-08 15:02:36.000000000","message":"should it be None?","commit_id":"f003e00d47c5d086e5fb69bc9395c735ee302f76"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"89ef3fa9bfc9e8489e96be3c36f487f2590a4500","unresolved":false,"context_lines":[{"line_number":3995,"context_line":"                        if rccg_name:"},{"line_number":3996,"context_line":"                            master_helper.stop_rccg(rccg_name)"},{"line_number":3997,"context_line":"                            master_helper.change_consistgrp_cyclingmode("},{"line_number":3998,"context_line":"                                rccg_name, \u0027none\u0027)"},{"line_number":3999,"context_line":"                            master_helper.start_rccg(rccg_name)"},{"line_number":4000,"context_line":"                        else:"},{"line_number":4001,"context_line":"                            master_helper.stop_relationship(volume.name)"}],"source_content_type":"text/x-python","patch_set":1,"id":"a1d7c33f_44696e35","line":3998,"range":{"start_line":3998,"start_character":44,"end_line":3998,"end_character":48},"in_reply_to":"6164d12b_8faa648d","updated":"2022-04-12 08:03:14.000000000","message":"Hi Ivan,\n\ncyclingmode parameter values are \u0027none\u0027/\u0027multi\u0027. The default value of cyclingmode is \u0027none\u0027. Please find the link for reference:\nhttps://www.ibm.com/docs/en/flashsystem-7x00/8.4.x?topic\u003dcommands-chrcconsistgrp","commit_id":"f003e00d47c5d086e5fb69bc9395c735ee302f76"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3d1ef50998cb1f841ef32a0758588484406a54b6","unresolved":true,"context_lines":[{"line_number":388,"context_line":"                                    cyclingmode\u003d\u0027none\u0027):"},{"line_number":389,"context_line":"        ssh_cmd \u003d [\u0027svctask\u0027, \u0027chrcconsistgrp\u0027,"},{"line_number":390,"context_line":"                   \u0027-cyclingmode\u0027, cyclingmode]"},{"line_number":391,"context_line":"        ssh_cmd.append(consistgrp)"},{"line_number":392,"context_line":"        self.run_ssh_assert_no_output(ssh_cmd)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def ch_rcrelationship_cyclingmode(self, relationship,"}],"source_content_type":"text/x-python","patch_set":4,"id":"f1ccd8de_0e44f2e6","line":391,"updated":"2022-04-18 18:42:12.000000000","message":"? why is this not added on the list creation?\n\n    ssh_cmd \u003d [\u0027svctask\u0027, \u0027chrcconsistgrp\u0027,\n               \u0027-cyclingmode\u0027, cyclingmode,\n               consistgrp]","commit_id":"0d1a50d7288e015cf0b4c25d6c899484504fb04d"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"a9bfc03db105a9a1c351b4ee9ca76d0ba5f97b5e","unresolved":false,"context_lines":[{"line_number":388,"context_line":"                                    cyclingmode\u003d\u0027none\u0027):"},{"line_number":389,"context_line":"        ssh_cmd \u003d [\u0027svctask\u0027, \u0027chrcconsistgrp\u0027,"},{"line_number":390,"context_line":"                   \u0027-cyclingmode\u0027, cyclingmode]"},{"line_number":391,"context_line":"        ssh_cmd.append(consistgrp)"},{"line_number":392,"context_line":"        self.run_ssh_assert_no_output(ssh_cmd)"},{"line_number":393,"context_line":""},{"line_number":394,"context_line":"    def ch_rcrelationship_cyclingmode(self, relationship,"}],"source_content_type":"text/x-python","patch_set":4,"id":"bbf0c29a_e530e4ad","line":391,"in_reply_to":"f1ccd8de_0e44f2e6","updated":"2022-04-19 11:10:10.000000000","message":"Thanks for the comment. Addressed it.","commit_id":"0d1a50d7288e015cf0b4c25d6c899484504fb04d"},{"author":{"_account_id":9535,"name":"Gorka Eguileor","email":"geguileo@redhat.com","username":"Gorka"},"change_message_id":"3d1ef50998cb1f841ef32a0758588484406a54b6","unresolved":true,"context_lines":[{"line_number":2619,"context_line":"                                                   cyclingmode)"},{"line_number":2620,"context_line":""},{"line_number":2621,"context_line":"    def change_consistgrp_cyclingmode(self, rccg_name,"},{"line_number":2622,"context_line":"                                      cyclingmode\u003d\u0027none\u0027):"},{"line_number":2623,"context_line":"        self.ssh.ch_rcconsistgrp_cyclingmode(rccg_name,"},{"line_number":2624,"context_line":"                                             cyclingmode)"},{"line_number":2625,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7efe2606_96fdb768","line":2622,"updated":"2022-04-18 18:42:12.000000000","message":"?: Should we change the default of the cyclingmode in the change_relationship_cyclingmode method as well for consistency","commit_id":"0d1a50d7288e015cf0b4c25d6c899484504fb04d"},{"author":{"_account_id":34201,"name":"Mounika Sreeram","email":"sreeram.mounika@ibm.com","username":"sreerammounika"},"change_message_id":"a9bfc03db105a9a1c351b4ee9ca76d0ba5f97b5e","unresolved":false,"context_lines":[{"line_number":2619,"context_line":"                                                   cyclingmode)"},{"line_number":2620,"context_line":""},{"line_number":2621,"context_line":"    def change_consistgrp_cyclingmode(self, rccg_name,"},{"line_number":2622,"context_line":"                                      cyclingmode\u003d\u0027none\u0027):"},{"line_number":2623,"context_line":"        self.ssh.ch_rcconsistgrp_cyclingmode(rccg_name,"},{"line_number":2624,"context_line":"                                             cyclingmode)"},{"line_number":2625,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"c85d1bc4_aae35908","line":2622,"in_reply_to":"7efe2606_96fdb768","updated":"2022-04-19 11:10:10.000000000","message":"Thanks for the comment. As suggested, to maintain consistency, added the cyclingmode default value as \u0027none\u0027 in change_relationship_cyclingmode method.","commit_id":"0d1a50d7288e015cf0b4c25d6c899484504fb04d"}]}