)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"5728d15ff5231224d4e31230e920205c16e5628e","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Added Datacore Software volume driver in Cinder"},{"line_number":8,"context_line":"Supports both iSCSI and Fibre Channel drivers."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Implements: datacore-volume-cinder-driver"},{"line_number":11,"context_line":"Change-Id: I520c743c3a421d66bc142ce06a43aa04e13beb8c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"8384c21a_e4ac779f","line":10,"updated":"2022-03-04 15:11:42.000000000","message":"Have you submitted this blueprint? See [1] for details.\n\n[1] https://wiki.openstack.org/wiki/Cinder/how-to-contribute-new-feature","commit_id":"d33428af3043ee314841937f0cf08875f8db0ddf"},{"author":{"_account_id":34588,"name":"DataCore Software","email":"cinder-ci@datacore.com","username":"Arun"},"change_message_id":"bc43881a5159a4ef495bd0774b4f8d70a7f8aea7","unresolved":true,"context_lines":[{"line_number":7,"context_line":"Added Datacore Software volume driver in Cinder"},{"line_number":8,"context_line":"Supports both iSCSI and Fibre Channel drivers."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Implements: datacore-volume-cinder-driver"},{"line_number":11,"context_line":"Change-Id: I520c743c3a421d66bc142ce06a43aa04e13beb8c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"ed8d751f_bd2d302d","line":10,"in_reply_to":"8384c21a_e4ac779f","updated":"2022-03-09 04:43:39.000000000","message":"Yes I have submitted the blueprint. Below is the link.\nhttps://blueprints.launchpad.net/cinder/+spec/datacore-volume-cinder-driver\nPlease let me know if i\u0027m missing something.","commit_id":"d33428af3043ee314841937f0cf08875f8db0ddf"},{"author":{"_account_id":34588,"name":"DataCore Software","email":"cinder-ci@datacore.com","username":"Arun"},"change_message_id":"aec25d57255f522a40982ea8a638b3a6b3c2735b","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Added Datacore Software volume driver in Cinder"},{"line_number":8,"context_line":"Supports both iSCSI and Fibre Channel drivers."},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Implements: datacore-volume-cinder-driver"},{"line_number":11,"context_line":"Change-Id: I520c743c3a421d66bc142ce06a43aa04e13beb8c"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"737dd125_c1c4ab73","line":10,"in_reply_to":"ed8d751f_bd2d302d","updated":"2022-03-09 04:57:22.000000000","message":"Ack","commit_id":"d33428af3043ee314841937f0cf08875f8db0ddf"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":11904,"name":"Sean McGinnis","email":"sean.mcginnis@gmail.com","username":"SeanM"},"change_message_id":"50244427ffa3e77e866d59398df42003d166487e","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"1b47a314_17086ae0","updated":"2022-02-28 12:39:12.000000000","message":"Please submit code under a user account, not your CI account.","commit_id":"d33428af3043ee314841937f0cf08875f8db0ddf"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"848829e7853e19a40c1641c47014d0e8e0e0f952","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"9fa4bcf8_10570438","updated":"2022-03-02 13:59:46.000000000","message":"Several items are missing, and will need to be addressed before a patch like this gets much attention.\n- pep8 issues need to be fixed\n- unit tests are missing\n- documentation is missing\n- CI job needs to be in place, and passing\n\nThe commit message could also be improved. \"Added\" should be \"Add\" and the \"in Cinder\" portion should be deleted (this is the cinder project, so \"in cinder\" is implied). There should also be a blank line between the summary line and the rest of the body of the commit message (this is standard git practice).","commit_id":"d33428af3043ee314841937f0cf08875f8db0ddf"},{"author":{"_account_id":34588,"name":"DataCore Software","email":"cinder-ci@datacore.com","username":"Arun"},"change_message_id":"9aa66a005f035b28648a8b12e91cbf867c83cb89","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"99431061_4c9902fd","updated":"2022-03-04 08:27:31.000000000","message":"Thank you for the response Alan/Sean McGinnis\nI have fixed all the  pep8 issues\n\n  py3: commands succeeded\n  compliance: commands succeeded\n  pep8: commands succeeded\n  congratulations :)\n\nCould you please point me to some documentation of how to write unit test case for our cinder driver.","commit_id":"d33428af3043ee314841937f0cf08875f8db0ddf"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"5728d15ff5231224d4e31230e920205c16e5628e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"996f8c0b_617d8c4e","updated":"2022-03-04 15:11:42.000000000","message":"Two more things to consider:\n\nYou should review the patch that removed the driver during the Train cycle [1]. It will show you a list of files other than the DataCore driver files that had to be touched. Most of these are in the doc tree, but there are others as well.\n\n[1] https://review.opendev.org/c/openstack/cinder/+/638029\n\nYou should not be removing all the other driver replies from the gerrit CC list. While I understand these gerrit replies generate a lot of noisy email, they are a standard side effect of how CI results are reported to gerrit. Furthermore, they will all add themselves back to the review the next time you submit another patch set.","commit_id":"d33428af3043ee314841937f0cf08875f8db0ddf"},{"author":{"_account_id":34588,"name":"DataCore Software","email":"cinder-ci@datacore.com","username":"Arun"},"change_message_id":"aec25d57255f522a40982ea8a638b3a6b3c2735b","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"a51c5d3b_af8762be","in_reply_to":"1b47a314_17086ae0","updated":"2022-03-09 04:57:22.000000000","message":"Hi Sean McGinnis,\n\nI\u0027m the only developer working on this project, so is there a way I can modify the account.","commit_id":"d33428af3043ee314841937f0cf08875f8db0ddf"},{"author":{"_account_id":21129,"name":"Alan Bishop","email":"abishopsweng@gmail.com","username":"ASBishop","status":"ex Red Hat"},"change_message_id":"5728d15ff5231224d4e31230e920205c16e5628e","unresolved":true,"context_lines":[],"source_content_type":"","patch_set":1,"id":"c55b8393_5a665cce","in_reply_to":"99431061_4c9902fd","updated":"2022-03-04 15:11:42.000000000","message":"For each of the pep error comments, please mark the item \"Resolved\" to indicate in the gerrit review that you\u0027ve addressed the comment. This will make it much easier for reviewers to keep track of whether there are open issues that still need to be addressed.\n\nYou will find a large body of driver unit test examples in [1]. You should also review the DataCore unit tests that were in place back before the driver was removed during the Train cycle. See [2].\n\n[1] https://opendev.org/openstack/cinder/src/branch/master/cinder/tests/unit/volume/drivers\n[2] https://opendev.org/openstack/cinder/src/branch/stable/stein/cinder/tests/unit/volume/drivers/datacore","commit_id":"d33428af3043ee314841937f0cf08875f8db0ddf"},{"author":{"_account_id":34588,"name":"DataCore Software","email":"cinder-ci@datacore.com","username":"Arun"},"change_message_id":"aec25d57255f522a40982ea8a638b3a6b3c2735b","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"8d2e7ae1_c2cbc4b7","in_reply_to":"996f8c0b_617d8c4e","updated":"2022-03-09 04:57:22.000000000","message":"Ack","commit_id":"d33428af3043ee314841937f0cf08875f8db0ddf"},{"author":{"_account_id":34588,"name":"DataCore Software","email":"cinder-ci@datacore.com","username":"Arun"},"change_message_id":"47ba1a462b05719bc0c671edac588bd404d41053","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"32cf782f_06004792","in_reply_to":"c55b8393_5a665cce","updated":"2022-03-09 04:48:56.000000000","message":"Thank you for the information.\nI have added the unit test and pushed it for review.","commit_id":"d33428af3043ee314841937f0cf08875f8db0ddf"}]}